)]}'
{"trove/taskmanager/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"899383d0daf9bf5b118a8a243327c0d0cbea686b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                           availability_zone, root_password,"},{"line_number":102,"context_line":"                                           nics, overrides, None)"},{"line_number":103,"context_line":"        finally:"},{"line_number":104,"context_line":"            self.delete_backup(context, snapshot[\u0027dataset\u0027][\u0027snapshot_id\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        instance_tasks.attach_replication_slave(snapshot)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_8087e911","line":104,"updated":"2014-09-08 11:00:55.000000000","message":"according to test report, backup still exist.\n\n09:49:36 \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n09:49:36 FAIL: proboscis.case.MethodTest (test_backup_deleted)\n09:49:36 ----------------------------------------------------------------------\n09:49:36 Traceback (most recent call last):\n09:49:36   File \"/usr/local/lib/python2.7/dist-packages/proboscis/case.py\", line 296, in testng_method_mistake_capture_func\n09:49:36     compatability.capture_type_error(s_func)\n09:49:36   File \"/usr/local/lib/python2.7/dist-packages/proboscis/compatability/exceptions_2_6.py\", line 27, in capture_type_error\n09:49:36     func()\n09:49:36   File \"/usr/local/lib/python2.7/dist-packages/proboscis/case.py\", line 350, in func\n09:49:36     func(test_case.state.get_state())\n09:49:36   File \"/mnt/opt/stack/trove/trove/tests/api/replication.py\", line 116, in test_backup_deleted\n09:49:36     assert_equal(len(backup), 0)\n09:49:36 AssertionError: 1 !\u003d 0","commit_id":"8d302ce039cafa8a498c297b6a4599725fcf51c6"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"76919177d4a24f26044b499206537b431ce921a5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                           availability_zone, root_password,"},{"line_number":102,"context_line":"                                           nics, overrides, None)"},{"line_number":103,"context_line":"        finally:"},{"line_number":104,"context_line":"            self.delete_backup(context, snapshot[\u0027dataset\u0027][\u0027snapshot_id\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        instance_tasks.attach_replication_slave(snapshot)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_62c0427d","line":104,"in_reply_to":"fa98f980_8087e911","updated":"2014-09-08 15:03:17.000000000","message":"Yes thanks this is strange. where did you access these logs?","commit_id":"8d302ce039cafa8a498c297b6a4599725fcf51c6"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"bbedab18515252a49d4886242dbb46348a442313","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                           availability_zone, root_password,"},{"line_number":102,"context_line":"                                           nics, overrides, None)"},{"line_number":103,"context_line":"        finally:"},{"line_number":104,"context_line":"            self.delete_backup(context, snapshot[\u0027dataset\u0027][\u0027snapshot_id\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        instance_tasks.attach_replication_slave(snapshot)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa98f980_36526bde","line":104,"updated":"2014-09-12 15:01:00.000000000","message":"backup qouta still appears to be decreased. At previous comments you are referring to API service code, but this code is a part of taskmanager code. By calling delete_backup of \u0027self\u0027 object calls the method of Manager class.\n\n    def delete_backup(self, context, backup_id):\n        models.BackupTasks.delete_backup(context, backup_id)\n\nAnd this method doesn\u0027t deal with quotas, at all. you need to update quotas here, once backup is deleted.","commit_id":"8f47fea2c9b570eba902c089c3535bbb61c22561"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"cadc640326b66fae3a46d58f528af4f9c8a67f7c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                           availability_zone, root_password,"},{"line_number":102,"context_line":"                                           nics, overrides, None)"},{"line_number":103,"context_line":"        finally:"},{"line_number":104,"context_line":"            self.delete_backup(context, snapshot[\u0027dataset\u0027][\u0027snapshot_id\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        instance_tasks.attach_replication_slave(snapshot)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa98f980_c0b76383","line":104,"in_reply_to":"fa98f980_36526bde","updated":"2014-09-15 15:54:21.000000000","message":"good catch denis. will fix it.","commit_id":"8f47fea2c9b570eba902c089c3535bbb61c22561"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0ec5a435a3adb80f1c1d4adaff89390d401f5a6a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                           availability_zone, root_password,"},{"line_number":103,"context_line":"                                           nics, overrides, None)"},{"line_number":104,"context_line":"        finally:"},{"line_number":105,"context_line":"            Backup.delete(context, snapshot[\u0027dataset\u0027][\u0027snapshot_id\u0027])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        instance_tasks.attach_replication_slave(snapshot)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_36b23949","line":105,"updated":"2014-09-15 16:36:42.000000000","message":"Nice. Definitely +1.","commit_id":"27af8c912c1627d4bd96f010e3fc1ab30bf15a94"}],"trove/taskmanager/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6af218b986e95527cd5ccf02ee2291ee1876b13d","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SLAVE"},{"line_number":361,"context_line":"            Backup.delete(context, snapshot_info[\u0027id\u0027])"},{"line_number":362,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":363,"context_line":"        except:"},{"line_number":364,"context_line":"            Backup.delete(context, snapshot_info[\u0027id\u0027])"},{"line_number":365,"context_line":"            raise"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_3f31c20b","line":363,"updated":"2014-09-09 22:38:23.000000000","message":"this is not the best way to write exception handling, why not just write finally block?\nif you know that, there\u0027s another type of exception can occure here, then you need to add it into exception tuple (line #355).\n\ncould you please re-concider it?","commit_id":"d9cfd17a64e2ca4dce3b50c53bff2daa91325db1"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"007b1251dc135e61aed6ece4593915d25a8658d6","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SLAVE"},{"line_number":361,"context_line":"            Backup.delete(context, snapshot_info[\u0027id\u0027])"},{"line_number":362,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":363,"context_line":"        except:"},{"line_number":364,"context_line":"            Backup.delete(context, snapshot_info[\u0027id\u0027])"},{"line_number":365,"context_line":"            raise"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_344f03c0","line":363,"in_reply_to":"fa98f980_3f31c20b","updated":"2014-09-10 21:26:12.000000000","message":"Finally will execute this even if the backup is successful. I want to make sure the database is cleant up if any exception is raised and backup fails.\nIf its successful we want the data to be deleted as well. And that happens in manager.py","commit_id":"d9cfd17a64e2ca4dce3b50c53bff2daa91325db1"}],"trove/tests/api/replication.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"899383d0daf9bf5b118a8a243327c0d0cbea686b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return find_database"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @test"},{"line_number":114,"context_line":"    def test_backup_deleted(self):"},{"line_number":115,"context_line":"        backup \u003d instance_info.dbaas.instances.backups(instance_info.id)"},{"line_number":116,"context_line":"        assert_equal(len(backup), 0)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_00a2199a","line":114,"updated":"2014-09-08 11:00:55.000000000","message":"as i can see, this test should run after \n\n       test_correctly_started_replication\n\nbecause of race conditions","commit_id":"8d302ce039cafa8a498c297b6a4599725fcf51c6"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8e33639c0bf22cf1b50b3bb4a3c8a4b3c3ed52c2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def test_correctly_started_replication(self):"},{"line_number":116,"context_line":"        poll_until(slave_is_running())"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @test(depends_on\u003d[test_correctly_started_replication])"},{"line_number":119,"context_line":"    def test_backup_deleted(self):"},{"line_number":120,"context_line":"        backup \u003d instance_info.dbaas.instances.backups(instance_info.id)"},{"line_number":121,"context_line":"        assert_equal(len(backup), 0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_7f126a63","line":118,"updated":"2014-09-09 22:39:56.000000000","message":"this test case doesn\u0027t depend on test above, you should use:\n   runs_after\u003d[...]","commit_id":"d9cfd17a64e2ca4dce3b50c53bff2daa91325db1"}]}