)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"9bc4759ac192627cb5d0452cac72ab46b4766815","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update some log calls for translation and lazyness"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update log calls to use _LI and friends."},{"line_number":10,"context_line":"Follow oslo.i18n recommendation to use \",\" instead of % so that"},{"line_number":11,"context_line":"lazy evaluation of debug messages is possible."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa201ad_af81394f","line":9,"updated":"2014-10-10 11:47:28.000000000","message":"Please, explain this part better. \n\nWhy we need to use them? Which one of them is for ERROR, WARNING, ...","commit_id":"59952a20e0592c1fa08edd4683a9e91d6fcaf2e5"}],"trove/instance/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"fb252499e9f65e31605117710129e0f81193ba15","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from trove.instance.tasks import InstanceTasks"},{"line_number":41,"context_line":"from trove.taskmanager import api as task_api"},{"line_number":42,"context_line":"from trove.openstack.common import log as logging"},{"line_number":43,"context_line":"from trove.openstack.common.gettextutils import _, _LE, _LI, _LW"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_6d1da2bd","line":43,"updated":"2014-10-20 12:59:25.000000000","message":"this affects PEP8 H302\nwe\u0027re allowed to do only one import per line.","commit_id":"404df3f7f3b9ef0e3402c3b255e2d4b77834b26b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"c492c82d9e61a0ace3ecb053d13393df34a96b5e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from trove.instance.tasks import InstanceTasks"},{"line_number":41,"context_line":"from trove.taskmanager import api as task_api"},{"line_number":42,"context_line":"from trove.openstack.common import log as logging"},{"line_number":43,"context_line":"from trove.openstack.common.gettextutils import _, _LE, _LI, _LW"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_4d937efa","line":43,"in_reply_to":"9aa7fdbe_6d1da2bd","updated":"2014-10-20 13:03:12.000000000","message":"It\u0027s H301 which is disabled for trove - but let me fix it, no sense in introducing more of these...","commit_id":"404df3f7f3b9ef0e3402c3b255e2d4b77834b26b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6b7e31b4eb4b6a63fa81ee3186a93a3df3c3cbac","unresolved":false,"context_lines":[{"line_number":45,"context_line":"from trove.openstack.common.gettextutils import _LI"},{"line_number":46,"context_line":"from trove.openstack.common.gettextutils import _LW"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d cfg.CONF"},{"line_number":50,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_e3036371","line":48,"updated":"2014-10-20 13:51:43.000000000","message":"looks much better!\n\nthere\u0027s a small trick (i\u0027ve seen it multiple times):\n\nfrom trove.openstack.common import gettextutils\n\n(LE, LI, LW) \u003d (gettextutils._LE, gettextutils._LI, gettextutils._LW)","commit_id":"fe120a53ac5465837e73ba65d30e5cdb91dcc2e0"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"969cba7fcd98471334e76be40f4eec09a6b777f4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from trove.openstack.common import log as logging"},{"line_number":43,"context_line":"from trove.openstack.common import gettextutils"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"(_LE, _LI, _LW) \u003d (gettextutils._LE, gettextutils._LI, gettextutils._LW)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"CONF \u003d cfg.CONF"},{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_7ae70941","line":45,"updated":"2014-10-20 17:55:19.000000000","message":"Shouldnt we add gettextutils._ to this list? Thanks.","commit_id":"241c10c128443b42eb4e314814fd2a10cb49cfaa"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"974f649dcb31f5fc168654af22fc3b275d2ac1ef","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from trove.openstack.common import log as logging"},{"line_number":43,"context_line":"from trove.openstack.common import gettextutils"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"(_LE, _LI, _LW) \u003d (gettextutils._LE, gettextutils._LI, gettextutils._LW)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"CONF \u003d cfg.CONF"},{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_c02648ba","line":45,"in_reply_to":"9aa7fdbe_7ae70941","updated":"2014-10-20 19:02:56.000000000","message":"Done","commit_id":"241c10c128443b42eb4e314814fd2a10cb49cfaa"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"969cba7fcd98471334e76be40f4eec09a6b777f4","unresolved":false,"context_lines":[{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            if self.slaves:"},{"line_number":558,"context_line":"                msg \u003d _(\"Detach replicas before deleting replica source.\")"},{"line_number":559,"context_line":"                LOG.warn(msg)"},{"line_number":560,"context_line":"                raise exception.ReplicaSourceDeleteForbidden(msg)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"            self.update_db(task_status\u003dInstanceTasks.DELETING,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_bf4a4381","line":559,"updated":"2014-10-20 17:55:19.000000000","message":"Missed _LW here","commit_id":"241c10c128443b42eb4e314814fd2a10cb49cfaa"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"974f649dcb31f5fc168654af22fc3b275d2ac1ef","unresolved":false,"context_lines":[{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            if self.slaves:"},{"line_number":558,"context_line":"                msg \u003d _(\"Detach replicas before deleting replica source.\")"},{"line_number":559,"context_line":"                LOG.warn(msg)"},{"line_number":560,"context_line":"                raise exception.ReplicaSourceDeleteForbidden(msg)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"            self.update_db(task_status\u003dInstanceTasks.DELETING,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_40417838","line":559,"in_reply_to":"9aa7fdbe_bf4a4381","updated":"2014-10-20 19:02:56.000000000","message":"This is correct, see http://docs.openstack.org/developer/oslo.i18n/guidelines.html\n\nSince we raise it as exception as well, we should not mark it with _LW but use _.","commit_id":"241c10c128443b42eb4e314814fd2a10cb49cfaa"}],"trove/instance/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"fb252499e9f65e31605117710129e0f81193ba15","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from trove.backup.models import Backup as backup_model"},{"line_number":28,"context_line":"from trove.backup import views as backup_views"},{"line_number":29,"context_line":"from trove.openstack.common import log as logging"},{"line_number":30,"context_line":"from trove.openstack.common.gettextutils import _, _LI"},{"line_number":31,"context_line":"import trove.common.apischema as apischema"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_ad7eaae2","line":30,"updated":"2014-10-20 12:59:25.000000000","message":"same here","commit_id":"404df3f7f3b9ef0e3402c3b255e2d4b77834b26b"}]}