)]}'
{"trove/instance/models.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c4685ea04e7b1af80684af25b86126403a956ad3","unresolved":false,"context_lines":[{"line_number":669,"context_line":"            try:"},{"line_number":670,"context_line":"                # looking for root replica"},{"line_number":671,"context_line":"                root_replica \u003d DBInstance.find_by(context, id\u003dslave_of_id,"},{"line_number":672,"context_line":"                                                  deleted\u003dFalse)"},{"line_number":673,"context_line":"                # load_instance(BaseInstance, context, slave_of_id)"},{"line_number":674,"context_line":"                load_simple_instance_server_status(context, root_replica)"},{"line_number":675,"context_line":"                # getting root replica datastore status"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_6563001b","line":672,"updated":"2014-09-22 00:59:22.000000000","message":"Please use some other terminology than \"root\". It\u0027s very easy to confuse this with the actual enable root API call we support which is completely different. \n\nI\u0027d recommend something like \"replica source\" instead.","commit_id":"ceb8a966d314332a7bcfcf7f404cbefa583ecc2a"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"cb21b608fb7df6d61a0a23dfd25257c7598f1607","unresolved":false,"context_lines":[{"line_number":669,"context_line":"            try:"},{"line_number":670,"context_line":"                # looking for root replica"},{"line_number":671,"context_line":"                root_replica \u003d DBInstance.find_by(context, id\u003dslave_of_id,"},{"line_number":672,"context_line":"                                                  deleted\u003dFalse)"},{"line_number":673,"context_line":"                # load_instance(BaseInstance, context, slave_of_id)"},{"line_number":674,"context_line":"                load_simple_instance_server_status(context, root_replica)"},{"line_number":675,"context_line":"                # getting root replica datastore status"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_326cd39c","line":672,"in_reply_to":"da9df570_6563001b","updated":"2014-09-22 13:05:18.000000000","message":"Done","commit_id":"ceb8a966d314332a7bcfcf7f404cbefa583ecc2a"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c4685ea04e7b1af80684af25b86126403a956ad3","unresolved":false,"context_lines":[{"line_number":682,"context_line":"                                                 datastore_status,"},{"line_number":683,"context_line":"                                                 root_replica_status)"},{"line_number":684,"context_line":"            except exception.ModelNotFoundError:"},{"line_number":685,"context_line":"                LOG.exception(_(\"Root replica not found.\"))"},{"line_number":686,"context_line":"                raise exception.NotFound(uuid\u003dslave_of_id)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        client \u003d create_nova_client(context)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_2581f88f","line":685,"updated":"2014-09-22 00:59:22.000000000","message":"This is a possible erroneous error message. It may be the case that the replica source was found, but was not ready (BUILD, or something similar).","commit_id":"ceb8a966d314332a7bcfcf7f404cbefa583ecc2a"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"cb21b608fb7df6d61a0a23dfd25257c7598f1607","unresolved":false,"context_lines":[{"line_number":682,"context_line":"                                                 datastore_status,"},{"line_number":683,"context_line":"                                                 root_replica_status)"},{"line_number":684,"context_line":"            except exception.ModelNotFoundError:"},{"line_number":685,"context_line":"                LOG.exception(_(\"Root replica not found.\"))"},{"line_number":686,"context_line":"                raise exception.NotFound(uuid\u003dslave_of_id)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        client \u003d create_nova_client(context)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_5269578a","line":685,"in_reply_to":"da9df570_2581f88f","updated":"2014-09-22 13:05:18.000000000","message":"Done","commit_id":"ceb8a966d314332a7bcfcf7f404cbefa583ecc2a"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c4685ea04e7b1af80684af25b86126403a956ad3","unresolved":false,"context_lines":[{"line_number":904,"context_line":"        task_api.API(self.context).migrate(self.id, host)"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"    @classmethod"},{"line_number":907,"context_line":"    def _validate_can_perform_action(cls, db_info, datastore_status, status):"},{"line_number":908,"context_line":"        \"\"\""},{"line_number":909,"context_line":"        Raises exception if an instance action cannot currently be performed."},{"line_number":910,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_457efcaf","line":907,"updated":"2014-09-22 00:59:22.000000000","message":"Why are we making this a class method instead of on instance method, and passing all the instance properties are arguments? Why not just call the instance method on the replica source instance?","commit_id":"ceb8a966d314332a7bcfcf7f404cbefa583ecc2a"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"cb21b608fb7df6d61a0a23dfd25257c7598f1607","unresolved":false,"context_lines":[{"line_number":904,"context_line":"        task_api.API(self.context).migrate(self.id, host)"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"    @classmethod"},{"line_number":907,"context_line":"    def _validate_can_perform_action(cls, db_info, datastore_status, status):"},{"line_number":908,"context_line":"        \"\"\""},{"line_number":909,"context_line":"        Raises exception if an instance action cannot currently be performed."},{"line_number":910,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_920adfd0","line":907,"in_reply_to":"da9df570_457efcaf","updated":"2014-09-22 13:05:18.000000000","message":"fixed","commit_id":"ceb8a966d314332a7bcfcf7f404cbefa583ecc2a"}],"trove/tests/unittests/instance/test_instance_models.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"65d11b6a257af589f72a0fce7c71440ae1a06f5f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def tearDown(self):"},{"line_number":119,"context_line":"        self.root_info.delete()"},{"line_number":120,"context_line":"        self.status.delete()"},{"line_number":121,"context_line":"        util.clean_db()"},{"line_number":122,"context_line":"        super(TestReplication, self).tearDown()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_replica_provisioning_with_unprocessable_root_replica(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_7e46f37c","line":121,"updated":"2014-09-18 20:04:16.000000000","message":"clean_db dne.","commit_id":"ef590d9ba4fcaedeb47d02a11c627f34451447f7"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"48dd8191f36f7fecd95284b1b0d3454e5df5fbbf","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def tearDown(self):"},{"line_number":119,"context_line":"        self.root_info.delete()"},{"line_number":120,"context_line":"        self.status.delete()"},{"line_number":121,"context_line":"        util.clean_db()"},{"line_number":122,"context_line":"        super(TestReplication, self).tearDown()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_replica_provisioning_with_unprocessable_root_replica(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_2130ca06","line":121,"in_reply_to":"fa98f980_7e46f37c","updated":"2014-09-18 20:44:47.000000000","message":"oh, right, forget to drop it off.","commit_id":"ef590d9ba4fcaedeb47d02a11c627f34451447f7"}]}