)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"43353366d4ad35c9958911c90aa855c4ec725fce","unresolved":false,"context_lines":[{"line_number":10,"context_line":"as the query-router flavor for mongodb clusters. prior to this"},{"line_number":11,"context_line":"patch, the routers and config-servers would inherit the flavor"},{"line_number":12,"context_line":"chosen for the instances, which is an extremely inefficient"},{"line_number":13,"context_line":"use of resources."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iac0803401c30141f5e9d9544bf982597647092d9"},{"line_number":16,"context_line":"Implements: blueprint clustering-sizing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba3cc151_ad5e4d43","line":13,"updated":"2015-07-07 01:17:45.000000000","message":"DocImpact flag should be here.","commit_id":"4e8732f7c971d84a8b1fdf9c728aca8d09c4294a"}],"trove/common/cfg.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ef79f5c231caf20486ed375f7d651bbaf1a58a3e","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                default\u003dTrue,"},{"line_number":503,"context_line":"                help\u003d\u0027Whether to provision a cinder volume for datadir.\u0027),"},{"line_number":504,"context_line":"    cfg.StrOpt(\u0027device_path\u0027, default\u003d\u0027/dev/vdb\u0027),"},{"line_number":505,"context_line":"    cfg.StrOpt(\u0027config_server_flavor_id\u0027, default\u003d\u00277\u0027,"},{"line_number":506,"context_line":"               help\u003d\u0027The flavor to use for config server instances.\u0027),"},{"line_number":507,"context_line":"    cfg.IntOpt(\u0027config_server_volume_size\u0027, default\u003d5,"},{"line_number":508,"context_line":"               help\u003d\u0027The volume size to use for config server instances (\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_562e0f8d","line":505,"updated":"2014-09-12 14:55:24.000000000","message":"we can\u0027t actually pin to flavor IDs, let me explain why.\n\nSuppose we have OpenStack deployment with flavors that misses flavor with ID equals to 7.\nBy saying that only this flavor (flavor 7 is the small one) is suitable we\u0027re saying that for query router and config server we need less RAM and disk space than each shard. Let\u0027s use RAM and disk size and when cluster gets provisioned API service will look up for suitable flavor for given RAM and disk space.\n\nSo, i\u0027d strongly recommend to use:\n  cfg.StrOpt(\u0027config_server_ram\u0027, default\u003d\u0027768\u0027)\n  cfg.StrOpt(\u0027query_router_ram\u0027, default\u003d\u0027768\u0027)\nand\n  cfg.IntOpt(\u0027config_server_disk_size\u0027, default\u003d\u00275\u0027)  \n  cfg.IntOpt(\u0027query_router_disk_size\u0027, default\u003d\u00275\u0027)\n\ninstead of flavor IDs","commit_id":"0a565f169759a248edd8d5f1de23965ca82e7efe"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"c5ff4b705aef6b3404c822ae72b160fc840333d4","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                default\u003dTrue,"},{"line_number":503,"context_line":"                help\u003d\u0027Whether to provision a cinder volume for datadir.\u0027),"},{"line_number":504,"context_line":"    cfg.StrOpt(\u0027device_path\u0027, default\u003d\u0027/dev/vdb\u0027),"},{"line_number":505,"context_line":"    cfg.StrOpt(\u0027config_server_flavor_id\u0027, default\u003d\u00277\u0027,"},{"line_number":506,"context_line":"               help\u003d\u0027The flavor to use for config server instances.\u0027),"},{"line_number":507,"context_line":"    cfg.IntOpt(\u0027config_server_volume_size\u0027, default\u003d5,"},{"line_number":508,"context_line":"               help\u003d\u0027The volume size to use for config server instances (\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_07528f66","line":505,"in_reply_to":"fa98f980_562e0f8d","updated":"2014-09-12 16:46:26.000000000","message":"i think you\u0027re on the right track, but how would this deal with disambiguation of multiple flavors that have 768 ram?\n\nby virtue of it being possible that a flavor id of 7 doesn\u0027t exist, it\u0027s also possible that a flavor with 768 ram doesn\u0027t exist, so this doesn\u0027t really solve the problem.\n\nlet me ponder this a bit more and reply later.","commit_id":"0a565f169759a248edd8d5f1de23965ca82e7efe"}],"trove/common/strategies/mongodb/api.py":[{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"a85f01b29056bb027d5fb11c1ca8a3798279eee9","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            router_volume_size \u003d mongo_conf.query_router_volume_size"},{"line_number":102,"context_line":"            delta_config_volumes \u003d config_volume_size * num_configsvr"},{"line_number":103,"context_line":"            delta_router_volumes \u003d router_volume_size * num_router"},{"line_number":104,"context_line":"            deltas[\u0027volumes\u0027] \u003d ((volume_size * delta_instances)"},{"line_number":105,"context_line":"                                 + delta_config_volumes"},{"line_number":106,"context_line":"                                 + delta_router_volumes)"},{"line_number":107,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_05a2aefc","line":104,"updated":"2014-09-11 16:29:29.000000000","message":"Should delta_instances be num_instances?","commit_id":"a5f22f5e4d61adf9abe4eae0ac16f53b7621d207"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ceb2b4ca2132c2f0aa951a75caec75b031a2f6d8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            router_volume_size \u003d mongo_conf.query_router_volume_size"},{"line_number":102,"context_line":"            delta_config_volumes \u003d config_volume_size * num_configsvr"},{"line_number":103,"context_line":"            delta_router_volumes \u003d router_volume_size * num_router"},{"line_number":104,"context_line":"            deltas[\u0027volumes\u0027] \u003d ((volume_size * delta_instances)"},{"line_number":105,"context_line":"                                 + delta_config_volumes"},{"line_number":106,"context_line":"                                 + delta_router_volumes)"},{"line_number":107,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_41d10056","line":104,"in_reply_to":"fa98f980_05a2aefc","updated":"2014-09-11 21:28:29.000000000","message":"good catch.","commit_id":"a5f22f5e4d61adf9abe4eae0ac16f53b7621d207"}]}