)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4a434433dc3797f4a9c89940e82d495489c5eb4d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Discover config file for mongodb"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"mongodb 2.6 uses diff config file as opposed to"},{"line_number":10,"context_line":"lower versions. Given diff file candidates code"},{"line_number":11,"context_line":"selects config file that is available"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8fe9eea39a47aa890834a0c55e98c062f9b9fd15"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baa201ad_37b6883e","line":10,"updated":"2014-09-29 18:41:34.000000000","message":"earlier","commit_id":"31cede58f36d9abb29fd102e6ebbe84a410d32d8"}],"trove/guestagent/datastore/mongodb/service.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"73aff985a2dcef5818cef33570d769d9b5602de7","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                t.write(config_contents)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            config_file \u003d (operating_system."},{"line_number":175,"context_line":"                           file_discovery(system.CONFIG_CANDIDATES))"},{"line_number":176,"context_line":"            LOG.info(_(\"Moving %(a)s to %(b)s\")"},{"line_number":177,"context_line":"                     % {\u0027a\u0027: system.TMP_CONFIG, \u0027b\u0027: config_file})"},{"line_number":178,"context_line":"            utils.execute_with_timeout(\"mv\", system.TMP_CONFIG, config_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_93a58e06","line":175,"updated":"2014-09-22 03:35:09.000000000","message":"Why not set this once at the module level and then reuse it in all these places? (It shouldn\u0027t change on the fly)\n\nSomething like \n CONFIG_FILE \u003d operating_system.file_discovery(system.CONFIG_CANDIDATES)\n\nat the top of the file, and then use CONFIG_FILE wherever needed in the code.","commit_id":"c74f08564757bc4314688175e148969bed7683a2"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"853e22b4c8bbc2a72f2389376e49b7606eb339d9","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                t.write(config_contents)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            config_file \u003d (operating_system."},{"line_number":175,"context_line":"                           file_discovery(system.CONFIG_CANDIDATES))"},{"line_number":176,"context_line":"            LOG.info(_(\"Moving %(a)s to %(b)s\")"},{"line_number":177,"context_line":"                     % {\u0027a\u0027: system.TMP_CONFIG, \u0027b\u0027: config_file})"},{"line_number":178,"context_line":"            utils.execute_with_timeout(\"mv\", system.TMP_CONFIG, config_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_d999e26f","line":175,"in_reply_to":"da9df570_93a58e06","updated":"2014-09-22 19:18:24.000000000","message":"Agree. Fixed. Thanks!","commit_id":"c74f08564757bc4314688175e148969bed7683a2"}],"trove/guestagent/datastore/mongodb/system.py":[{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"1b4403c21136de9eaab01059b805702530cf0c8f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"TIME_OUT \u003d 1000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"INIT_EXEC_MONGOS \u003d (\"start-stop-daemon --start --quiet --chuid mongodb \""},{"line_number":34,"context_line":"                    \"--exec  /usr/bin/mongos -- --config CONFIG_PROXY\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"MONGOS_UPSTART_CONTENTS \u003d \"\"\"pre-start script"},{"line_number":37,"context_line":"    mkdir -p /var/log/mongodb/"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_efbb3470","line":34,"updated":"2014-09-22 20:40:35.000000000","message":"Nitpick: Is there a precedent for using the term \"proxy\" in a placeholder variable name? It just struck me as a strange choice of term.\n\nAnother nitpick: What about using:\n\n    INIT_EXEC_MONGOS \u003d \"... {config_file_placeholder} ...\"\n    ...\n    INIT_EXEC_MONGOS.format(config_file_placeholder\u003d\"blahblahblah\")\n\nor:\n\n    INIT_EXEC_MONGOS \u003d \"... $config_file_placeholder ...\"\n    ...\n    string.Template(INIT_EXEC_MONGOS).substitute(\n        config_file_placeholder\u003d\"blahblahblah\"\n\nIn both of the above examples, it\u0027s a bit more obvious that the string will be interpolated later.","commit_id":"6fa1a57f6bef8f9ca2e1926b5df00fc4d1f85478"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"348ae6a207ce9869008b6ba9b38162bf0482325e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"TIME_OUT \u003d 1000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"INIT_EXEC_MONGOS \u003d (\"start-stop-daemon --start --quiet --chuid mongodb \""},{"line_number":34,"context_line":"                    \"--exec  /usr/bin/mongos -- --config CONFIG_PROXY\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"MONGOS_UPSTART_CONTENTS \u003d \"\"\"pre-start script"},{"line_number":37,"context_line":"    mkdir -p /var/log/mongodb/"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_1bbc39bb","line":34,"in_reply_to":"da9df570_efbb3470","updated":"2014-09-22 23:50:52.000000000","message":"Had considered placeholder before but dismissed it as being too long. I do agree that it is more proper. Fixed. Thanks","commit_id":"6fa1a57f6bef8f9ca2e1926b5df00fc4d1f85478"}]}