)]}'
{"trove/common/template.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"605048d310e83a161bbc8f5f357ec10477b384a6","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"class ReplicaSourceConfigTemplate(SingleInstanceConfigTemplate):"},{"line_number":141,"context_line":"    template_name \u003d \"master.config.template\""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class ReplicaConfigTemplate(SingleInstanceConfigTemplate):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_e7ab5d87","line":141,"updated":"2014-09-30 13:36:42.000000000","message":"replica_source.config.template would be better to use","commit_id":"ae8cb2c65d7a616067c8c9e9f838e7e775cdb009"}],"trove/guestagent/api.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"501e8419e3bc74e1115e285eea0ea9710c461d8a","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                          snapshot_info\u003dsnapshot_info,"},{"line_number":332,"context_line":"                          replica_source_config\u003dreplica_source_config)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def attach_replication_slave(self, snapshot, replica_config\u003dNone):"},{"line_number":335,"context_line":"        LOG.debug(\"Configuring instance %s to replicate from %s.\","},{"line_number":336,"context_line":"                  self.id, snapshot.get(\u0027master\u0027).get(\u0027id\u0027))"},{"line_number":337,"context_line":"        self._cast(\"attach_replication_slave\", snapshot\u003dsnapshot,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_933e48b7","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":32},"updated":"2014-09-30 19:29:48.000000000","message":"It is my understanding that at this point the API is set. Therefore, isn\u0027t this a change which will break the RPC API? I believe the same argument was made in 118521 should apply here.\n\nhttps://review.openstack.org/#/c/118521/11/trove/guestagent/api.py,cm","commit_id":"ae8cb2c65d7a616067c8c9e9f838e7e775cdb009"}],"trove/guestagent/datastore/mysql/service.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"903162a6351a8f3197674ddcea82fce01e7f250f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"MYSQL_BIN_CANDIDATES \u003d [\"/usr/sbin/mysqld\", \"/usr/libexec/mysqld\"]"},{"line_number":65,"context_line":"MYCNF_OVERRIDES \u003d \"/etc/mysql/conf.d/overrides.cnf\""},{"line_number":66,"context_line":"MYCNF_OVERRIDES_TMP \u003d \"/tmp/overrides.cnf.tmp\""},{"line_number":67,"context_line":"MYCNF_REPLMASTER \u003d \"/etc/mysql/conf.d/0replication.cnf\""},{"line_number":68,"context_line":"MYCNF_REPLMASTER_TMP \u003d \"/tmp/replication.cnf.tmp\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_4b96e1f1","line":67,"updated":"2014-10-01 08:55:41.000000000","message":"Was wondering why it was necessary to change the name of the override conf file for replication?","commit_id":"4a3ea982e72a967d3bfbfce1e9bbfa4381105e04"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"a0e9304e42c11ddd8e2610bcf74bebd50f84d1fb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"MYSQL_BIN_CANDIDATES \u003d [\"/usr/sbin/mysqld\", \"/usr/libexec/mysqld\"]"},{"line_number":65,"context_line":"MYCNF_OVERRIDES \u003d \"/etc/mysql/conf.d/overrides.cnf\""},{"line_number":66,"context_line":"MYCNF_OVERRIDES_TMP \u003d \"/tmp/overrides.cnf.tmp\""},{"line_number":67,"context_line":"MYCNF_REPLMASTER \u003d \"/etc/mysql/conf.d/0replication.cnf\""},{"line_number":68,"context_line":"MYCNF_REPLMASTER_TMP \u003d \"/tmp/replication.cnf.tmp\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_3da9db7b","line":67,"in_reply_to":"baa201ad_4b96e1f1","updated":"2014-10-01 13:04:04.000000000","message":"Because confd loads the files in alphabetical order. we would want the overrides.cnf to still override the replication\u0027s configs.","commit_id":"4a3ea982e72a967d3bfbfce1e9bbfa4381105e04"}],"trove/tests/unittests/common/test_template.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"2e07241048465c100b06e1ce648b43515a02a8f6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        config \u003d template.ReplicaSourceConfigTemplate(datastore,"},{"line_number":94,"context_line":"                                                      self.flavor_dict,"},{"line_number":95,"context_line":"                                                      self.server_id)"},{"line_number":96,"context_line":"        if not self._find_in_template(config.render(), \"log_bin\"):"},{"line_number":97,"context_line":"            raise \"Not found in template\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_replica_config_rendering(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_305ca819","line":96,"updated":"2014-09-18 10:00:09.000000000","message":"it should be an assert call, not exception raising.\n\n        self.assertTrue(self._find_in_template(config.render(), \u0027log_big\u0027)","commit_id":"7b3a26bd146791ea230ae584360501b061f3331b"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"ea48e96196b4befeebfc3f3c9856624f920031b4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        config \u003d template.ReplicaSourceConfigTemplate(datastore,"},{"line_number":94,"context_line":"                                                      self.flavor_dict,"},{"line_number":95,"context_line":"                                                      self.server_id)"},{"line_number":96,"context_line":"        if not self._find_in_template(config.render(), \"log_bin\"):"},{"line_number":97,"context_line":"            raise \"Not found in template\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_replica_config_rendering(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_ca0ba022","line":96,"in_reply_to":"fa98f980_305ca819","updated":"2014-09-18 15:22:59.000000000","message":"I just mimiced what other tests do with validate_template.","commit_id":"7b3a26bd146791ea230ae584360501b061f3331b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"2e07241048465c100b06e1ce648b43515a02a8f6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        config \u003d template.ReplicaConfigTemplate(datastore,"},{"line_number":105,"context_line":"                                                self.flavor_dict,"},{"line_number":106,"context_line":"                                                self.server_id)"},{"line_number":107,"context_line":"        if not self._find_in_template(config.render(), \"relay_log\"):"},{"line_number":108,"context_line":"            raise \"Not found in template\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_509a0cc6","line":107,"updated":"2014-09-18 10:00:09.000000000","message":"same here","commit_id":"7b3a26bd146791ea230ae584360501b061f3331b"}]}