)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d0da92c09806291f6bbf2f5e12ef1fc57c468fc5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"DEFAULT section of the configuration file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This attempts to do a cleanup of the volume and backup options and to"},{"line_number":14,"context_line":"prepare for a final cleanup (of the newly deprecated options) in a"},{"line_number":15,"context_line":"future release."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"A few missing help strings were also added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aa7fdbe_0d59008e","line":14,"updated":"2014-10-23 16:53:22.000000000","message":"if this is step 1 of 2, shouldn\u0027t this be \u0027partial-bug\u0027: #...\n\nelse how will we come back and do part 2 of 2?","commit_id":"730c73a893a01acddd1683fe4bf7632965c670da"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"2186bf0c5d5bfc51c913f9b2a9c542a65cb82acf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"DEFAULT section of the configuration file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This attempts to do a cleanup of the volume and backup options and to"},{"line_number":14,"context_line":"prepare for a final cleanup (of the newly deprecated options) in a"},{"line_number":15,"context_line":"future release."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"A few missing help strings were also added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a890539_38e336a5","line":14,"in_reply_to":"9aa7fdbe_0d59008e","updated":"2014-11-15 19:09:02.000000000","message":"agreed","commit_id":"730c73a893a01acddd1683fe4bf7632965c670da"}],"trove/common/cfg.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"17f36206899cad8d179f6bc807694f66fc1273f2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dTrue,"},{"line_number":53,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for datadir.\u0027,"},{"line_number":54,"context_line":"                deprecated_name\u003d\u0027trove_volume_support\u0027),"},{"line_number":55,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027],"},{"line_number":56,"context_line":"                help\u003d\u0027Roles to add to an admin user.\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027update_status_on_fail\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_c9eb39da","line":54,"updated":"2014-11-17 06:22:19.000000000","message":"I don\u0027t fully understand why we are marking option X as having a deprecated_name X in the DEFAULT group (seems a bit iffy).\n\nI think the right thing to do in this case is to remove option X from the DEFAULT group, and mark the same option in the [datastore] group as having a deprecated_name of X, and a deprecated_group of DEFAULT.","commit_id":"730c73a893a01acddd1683fe4bf7632965c670da"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c57f0d3b070afbbae2285de951dba463fd8d765d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dTrue,"},{"line_number":53,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for datadir.\u0027,"},{"line_number":54,"context_line":"                deprecated_name\u003d\u0027trove_volume_support\u0027),"},{"line_number":55,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027],"},{"line_number":56,"context_line":"                help\u003d\u0027Roles to add to an admin user.\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027update_status_on_fail\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_5280c48a","line":54,"in_reply_to":"5a890539_c9eb39da","updated":"2014-11-17 16:36:33.000000000","message":"Done","commit_id":"730c73a893a01acddd1683fe4bf7632965c670da"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f08c7dbc3b0b2251bb4b7b86a2f4a01e7008324e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                    \u0027revert.\u0027),"},{"line_number":216,"context_line":"    cfg.IntOpt(\u0027cluster_delete_time_out\u0027, default\u003d60 * 3,"},{"line_number":217,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for a cluster delete.\u0027),"},{"line_number":218,"context_line":"    cfg.ListOpt(\u0027root_grant\u0027, default\u003d[\u0027ALL\u0027],"},{"line_number":219,"context_line":"                help\u003d\"Permissions to grant to the \u0027root\u0027 user.\"),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027root_grant_option\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d\"Assign the \u0027root\u0027 user GRANT permissions.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_0c02483e","line":218,"updated":"2014-09-30 13:28:56.000000000","message":"this option also should be per-datastore, because it\u0027s specific only for MySQL/Percona/PostgreSQL","commit_id":"730c73a893a01acddd1683fe4bf7632965c670da"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"06f7005ed9fda0147e1b8419fe528634cc300b6b","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                    \u0027revert.\u0027),"},{"line_number":216,"context_line":"    cfg.IntOpt(\u0027cluster_delete_time_out\u0027, default\u003d60 * 3,"},{"line_number":217,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for a cluster delete.\u0027),"},{"line_number":218,"context_line":"    cfg.ListOpt(\u0027root_grant\u0027, default\u003d[\u0027ALL\u0027],"},{"line_number":219,"context_line":"                help\u003d\"Permissions to grant to the \u0027root\u0027 user.\"),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027root_grant_option\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d\"Assign the \u0027root\u0027 user GRANT permissions.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_5326a0b8","line":218,"in_reply_to":"baa201ad_0c02483e","updated":"2014-09-30 19:28:00.000000000","message":"I agree, but it doesn\u0027t affect things right now and would require more code changes than simply changing it here.  Probably best to push it into its own commit.","commit_id":"730c73a893a01acddd1683fe4bf7632965c670da"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"2186bf0c5d5bfc51c913f9b2a9c542a65cb82acf","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                    \u0027revert.\u0027),"},{"line_number":216,"context_line":"    cfg.IntOpt(\u0027cluster_delete_time_out\u0027, default\u003d60 * 3,"},{"line_number":217,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for a cluster delete.\u0027),"},{"line_number":218,"context_line":"    cfg.ListOpt(\u0027root_grant\u0027, default\u003d[\u0027ALL\u0027],"},{"line_number":219,"context_line":"                help\u003d\"Permissions to grant to the \u0027root\u0027 user.\"),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027root_grant_option\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d\"Assign the \u0027root\u0027 user GRANT permissions.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_78f05e67","line":218,"in_reply_to":"baa201ad_5326a0b8","updated":"2014-11-15 19:09:02.000000000","message":"agreed, just trying to point out certain things for \u0027Stage 2\u0027","commit_id":"730c73a893a01acddd1683fe4bf7632965c670da"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f08c7dbc3b0b2251bb4b7b86a2f4a01e7008324e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for a cluster delete.\u0027),"},{"line_number":218,"context_line":"    cfg.ListOpt(\u0027root_grant\u0027, default\u003d[\u0027ALL\u0027],"},{"line_number":219,"context_line":"                help\u003d\"Permissions to grant to the \u0027root\u0027 user.\"),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027root_grant_option\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d\"Assign the \u0027root\u0027 user GRANT permissions.\"),"},{"line_number":222,"context_line":"    cfg.IntOpt(\u0027default_password_length\u0027, default\u003d36,"},{"line_number":223,"context_line":"               help\u003d\u0027Character length of generated passwords.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_6c9034ed","line":220,"updated":"2014-09-30 13:28:56.000000000","message":"Same","commit_id":"730c73a893a01acddd1683fe4bf7632965c670da"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"06f7005ed9fda0147e1b8419fe528634cc300b6b","unresolved":false,"context_lines":[{"line_number":217,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for a cluster delete.\u0027),"},{"line_number":218,"context_line":"    cfg.ListOpt(\u0027root_grant\u0027, default\u003d[\u0027ALL\u0027],"},{"line_number":219,"context_line":"                help\u003d\"Permissions to grant to the \u0027root\u0027 user.\"),"},{"line_number":220,"context_line":"    cfg.BoolOpt(\u0027root_grant_option\u0027, default\u003dTrue,"},{"line_number":221,"context_line":"                help\u003d\"Assign the \u0027root\u0027 user GRANT permissions.\"),"},{"line_number":222,"context_line":"    cfg.IntOpt(\u0027default_password_length\u0027, default\u003d36,"},{"line_number":223,"context_line":"               help\u003d\u0027Character length of generated passwords.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_b3342cdf","line":220,"in_reply_to":"baa201ad_6c9034ed","updated":"2014-09-30 19:28:00.000000000","message":"ditto","commit_id":"730c73a893a01acddd1683fe4bf7632965c670da"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"91a04722173b7605b241a77fa18a9c17638a4083","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    cfg.BoolOpt(\u0027use_nova_server_volume\u0027, default\u003dFalse,"},{"line_number":194,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for the \u0027"},{"line_number":195,"context_line":"                     \u0027Nova instance.\u0027,"},{"line_number":196,"context_line":"                deprecated_name\u003d\u0027use_nova_server_volume\u0027),"},{"line_number":197,"context_line":"    cfg.BoolOpt(\u0027use_heat\u0027, default\u003dFalse,"},{"line_number":198,"context_line":"                help\u003d\u0027Use Heat for provisioning.\u0027),"},{"line_number":199,"context_line":"    cfg.StrOpt(\u0027device_path\u0027, default\u003d\u0027/dev/vdb\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_6c116051","line":196,"updated":"2014-11-17 17:29:52.000000000","message":"I don\u0027t understand this change.","commit_id":"38f4737c91650d969ba986b7218ad7546259e004"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"e3c4d50e86fb49f03edffb834a96cbd6c5fbe922","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    cfg.BoolOpt(\u0027use_nova_server_volume\u0027, default\u003dFalse,"},{"line_number":194,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for the \u0027"},{"line_number":195,"context_line":"                     \u0027Nova instance.\u0027,"},{"line_number":196,"context_line":"                deprecated_name\u003d\u0027use_nova_server_volume\u0027),"},{"line_number":197,"context_line":"    cfg.BoolOpt(\u0027use_heat\u0027, default\u003dFalse,"},{"line_number":198,"context_line":"                help\u003d\u0027Use Heat for provisioning.\u0027),"},{"line_number":199,"context_line":"    cfg.StrOpt(\u0027device_path\u0027, default\u003d\u0027/dev/vdb\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_f6251b5c","line":196,"in_reply_to":"5a890539_6c116051","updated":"2014-11-17 21:13:33.000000000","message":"I originally thought this was replaced with volume_support, but looking at the code the only difference is whether we create the volume ourselves, or let nova create the volume for us.  If this is set to true, then nova does the work. The code to call nova, however, doesn\u0027t check if volume_support is enables, so I assumed it was old and shouldn\u0027t be used anymore (hence deprecated). If I\u0027m wrong, let me know and I\u0027ll remove the deprecation tag.","commit_id":"38f4737c91650d969ba986b7218ad7546259e004"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"91a04722173b7605b241a77fa18a9c17638a4083","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    cfg.StrOpt(\u0027backup_runner\u0027,"},{"line_number":262,"context_line":"               default\u003d\u0027trove.guestagent.backup.backup_types.InnoBackupEx\u0027,"},{"line_number":263,"context_line":"               help\u003d\u0027Runner to use for backups.\u0027,"},{"line_number":264,"context_line":"               deprecated_name\u003d\u0027backup_runner\u0027),"},{"line_number":265,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":266,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027,"},{"line_number":267,"context_line":"                deprecated_name\u003d\u0027backup_runner_options\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_cc025409","line":264,"updated":"2014-11-17 17:29:52.000000000","message":"I\u0027m not sure I understand this change ...","commit_id":"38f4737c91650d969ba986b7218ad7546259e004"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"e3c4d50e86fb49f03edffb834a96cbd6c5fbe922","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    cfg.StrOpt(\u0027backup_runner\u0027,"},{"line_number":262,"context_line":"               default\u003d\u0027trove.guestagent.backup.backup_types.InnoBackupEx\u0027,"},{"line_number":263,"context_line":"               help\u003d\u0027Runner to use for backups.\u0027,"},{"line_number":264,"context_line":"               deprecated_name\u003d\u0027backup_runner\u0027),"},{"line_number":265,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":266,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027,"},{"line_number":267,"context_line":"                deprecated_name\u003d\u0027backup_runner_options\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_3616c34c","line":264,"in_reply_to":"5a890539_cc025409","updated":"2014-11-17 21:13:33.000000000","message":"Hasn\u0027t this been replaced with backup_strategy (on a per-datastore basis) ?","commit_id":"38f4737c91650d969ba986b7218ad7546259e004"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"91a04722173b7605b241a77fa18a9c17638a4083","unresolved":false,"context_lines":[{"line_number":264,"context_line":"               deprecated_name\u003d\u0027backup_runner\u0027),"},{"line_number":265,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":266,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027,"},{"line_number":267,"context_line":"                deprecated_name\u003d\u0027backup_runner_options\u0027),"},{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027verify_swift_checksum_on_restore\u0027, default\u003dTrue,"},{"line_number":269,"context_line":"                help\u003d\u0027Enable verification of Swift checksum before starting \u0027"},{"line_number":270,"context_line":"                \u0027restore. Makes sure the checksum of original backup matches \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_2c0cb83a","line":267,"updated":"2014-11-17 17:29:52.000000000","message":"or this one. where are they deprecated from?","commit_id":"38f4737c91650d969ba986b7218ad7546259e004"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"e3c4d50e86fb49f03edffb834a96cbd6c5fbe922","unresolved":false,"context_lines":[{"line_number":264,"context_line":"               deprecated_name\u003d\u0027backup_runner\u0027),"},{"line_number":265,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":266,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027,"},{"line_number":267,"context_line":"                deprecated_name\u003d\u0027backup_runner_options\u0027),"},{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027verify_swift_checksum_on_restore\u0027, default\u003dTrue,"},{"line_number":269,"context_line":"                help\u003d\u0027Enable verification of Swift checksum before starting \u0027"},{"line_number":270,"context_line":"                \u0027restore. Makes sure the checksum of original backup matches \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_563fcfb3","line":267,"in_reply_to":"5a890539_2c0cb83a","updated":"2014-11-17 21:13:33.000000000","message":"Here too, although I don\u0027t know if the code for this one is complete yet.","commit_id":"38f4737c91650d969ba986b7218ad7546259e004"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"773dff8853284878978924f1a103c96ced635979","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dTrue,"},{"line_number":53,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for datadir.\u0027,"},{"line_number":54,"context_line":"                deprecated_name\u003d\u0027trove_volume_support\u0027),"},{"line_number":55,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027],"},{"line_number":56,"context_line":"                help\u003d\u0027Roles to add to an admin user.\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027update_status_on_fail\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_16c5220a","line":54,"updated":"2014-11-26 17:05:18.000000000","message":"I don\u0027t know what this change accomplishes. As best as I have been able to understand, the way in which you use deprecated_name and deprecated_section is when you move a parameter from one section to another.\n\nThis change doesn\u0027t, I don\u0027t believe, accomplish anything.","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b53d278be9ffc7bc5cc32eb16265a4b16ca64415","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dTrue,"},{"line_number":53,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for datadir.\u0027,"},{"line_number":54,"context_line":"                deprecated_name\u003d\u0027trove_volume_support\u0027),"},{"line_number":55,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027],"},{"line_number":56,"context_line":"                help\u003d\u0027Roles to add to an admin user.\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027update_status_on_fail\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_5ec22a87","line":54,"in_reply_to":"5a890539_16c5220a","updated":"2014-11-28 15:43:57.000000000","message":"Right, this option has been moved to a per-datastore section, hence this option is now \u0027deprecated.\u0027  If I remove the option completely, then the code complains because it is still in use (and it\u0027s also not \u0027deprecated,\u0027 it would then be removed entirely).\n\nIf this is not the way it should be done, I\u0027m open to suggestions.","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6237be3c174b9619e7aa9781e966feb4cdc812a2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dTrue,"},{"line_number":53,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for datadir.\u0027,"},{"line_number":54,"context_line":"                deprecated_name\u003d\u0027trove_volume_support\u0027),"},{"line_number":55,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027],"},{"line_number":56,"context_line":"                help\u003d\u0027Roles to add to an admin user.\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027update_status_on_fail\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_6eb9e6eb","line":54,"in_reply_to":"5a890539_16c5220a","updated":"2014-11-30 15:07:24.000000000","message":"why can\u0027t we just delete this one without doing deprecation since it is not used anywhere.","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"3171f6c8236dd161dd859ff8a38327eeee8582fb","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dTrue,"},{"line_number":53,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for datadir.\u0027,"},{"line_number":54,"context_line":"                deprecated_name\u003d\u0027trove_volume_support\u0027),"},{"line_number":55,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027],"},{"line_number":56,"context_line":"                help\u003d\u0027Roles to add to an admin user.\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027update_status_on_fail\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_5fde8540","line":54,"in_reply_to":"5a890539_5ec22a87","updated":"2015-02-03 00:36:02.000000000","message":"Its better to completely remove them from the code, rather than first switching them to deprecated.","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"773dff8853284878978924f1a103c96ced635979","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    cfg.BoolOpt(\u0027use_nova_server_volume\u0027, default\u003dFalse,"},{"line_number":197,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for the \u0027"},{"line_number":198,"context_line":"                     \u0027Nova instance.\u0027,"},{"line_number":199,"context_line":"                deprecated_name\u003d\u0027use_nova_server_volume\u0027),"},{"line_number":200,"context_line":"    cfg.BoolOpt(\u0027use_heat\u0027, default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\u0027Use Heat for provisioning.\u0027),"},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027device_path\u0027, default\u003d\u0027/dev/vdb\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_96d832f2","line":199,"updated":"2014-11-26 17:05:18.000000000","message":"same as previous comment. \n\nI don\u0027t know what this change accomplishes. As best as I have been able to understand, the way in which you use deprecated_name and deprecated_section is when you move a parameter from one section to another.\n\nThis change doesn\u0027t, I don\u0027t believe, accomplish anything.","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b53d278be9ffc7bc5cc32eb16265a4b16ca64415","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    cfg.BoolOpt(\u0027use_nova_server_volume\u0027, default\u003dFalse,"},{"line_number":197,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for the \u0027"},{"line_number":198,"context_line":"                     \u0027Nova instance.\u0027,"},{"line_number":199,"context_line":"                deprecated_name\u003d\u0027use_nova_server_volume\u0027),"},{"line_number":200,"context_line":"    cfg.BoolOpt(\u0027use_heat\u0027, default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\u0027Use Heat for provisioning.\u0027),"},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027device_path\u0027, default\u003d\u0027/dev/vdb\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_3e5c7eed","line":199,"in_reply_to":"5a890539_96d832f2","updated":"2014-11-28 15:43:57.000000000","message":"This one is just being marked as deprecated, as it will no longer be supported in a future release.  Since we can\u0027t just delete something, this serves as the warning that in the future this option will no longer be available.\n\nIf I\u0027m wrong, and we intend to support this going forward, please let me know and I\u0027ll remove the deprecated tag.","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6237be3c174b9619e7aa9781e966feb4cdc812a2","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                deprecated_name\u003d\u0027use_nova_server_volume\u0027),"},{"line_number":200,"context_line":"    cfg.BoolOpt(\u0027use_heat\u0027, default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\u0027Use Heat for provisioning.\u0027),"},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027device_path\u0027, default\u003d\u0027/dev/vdb\u0027,"},{"line_number":203,"context_line":"               help\u003d\u0027Device path for volume if volume support is enabled.\u0027),"},{"line_number":204,"context_line":"    cfg.StrOpt(\u0027default_datastore\u0027, default\u003dNone,"},{"line_number":205,"context_line":"               help\u003d\u0027The default datastore id or name to use if one is not \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_6ea006a6","line":202,"updated":"2014-11-30 15:07:24.000000000","message":"device path is also a part of datastore options.\n\nalso, it seems like conf samples are saying that device path is a per-datastore option\n\nhttps://github.com/openstack/trove/blob/290b300edea3fc3800e9615bf128eb5a457f3938/etc/trove/trove.conf.sample#L187-L216\n\nalso, take a look at\nhttps://github.com/openstack/trove/blob/b2aa4f993e4559fee0410bd7b69753e4ab8c0e2c/trove/instance/models.py#L352-L354","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"773dff8853284878978924f1a103c96ced635979","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    cfg.StrOpt(\u0027backup_runner\u0027,"},{"line_number":265,"context_line":"               default\u003d\u0027trove.guestagent.backup.backup_types.InnoBackupEx\u0027,"},{"line_number":266,"context_line":"               help\u003d\u0027Runner to use for backups.\u0027,"},{"line_number":267,"context_line":"               deprecated_name\u003d\u0027backup_runner\u0027),"},{"line_number":268,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":269,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027,"},{"line_number":270,"context_line":"                deprecated_name\u003d\u0027backup_runner_options\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_16ec4292","line":267,"updated":"2014-11-26 17:05:18.000000000","message":"I don\u0027t know what this change accomplishes. As best as I have been able to understand, the way in which you use deprecated_name and deprecated_section is when you move a parameter from one section to another.\n\nThis change doesn\u0027t, I don\u0027t believe, accomplish anything.","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"773dff8853284878978924f1a103c96ced635979","unresolved":false,"context_lines":[{"line_number":267,"context_line":"               deprecated_name\u003d\u0027backup_runner\u0027),"},{"line_number":268,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":269,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027,"},{"line_number":270,"context_line":"                deprecated_name\u003d\u0027backup_runner_options\u0027),"},{"line_number":271,"context_line":"    cfg.BoolOpt(\u0027verify_swift_checksum_on_restore\u0027, default\u003dTrue,"},{"line_number":272,"context_line":"                help\u003d\u0027Enable verification of Swift checksum before starting \u0027"},{"line_number":273,"context_line":"                \u0027restore. Makes sure the checksum of original backup matches \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_76ebc678","line":270,"updated":"2014-11-26 17:05:18.000000000","message":"I don\u0027t know what this change accomplishes. As best as I have been able to understand, the way in which you use deprecated_name and deprecated_section is when you move a parameter from one section to another.\n\nThis change doesn\u0027t, I don\u0027t believe, accomplish anything.","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b53d278be9ffc7bc5cc32eb16265a4b16ca64415","unresolved":false,"context_lines":[{"line_number":267,"context_line":"               deprecated_name\u003d\u0027backup_runner\u0027),"},{"line_number":268,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":269,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027,"},{"line_number":270,"context_line":"                deprecated_name\u003d\u0027backup_runner_options\u0027),"},{"line_number":271,"context_line":"    cfg.BoolOpt(\u0027verify_swift_checksum_on_restore\u0027, default\u003dTrue,"},{"line_number":272,"context_line":"                help\u003d\u0027Enable verification of Swift checksum before starting \u0027"},{"line_number":273,"context_line":"                \u0027restore. Makes sure the checksum of original backup matches \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_de9ffa63","line":270,"in_reply_to":"5a890539_76ebc678","updated":"2014-11-28 15:43:57.000000000","message":"same goes for these two options.","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"773dff8853284878978924f1a103c96ced635979","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    cfg.BoolOpt(\u0027volume_support\u0027, default\u003dTrue,"},{"line_number":435,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for datadir.\u0027,"},{"line_number":436,"context_line":"                deprecated_name\u003d\u0027trove_volume_support\u0027,"},{"line_number":437,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":438,"context_line":"    cfg.StrOpt(\u0027device_path\u0027, default\u003d\u0027/dev/vdb\u0027,"},{"line_number":439,"context_line":"               help\u003d\u0027Device path for volume if volume support is enabled.\u0027),"},{"line_number":440,"context_line":"    cfg.DictOpt(\u0027backup_incremental_strategy\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_1661a211","line":437,"updated":"2014-11-26 17:05:18.000000000","message":"so I get this change ... moving trove_volume_support from default to mysql.","commit_id":"1f706308df316ce7c87544d11e8a2434d29a4bd3"}]}