)]}'
{"trove/extensions/mgmt/instances/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0b3b626930728f584c0a970e44d973ac75bc6f50","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class MgmtInstancePing(object):"},{"line_number":134,"context_line":"    @staticmethod"},{"line_number":135,"context_line":"    def rpc_ping(context, id):"},{"line_number":136,"context_line":"        guest_client \u003d remote.create_guest_client(context, id)"},{"line_number":137,"context_line":"        guest_client.rpc_ping()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_653768e4","line":134,"updated":"2014-12-08 18:24:36.000000000","message":"why static? why not class method or even instance object method?","commit_id":"83e8f415d427230f6f97fb8a2b9161c45a57f7a2"}],"trove/extensions/mgmt/instances/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0b3b626930728f584c0a970e44d973ac75bc6f50","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % req)"},{"line_number":197,"context_line":"        LOG.info(_(\"id : \u0027%s\u0027\\n\\n\") % id)"},{"line_number":198,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":199,"context_line":"        models.MgmtInstancePing.rpc_ping(context, id)"},{"line_number":200,"context_line":"        return wsgi.Result(None, 204)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a548705c","line":199,"updated":"2014-12-08 18:24:36.000000000","message":"decision is not really clear to me, seems like good solution is to use class method (to reduce memory usage).","commit_id":"83e8f415d427230f6f97fb8a2b9161c45a57f7a2"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"ed035395069bb9cc51c0e025ac11d9e79d57379d","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % req)"},{"line_number":197,"context_line":"        LOG.info(_(\"id : \u0027%s\u0027\\n\\n\") % id)"},{"line_number":198,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":199,"context_line":"        models.MgmtInstancePing.rpc_ping(context, id)"},{"line_number":200,"context_line":"        return wsgi.Result(None, 204)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_34cbd6a6","line":199,"in_reply_to":"3a961159_a548705c","updated":"2015-01-28 16:20:39.000000000","message":"I agree. As far as I understand, static methods in Python are mostly an organization/stylistic feature. Since MgmtInstancePing contains only a single method it is questionable whether it requires its own class at all.\n\nIf we need a class, a @classmethod would probably be more appropriate - it can also be overridden if that becomes necessary.","commit_id":"83e8f415d427230f6f97fb8a2b9161c45a57f7a2"}],"trove/guestagent/datastore/cassandra/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0b3b626930728f584c0a970e44d973ac75bc6f50","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.appStatus.update()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def rpc_ping(self, context):"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def restart(self, context):"},{"line_number":47,"context_line":"        self.app.restart()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_65acc8ee","line":44,"updated":"2014-12-08 18:24:36.000000000","message":"i guess if you are using call method type, shouldn\u0027t guest send something like \"OK\" instead of None?","commit_id":"83e8f415d427230f6f97fb8a2b9161c45a57f7a2"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"ed035395069bb9cc51c0e025ac11d9e79d57379d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.appStatus.update()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def rpc_ping(self, context):"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def restart(self, context):"},{"line_number":47,"context_line":"        self.app.restart()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_94c72245","line":44,"in_reply_to":"3a961159_65acc8ee","updated":"2015-01-28 16:20:39.000000000","message":"+1, or maybe could log a debug message too.","commit_id":"83e8f415d427230f6f97fb8a2b9161c45a57f7a2"}],"trove/guestagent/datastore/couchbase/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0b3b626930728f584c0a970e44d973ac75bc6f50","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        self.appStatus.update()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def rpc_ping(self, context):"},{"line_number":54,"context_line":"        return"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def change_passwords(self, context, users):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_85b9b430","line":53,"updated":"2014-12-08 18:24:36.000000000","message":"same","commit_id":"83e8f415d427230f6f97fb8a2b9161c45a57f7a2"}],"trove/guestagent/datastore/experimental/cassandra/manager.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d5bccef347dd040acc57fce1956a8c9b9dfa8043","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.appStatus.update()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def rpc_ping(self, context):"},{"line_number":44,"context_line":"        LOG.debug(_(\"Responding to RPC ping.\"))"},{"line_number":45,"context_line":"        return True"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def restart(self, context):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_26b833e8","line":44,"updated":"2015-03-16 20:17:54.000000000","message":"no _","commit_id":"1133bb8ec34e6601679cbd1c9ba7c5a0a0d76ec5"}],"trove/guestagent/datastore/experimental/couchbase/manager.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d5bccef347dd040acc57fce1956a8c9b9dfa8043","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.appStatus.update()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def rpc_ping(self, context):"},{"line_number":54,"context_line":"        LOG.debug(_(\"Responding to RPC ping.\"))"},{"line_number":55,"context_line":"        return True"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def change_passwords(self, context, users):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_a6e4230f","line":54,"updated":"2015-03-16 20:17:54.000000000","message":"no _","commit_id":"1133bb8ec34e6601679cbd1c9ba7c5a0a0d76ec5"}],"trove/guestagent/datastore/experimental/mongodb/manager.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d5bccef347dd040acc57fce1956a8c9b9dfa8043","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.status.update()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def rpc_ping(self, context):"},{"line_number":49,"context_line":"        LOG.debug(_(\"Responding to RPC ping.\"))"},{"line_number":50,"context_line":"        return True"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_26d11330","line":49,"updated":"2015-03-16 20:17:54.000000000","message":"no _","commit_id":"1133bb8ec34e6601679cbd1c9ba7c5a0a0d76ec5"}],"trove/guestagent/datastore/experimental/postgresql/manager.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d5bccef347dd040acc57fce1956a8c9b9dfa8043","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        PgSqlAppStatus.get().update()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def rpc_ping(self, context):"},{"line_number":54,"context_line":"        LOG.debug(_(\"Responding to RPC ping.\"))"},{"line_number":55,"context_line":"        return True"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def prepare("}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_c61af717","line":54,"updated":"2015-03-16 20:17:54.000000000","message":"no _ for debug, you can also lose the import","commit_id":"1133bb8ec34e6601679cbd1c9ba7c5a0a0d76ec5"}],"trove/guestagent/datastore/experimental/redis/manager.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d5bccef347dd040acc57fce1956a8c9b9dfa8043","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        RedisAppStatus.get().update()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def rpc_ping(self, context):"},{"line_number":52,"context_line":"        LOG.debug(_(\"Responding to RPC ping.\"))"},{"line_number":53,"context_line":"        return True"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def change_passwords(self, context, users):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_e617fbec","line":52,"updated":"2015-03-16 20:17:54.000000000","message":"no _","commit_id":"1133bb8ec34e6601679cbd1c9ba7c5a0a0d76ec5"}],"trove/guestagent/datastore/mongodb/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0b3b626930728f584c0a970e44d973ac75bc6f50","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \"\"\"Update the status of the MongoDB service.\"\"\""},{"line_number":45,"context_line":"        self.status.update()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def rpc_ping(self, context):"},{"line_number":48,"context_line":"        return"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a5b6b03b","line":47,"updated":"2014-12-08 18:24:36.000000000","message":"same","commit_id":"83e8f415d427230f6f97fb8a2b9161c45a57f7a2"}],"trove/guestagent/datastore/mysql/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0b3b626930728f584c0a970e44d973ac75bc6f50","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\"Update the status of the MySQL service.\"\"\""},{"line_number":49,"context_line":"        MySqlAppStatus.get().update()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def rpc_ping(self, context):"},{"line_number":52,"context_line":"        return"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def change_passwords(self, context, users):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_c582dc51","line":51,"updated":"2014-12-08 18:24:36.000000000","message":"same","commit_id":"83e8f415d427230f6f97fb8a2b9161c45a57f7a2"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d5bccef347dd040acc57fce1956a8c9b9dfa8043","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        MySqlAppStatus.get().update()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def rpc_ping(self, context):"},{"line_number":52,"context_line":"        LOG.debug(_(\"Responding to RPC ping.\"))"},{"line_number":53,"context_line":"        return True"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def change_passwords(self, context, users):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_66b22b08","line":52,"updated":"2015-03-16 20:17:54.000000000","message":"no _","commit_id":"1133bb8ec34e6601679cbd1c9ba7c5a0a0d76ec5"}],"trove/guestagent/datastore/postgresql/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0b3b626930728f584c0a970e44d973ac75bc6f50","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def update_status(self, context):"},{"line_number":50,"context_line":"        PgSqlAppStatus.get().update()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def rpc_ping(self, context):"},{"line_number":53,"context_line":"        return"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def prepare("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_e587d85f","line":52,"updated":"2014-12-08 18:24:36.000000000","message":"same","commit_id":"83e8f415d427230f6f97fb8a2b9161c45a57f7a2"}],"trove/guestagent/datastore/redis/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0b3b626930728f584c0a970e44d973ac75bc6f50","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        RedisAppStatus.get().update()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def rpc_ping(self, context):"},{"line_number":50,"context_line":"        return"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def change_passwords(self, context, users):"},{"line_number":53,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_057dc46e","line":50,"updated":"2014-12-08 18:24:36.000000000","message":"same","commit_id":"83e8f415d427230f6f97fb8a2b9161c45a57f7a2"}]}