)]}'
{"trove/taskmanager/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b31e5f2d008e319a3e7db3fcae846cd071b45f03","unresolved":false,"context_lines":[{"line_number":956,"context_line":"    def reboot(self):"},{"line_number":957,"context_line":"        try:"},{"line_number":958,"context_line":"            # Issue a guest stop db call to shutdown the db if running"},{"line_number":959,"context_line":"            LOG.debug(_(\"Stopping datastore on instance %s.\") % self.id)"},{"line_number":960,"context_line":"            try:"},{"line_number":961,"context_line":"                self.guest.stop_db()"},{"line_number":962,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_a6d2e259","line":959,"updated":"2014-10-03 13:39:51.000000000","message":"debug level doesn\u0027t need to be translated","commit_id":"4011a4662f9f6a902b1437b5df47030313e84d91"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"31a2e81ad18bb48754d324677d09f169a06d6350","unresolved":false,"context_lines":[{"line_number":956,"context_line":"    def reboot(self):"},{"line_number":957,"context_line":"        try:"},{"line_number":958,"context_line":"            # Issue a guest stop db call to shutdown the db if running"},{"line_number":959,"context_line":"            LOG.debug(_(\"Stopping datastore on instance %s.\") % self.id)"},{"line_number":960,"context_line":"            try:"},{"line_number":961,"context_line":"                self.guest.stop_db()"},{"line_number":962,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_9d7c44b7","line":959,"in_reply_to":"baa201ad_a6d2e259","updated":"2014-10-03 19:38:52.000000000","message":"ok will fix","commit_id":"4011a4662f9f6a902b1437b5df47030313e84d91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b31e5f2d008e319a3e7db3fcae846cd071b45f03","unresolved":false,"context_lines":[{"line_number":959,"context_line":"            LOG.debug(_(\"Stopping datastore on instance %s.\") % self.id)"},{"line_number":960,"context_line":"            try:"},{"line_number":961,"context_line":"                self.guest.stop_db()"},{"line_number":962,"context_line":"            except Exception as e:"},{"line_number":963,"context_line":"                # Acceptable to be here if db was already in crashed state"},{"line_number":964,"context_line":"                LOG.debug(str(e))"},{"line_number":965,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_66bc7a07","line":962,"updated":"2014-10-03 13:39:51.000000000","message":"too broad exception, you should expect GuestError, RemoteError, GuestTimeout exceptions and handle them appropriately.","commit_id":"4011a4662f9f6a902b1437b5df47030313e84d91"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"31a2e81ad18bb48754d324677d09f169a06d6350","unresolved":false,"context_lines":[{"line_number":959,"context_line":"            LOG.debug(_(\"Stopping datastore on instance %s.\") % self.id)"},{"line_number":960,"context_line":"            try:"},{"line_number":961,"context_line":"                self.guest.stop_db()"},{"line_number":962,"context_line":"            except Exception as e:"},{"line_number":963,"context_line":"                # Acceptable to be here if db was already in crashed state"},{"line_number":964,"context_line":"                LOG.debug(str(e))"},{"line_number":965,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_bd4ca89f","line":962,"in_reply_to":"baa201ad_66bc7a07","updated":"2014-10-03 19:38:52.000000000","message":"ok will fix, though the intention is to capture the broadest range of exception","commit_id":"4011a4662f9f6a902b1437b5df47030313e84d91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b31e5f2d008e319a3e7db3fcae846cd071b45f03","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                # We will bail if db did not get stopped or is blocked"},{"line_number":972,"context_line":"                LOG.error(_(\"Cannot reboot instance. DB status is %s.\")"},{"line_number":973,"context_line":"                          % self.datastore_status.status)"},{"line_number":974,"context_line":"                return"},{"line_number":975,"context_line":"            LOG.debug(_(\"The guest service status is %s.\")"},{"line_number":976,"context_line":"                      % self.datastore_status.status)"},{"line_number":977,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_264d123f","line":974,"range":{"start_line":974,"start_character":16,"end_line":974,"end_character":22},"updated":"2014-10-03 13:39:51.000000000","message":"don\u0027t need to use \u0027return\u0027 explicitly","commit_id":"4011a4662f9f6a902b1437b5df47030313e84d91"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"31a2e81ad18bb48754d324677d09f169a06d6350","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                # We will bail if db did not get stopped or is blocked"},{"line_number":972,"context_line":"                LOG.error(_(\"Cannot reboot instance. DB status is %s.\")"},{"line_number":973,"context_line":"                          % self.datastore_status.status)"},{"line_number":974,"context_line":"                return"},{"line_number":975,"context_line":"            LOG.debug(_(\"The guest service status is %s.\")"},{"line_number":976,"context_line":"                      % self.datastore_status.status)"},{"line_number":977,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_1d3f74d7","line":974,"in_reply_to":"baa201ad_264d123f","updated":"2014-10-03 19:38:52.000000000","message":"yes we do need to return if guest is not stopped, else we will be broadening the scope of this bug. Also the new code will not be backward compatible.","commit_id":"4011a4662f9f6a902b1437b5df47030313e84d91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b31e5f2d008e319a3e7db3fcae846cd071b45f03","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                LOG.error(_(\"Cannot reboot instance. DB status is %s.\")"},{"line_number":973,"context_line":"                          % self.datastore_status.status)"},{"line_number":974,"context_line":"                return"},{"line_number":975,"context_line":"            LOG.debug(_(\"The guest service status is %s.\")"},{"line_number":976,"context_line":"                      % self.datastore_status.status)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"            LOG.info(_(\"Rebooting instance %s.\") % self.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_a66022a6","line":975,"updated":"2014-10-03 13:39:51.000000000","message":"same as above","commit_id":"4011a4662f9f6a902b1437b5df47030313e84d91"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"31a2e81ad18bb48754d324677d09f169a06d6350","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                LOG.error(_(\"Cannot reboot instance. DB status is %s.\")"},{"line_number":973,"context_line":"                          % self.datastore_status.status)"},{"line_number":974,"context_line":"                return"},{"line_number":975,"context_line":"            LOG.debug(_(\"The guest service status is %s.\")"},{"line_number":976,"context_line":"                      % self.datastore_status.status)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"            LOG.info(_(\"Rebooting instance %s.\") % self.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_3d27d8cb","line":975,"in_reply_to":"baa201ad_a66022a6","updated":"2014-10-03 19:38:52.000000000","message":"wil fix.","commit_id":"4011a4662f9f6a902b1437b5df47030313e84d91"}]}