)]}'
{"trove/extensions/mgmt/instances/views.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"022a0ef6ca04df365a46d88a59bab8f657452a05","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            server \u003d self.instance.server"},{"line_number":72,"context_line":"            result[\u0027instance\u0027][\u0027server\u0027].update("},{"line_number":73,"context_line":"                {\u0027addresses\u0027: server.addresses})"},{"line_number":74,"context_line":"        elif self.instance.server_id:"},{"line_number":75,"context_line":"            result[\u0027instance\u0027][\u0027server\u0027] \u003d {\"id\": self.instance.server_id}"},{"line_number":76,"context_line":"        if self.root_history:"},{"line_number":77,"context_line":"            result[\u0027instance\u0027][\u0027root_enabled\u0027] \u003d self.root_history.created"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_c6cbd748","line":74,"updated":"2015-03-16 20:23:20.000000000","message":"not sure I understand this","commit_id":"cc1d7ab24022d175c9aed3f42eb785195e91844b"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2ec4b9ea82435e50f1f5a1835c5a2a46f24d7881","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            server \u003d self.instance.server"},{"line_number":72,"context_line":"            result[\u0027instance\u0027][\u0027server\u0027].update("},{"line_number":73,"context_line":"                {\u0027addresses\u0027: server.addresses})"},{"line_number":74,"context_line":"        elif self.instance.server_id:"},{"line_number":75,"context_line":"            result[\u0027instance\u0027][\u0027server\u0027] \u003d {\"id\": self.instance.server_id}"},{"line_number":76,"context_line":"        if self.root_history:"},{"line_number":77,"context_line":"            result[\u0027instance\u0027][\u0027root_enabled\u0027] \u003d self.root_history.created"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_65713344","line":74,"in_reply_to":"9a80dd14_284475b6","updated":"2015-03-17 04:21:38.000000000","message":"What use case covers this? I mean, AFAIU, you have the server_id of the instance that has been deleted. How could you use that information?","commit_id":"cc1d7ab24022d175c9aed3f42eb785195e91844b"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"8da479641935a6608ad97478c7789c3d58f22ae1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            server \u003d self.instance.server"},{"line_number":72,"context_line":"            result[\u0027instance\u0027][\u0027server\u0027].update("},{"line_number":73,"context_line":"                {\u0027addresses\u0027: server.addresses})"},{"line_number":74,"context_line":"        elif self.instance.server_id:"},{"line_number":75,"context_line":"            result[\u0027instance\u0027][\u0027server\u0027] \u003d {\"id\": self.instance.server_id}"},{"line_number":76,"context_line":"        if self.root_history:"},{"line_number":77,"context_line":"            result[\u0027instance\u0027][\u0027root_enabled\u0027] \u003d self.root_history.created"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_b8398ef4","line":74,"in_reply_to":"9a80dd14_65713344","updated":"2015-03-17 05:07:28.000000000","message":"This is the server_id of the corresponding nova server for the trove instance. It would be useful in case you wanted to troubleshoot the nova logs, for instance. Since nova uses soft-deletes, another case could be if an admin (for disaster/data recovery) wanted to restore a soft-deleted instance -- the corresponding nova instance id would be needed in that case.","commit_id":"cc1d7ab24022d175c9aed3f42eb785195e91844b"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"09c4669aaec3f5a5610610939b8d08bffc19f3bc","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            server \u003d self.instance.server"},{"line_number":72,"context_line":"            result[\u0027instance\u0027][\u0027server\u0027].update("},{"line_number":73,"context_line":"                {\u0027addresses\u0027: server.addresses})"},{"line_number":74,"context_line":"        elif self.instance.server_id:"},{"line_number":75,"context_line":"            result[\u0027instance\u0027][\u0027server\u0027] \u003d {\"id\": self.instance.server_id}"},{"line_number":76,"context_line":"        if self.root_history:"},{"line_number":77,"context_line":"            result[\u0027instance\u0027][\u0027root_enabled\u0027] \u003d self.root_history.created"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_9568fe22","line":74,"in_reply_to":"9a80dd14_b8398ef4","updated":"2015-03-17 15:18:00.000000000","message":"Fair enough :) Thanks for clearing it up","commit_id":"cc1d7ab24022d175c9aed3f42eb785195e91844b"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"cb6b8bf4c161795a0d01ea1d2ed73882a8f1a048","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            server \u003d self.instance.server"},{"line_number":72,"context_line":"            result[\u0027instance\u0027][\u0027server\u0027].update("},{"line_number":73,"context_line":"                {\u0027addresses\u0027: server.addresses})"},{"line_number":74,"context_line":"        elif self.instance.server_id:"},{"line_number":75,"context_line":"            result[\u0027instance\u0027][\u0027server\u0027] \u003d {\"id\": self.instance.server_id}"},{"line_number":76,"context_line":"        if self.root_history:"},{"line_number":77,"context_line":"            result[\u0027instance\u0027][\u0027root_enabled\u0027] \u003d self.root_history.created"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_284475b6","line":74,"in_reply_to":"9a80dd14_c6cbd748","updated":"2015-03-17 01:31:13.000000000","message":"This specifically tackles adding the nova server_id to the response in case of a show on a deleted trove instance. The actual nova server doesn\u0027t exist (since it has been deleted) so self.instance.server is None, but we still do keep track of the corresponding nova server id in the Trove database as self.instance.server_id. \n\nUseful for troubleshooting.","commit_id":"cc1d7ab24022d175c9aed3f42eb785195e91844b"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"cb6b8bf4c161795a0d01ea1d2ed73882a8f1a048","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                \"total\": self.instance.volume_total or None,"},{"line_number":90,"context_line":"            }"},{"line_number":91,"context_line":"        elif self.instance.volume_id:"},{"line_number":92,"context_line":"            result[\u0027instance\u0027][\u0027volume\u0027] \u003d {\"id\": self.instance.volume_id}"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            result[\u0027instance\u0027][\u0027volume\u0027] \u003d None"},{"line_number":95,"context_line":"        description \u003d self.instance.datastore_status.status.description"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_a80f8587","line":92,"updated":"2015-03-17 01:31:13.000000000","message":"Same here for the Cinder volume_id.","commit_id":"cc1d7ab24022d175c9aed3f42eb785195e91844b"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2ec4b9ea82435e50f1f5a1835c5a2a46f24d7881","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                \"total\": self.instance.volume_total or None,"},{"line_number":90,"context_line":"            }"},{"line_number":91,"context_line":"        elif self.instance.volume_id:"},{"line_number":92,"context_line":"            result[\u0027instance\u0027][\u0027volume\u0027] \u003d {\"id\": self.instance.volume_id}"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            result[\u0027instance\u0027][\u0027volume\u0027] \u003d None"},{"line_number":95,"context_line":"        description \u003d self.instance.datastore_status.status.description"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_a5924b49","line":92,"in_reply_to":"9a80dd14_a80f8587","updated":"2015-03-17 04:21:38.000000000","message":"Ditto","commit_id":"cc1d7ab24022d175c9aed3f42eb785195e91844b"}]}