)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"229975c6ab38361ce1b7a2ab4467da4e56f4761e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     amcrn \u003camcreynolds@ebaysf.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-20 16:49:47 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Instance-Delete Should Stop the Database First"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"on instance-delete, the database should be stopped before deleting"},{"line_number":10,"context_line":"the nova compute."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aa7fdbe_b30a5b1f","line":7,"updated":"2014-10-21 18:12:38.000000000","message":"I love the capitalization of the headline!","commit_id":"9a9477c2225ec05dc8f0a2e45fe0f4cdd0a33e7c"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4359e10e2bba40e44b3a9377e3b1ff1b34fd6edd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"on instance-delete, the database should be stopped before deleting"},{"line_number":10,"context_line":"the nova compute."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug #1381174"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I94c2fa08be7faac37e1ac0a4460ad61f1f7ef164"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aa7fdbe_30b58631","line":12,"updated":"2014-10-21 14:58:40.000000000","message":"Link is not created here probably due to missing colon.","commit_id":"9a9477c2225ec05dc8f0a2e45fe0f4cdd0a33e7c"}],"trove/taskmanager/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6035df31837e35ca7c68abb356dbd7994da15fee","unresolved":false,"context_lines":[{"line_number":851,"context_line":"                  \"resources.\" % self.id)"},{"line_number":852,"context_line":"        try:"},{"line_number":853,"context_line":"            self.guest.stop_db()"},{"line_number":854,"context_line":"        except Exception:"},{"line_number":855,"context_line":"            LOG.exception(_(\"Error stopping the datastore before attempting \""},{"line_number":856,"context_line":"                            \"to delete instance id %s.\") % self.id)"},{"line_number":857,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_1e56435c","line":854,"updated":"2014-10-17 10:51:46.000000000","message":"too broad exception,\nyou need to expect GuestError, RemoteError, GuestTimeout","commit_id":"2887052d1c0bcec28a41dbc08a35b074af376546"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"540b49ea1d0d7bcf692f12cb585927df0d55ea88","unresolved":false,"context_lines":[{"line_number":851,"context_line":"                  \"resources.\" % self.id)"},{"line_number":852,"context_line":"        try:"},{"line_number":853,"context_line":"            self.guest.stop_db()"},{"line_number":854,"context_line":"        except Exception:"},{"line_number":855,"context_line":"            LOG.exception(_(\"Error stopping the datastore before attempting \""},{"line_number":856,"context_line":"                            \"to delete instance id %s.\") % self.id)"},{"line_number":857,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_d4ff3064","line":854,"in_reply_to":"baa201ad_1e56435c","updated":"2014-10-17 18:13:15.000000000","message":"according to the code review guidelines, this is an opinion. if you look throughout this class, catching Exception is common and for good reason. no matter what the exception is on stop_db here, we should continue on with trying to delete the rest of the assets.","commit_id":"2887052d1c0bcec28a41dbc08a35b074af376546"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"d4df67d612afa6a0a3bb9cea040b876e81cdbbd8","unresolved":false,"context_lines":[{"line_number":852,"context_line":"        try:"},{"line_number":853,"context_line":"            self.guest.stop_db()"},{"line_number":854,"context_line":"        except Exception:"},{"line_number":855,"context_line":"            LOG.exception(_(\"Error stopping the datastore before attempting \""},{"line_number":856,"context_line":"                            \"to delete instance id %s.\") % self.id)"},{"line_number":857,"context_line":"        try:"},{"line_number":858,"context_line":"            if use_heat:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_1d22bbb8","line":855,"updated":"2014-10-17 20:40:35.000000000","message":"is the intent to throw an exception on delete when we cannot stop the db? or to just log it and continue with the delete?","commit_id":"2887052d1c0bcec28a41dbc08a35b074af376546"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"3659a2b2b06cbe89dee5ef04c6d6548caf0c6b27","unresolved":false,"context_lines":[{"line_number":852,"context_line":"        try:"},{"line_number":853,"context_line":"            self.guest.stop_db()"},{"line_number":854,"context_line":"        except Exception:"},{"line_number":855,"context_line":"            LOG.exception(_(\"Error stopping the datastore before attempting \""},{"line_number":856,"context_line":"                            \"to delete instance id %s.\") % self.id)"},{"line_number":857,"context_line":"        try:"},{"line_number":858,"context_line":"            if use_heat:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_4f6e2dcb","line":855,"in_reply_to":"baa201ad_1d22bbb8","updated":"2014-10-17 21:18:57.000000000","message":"log and continue with the delete.\n\nreasoning: there are a ton of reasons why a stop_db could fail, many of which could be red herrings (it\u0027s actually already stopped). since the stop_db is meant as a best effort for those who would desire a graceful shutdown before deletion, it\u0027s ok to proceed either way.","commit_id":"2887052d1c0bcec28a41dbc08a35b074af376546"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"229975c6ab38361ce1b7a2ab4467da4e56f4761e","unresolved":false,"context_lines":[{"line_number":850,"context_line":"            self.guest.stop_db()"},{"line_number":851,"context_line":"        except Exception:"},{"line_number":852,"context_line":"            LOG.exception(_(\"Error stopping the datastore before attempting \""},{"line_number":853,"context_line":"                            \"to delete instance id %s.\") % self.id)"},{"line_number":854,"context_line":"        try:"},{"line_number":855,"context_line":"            if use_heat:"},{"line_number":856,"context_line":"                # Delete the server via heat"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_b0b7b185","line":853,"updated":"2014-10-21 18:12:38.000000000","message":"Would it be possible to add some verbiage that would indicate that you are going ahead with the delete nonetheless.","commit_id":"9a9477c2225ec05dc8f0a2e45fe0f4cdd0a33e7c"}]}