)]}'
{"trove/backup/models.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6537ed3db0ab06eb20f09f547e744d592ce2763d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            ds \u003d instance_model.datastore"},{"line_number":77,"context_line":"            ds_version \u003d instance_model.datastore_version"},{"line_number":78,"context_line":"            parent \u003d None"},{"line_number":79,"context_line":"            if parent_id:"},{"line_number":80,"context_line":"                # Look up the parent info or fail early if not found or if"},{"line_number":81,"context_line":"                # the user does not have access to the parent."},{"line_number":82,"context_line":"                _parent \u003d cls.get_by_id(context, parent_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_5a82d2c8","side":"PARENT","line":79,"updated":"2014-10-24 00:48:11.000000000","message":"Why move this block of code. Honestly, it seems more sense to me to first check if a person is allowed to take backups before checking whether the parent is in failed state or not.\n\n\"Fast fail\" which you mention in the other review effectively means that it is now a \"slow fail\" for someone who isn\u0027t allowed to perform backups but tries ;)","commit_id":"101d454b70c0a386f39a1c1106ba66d86765cb7e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7229f5ebd3f791b030b51a8cc89756bc33bfed58","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            ds \u003d instance_model.datastore"},{"line_number":77,"context_line":"            ds_version \u003d instance_model.datastore_version"},{"line_number":78,"context_line":"            parent \u003d None"},{"line_number":79,"context_line":"            if parent_id:"},{"line_number":80,"context_line":"                # Look up the parent info or fail early if not found or if"},{"line_number":81,"context_line":"                # the user does not have access to the parent."},{"line_number":82,"context_line":"                _parent \u003d cls.get_by_id(context, parent_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_c16972bf","side":"PARENT","line":79,"in_reply_to":"9aa7fdbe_5a82d2c8","updated":"2014-10-24 10:59:27.000000000","message":"Ok. I see what you mean. If that\u0027s so, i\u0027d suggest next way to provide real fast-fail:\n1. Check if given instance is not a part of cluster.\n2. Check if backup\u0027ing is allowed.\n3. (Optinal, if parent ID was mentioned) Check if parent backup is not failed.\n4. Check if Swift is available.\n5. Do backup.","commit_id":"101d454b70c0a386f39a1c1106ba66d86765cb7e"}],"trove/common/exception.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6537ed3db0ab06eb20f09f547e744d592ce2763d","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"class ParentBackupFailedError(TroveError):"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    message \u003d _(\"Parent backup: %(backup_id)s is in FAILED state.\")"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"class BackupFileNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_faed46b8","line":370,"updated":"2014-10-24 00:48:11.000000000","message":"Since the state of that backup isn\u0027t going to change, the message \"Cannot create incremental backup on a failed parent backup %(id)s.\" may be more descriptive?\n\nFrom the simple consistency perspective, the all capitals looks out of place. For example, the previous exception isn\u0027t \"Unable to create instance because backup is NOT COMPLETED state\"","commit_id":"5fd1c1ba82e1f078feb373bdaef6b98a77440419"}]}