)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1cab7304e115b7404e40567cb35d280c78933bd3","unresolved":false,"context_lines":[{"line_number":17,"context_line":" - unit/fake-int tests proposed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Behaviour:"},{"line_number":20,"context_line":" - server side will raise IncrementalBackupNotSupported;"},{"line_number":21,"context_line":" - from client perspective this error will interpreted"},{"line_number":22,"context_line":"   as HTTP NotImplemented(501)."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_eb065f85","line":20,"updated":"2014-10-23 22:06:46.000000000","message":"I don\u0027t find this exception in the code proposed. Is the commit message correct?","commit_id":"965fb7a91aec5e729320884db108851e2e83d3b8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"39c749dc605988b3b8409cfcc9204a1380e151a8","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Changes:"},{"line_number":15,"context_line":" - incremental backups feature validation stage added;"},{"line_number":16,"context_line":" - refactoring validate_can_perform_action method of Backup class to handle cases, such as:"},{"line_number":17,"context_line":"   - validate that datastore is able to handle full backup creation;"},{"line_number":18,"context_line":"   - validate that datastore is able to handle incremental backup creation;"},{"line_number":19,"context_line":" - adding fix to fake guest to prevent fake-mode tests failure;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9aa7fdbe_13157e3f","line":16,"updated":"2014-10-24 19:23:53.000000000","message":"please wrap the commit message","commit_id":"92aeecd6796810f2fb02eb694501367a5a66d60c"}],"apidocs/src/samples/db-flavors-by-id-response.json":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"328002b4f0006c6b7c9e84e8b119173c80907a57","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \"str_id\": \"1\""},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"}"},{"line_number":19,"context_line":""}],"source_content_type":"application/json","patch_set":12,"id":"da86d52c_55dbdd7c","line":19,"updated":"2015-02-16 06:01:58.000000000","message":"This is what is making gate-trove-tox-checkniceness to fail, we do not need this blank line.","commit_id":"6c6e0d86bd24671d5ef6e5afc8849862a69f570e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bc546873c5fc66664a64388e6208b86d62d4de07","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \"str_id\": \"1\""},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"}"},{"line_number":19,"context_line":""}],"source_content_type":"application/json","patch_set":12,"id":"da86d52c_e4b3e14a","line":19,"updated":"2015-02-11 12:46:31.000000000","message":"is that a blank new-line?\n\nNot sure how this relates to the proposed change.","commit_id":"6c6e0d86bd24671d5ef6e5afc8849862a69f570e"}],"apidocs/src/samples/db-flavors-response.json":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"328002b4f0006c6b7c9e84e8b119173c80907a57","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        }"},{"line_number":211,"context_line":"    ]"},{"line_number":212,"context_line":"}"},{"line_number":213,"context_line":""}],"source_content_type":"application/json","patch_set":12,"id":"da86d52c_95e5553a","line":213,"updated":"2015-02-16 06:01:58.000000000","message":"This is what is making gate-trove-tox-checkniceness to fail, we do not need this blank line.","commit_id":"6c6e0d86bd24671d5ef6e5afc8849862a69f570e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bc546873c5fc66664a64388e6208b86d62d4de07","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        }"},{"line_number":211,"context_line":"    ]"},{"line_number":212,"context_line":"}"},{"line_number":213,"context_line":""}],"source_content_type":"application/json","patch_set":12,"id":"da86d52c_24897975","line":213,"updated":"2015-02-11 12:46:31.000000000","message":"ditto","commit_id":"6c6e0d86bd24671d5ef6e5afc8849862a69f570e"}],"apidocs/src/samples/db-mgmt-get-host-detail-response.json":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"328002b4f0006c6b7c9e84e8b119173c80907a57","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        \"usedRAM\": 4096"},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":""}],"source_content_type":"application/json","patch_set":12,"id":"da86d52c_b5e2592d","line":18,"updated":"2015-02-16 06:01:58.000000000","message":"This is what is making gate-trove-tox-checkniceness to fail, we do not need this blank line.","commit_id":"6c6e0d86bd24671d5ef6e5afc8849862a69f570e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bc546873c5fc66664a64388e6208b86d62d4de07","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        \"usedRAM\": 4096"},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":""}],"source_content_type":"application/json","patch_set":12,"id":"da86d52c_447aed77","line":18,"updated":"2015-02-11 12:46:31.000000000","message":"ditto","commit_id":"6c6e0d86bd24671d5ef6e5afc8849862a69f570e"}],"trove/backup/models.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1cab7304e115b7404e40567cb35d280c78933bd3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                operation\u003doperation, datastore\u003dinstance.datastore.name)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @classmethod"},{"line_number":51,"context_line":"    def validate_can_perform_incremental_backup(cls,"},{"line_number":52,"context_line":"                                                instance,"},{"line_number":53,"context_line":"                                                operation,"},{"line_number":54,"context_line":"                                                parent):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_6bd34f04","line":51,"updated":"2014-10-23 22:06:46.000000000","message":"I will reiterate my comment from earlier review that what is being accomplished in this change is to perform this three line test found in this method, and this test is performed in exactly one place.\n\nThere seems to be way too much code being added for something so simple as this. The earlier code had a new exception and the reason was that no other exception seemed to suffice. It appears that we\u0027ve now found an exception that must suffice. \n\nWe have in this method a parameter \u0027operation\u0027 which is redundant and should be defaulted to \u0027incremental backup\u0027 because ti isn\u0027t as though you change what you look for based on the operation that the user specifies.","commit_id":"965fb7a91aec5e729320884db108851e2e83d3b8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"39c749dc605988b3b8409cfcc9204a1380e151a8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                raise exception.DatastoreOperationNotSupported("},{"line_number":54,"context_line":"                    operation\u003doperation, datastore\u003dinstance.datastore.name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        def validate_can_perform_incremental_backup():"},{"line_number":57,"context_line":"            \"\"\""},{"line_number":58,"context_line":"            Raises exception if incremental backup is not supported"},{"line_number":59,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_f3a8fadc","line":56,"updated":"2014-10-24 19:23:53.000000000","message":"nobody uses this, why add this? more code for someone to manage later.\n\nalso, the earlier comment was that for about 3 lines of useful benefit, we\u0027re adding a lot more than 3 lines. Now it appears that we\u0027re adding even more.","commit_id":"92aeecd6796810f2fb02eb694501367a5a66d60c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1fb68481a99193d7d0702c4326e43c64641a420d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                raise exception.DatastoreOperationNotSupported("},{"line_number":54,"context_line":"                    operation\u003doperation, datastore\u003dinstance.datastore.name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        def validate_can_perform_incremental_backup():"},{"line_number":57,"context_line":"            \"\"\""},{"line_number":58,"context_line":"            Raises exception if incremental backup is not supported"},{"line_number":59,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_9ca25bfb","line":56,"in_reply_to":"9aa7fdbe_f3a8fadc","updated":"2014-10-24 21:28:52.000000000","message":"Amrith, completely disagree. I\u0027d to put less efforts for criticizing this code and propose something. It\u0027s pretty hard to satisfy all needs. Sometimes it\u0027s hard to find balance between size of fix and  the quality of it.\nI tried lots of variants, but the size (LOC) of all variants are not small. There\u0027s no fix that\u0027ll take from 5 up to 10 LOC.","commit_id":"92aeecd6796810f2fb02eb694501367a5a66d60c"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"6f4ba10d0ed9e3a1aec798595256ba5228a65e4c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            raise exception.DatastoreOperationNotSupported("},{"line_number":50,"context_line":"                operation\u003doperation,"},{"line_number":51,"context_line":"                datastore\u003dinstance.datastore.name)"},{"line_number":52,"context_line":"        if datastore_cfg and datastore_cfg.get(option_to_validate):"},{"line_number":53,"context_line":"            if isinstance(datastore_cfg.get(option_to_validate), dict):"},{"line_number":54,"context_line":"                if len(datastore_cfg.get(option_to_validate)) !\u003d 0:"},{"line_number":55,"context_line":"                    if not datastore_cfg.get(option_to_validate).get("}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_a08ef02b","line":52,"range":{"start_line":52,"start_character":47,"end_line":52,"end_character":65},"updated":"2015-02-05 22:44:04.000000000","message":"\u0027datastore_cfg.get(option_to_validate)\u0027 is used on every line here. I\u0027d suggest pulling it out into a local constant and using that instead of calling for it every time.","commit_id":"f3b414ce63f0a0d7c7aee35d3665520f53b3f384"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bc546873c5fc66664a64388e6208b86d62d4de07","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class Backup(object):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def validate_can_perform_action(cls, instance,"},{"line_number":41,"context_line":"                                    option_to_validate,"},{"line_number":42,"context_line":"                                    operation, **kwargs):"},{"line_number":43,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_6429b136","line":40,"updated":"2015-02-11 12:46:31.000000000","message":"I submit to you that this method needs more unit testing.","commit_id":"6c6e0d86bd24671d5ef6e5afc8849862a69f570e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bc546873c5fc66664a64388e6208b86d62d4de07","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            if isinstance(_option_to_validate, dict):"},{"line_number":55,"context_line":"                if len(_option_to_validate) !\u003d 0:"},{"line_number":56,"context_line":"                    if not _option_to_validate.get("},{"line_number":57,"context_line":"                            kwargs.get(\u0027parent\u0027).backup_type):"},{"line_number":58,"context_line":"                        _raise()"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            _raise()"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_a4f729d2","line":57,"updated":"2015-02-11 12:46:31.000000000","message":"what if kwargs.get(\u0027parent\u0027) doesn\u0027t have a backup_type?\n\ndon\u0027t you want kwargs.get(\u0027parent\u0027).get(\u0027backup_type\u0027)","commit_id":"6c6e0d86bd24671d5ef6e5afc8849862a69f570e"}]}