)]}'
{"trove/taskmanager/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b9d6484bc870e6bccb4513eef4b967f9b62572e9","unresolved":false,"context_lines":[{"line_number":947,"context_line":"                        self.id)"},{"line_number":948,"context_line":"                LOG.exception(msg)"},{"line_number":949,"context_line":"                raise TroveError(message\u003dmsg)"},{"line_number":950,"context_line":"            except Exception as e:"},{"line_number":951,"context_line":"                msg \u003d _(\"An unexpected error occurred while getting \""},{"line_number":952,"context_line":"                        \"the replication snapshot from %s\") % self.id"},{"line_number":953,"context_line":"                LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_93220150","line":950,"updated":"2014-10-28 21:45:52.000000000","message":"I\u0027d suggest to work with exception handling where it really needed. Like you said - templates handling, etc.\nCurrent fix just addresses symptoms. Let\u0027s find proper cure.","commit_id":"d6d602031732f35430284b78500794803dfaae63"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"78ae293b8b499929bada4578165f062b3e2f4848","unresolved":false,"context_lines":[{"line_number":951,"context_line":"                msg \u003d _(\"An unexpected error occurred while getting \""},{"line_number":952,"context_line":"                        \"the replication snapshot from %s\") % self.id"},{"line_number":953,"context_line":"                LOG.exception(msg)"},{"line_number":954,"context_line":"                raise TroveError(message\u003dmsg)"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"        return run_with_quotas(self.context.tenant, {\u0027backups\u0027: 1},"},{"line_number":957,"context_line":"                               _get_replication_snapshot)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_00121d58","line":954,"updated":"2014-10-29 17:42:01.000000000","message":"Both of the error messages in the separate catch blocks are pretty much identical.  If there is nothing meaningful we can surmise from catching the typed exceptions, then they should be collapsed into a single catch-all.","commit_id":"03cc641f348ed13fcc601d798c0d5fbfc570f074"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a70c7e65474bed85993471a50b753bea745a0624","unresolved":false,"context_lines":[{"line_number":944,"context_line":"                return result"},{"line_number":945,"context_line":"            except Exception:"},{"line_number":946,"context_line":"                msg \u003d (_(\"Failed to get replication snapshot from %s\") %"},{"line_number":947,"context_line":"                       self.id)"},{"line_number":948,"context_line":"                LOG.exception(msg)"},{"line_number":949,"context_line":"                raise TroveError(message\u003dmsg)"},{"line_number":950,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8c0949_5103cf41","line":947,"updated":"2014-11-06 11:26:10.000000000","message":"Missing period","commit_id":"565683c32272d43f87e1ee1ea6310995e8ae9790"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"33fdd41fc822dd82662c85e76c0a3cb343d913a4","unresolved":false,"context_lines":[{"line_number":946,"context_line":"                msg \u003d (_(\"Failed to get replication snapshot from %s\") %"},{"line_number":947,"context_line":"                       self.id)"},{"line_number":948,"context_line":"                LOG.exception(msg)"},{"line_number":949,"context_line":"                raise TroveError(message\u003dmsg)"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        return run_with_quotas(self.context.tenant, {\u0027backups\u0027: 1},"},{"line_number":952,"context_line":"                               _get_replication_snapshot)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_032d7efe","line":949,"updated":"2014-11-13 06:54:26.000000000","message":"Is there a reason to clobber the original exception with a TroveError?\n\nThis isn\u0027t in the API so I don\u0027t think the exception or traceback is being returned to the user.","commit_id":"565683c32272d43f87e1ee1ea6310995e8ae9790"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"5d15f7599cdf0d839d56e774f2073a24fb367c61","unresolved":false,"context_lines":[{"line_number":946,"context_line":"                msg \u003d (_(\"Failed to get replication snapshot from %s\") %"},{"line_number":947,"context_line":"                       self.id)"},{"line_number":948,"context_line":"                LOG.exception(msg)"},{"line_number":949,"context_line":"                raise TroveError(message\u003dmsg)"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        return run_with_quotas(self.context.tenant, {\u0027backups\u0027: 1},"},{"line_number":952,"context_line":"                               _get_replication_snapshot)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_b1f05868","line":949,"in_reply_to":"5a890539_032d7efe","updated":"2014-11-14 16:00:36.000000000","message":"You\u0027re right, none of this makes it back to the user. I did the wrap basically to indicate that the exception had been handled (i.e. logged) so it wouldn\u0027t be logged again later.  The calling point of this method will wrap it anyways, so I can remove it (however the message will then appear twice in the log, once here and again in the calling method).","commit_id":"565683c32272d43f87e1ee1ea6310995e8ae9790"}]}