)]}'
{"trove/tests/unittests/configuration/test_configuration_controller.py":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"9680423c0e943e1695442603b7e80cb1923d2e30","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        config_val1.max_size \u003d 18446744073709551615"},{"line_number":172,"context_line":"        config_val1.min_size \u003d 4096"},{"line_number":173,"context_line":"        config_val1.data_type \u003d \u0027integer\u0027"},{"line_number":174,"context_line":"        config_rules \u003d [config_val1]"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        ConfigurationsController._validate_configuration("},{"line_number":177,"context_line":"            {\u0027myisam_sort_buffer_size\u0027: 18446744073709551615},"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_9c164aa6","line":174,"updated":"2014-11-04 15:26:02.000000000","message":"I see code duplication here and in _test_validate_configuration(). Can we reuse it?","commit_id":"17a28954f1f2ae7dd2219d5f2a4b294289491c7c"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4c52d09dd02108fadcf6174dfb343f305ea655e1","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        config_rules \u003d [config_val1]"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        ConfigurationsController._validate_configuration("},{"line_number":177,"context_line":"            {\u0027myisam_sort_buffer_size\u0027: 18446744073709551615},"},{"line_number":178,"context_line":"            None, config_rules)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_a0e4d40d","line":177,"updated":"2014-10-31 17:01:33.000000000","message":"no negative tests? like picking a slightly smaller max value and using this value for the size etc.,\n\neffectively this test is a boundary test.","commit_id":"17a28954f1f2ae7dd2219d5f2a4b294289491c7c"}]}