)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"58f39973696a9034adb344af047bc09153cbf2b5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use unit file to enable systemd service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_ee97f445","line":9,"updated":"2014-12-15 07:56:10.000000000","message":"Have you reported the bug against systemd?","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a0a31137090056315a52e831a6b3ed88f6a6af25","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use unit file to enable systemd service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_3f3afd98","line":9,"in_reply_to":"3a961159_04e6d843","updated":"2014-12-15 13:12:37.000000000","message":"Just happened to jump into this and I thought I\u0027d drop my thoughts as well.\n\n@Ihar As much as I\u0027d like to believe that -1 shouldn\u0027t prevent people from reviewing patches, I don\u0027t think that\u0027s the case. 2 things about your comments above:\n\n1. -1 means there\u0027s something wrong about the patch. Your suggestion and concerns are related to something that doesn\u0027t depend on OpenStack *at all* therefore, putting -1 on this patch is wrong. What I normally do when I face cases like this is to drop a comment with a neutral vote (because the patch is *not wrong*) or I\u0027d go and do it *myself* if it\u0027s really important. If there\u0027s something broken in OpenStack, that\u0027s my priority when I review the patch. Encouraging folks to contribute to other open source projects is great but it\u0027s not a requirement.\n\n2. You both mentioned something important w.r.t when this would have been done by Sergey. Sergey said that he\u0027d have to do it in his free time and you raised a valid concern saying that it\u0027s a bit worrisome when to know that someone doesn\u0027t have enough time to do what\u0027s request. This, however, falls into the point .1, this is not something strictly related to OpenStack and contributors of this community are not *expected* to do work \"elsewhere\". This is to say that we should value more the time they have spent on fixing something in our project than worrying about the time they can\u0027t spend on other projects. This, for me, would be a perfect sign that I should report the issue myself and simply thank the person for his contribution.\n\nNow, please, take my words with the same humility that I\u0027m expressing them. My intention is just to provide some comments based on my experience and again, to share my humble opinion.\n\nThank you both for caring.","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"93a00662bbce9a6aeb7c5e4c30c5512a6b96a369","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use unit file to enable systemd service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_9f7e9168","line":9,"in_reply_to":"3a961159_30995279","updated":"2014-12-15 13:14:16.000000000","message":"In the meantime, you could carry a patch in the Fedora package.","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"72ff82d7be62a431f83512c40d7d8af0dc53db59","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use unit file to enable systemd service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_709bda17","line":9,"in_reply_to":"3a961159_30995279","updated":"2014-12-15 10:58:02.000000000","message":"No, I just mean we should not loose opportunity to make systemd developers aware of the issue. Once they are informed, they may work on the bug in parallel with your quick-fix.\n\nI don\u0027t mean that you should block the patch merge. Just report the bug upstream, then proceed with Trove fix.","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9951e3e03cb153a6edd48305ef268f8a59ce0d5b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use unit file to enable systemd service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_04e6d843","line":9,"in_reply_to":"3a961159_39bdbdd8","updated":"2014-12-15 12:42:06.000000000","message":"I don\u0027t think -1 vote is worth being called \u0027blocking the patch\u0027. In my world view, only -2 would count like that. If the patch *must* be merged, core reviewers are free to push it into the gate no matter what my vote is.\n\nI haven\u0027t considered the patch itself but based my vote on the commit message only, that suggested to me that we may miss a valid incompatibility issue in systemd you\u0027re spotted if we don\u0027t make reporting the bug to the project a priority. That concern is proved when you say that you\u0027ll open the bug on your free time. Probably being a busy person, it may indeed be the case that you won\u0027t find that free time in any near future.\n\n(That\u0027s the same thing as when someone suggests to report a bug in Launchpad before sending a patch for review, and the author of the patch answers that he will do it some time in the future in his spare time.)\n\nAll in all, thank you for considering my point; hopefully trove core reviewers will honestly judge whether this patch should go in immediately.","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"35d36b0ccbbe899f344d02bde7da2d5bfb811b35","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use unit file to enable systemd service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_30995279","line":9,"in_reply_to":"3a961159_6d9b0718","updated":"2014-12-15 10:47:08.000000000","message":"I am not sure I am following. Do you mean that meantime creating of Trove images for Fedora users should be impossible till then? Just because 2 month ago when I wrote this code in Trove I decided to use a full path instead of unit file name like 99% of users do?","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"5c549665c02ff910922702cfe2434bd079850499","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use unit file to enable systemd service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_39bdbdd8","line":9,"in_reply_to":"3a961159_709bda17","updated":"2014-12-15 12:21:31.000000000","message":"Ihar,\n\nI agree with you that systemd developers should be aware of that issue and I\u0027ll open a bug on my free time.\n\nBut your -1 blocking this patch from being merged because it\u0027s hard to bring \nreviewers to patch which is already minus oned. So can you, please, remove -1 if you agree that this patch must be merged?","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"28e4581cfdfcaa55f1fa64fc6c93a9fe6a9a383f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use unit file to enable systemd service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_6d9b0718","line":9,"in_reply_to":"3a961159_aaccf5bb","updated":"2014-12-15 10:24:04.000000000","message":"I think we should first report it in upstream, and only then allow the fix in.","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"4c5610689c1cc227219123ae6b632d7236745b70","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use unit file to enable systemd service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_d1480d2f","line":9,"in_reply_to":"3a961159_ee97f445","updated":"2014-12-15 13:43:28.000000000","message":"IMO having reported or not this bug against systemd doesn\u0027t change the fact that this fix is needed right now.","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"30f5b45fa3a5f89c179c624a8b337a9f8098886b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use unit file to enable systemd service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_aaccf5bb","line":9,"in_reply_to":"3a961159_ee97f445","updated":"2014-12-15 09:47:19.000000000","message":"Not yet.","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"93a00662bbce9a6aeb7c5e4c30c5512a6b96a369","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although systemd\u0027s systemctl should support an absolute path for unit"},{"line_number":10,"context_line":"file commands like for example \u0027enable\u0027, it seems like after latest"},{"line_number":11,"context_line":"Fedora update, the following doesn\u0027t work anymore:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"systemctl enable /usr/lib/systemd/system/mariadb.service"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_5f0b49d5","line":11,"updated":"2014-12-15 13:14:16.000000000","message":"Full path was documented as supported in Fedora 20 can you be specific which update is that: F20 update or F21 new release?\n\nIn anycase, please file bug against systemd upstream and reference it here.","commit_id":"286697750b33b9d16e5d62562380a32332fc83dc"}],"trove/guestagent/common/operating_system.py":[{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"f9ebd00dd3283816429744d4d7bbc61903bf96b3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            # replacing a symlink with its real path"},{"line_number":83,"context_line":"            if os.path.islink(service_path):"},{"line_number":84,"context_line":"                real_path \u003d os.path.realpath(service_path)"},{"line_number":85,"context_line":"                unit_file \u003d os.path.basename(real_path)"},{"line_number":86,"context_line":"                result[\u0027cmd_enable\u0027] \u003d \"sudo systemctl enable %s\" % unit_file"},{"line_number":87,"context_line":"                result[\u0027cmd_disable\u0027] \u003d (\"sudo systemctl disable %s\" %"},{"line_number":88,"context_line":"                                         unit_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_323884d2","line":85,"updated":"2014-12-14 18:58:50.000000000","message":"Maybe unit_file_name instead of unit_file?","commit_id":"12f8a656cb281bf00b27a1c1e0b5887423bcd5c8"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"ea9325e60ece40c85d7a381af781bc9633359105","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            # replacing a symlink with its real path"},{"line_number":83,"context_line":"            if os.path.islink(service_path):"},{"line_number":84,"context_line":"                real_path \u003d os.path.realpath(service_path)"},{"line_number":85,"context_line":"                unit_file \u003d os.path.basename(real_path)"},{"line_number":86,"context_line":"                result[\u0027cmd_enable\u0027] \u003d \"sudo systemctl enable %s\" % unit_file"},{"line_number":87,"context_line":"                result[\u0027cmd_disable\u0027] \u003d (\"sudo systemctl disable %s\" %"},{"line_number":88,"context_line":"                                         unit_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_928bf81d","line":85,"in_reply_to":"3a961159_323884d2","updated":"2014-12-14 20:19:21.000000000","message":"Sure. Sounds good!","commit_id":"12f8a656cb281bf00b27a1c1e0b5887423bcd5c8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"8fa7a964cadbbd759309f256a4f5204b0aa001f8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            # replacing a symlink with its real path"},{"line_number":83,"context_line":"            if os.path.islink(service_path):"},{"line_number":84,"context_line":"                real_path \u003d os.path.realpath(service_path)"},{"line_number":85,"context_line":"                unit_file_name \u003d os.path.basename(real_path)"},{"line_number":86,"context_line":"                result[\u0027cmd_enable\u0027] \u003d (\"sudo systemctl enable %s\" %"},{"line_number":87,"context_line":"                                        unit_file_name)"},{"line_number":88,"context_line":"                result[\u0027cmd_disable\u0027] \u003d (\"sudo systemctl disable %s\" %"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_d64d0ac6","line":85,"updated":"2014-12-17 17:17:20.000000000","message":"I would add a comment with a reference to why this is being done.","commit_id":"bdb3f3b3b9bda93055ac20ee0bfbbe5aecf1d37b"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"5baeccdeb99f16307930b092b10532f1c7337d7b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            # replacing a symlink with its real path"},{"line_number":83,"context_line":"            if os.path.islink(service_path):"},{"line_number":84,"context_line":"                real_path \u003d os.path.realpath(service_path)"},{"line_number":85,"context_line":"                unit_file_name \u003d os.path.basename(real_path)"},{"line_number":86,"context_line":"                result[\u0027cmd_enable\u0027] \u003d (\"sudo systemctl enable %s\" %"},{"line_number":87,"context_line":"                                        unit_file_name)"},{"line_number":88,"context_line":"                result[\u0027cmd_disable\u0027] \u003d (\"sudo systemctl disable %s\" %"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_f4b71ed6","line":85,"in_reply_to":"3a961159_d64d0ac6","updated":"2014-12-19 10:35:03.000000000","message":"Reading the comment above -- I have a question. Consider the case when the unit is symlinked to a real file with a different name -- does systemd work with the basename of the real file, or the basename of the symlink? Because if it\u0027s the latter, this could cause an error in that case.","commit_id":"bdb3f3b3b9bda93055ac20ee0bfbbe5aecf1d37b"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"a36836405d74f45bd74fb4478ba5289c81b39816","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            # replacing a symlink with its real path"},{"line_number":83,"context_line":"            if os.path.islink(service_path):"},{"line_number":84,"context_line":"                real_path \u003d os.path.realpath(service_path)"},{"line_number":85,"context_line":"                unit_file_name \u003d os.path.basename(real_path)"},{"line_number":86,"context_line":"                result[\u0027cmd_enable\u0027] \u003d (\"sudo systemctl enable %s\" %"},{"line_number":87,"context_line":"                                        unit_file_name)"},{"line_number":88,"context_line":"                result[\u0027cmd_disable\u0027] \u003d (\"sudo systemctl disable %s\" %"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_4f11065c","line":85,"in_reply_to":"3a961159_f4b71ed6","updated":"2014-12-22 22:45:10.000000000","message":"In case of \"enable\" action systemd works with the basename of the real file. All other commands support both real file and symlink.","commit_id":"bdb3f3b3b9bda93055ac20ee0bfbbe5aecf1d37b"}]}