)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b69e15e36595e41c2bffb1ad45aa26ac9ccca5bb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":"- query used in list_database for MySQL datastore uses a"},{"line_number":11,"context_line":"  hard-coded where clause condition to filter schemas,"},{"line_number":12,"context_line":"  instead of using the values from config variable gnore_dbs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Changes:"},{"line_number":15,"context_line":"- Removed the hard-coded where condition."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_e3f81b7e","line":12,"updated":"2014-12-22 12:50:36.000000000","message":"s/gnore_dbs/ignore_dbs","commit_id":"cc874295e4a3e8b7d0a16b8342f8628c1670f1ba"}],"trove/guestagent/datastore/mysql/service.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"9250b3e514501607b065e8ac1a99d4925e8b4422","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                    mysql_db.collate \u003d database[2]"},{"line_number":458,"context_line":"                    databases.append(mysql_db.serialize())"},{"line_number":459,"context_line":"                except ValueError:"},{"line_number":460,"context_line":"                    # Just ignore the value from ignore_dbs"},{"line_number":461,"context_line":"                    pass"},{"line_number":462,"context_line":"        LOG.debug(\"databases \u003d \" + str(databases))"},{"line_number":463,"context_line":"        if database_names.rowcount \u003c\u003d limit:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_85d7b1be","line":460,"updated":"2015-02-03 15:29:44.000000000","message":"I would suggest logging a DEBUG statement with the actual validation error message here. Just in case one day somebody is looking for mysteriously missing user databases...","commit_id":"996ad22ec30db3af5c0716fa910cbccc0b8473fe"},{"author":{"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},"change_message_id":"aa247d134636992ecbdc1e6c932197c670af8881","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                    mysql_db.collate \u003d database[2]"},{"line_number":458,"context_line":"                    databases.append(mysql_db.serialize())"},{"line_number":459,"context_line":"                except ValueError:"},{"line_number":460,"context_line":"                    # Just ignore the value from ignore_dbs"},{"line_number":461,"context_line":"                    pass"},{"line_number":462,"context_line":"        LOG.debug(\"databases \u003d \" + str(databases))"},{"line_number":463,"context_line":"        if database_names.rowcount \u003c\u003d limit:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_aeeb9b11","line":460,"in_reply_to":"da86d52c_1e114fac","updated":"2015-02-04 01:08:47.000000000","message":"I agree with Petr and Denis. I don\u0027t like the idea that we are just ignoring the exception.","commit_id":"996ad22ec30db3af5c0716fa910cbccc0b8473fe"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7e2c618da74a91cdc477efd00f3f6af415f72938","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                    mysql_db.collate \u003d database[2]"},{"line_number":458,"context_line":"                    databases.append(mysql_db.serialize())"},{"line_number":459,"context_line":"                except ValueError:"},{"line_number":460,"context_line":"                    # Just ignore the value from ignore_dbs"},{"line_number":461,"context_line":"                    pass"},{"line_number":462,"context_line":"        LOG.debug(\"databases \u003d \" + str(databases))"},{"line_number":463,"context_line":"        if database_names.rowcount \u003c\u003d limit:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1e114fac","line":460,"in_reply_to":"da86d52c_85d7b1be","updated":"2015-02-03 16:21:43.000000000","message":"Agreed with Petr, that it\u0027ll be a good thing to have logging here, but a bit disagree on the level. I\u0027d suggest to add EXCEPTION level with DEBUG level.","commit_id":"996ad22ec30db3af5c0716fa910cbccc0b8473fe"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"32a16d31f9f1fb28a342b5f2664a90543de1cdd9","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                    mysql_db.collate \u003d database[2]"},{"line_number":458,"context_line":"                    databases.append(mysql_db.serialize())"},{"line_number":459,"context_line":"                except ValueError:"},{"line_number":460,"context_line":"                    LOG.debug(\"database \u003d %s is on ignore_dbs list\" %"},{"line_number":461,"context_line":"                              str(database))"},{"line_number":462,"context_line":"        LOG.debug(\"databases \u003d \" + str(databases))"},{"line_number":463,"context_line":"        if database_names.rowcount \u003c\u003d limit:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_a086b963","line":460,"updated":"2015-02-07 21:01:48.000000000","message":"I would personally prefer a slightly more descriptive message (something like \"Database name \u0027%s\u0027 is on the ignore list (ignore_dbs) and will be omitted from the output.\").","commit_id":"1feb8987ef1f8c7cf6a5fe91e9707f890a51a3fd"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"1ee01a7a81618a81a4b0b12013a6d52694d087da","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                    databases.append(mysql_db.serialize())"},{"line_number":459,"context_line":"                except ValueError:"},{"line_number":460,"context_line":"                    LOG.debug(\"database \u003d %s is on ignore_dbs list\" %"},{"line_number":461,"context_line":"                              str(database))"},{"line_number":462,"context_line":"        LOG.debug(\"databases \u003d \" + str(databases))"},{"line_number":463,"context_line":"        if database_names.rowcount \u003c\u003d limit:"},{"line_number":464,"context_line":"            next_marker \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_7173a715","line":461,"updated":"2015-02-09 09:13:51.000000000","message":"Skipping the DBs like this has the potential to break pagination -- since you are no longer guaranteed that you have a \"limit\" number of entries. Consider adding the ignore_dbs list to the where clause, or updating count taking into account the skipped DBs.","commit_id":"1feb8987ef1f8c7cf6a5fe91e9707f890a51a3fd"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"01618288ff1a4390aa89db12a788cf5b21e6485d","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                    databases.append(mysql_db.serialize())"},{"line_number":459,"context_line":"                except ValueError:"},{"line_number":460,"context_line":"                    LOG.debug(\"database \u003d %s is on ignore_dbs list\" %"},{"line_number":461,"context_line":"                              str(database))"},{"line_number":462,"context_line":"        LOG.debug(\"databases \u003d \" + str(databases))"},{"line_number":463,"context_line":"        if database_names.rowcount \u003c\u003d limit:"},{"line_number":464,"context_line":"            next_marker \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_f0b2c347","line":461,"in_reply_to":"da86d52c_1fb05b42","updated":"2015-02-18 08:12:48.000000000","message":"That would be my first preference as well (hence I mentioned it first). I don\u0027t see why de-coupling count from the loop variable and incrementing it independently only when the db doesn\u0027t match one on the ignore list wouldn\u0027t work -- limit is just the page limit, so that should stay constant. However, the former solution of just adding the ignore_dbs to the where clause seems cleaner, so I\u0027d probably stick with that.","commit_id":"1feb8987ef1f8c7cf6a5fe91e9707f890a51a3fd"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"ec723d3d2db35a8523a205476b8bab16a505616b","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                    databases.append(mysql_db.serialize())"},{"line_number":459,"context_line":"                except ValueError:"},{"line_number":460,"context_line":"                    LOG.debug(\"database \u003d %s is on ignore_dbs list\" %"},{"line_number":461,"context_line":"                              str(database))"},{"line_number":462,"context_line":"        LOG.debug(\"databases \u003d \" + str(databases))"},{"line_number":463,"context_line":"        if database_names.rowcount \u003c\u003d limit:"},{"line_number":464,"context_line":"            next_marker \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_1fb05b42","line":461,"in_reply_to":"da86d52c_7173a715","updated":"2015-02-10 21:04:08.000000000","message":"I think we should just add the _ignore_dbs to the where clause. I\u0027m not sure I quite get why we decided to rely on _is_valid() to figure this out. Updating count proposed by Nikhil won\u0027t work, you\u0027d have to update limit based on the number of _ignore_db\u0027s, right?","commit_id":"1feb8987ef1f8c7cf6a5fe91e9707f890a51a3fd"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"9b41a661ad9d29cb74e9c1cb5fc6b56a59217f5c","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                    databases.append(mysql_db.serialize())"},{"line_number":459,"context_line":"                except ValueError:"},{"line_number":460,"context_line":"                    LOG.debug(\"database \u003d %s is on ignore_dbs list\" %"},{"line_number":461,"context_line":"                              str(database))"},{"line_number":462,"context_line":"        LOG.debug(\"databases \u003d \" + str(databases))"},{"line_number":463,"context_line":"        if database_names.rowcount \u003c\u003d limit:"},{"line_number":464,"context_line":"            next_marker \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_668f4c24","line":461,"in_reply_to":"da86d52c_7173a715","updated":"2015-02-09 19:42:48.000000000","message":"good catch, agreed.","commit_id":"1feb8987ef1f8c7cf6a5fe91e9707f890a51a3fd"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"28e5927ece4b2a2ae5ad8be29fb8964fd5980788","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            ]"},{"line_number":436,"context_line":"            q.tables \u003d [\u0027information_schema.schemata\u0027]"},{"line_number":437,"context_line":"            q.where \u003d [\"schema_name NOT IN (\u0027\" +"},{"line_number":438,"context_line":"                       \"\u0027, \u0027\".join(CONF.ignore_dbs) +"},{"line_number":439,"context_line":"                       \"\u0027)\"]"},{"line_number":440,"context_line":"            q.order \u003d [\u0027schema_name ASC\u0027]"},{"line_number":441,"context_line":"            if limit:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_375196d9","line":438,"updated":"2015-02-18 19:01:29.000000000","message":"Since we now have this list, wouldn\u0027t it still be a good idea to leave a log message with what names are being ignored?","commit_id":"61c7332adc5d26aae565e5fb21428a4ec3bbeaa7"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"45ef0cfaba63dc302da8fbb9faad1fb43f740cfb","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            ]"},{"line_number":436,"context_line":"            q.tables \u003d [\u0027information_schema.schemata\u0027]"},{"line_number":437,"context_line":"            q.where \u003d [\"schema_name NOT IN (\u0027\" +"},{"line_number":438,"context_line":"                       \"\u0027, \u0027\".join(CONF.ignore_dbs) +"},{"line_number":439,"context_line":"                       \"\u0027)\"]"},{"line_number":440,"context_line":"            q.order \u003d [\u0027schema_name ASC\u0027]"},{"line_number":441,"context_line":"            if limit:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_a1c15fe6","line":438,"in_reply_to":"ba7be1f8_f485d6ad","updated":"2015-02-20 13:32:24.000000000","message":"why do we need that list to be printed, it is simply everytime going to be the entire list, since there is no selective restriction to what goes in the query","commit_id":"61c7332adc5d26aae565e5fb21428a4ec3bbeaa7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"904af1f54bce47caab2e22d37e9795eea6b78198","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            ]"},{"line_number":436,"context_line":"            q.tables \u003d [\u0027information_schema.schemata\u0027]"},{"line_number":437,"context_line":"            q.where \u003d [\"schema_name NOT IN (\u0027\" +"},{"line_number":438,"context_line":"                       \"\u0027, \u0027\".join(CONF.ignore_dbs) +"},{"line_number":439,"context_line":"                       \"\u0027)\"]"},{"line_number":440,"context_line":"            q.order \u003d [\u0027schema_name ASC\u0027]"},{"line_number":441,"context_line":"            if limit:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_f485d6ad","line":438,"in_reply_to":"da86d52c_375196d9","updated":"2015-02-20 12:42:53.000000000","message":"Each time someone runs this command? Seems a tad excessive to me ...","commit_id":"61c7332adc5d26aae565e5fb21428a4ec3bbeaa7"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"54264a305b41588a8b64b849547340f0bd05e59d","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def list_databases(self, limit\u003dNone, marker\u003dNone, include_marker\u003dFalse):"},{"line_number":422,"context_line":"        \"\"\"List databases the user created on this mysql instance.\"\"\""},{"line_number":423,"context_line":"        LOG.debug(\"---Listing Databases---\")"},{"line_number":424,"context_line":"        databases \u003d []"},{"line_number":425,"context_line":"        with LocalSqlClient(get_engine()) as client:"},{"line_number":426,"context_line":"            # If you have an external volume mounted at /var/lib/mysql"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_cb6e62c9","line":423,"updated":"2015-02-20 18:56:36.000000000","message":"Since we are already logging a DEBUG statement anyway why not to do something like this. I just see picture somebody desperately trying to figure out why a particular database is not showing up.\n\nLOG.debug(\"---Listing Databases---\")\n_ignored_database_names \u003d \"\u0027%s\u0027\" % \"\u0027, \u0027\".join(CONF.ignore_dbs) \nLOG.debug(\"The following database names are on the ignore list and will be omitted from the listing: %s\" % _ignored_database_names)\n\n...\n\nq.where \u003d \"schema_name NOT IN (%)\" % _ignored_database_names","commit_id":"fada982689bfd31a52a17af16846ea13d3b7d44e"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"2eac300867ac7f2f312e603a5d3693153c8b7313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a80dd14_fa997e1f","updated":"2015-03-20 14:09:43.000000000","message":"If","commit_id":"287372bae47a1967b60f11e28c91e99eb539af0e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"44936bf70165afcfc6b6113d2c78ff3ecf9aa575","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        \"\"\""},{"line_number":419,"context_line":"        return MySqlRootAccess.enable_root(root_password)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def list_databases(self, limit\u003dNone, marker\u003dNone, include_marker\u003dFalse):"},{"line_number":422,"context_line":"        \"\"\"List databases the user created on this mysql instance.\"\"\""},{"line_number":423,"context_line":"        LOG.debug(\"---Listing Databases---\")"},{"line_number":424,"context_line":"        _ignored_database_names \u003d \"\u0027%s\u0027\" % \"\u0027, \u0027\".join(CONF.ignore_dbs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_66aa5e72","line":421,"updated":"2015-03-20 13:48:41.000000000","message":"I\u0027d prefer (and this isn\u0027t anything other than a suggestion) that you make this function:\n\nlist_databases(self, limit, marker, include_marker, ignore\u003dCONF.ignore_dbs):\n\nand go from there. Just a suggestion.","commit_id":"287372bae47a1967b60f11e28c91e99eb539af0e"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"076391eda46a685b5a9e524934aa6633d57e6345","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    def list_databases(self, limit\u003dNone, marker\u003dNone, include_marker\u003dFalse):"},{"line_number":422,"context_line":"        \"\"\"List databases the user created on this mysql instance.\"\"\""},{"line_number":423,"context_line":"        LOG.debug(\"---Listing Databases---\")"},{"line_number":424,"context_line":"        _ignored_database_names \u003d \"\u0027%s\u0027\" % \"\u0027, \u0027\".join(CONF.ignore_dbs)"},{"line_number":425,"context_line":"        LOG.debug(\"The following database names are on ignore list and will \""},{"line_number":426,"context_line":"                  \"be omitted from the listing: %s\" % _ignored_database_names)"},{"line_number":427,"context_line":"        databases \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_902a7fe5","line":424,"updated":"2015-03-18 20:33:37.000000000","message":"Local variables shouldn\u0027t start with an \u0027_\u0027.","commit_id":"287372bae47a1967b60f11e28c91e99eb539af0e"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"2eac300867ac7f2f312e603a5d3693153c8b7313","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    def list_databases(self, limit\u003dNone, marker\u003dNone, include_marker\u003dFalse):"},{"line_number":422,"context_line":"        \"\"\"List databases the user created on this mysql instance.\"\"\""},{"line_number":423,"context_line":"        LOG.debug(\"---Listing Databases---\")"},{"line_number":424,"context_line":"        _ignored_database_names \u003d \"\u0027%s\u0027\" % \"\u0027, \u0027\".join(CONF.ignore_dbs)"},{"line_number":425,"context_line":"        LOG.debug(\"The following database names are on ignore list and will \""},{"line_number":426,"context_line":"                  \"be omitted from the listing: %s\" % _ignored_database_names)"},{"line_number":427,"context_line":"        databases \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_5adc4ae4","line":424,"in_reply_to":"9a80dd14_66c5fe5a","updated":"2015-03-20 14:09:43.000000000","message":"That\u0027s to quote individual db names. The separator inserts closing and opening while the placeholder provides the outside quotes for the first/last element.","commit_id":"287372bae47a1967b60f11e28c91e99eb539af0e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"44936bf70165afcfc6b6113d2c78ff3ecf9aa575","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    def list_databases(self, limit\u003dNone, marker\u003dNone, include_marker\u003dFalse):"},{"line_number":422,"context_line":"        \"\"\"List databases the user created on this mysql instance.\"\"\""},{"line_number":423,"context_line":"        LOG.debug(\"---Listing Databases---\")"},{"line_number":424,"context_line":"        _ignored_database_names \u003d \"\u0027%s\u0027\" % \"\u0027, \u0027\".join(CONF.ignore_dbs)"},{"line_number":425,"context_line":"        LOG.debug(\"The following database names are on ignore list and will \""},{"line_number":426,"context_line":"                  \"be omitted from the listing: %s\" % _ignored_database_names)"},{"line_number":427,"context_line":"        databases \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_66c5fe5a","line":424,"in_reply_to":"9a80dd14_902a7fe5","updated":"2015-03-20 13:48:41.000000000","message":"The quoting here confuses me no end.\n\nYou have ... \"\u0027%s\u0027\". \n\nIs that right? Should it be \"%s\", does it matter?\n\nMy quick test from a python shell says it doesn\u0027t but I\u0027m not sure I understand this completely.\n\namrith@homegw:~$ python\nPython 2.7.6 (default, Mar 22 2014, 22:59:56)\n[GCC 4.8.2] on linux2\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e ign\u003d[\u0027abc\u0027, \u0027def\u0027]\n\u003e\u003e\u003e name\u003d\"\u0027%s\u0027\" % \"\u0027, \u0027\".join(ign)\n\u003e\u003e\u003e print name\n\u0027abc\u0027, \u0027def\u0027\n\nThe output above indicates that you are correct but I\u0027m not sure why you have \"\u0027%s\u0027\" and not just \"%s\". Also whether it matters.","commit_id":"287372bae47a1967b60f11e28c91e99eb539af0e"}],"trove/tests/unittests/guestagent/test_dbaas.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"904af1f54bce47caab2e22d37e9795eea6b78198","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                    \"default_collation_name as collation\","},{"line_number":333,"context_line":"                    \"FROM information_schema.schemata\","},{"line_number":334,"context_line":"                    (\"schema_name NOT IN (\""},{"line_number":335,"context_line":"                     \"\u0027lost+found\u0027, \""},{"line_number":336,"context_line":"                     \"\u0027mysql\u0027, \u0027information_schema\u0027\""},{"line_number":337,"context_line":"                     \")\"),"},{"line_number":338,"context_line":"                    \"ORDER BY schema_name ASC\","}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_544a2284","line":335,"updated":"2015-02-20 12:42:53.000000000","message":"Since you are changing the code in list_databases() to use CONF.ignore_dbs instead of the earlier fixed list, it would be good to have a test that actually ensures that this is the case. As it is, all you are testing is the formatting of the string but not the essence of your change, namely that you now use CONF.ignore_dbs. \n\nI could, in theory revert that change and use the static list of three databases below and you still wouldn\u0027t catch it.","commit_id":"61c7332adc5d26aae565e5fb21428a4ec3bbeaa7"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"45ef0cfaba63dc302da8fbb9faad1fb43f740cfb","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                    \"default_collation_name as collation\","},{"line_number":333,"context_line":"                    \"FROM information_schema.schemata\","},{"line_number":334,"context_line":"                    (\"schema_name NOT IN (\""},{"line_number":335,"context_line":"                     \"\u0027lost+found\u0027, \""},{"line_number":336,"context_line":"                     \"\u0027mysql\u0027, \u0027information_schema\u0027\""},{"line_number":337,"context_line":"                     \")\"),"},{"line_number":338,"context_line":"                    \"ORDER BY schema_name ASC\","}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_81637b19","line":335,"in_reply_to":"ba7be1f8_544a2284","updated":"2015-02-20 13:32:24.000000000","message":"I would take that amrith, sure this needs to be updated, to behave as the values in CONF.ignore_dbs","commit_id":"61c7332adc5d26aae565e5fb21428a4ec3bbeaa7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"394dc7bd2e70ef04c85003bee17ee00b09e863ff","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                    \"default_character_set_name as charset,\","},{"line_number":335,"context_line":"                    \"default_collation_name as collation\","},{"line_number":336,"context_line":"                    \"FROM information_schema.schemata\","},{"line_number":337,"context_line":"                    (\"schema_name NOT IN (\u0027\" + \"\u0027, \u0027\".join(CONF.ignore_dbs) +"},{"line_number":338,"context_line":"                     \"\u0027)\"),"},{"line_number":339,"context_line":"                    \"ORDER BY schema_name ASC\","},{"line_number":340,"context_line":"                    ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_b5b0b5de","line":337,"updated":"2015-02-20 14:58:56.000000000","message":"That\u0027s good, thanks. I was hoping you\u0027d set CONF.ignore_dbs to something else (non-default) and verify it but this works for now.","commit_id":"fada982689bfd31a52a17af16846ea13d3b7d44e"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"1be055389c4f85e9ef4301731f78fbf5a0d04e71","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"        self.orig_service_discovery \u003d operating_system.service_discovery"},{"line_number":1790,"context_line":"        operating_system.service_discovery \u003d ("},{"line_number":1791,"context_line":"            self.fake_couchdb_service_discovery)"},{"line_number":1792,"context_line":"        operating_system.get_ip_address \u003d Mock()"},{"line_number":1793,"context_line":"        util.init_db()"},{"line_number":1794,"context_line":"        self.FAKE_ID \u003d str(uuid4())"},{"line_number":1795,"context_line":"        InstanceServiceStatus.create(instance_id\u003dself.FAKE_ID,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a75e904_e6161ef1","line":1792,"updated":"2015-03-21 00:16:10.000000000","message":"I think you should save and restore this one as well.\nBTW, Couchbase test suffers the same issue...","commit_id":"93605cdf2bb37f3263a0d9f596e38e3bb822c3ad"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"8a82f1023c39fb6995912945f2dd0db34b585516","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"        self.orig_service_discovery \u003d operating_system.service_discovery"},{"line_number":1790,"context_line":"        operating_system.service_discovery \u003d ("},{"line_number":1791,"context_line":"            self.fake_couchdb_service_discovery)"},{"line_number":1792,"context_line":"        operating_system.get_ip_address \u003d Mock()"},{"line_number":1793,"context_line":"        util.init_db()"},{"line_number":1794,"context_line":"        self.FAKE_ID \u003d str(uuid4())"},{"line_number":1795,"context_line":"        InstanceServiceStatus.create(instance_id\u003dself.FAKE_ID,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a75e904_af50795f","line":1792,"in_reply_to":"7a75e904_e6161ef1","updated":"2015-03-21 05:12:36.000000000","message":"Filed a bug https://bugs.launchpad.net/trove/+bug/1434767\nand resolution \nhttps://review.openstack.org/166502","commit_id":"93605cdf2bb37f3263a0d9f596e38e3bb822c3ad"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2cb922ab472de3a8d00006404a589695eb4977ad","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"        self.orig_service_discovery \u003d operating_system.service_discovery"},{"line_number":1790,"context_line":"        operating_system.service_discovery \u003d ("},{"line_number":1791,"context_line":"            self.fake_couchdb_service_discovery)"},{"line_number":1792,"context_line":"        operating_system.get_ip_address \u003d Mock()"},{"line_number":1793,"context_line":"        util.init_db()"},{"line_number":1794,"context_line":"        self.FAKE_ID \u003d str(uuid4())"},{"line_number":1795,"context_line":"        InstanceServiceStatus.create(instance_id\u003dself.FAKE_ID,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a75e904_06eeda8b","line":1792,"in_reply_to":"7a75e904_e6161ef1","updated":"2015-03-21 00:25:21.000000000","message":"Great catch. this should definitely be fixed even though I realize this isn\u0027t related to your change!","commit_id":"93605cdf2bb37f3263a0d9f596e38e3bb822c3ad"}]}