)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"3b56e38918a0b2789a097b022d6bd6a9c6968937","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  at end of message."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Changes:"},{"line_number":22,"context_line":"- Stripped \u0027.\u0027 from message passed while re-raising the exception."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ib1357f063f39b8544f341895bc164f33e69394fe"},{"line_number":25,"context_line":"Closes-Bug: #1290925"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_9f118a54","line":22,"updated":"2014-12-19 17:24:49.000000000","message":"Why \"changes\" block appears twice? I think \"stripped\" statement was true for patchset 1, is that true here?","commit_id":"8271a2c894add4a0e5af1d63cdcf8792d5a9a2f5"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"224744ec964185fc538cde53101e6c695c5005b4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  at end of message."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Changes:"},{"line_number":22,"context_line":"- Stripped \u0027.\u0027 from message passed while re-raising the exception."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ib1357f063f39b8544f341895bc164f33e69394fe"},{"line_number":25,"context_line":"Closes-Bug: #1290925"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_1d4e786f","line":22,"in_reply_to":"3a961159_2a13ecb8","updated":"2014-12-20 03:40:11.000000000","message":"This got left from previous commit, need to update this.","commit_id":"8271a2c894add4a0e5af1d63cdcf8792d5a9a2f5"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b578397a2edf67fdb9ac6604647db1bbbd0bdc46","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  at end of message."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Changes:"},{"line_number":22,"context_line":"- Stripped \u0027.\u0027 from message passed while re-raising the exception."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ib1357f063f39b8544f341895bc164f33e69394fe"},{"line_number":25,"context_line":"Closes-Bug: #1290925"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_2a13ecb8","line":22,"in_reply_to":"3a961159_9f118a54","updated":"2014-12-20 02:45:51.000000000","message":"Yes, this needs to be updated. It seems outdated and doesn\u0027t describe the current patchset.","commit_id":"8271a2c894add4a0e5af1d63cdcf8792d5a9a2f5"}],"trove/common/exception.py":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"3b56e38918a0b2789a097b022d6bd6a9c6968937","unresolved":false,"context_lines":[{"line_number":174,"context_line":"class GuestError(TroveError):"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    message \u003d _(\"An error occurred communicating with the guest: \""},{"line_number":177,"context_line":"                \"%(original_message)s\")"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class GuestTimeout(TroveError):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_249c0d0f","line":177,"updated":"2014-12-19 17:24:49.000000000","message":"I saw Nikhil\u0027s comment on the previous patch set, but didn\u0027t have time to ask.\n\n1. It seems like all other exception messages have a period, so I find this one as very confusing, someone probably will be confused as I am and one day will add a period.\n\n2. According to the bug that this suppose to close:\n\n\"We should remove the period at the end of GuestError and TaskManagerError exceptions\"\n\nI don\u0027t see any change in TaskManagerError.\n\nBut anyway, keep some exception messages with period and some without is really confusing.","commit_id":"8271a2c894add4a0e5af1d63cdcf8792d5a9a2f5"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b578397a2edf67fdb9ac6604647db1bbbd0bdc46","unresolved":false,"context_lines":[{"line_number":174,"context_line":"class GuestError(TroveError):"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    message \u003d _(\"An error occurred communicating with the guest: \""},{"line_number":177,"context_line":"                \"%(original_message)s\")"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class GuestTimeout(TroveError):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_4aa758bd","line":177,"in_reply_to":"3a961159_249c0d0f","updated":"2014-12-20 02:45:51.000000000","message":"The (original message) part of this message is an exception message itself, and consequently has a period at the end of it. Since this message is just using that exception message, there shouldn\u0027t be a need to duplicate that period again.","commit_id":"8271a2c894add4a0e5af1d63cdcf8792d5a9a2f5"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7c96a6e099515bb8f8b4cae8f43cf15ad948fa60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a961159_545f00e5","line":511,"updated":"2014-12-19 21:06:51.000000000","message":"So this is now one of the few messages with no trailing period? Strike that, the only message with no trailing period. That seems like a bad thing.","commit_id":"8271a2c894add4a0e5af1d63cdcf8792d5a9a2f5"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b578397a2edf67fdb9ac6604647db1bbbd0bdc46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a961159_0ac2b052","line":511,"in_reply_to":"3a961159_545f00e5","updated":"2014-12-20 02:45:51.000000000","message":"It does have a period at the end of it -- part of the exception message that comprises (original_message).","commit_id":"8271a2c894add4a0e5af1d63cdcf8792d5a9a2f5"}],"trove/guestagent/api.py":[{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"d56fa50e02d57ff15180e7737c244101eb256b58","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return result"},{"line_number":57,"context_line":"        except common.RemoteError as r:"},{"line_number":58,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"},{"line_number":59,"context_line":"            raise exception.GuestError(original_message\u003dr.value.strip(\u0027.\u0027))"},{"line_number":60,"context_line":"        except Exception as e:"},{"line_number":61,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"},{"line_number":62,"context_line":"            raise exception.GuestError(original_message\u003dstr(e).strip(\u0027.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3772a1e3","line":59,"updated":"2014-12-18 17:45:36.000000000","message":"This seems very odd. We should fix the message itself or the code that actually adds the other period not make an assumption and strip characters out of the exception.","commit_id":"e82057f2c7fb80f8525652ee3d2ef08f4ec1d6fe"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"2afdf5f507d1fa59198f91ab9710d62f4bdc2b48","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return result"},{"line_number":57,"context_line":"        except common.RemoteError as r:"},{"line_number":58,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"},{"line_number":59,"context_line":"            raise exception.GuestError(original_message\u003dr.value.strip(\u0027.\u0027))"},{"line_number":60,"context_line":"        except Exception as e:"},{"line_number":61,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"},{"line_number":62,"context_line":"            raise exception.GuestError(original_message\u003dstr(e).strip(\u0027.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6e97e190","line":59,"in_reply_to":"3a961159_1cb93a79","updated":"2014-12-19 09:12:59.000000000","message":"In that case, why not remove the \u0027.\u0027 from the GuestError exception  instead? (refer to https://github.com/openstack/trove/blob/master/trove/common/exception.py#L177 )","commit_id":"e82057f2c7fb80f8525652ee3d2ef08f4ec1d6fe"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"34aed6915d2d8ca3d89883f67d236fcff5ff9f4d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return result"},{"line_number":57,"context_line":"        except common.RemoteError as r:"},{"line_number":58,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"},{"line_number":59,"context_line":"            raise exception.GuestError(original_message\u003dr.value.strip(\u0027.\u0027))"},{"line_number":60,"context_line":"        except Exception as e:"},{"line_number":61,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"},{"line_number":62,"context_line":"            raise exception.GuestError(original_message\u003dstr(e).strip(\u0027.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_7cdfa9d6","line":59,"in_reply_to":"3a961159_3772a1e3","updated":"2014-12-18 20:30:29.000000000","message":"No!\n\nThe fix is to find places where we are generating these errors and removing the extra \u0027.\u0027","commit_id":"e82057f2c7fb80f8525652ee3d2ef08f4ec1d6fe"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"fdce2a0dbbc0a5944dfc0c465ee9c980d45197e8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return result"},{"line_number":57,"context_line":"        except common.RemoteError as r:"},{"line_number":58,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"},{"line_number":59,"context_line":"            raise exception.GuestError(original_message\u003dr.value.strip(\u0027.\u0027))"},{"line_number":60,"context_line":"        except Exception as e:"},{"line_number":61,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"},{"line_number":62,"context_line":"            raise exception.GuestError(original_message\u003dstr(e).strip(\u0027.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8ee5ed0a","line":59,"in_reply_to":"3a961159_6e97e190","updated":"2014-12-19 09:19:35.000000000","message":"We can consider that too, but then it will not show that \u0027.\u0027 while printing message to guest log when exception is raised.","commit_id":"e82057f2c7fb80f8525652ee3d2ef08f4ec1d6fe"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"e27757cac6c458ff6bc4b15640d1e569fd41ac74","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return result"},{"line_number":57,"context_line":"        except common.RemoteError as r:"},{"line_number":58,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"},{"line_number":59,"context_line":"            raise exception.GuestError(original_message\u003dr.value.strip(\u0027.\u0027))"},{"line_number":60,"context_line":"        except Exception as e:"},{"line_number":61,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"},{"line_number":62,"context_line":"            raise exception.GuestError(original_message\u003dstr(e).strip(\u0027.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_1cb93a79","line":59,"in_reply_to":"3a961159_7cdfa9d6","updated":"2014-12-19 04:19:45.000000000","message":"I looked through the codebase and found out that it is at these places, that we are re-raising the exception with the message from previous exception which contains a \u0027.\u0027 and this message is reused in the exception raised due to which it becomes \u0027..\u0027 at end of message.\n\nThis is why I used the simplest possible option of stripping the \u0027.\u0027 from previous exception.","commit_id":"e82057f2c7fb80f8525652ee3d2ef08f4ec1d6fe"}],"trove/guestagent/volume.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7c96a6e099515bb8f8b4cae8f43cf15ad948fa60","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                          attempts\u003dnum_tries)"},{"line_number":63,"context_line":"        except ProcessExecutionError:"},{"line_number":64,"context_line":"            LOG.exception(_(\"Error getting device status\"))"},{"line_number":65,"context_line":"            raise GuestError(_(\"InvalidDevicePath(path\u003d%s).\") %"},{"line_number":66,"context_line":"                             self.device_path)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _check_format(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_1469f88b","line":65,"updated":"2014-12-19 21:06:51.000000000","message":"and instead we put the \u0027.\u0027 here. That seems like the wrong direction to me!","commit_id":"8271a2c894add4a0e5af1d63cdcf8792d5a9a2f5"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b578397a2edf67fdb9ac6604647db1bbbd0bdc46","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                          attempts\u003dnum_tries)"},{"line_number":63,"context_line":"        except ProcessExecutionError:"},{"line_number":64,"context_line":"            LOG.exception(_(\"Error getting device status\"))"},{"line_number":65,"context_line":"            raise GuestError(_(\"InvalidDevicePath(path\u003d%s).\") %"},{"line_number":66,"context_line":"                             self.device_path)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _check_format(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_aa951c41","line":65,"in_reply_to":"3a961159_1469f88b","updated":"2014-12-20 02:45:51.000000000","message":"Shouldn\u0027t all exception messages have periods to end them according to your comment in the exception.py?","commit_id":"8271a2c894add4a0e5af1d63cdcf8792d5a9a2f5"}]}
