)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"470ba260e52cc889f4d5bbd76bc45f567600175d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":" - Cinder doesn\u0027t allow to attach volume that was provisioned in"},{"line_number":11,"context_line":"   different AZ that differes from compute instance AZ."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Changes:"},{"line_number":14,"context_line":" - add availability_zone attribute to volume.create call"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_a49e8652","line":11,"updated":"2015-01-22 19:49:41.000000000","message":"differs","commit_id":"4bc103e7971fab3e2180fb4475b61c64e75d26c5"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"3655519b7d8bcf7b5a78b1498507be188710c2af","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":" - Cinder doesn\u0027t allow to attach volume that was provisioned in"},{"line_number":11,"context_line":"   different AZ that differes from compute instance AZ."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Changes:"},{"line_number":14,"context_line":" - add availability_zone attribute to volume.create call"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_a6dea43d","line":11,"in_reply_to":"1a930d6b_a49e8652","updated":"2015-02-03 02:36:36.000000000","message":"+1, the first thing I too noticed while reading the text :)","commit_id":"4bc103e7971fab3e2180fb4475b61c64e75d26c5"}],"trove/taskmanager/models.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"da3dd992a4503c48f8af546319d612d46a8405d5","unresolved":false,"context_lines":[{"line_number":629,"context_line":"                  self.id)"},{"line_number":630,"context_line":"        return volume_info"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def _build_volume_info(self, datastore_manager, az, volume_size\u003dNone):"},{"line_number":633,"context_line":"        volume_info \u003d None"},{"line_number":634,"context_line":"        volume_support \u003d self.volume_support"},{"line_number":635,"context_line":"        device_path \u003d self.device_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c8f8294d","line":632,"updated":"2015-01-20 15:35:38.000000000","message":"Not sure why you abbreviated availability_zone to az (most, if not all, signatures seem to spell it out - including the ones you added for the tests)","commit_id":"4bc103e7971fab3e2180fb4475b61c64e75d26c5"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"3655519b7d8bcf7b5a78b1498507be188710c2af","unresolved":false,"context_lines":[{"line_number":629,"context_line":"                  self.id)"},{"line_number":630,"context_line":"        return volume_info"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def _build_volume_info(self, datastore_manager, az, volume_size\u003dNone):"},{"line_number":633,"context_line":"        volume_info \u003d None"},{"line_number":634,"context_line":"        volume_support \u003d self.volume_support"},{"line_number":635,"context_line":"        device_path \u003d self.device_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_e695fc40","line":632,"in_reply_to":"1a930d6b_04903a42","updated":"2015-02-03 02:36:36.000000000","message":"+1 to naming, it should more be in sync to usual style, though no restrictions.","commit_id":"4bc103e7971fab3e2180fb4475b61c64e75d26c5"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"470ba260e52cc889f4d5bbd76bc45f567600175d","unresolved":false,"context_lines":[{"line_number":629,"context_line":"                  self.id)"},{"line_number":630,"context_line":"        return volume_info"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def _build_volume_info(self, datastore_manager, az, volume_size\u003dNone):"},{"line_number":633,"context_line":"        volume_info \u003d None"},{"line_number":634,"context_line":"        volume_support \u003d self.volume_support"},{"line_number":635,"context_line":"        device_path \u003d self.device_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_04903a42","line":632,"in_reply_to":"3a961159_a9e11c9d","updated":"2015-01-22 19:49:41.000000000","message":"seems like that isn\u0027t a good reason to have datastore_manager, az, volume_size. It isn\u0027t about restriction to naming as much as consistency and understandability.","commit_id":"4bc103e7971fab3e2180fb4475b61c64e75d26c5"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"fef9153a959852b5b92b75ccf4cda60cbad5c35a","unresolved":false,"context_lines":[{"line_number":629,"context_line":"                  self.id)"},{"line_number":630,"context_line":"        return volume_info"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def _build_volume_info(self, datastore_manager, az, volume_size\u003dNone):"},{"line_number":633,"context_line":"        volume_info \u003d None"},{"line_number":634,"context_line":"        volume_support \u003d self.volume_support"},{"line_number":635,"context_line":"        device_path \u003d self.device_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a9e11c9d","line":632,"in_reply_to":"3a961159_c8f8294d","updated":"2015-01-20 17:40:19.000000000","message":"Good question, Peter. This is a private method, so, there\u0027s no restriction to naming, so, if there are critical concerns about its name i can change it.","commit_id":"4bc103e7971fab3e2180fb4475b61c64e75d26c5"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"470ba260e52cc889f4d5bbd76bc45f567600175d","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        self.update_db(task_status\u003dtask_status)"},{"line_number":662,"context_line":"        raise TroveError(message\u003dmessage)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def _create_volume(self, volume_size, datastore_manager, az):"},{"line_number":665,"context_line":"        LOG.debug(\"Begin _create_volume for id: %s\" % self.id)"},{"line_number":666,"context_line":"        volume_client \u003d create_cinder_client(self.context)"},{"line_number":667,"context_line":"        volume_desc \u003d (\"datastore volume for %s\" % self.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_84a34a9d","line":664,"updated":"2015-01-22 19:49:41.000000000","message":"same here","commit_id":"4bc103e7971fab3e2180fb4475b61c64e75d26c5"}]}