)]}'
{"trove/extensions/mysql/service.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"e9e26e7b70e5232b0adf93282751443f1aabf0a6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def create(self, req, body, tenant_id, instance_id):"},{"line_number":83,"context_line":"        \"\"\"Creates a set of users.\"\"\""},{"line_number":84,"context_line":"        LOG.info(_(\"Creating users for instance \u0027%s\u0027\") % instance_id)"},{"line_number":85,"context_line":"        LOG.info(logging.mask_password(_(\"req : \u0027%s\u0027\\n\\n\") % req))"},{"line_number":86,"context_line":"        LOG.info(logging.mask_password(_(\"body : \u0027%s\u0027\\n\\n\") % body))"},{"line_number":87,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":88,"context_line":"        users \u003d body[\u0027users\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_c1545f56","side":"PARENT","line":85,"updated":"2015-01-22 22:00:35.000000000","message":"FWIW, this will actually work fine.  The only problem is if you change the % to a , because it\u0027s within the mask_password call.  That\u0027s when you need to separate it out.","commit_id":"294ef919a956e201f7001e296481a23e220a7254"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"323db4b1972b1cb1bd7d8f20cb947dfa532edfef","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def create(self, req, body, tenant_id, instance_id):"},{"line_number":83,"context_line":"        \"\"\"Creates a set of users.\"\"\""},{"line_number":84,"context_line":"        LOG.info(_(\"Creating users for instance \u0027%s\u0027\") % instance_id)"},{"line_number":85,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % logging.mask_password(req))"},{"line_number":86,"context_line":"        LOG.info(_(\"body : \u0027%s\u0027\\n\\n\") % logging.mask_password(body))"},{"line_number":87,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":88,"context_line":"        users \u003d body[\u0027users\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_8972837a","line":85,"updated":"2015-01-22 19:17:58.000000000","message":"See comment below","commit_id":"53213dea1f743a8baa94c2bd9b3994ef191c449e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"323db4b1972b1cb1bd7d8f20cb947dfa532edfef","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def update(self, req, body, tenant_id, instance_id, id):"},{"line_number":136,"context_line":"        \"\"\"Change attributes for one user.\"\"\""},{"line_number":137,"context_line":"        LOG.info(_(\"Updating user attributes for instance \u0027%s\u0027\") % instance_id)"},{"line_number":138,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % logging.mask_password(req))"},{"line_number":139,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":140,"context_line":"        id \u003d correct_id_with_req(id, req)"},{"line_number":141,"context_line":"        username, hostname \u003d unquote_user_host(id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_894b632a","line":138,"updated":"2015-01-22 19:17:58.000000000","message":"You should use \",\" instead of \"%\" for lazy evaluation. But that was before already, so just mentioning.","commit_id":"53213dea1f743a8baa94c2bd9b3994ef191c449e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"323db4b1972b1cb1bd7d8f20cb947dfa532edfef","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    def update_all(self, req, body, tenant_id, instance_id):"},{"line_number":158,"context_line":"        \"\"\"Change the password of one or more users.\"\"\""},{"line_number":159,"context_line":"        LOG.info(_(\"Updating user passwords for instance \u0027%s\u0027\") % instance_id)"},{"line_number":160,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % logging.mask_password(req))"},{"line_number":161,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":162,"context_line":"        users \u003d body[\u0027users\u0027]"},{"line_number":163,"context_line":"        model_users \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_e95067d6","line":160,"updated":"2015-01-22 19:17:58.000000000","message":"Same comment like above for these two lines.","commit_id":"53213dea1f743a8baa94c2bd9b3994ef191c449e"}],"trove/instance/service.py":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"c8168759fa64c0c132a164c02de0094a69b34fb5","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        LOG.info(_LI(\"Showing database instance \u0027%(instance_id)s\u0027 for tenant \""},{"line_number":160,"context_line":"                     \"\u0027%(tenant_id)s\u0027\"),"},{"line_number":161,"context_line":"                 {\u0027instance_id\u0027: id, \u0027tenant_id\u0027: tenant_id})"},{"line_number":162,"context_line":"        LOG.debug(\"req : \u0027%s\u0027\\n\\n\", req)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":165,"context_line":"        server \u003d models.load_instance_with_guest(models.DetailInstance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_84898acc","line":162,"updated":"2015-01-22 19:57:38.000000000","message":"Should we mask that request either?","commit_id":"53213dea1f743a8baa94c2bd9b3994ef191c449e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3297180a184f7821286a693655e50b5e2b81b081","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        LOG.info(_LI(\"Showing database instance \u0027%(instance_id)s\u0027 for tenant \""},{"line_number":160,"context_line":"                     \"\u0027%(tenant_id)s\u0027\"),"},{"line_number":161,"context_line":"                 {\u0027instance_id\u0027: id, \u0027tenant_id\u0027: tenant_id})"},{"line_number":162,"context_line":"        LOG.debug(\"req : \u0027%s\u0027\\n\\n\", req)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":165,"context_line":"        server \u003d models.load_instance_with_guest(models.DetailInstance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_e4016e07","line":162,"in_reply_to":"1a930d6b_84898acc","updated":"2015-01-22 20:02:08.000000000","message":"i don\u0027t think this would have passwords.","commit_id":"53213dea1f743a8baa94c2bd9b3994ef191c449e"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"a3226c0048ed0f4d62ca9b6c991723e309936001","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        LOG.info(_LI(\"Showing database instance \u0027%(instance_id)s\u0027 for tenant \""},{"line_number":160,"context_line":"                     \"\u0027%(tenant_id)s\u0027\"),"},{"line_number":161,"context_line":"                 {\u0027instance_id\u0027: id, \u0027tenant_id\u0027: tenant_id})"},{"line_number":162,"context_line":"        LOG.debug(\"req : \u0027%s\u0027\\n\\n\", req)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":165,"context_line":"        server \u003d models.load_instance_with_guest(models.DetailInstance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_3713a1b9","line":162,"in_reply_to":"1a930d6b_e4016e07","updated":"2015-01-22 23:04:58.000000000","message":"Indeed, this shouldn\u0027t have a password.","commit_id":"53213dea1f743a8baa94c2bd9b3994ef191c449e"}]}