)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"fc2aa9241dace34c3c6bfff292b2555747124e29","unresolved":false,"context_lines":[{"line_number":24,"context_line":"and follow by \u0027killall\u0027 only if soft shutdown fails."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Iaba7baa2c4357cc6f2d28d8178e2946721e068e6"},{"line_number":27,"context_line":"Closes-bug: bug/1414186"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a930d6b_76494630","line":27,"updated":"2015-01-26 22:07:22.000000000","message":"Should be:\n\n  Closes-Bug: #1414186","commit_id":"f0b4d955f7025aa7eaab878be84cfbf87539109a"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"242a02f03c32d287ed63003f303f5fc51aacb199","unresolved":false,"context_lines":[{"line_number":24,"context_line":"and follow by \u0027killall\u0027 only if soft shutdown fails."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Iaba7baa2c4357cc6f2d28d8178e2946721e068e6"},{"line_number":27,"context_line":"Closes-bug: bug/1414186"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a930d6b_28fbcd79","line":27,"updated":"2015-01-27 08:25:30.000000000","message":"You probably want:\n\n Closes-bug: 1414186\n\nso that the infra system picks this up correctly.","commit_id":"0a0da897a34635f719f7343b4ec1ac04cae9db91"}],"trove/guestagent/strategies/restore/mysql_impl.py":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"baf0a13c04998b5d2f9f78390a8954866f4714c4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                LOG.debug(\"Database successfully shutdown\")"},{"line_number":91,"context_line":"            except exception.PollTimeOut:"},{"line_number":92,"context_line":"                LOG.debug(\"Timeout shutting down database\")"},{"line_number":93,"context_line":"                LOG.debug(\"Performing killall on mysqld_safe\")"},{"line_number":94,"context_line":"                utils.execute_with_timeout(\"killall\", \"mysqld_safe\","},{"line_number":95,"context_line":"                                           root_helper\u003d\"sudo\","},{"line_number":96,"context_line":"                                           run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_ebd47bbe","line":93,"updated":"2015-01-26 17:33:26.000000000","message":"Couldn\u0027t these be in one debug message?\ne.g.\nLOG.debug(\"Timeout shutting down database - performing killall on mysqld_safe\")\n          \nI will leave the pep8\u0027ness of that to you :)","commit_id":"9f2702a78b60719113cab96c35f56ee999b7dc5c"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"cf65426f841f56b3ecc8ee7f4c25763c8a61828e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                LOG.debug(\"Database successfully shutdown\")"},{"line_number":91,"context_line":"            except exception.PollTimeOut:"},{"line_number":92,"context_line":"                LOG.debug(\"Timeout shutting down database\")"},{"line_number":93,"context_line":"                LOG.debug(\"Performing killall on mysqld_safe\")"},{"line_number":94,"context_line":"                utils.execute_with_timeout(\"killall\", \"mysqld_safe\","},{"line_number":95,"context_line":"                                           root_helper\u003d\"sudo\","},{"line_number":96,"context_line":"                                           run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_bd81d4c4","line":93,"in_reply_to":"1a930d6b_ebd47bbe","updated":"2015-01-26 18:49:35.000000000","message":"Yeah, probably. Will fix that.","commit_id":"9f2702a78b60719113cab96c35f56ee999b7dc5c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0d2ba23fb9cb956ec48bfd53d32a5fe8c0c4fc09","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                LOG.debug(\"Database successfully shutdown\")"},{"line_number":91,"context_line":"            except exception.PollTimeOut:"},{"line_number":92,"context_line":"                LOG.debug(\"Timeout shutting down database \""},{"line_number":93,"context_line":"                          \"- performing killall on mysqld_safe\")"},{"line_number":94,"context_line":"                utils.execute_with_timeout(\"killall\", \"mysqld_safe\","},{"line_number":95,"context_line":"                                           root_helper\u003d\"sudo\","},{"line_number":96,"context_line":"                                           run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_b629ee9c","line":93,"updated":"2015-01-26 22:27:18.000000000","message":"LOG.exception\n\nand please add period","commit_id":"a086ccf55297381183ab060412d6f49c8bb7150a"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"93c649ef749dc16111d551bef97a62d46d464a84","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                LOG.debug(\"Database successfully shutdown\")"},{"line_number":91,"context_line":"            except exception.PollTimeOut:"},{"line_number":92,"context_line":"                LOG.debug(\"Timeout shutting down database \""},{"line_number":93,"context_line":"                          \"- performing killall on mysqld_safe\")"},{"line_number":94,"context_line":"                utils.execute_with_timeout(\"killall\", \"mysqld_safe\","},{"line_number":95,"context_line":"                                           root_helper\u003d\"sudo\","},{"line_number":96,"context_line":"                                           run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_99a98326","line":93,"in_reply_to":"1a930d6b_b629ee9c","updated":"2015-01-26 22:52:39.000000000","message":"I think the message logging is more appropriate for this case as the actual exception is being handled here. We just notify the user about the timeout and what we are going to do about it. If the killall command fails, that surely is an exception - error in this case.\n\nThanks for the period.","commit_id":"a086ccf55297381183ab060412d6f49c8bb7150a"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"28a1a3e5f541ff5e07ed76a38a3994005d29030b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                                 time_out\u003dself.RESET_ROOT_RETRY_TIMEOUT)"},{"line_number":90,"context_line":"                LOG.debug(\"Database successfully shutdown\")"},{"line_number":91,"context_line":"            except exception.PollTimeOut:"},{"line_number":92,"context_line":"                LOG.debug(\"Timeout shutting down database \""},{"line_number":93,"context_line":"                          \"- performing killall on mysqld_safe.\")"},{"line_number":94,"context_line":"                utils.execute_with_timeout(\"killall\", \"mysqld_safe\","},{"line_number":95,"context_line":"                                           root_helper\u003d\"sudo\","}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_5538b73c","line":92,"updated":"2015-01-27 04:06:05.000000000","message":"LOG.exception","commit_id":"0a0da897a34635f719f7343b4ec1ac04cae9db91"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"f394b95e6fbff25d8efcac3737f68aea9c48b2e5","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                                 time_out\u003dself.RESET_ROOT_RETRY_TIMEOUT)"},{"line_number":90,"context_line":"                LOG.debug(\"Database successfully shutdown\")"},{"line_number":91,"context_line":"            except exception.PollTimeOut:"},{"line_number":92,"context_line":"                LOG.debug(\"Timeout shutting down database \""},{"line_number":93,"context_line":"                          \"- performing killall on mysqld_safe.\")"},{"line_number":94,"context_line":"                utils.execute_with_timeout(\"killall\", \"mysqld_safe\","},{"line_number":95,"context_line":"                                           root_helper\u003d\"sudo\","}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_87058715","line":92,"in_reply_to":"1a930d6b_5538b73c","updated":"2015-01-27 13:02:34.000000000","message":"Edmond - I don\u0027t know that I agree with this change. The exception is being handled and we are indicating as such. Doing LOG.exception will dump a stack trace into the log which wouldn\u0027t really be useful at this point given that the code has an expectation that this situation can occur and is coded to handle it.","commit_id":"0a0da897a34635f719f7343b4ec1ac04cae9db91"}]}