)]}'
{"trove/backup/models.py":[{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"a9d30d6e281b46ec2570cf8df62c9bc3760a6000","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        try:"},{"line_number":250,"context_line":"            client \u003d create_swift_client(context)"},{"line_number":251,"context_line":"            client.get_account()"},{"line_number":252,"context_line":"        except (exception.NoServiceEndpoint, ClientException):"},{"line_number":253,"context_line":"            raise exception.SwiftAuthError(tenant_id\u003dcontext.tenant)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_2abc84db","line":252,"updated":"2015-02-13 04:44:56.000000000","message":"This doesn\u0027t seem like the right exception to throw in the case that swift is disabled. I would think an exception like SwiftNotFound(), because the SwiftAuthError basically means Swift is found but the tenant doesn\u0027t have authorization to create the client.\n\nEx:\nexcept exception.NoServiceEndpoint\n    raise exception.SwiftNotFound()","commit_id":"becb75660ade61ff3e741e1f66a8845eb6a1ed00"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"949fb977b18b0b58907dc1320ca532f5dee47eba","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        try:"},{"line_number":250,"context_line":"            client \u003d create_swift_client(context)"},{"line_number":251,"context_line":"            client.get_account()"},{"line_number":252,"context_line":"        except (exception.NoServiceEndpoint, ClientException):"},{"line_number":253,"context_line":"            raise exception.SwiftAuthError(tenant_id\u003dcontext.tenant)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_c34e6ac2","line":252,"in_reply_to":"da86d52c_2abc84db","updated":"2015-02-13 11:15:13.000000000","message":"right, you need to add another \u0027except\u0027 section to handle different exceptions.","commit_id":"becb75660ade61ff3e741e1f66a8845eb6a1ed00"}]}