)]}'
{"trove/tests/api/instances.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"26bda653db14a272eee9504f17163c554c096d9a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"class CreateInstanceQuotaTest(testtools.TestCase):"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def setUp(self):"},{"line_number":237,"context_line":"        import copy"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        self.test_info \u003d copy.deepcopy(instance_info)"},{"line_number":240,"context_line":"        self.test_info.dbaas_datastore \u003d CONFIG.dbaas_datastore"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_ce131cb6","line":237,"updated":"2015-02-19 15:33:16.000000000","message":"there needs to be included a TestCase.setUp\n\nfor eg. super(CreateInstanceQuotaTest, self).setUp()\n\nThis needs to be followed in all the classes.","commit_id":"5ffe75e04c5101adf21f40aa1b91ef03c8a4d0e1"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"201b5b9d1bacaab91a2f7e516286e1489e12a81b","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        self.test_info \u003d copy.deepcopy(instance_info)"},{"line_number":241,"context_line":"        self.test_info.dbaas_datastore \u003d CONFIG.dbaas_datastore"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def tearDown(self):"},{"line_number":244,"context_line":"        quota_dict \u003d {\u0027instances\u0027: CONFIG.trove_max_instances_per_user,"},{"line_number":245,"context_line":"                      \u0027volumes\u0027: CONFIG.trove_max_volumes_per_user}"},{"line_number":246,"context_line":"        dbaas_admin.quota.update(self.test_info.user.tenant_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_0b3a3acd","line":243,"updated":"2015-02-20 18:55:33.000000000","message":"Need to also provide :\nsuper(CreateInstanceQuotaTest, self).tearDown()","commit_id":"b3c0fb061318a69ead3f7f7f0f7f73f36584b91c"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"dcb0aa182fe2f73d7aa951e66cde3556ed96223c","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        import copy"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        super(CreateInstanceQuotaTest, self).setUp()"},{"line_number":240,"context_line":"        self.test_info \u003d copy.deepcopy(instance_info)"},{"line_number":241,"context_line":"        self.test_info.dbaas_datastore \u003d CONFIG.dbaas_datastore"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_e1a5beb5","line":240,"updated":"2015-02-24 03:27:16.000000000","message":"similar comment to amrith, have the super call as the first line in setUp.","commit_id":"9252906af130c0debe071980d262e6cc1cae59c8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"cba5bf5e7044ad1834a45c97d0f2cdc0f465ca71","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        import copy"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        super(CreateInstanceQuotaTest, self).setUp()"},{"line_number":240,"context_line":"        self.test_info \u003d copy.deepcopy(instance_info)"},{"line_number":241,"context_line":"        self.test_info.dbaas_datastore \u003d CONFIG.dbaas_datastore"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_9b145fa1","line":240,"in_reply_to":"ba7be1f8_e1a5beb5","updated":"2015-02-24 12:41:21.000000000","message":"Now I wonder, is deepcopy() required here?\n\nI think there\u0027s more to this change than just changing the import and the class hierarchy.\n\nI\u0027m moving my vote to -1 based on this and yesterdays question.","commit_id":"9252906af130c0debe071980d262e6cc1cae59c8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b776cdb2a8a37ea49e14734146cbe72c8df3c06f","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        if not CONFIG.values.get(\u0027neutron_enabled\u0027):"},{"line_number":764,"context_line":"            raise SkipTest(\"neutron is not enabled, skipping\")"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"        super(CreateInstanceWithNeutron, self).setUp()"},{"line_number":767,"context_line":"        user \u003d test_config.users.find_user("},{"line_number":768,"context_line":"            Requirements(is_admin\u003dFalse, services\u003d[\"nova\", \"trove\"]))"},{"line_number":769,"context_line":"        self.nova_client \u003d create_nova_client(user)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_ecbb07e3","line":766,"updated":"2015-02-23 18:54:42.000000000","message":"it is traditional to do this as the first thing in setUp.","commit_id":"9252906af130c0debe071980d262e6cc1cae59c8"}]}
