)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b9a4b67574c00c216888dfd15962776bf11a6a22","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix replica source state validation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":" - creating a slave for instance Trove"},{"line_number":11,"context_line":"   doesn\u0027t validate that master exist,"},{"line_number":12,"context_line":" - replica source is not proper state."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a75e904_f5b5e231","line":9,"updated":"2015-03-21 09:18:54.000000000","message":"If you respin this patch, please rewrite this paragraph.","commit_id":"a0fc8b9be8a8dbd082e1ee2bf545051f7c8c47b2"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b9a4b67574c00c216888dfd15962776bf11a6a22","unresolved":false,"context_lines":[{"line_number":21,"context_line":" - removed redundant import in unittest"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Co-authored by: Denis Makogon \u003cdmakogon@mirantis.com\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ib4e37ff0036998bc53058e400054ed93fcc2e144"},{"line_number":26,"context_line":"Closes-Bug: #1357704"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a75e904_15827e52","line":24,"updated":"2015-03-21 09:18:54.000000000","message":"Does this warrant (this is a question) a DocImpact? Your call.","commit_id":"a0fc8b9be8a8dbd082e1ee2bf545051f7c8c47b2"}],"trove/instance/models.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"1ce566f241113c26495a44350fb3841b35de80bd","unresolved":false,"context_lines":[{"line_number":730,"context_line":"                        context,"},{"line_number":731,"context_line":"                        instance_id\u003dslave_of_id))"},{"line_number":732,"context_line":"                replica_source_instance.validate_can_perform_action()"},{"line_number":733,"context_line":"            except exception.UnprocessableEntity as msg:"},{"line_number":734,"context_line":"                LOG.exception(msg)"},{"line_number":735,"context_line":"                raise"},{"line_number":736,"context_line":"            except exception.ModelNotFoundError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_72ac7336","line":733,"updated":"2015-03-11 15:29:35.000000000","message":"I believe that \u0027validate_can_perform_action\u0027 already does the logging. I don\u0027t think we need the stack trace for this particular exception as it\u0027s cause is well known and described in the log message.\nWe may just remove this catch block let Python re-throw it.","commit_id":"9137cd8c5ee1090bd947c1582499799e588fe24c"}],"trove/tests/api/replication.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"e192fe1ee3a10ce5507533ff6548cb757ff6a99a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"class CreateReplicationSlave(object):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @test"},{"line_number":71,"context_line":"    def test_replica_provisioning_with_missing_root_replica(self):"},{"line_number":72,"context_line":"        assert_raises(exceptions.NotFound,"},{"line_number":73,"context_line":"                      instance_info.dbaas.instances.create,"},{"line_number":74,"context_line":"                      instance_info.name + \"_slave\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_7188e322","line":71,"range":{"start_line":71,"start_character":47,"end_line":71,"end_character":59},"updated":"2015-03-11 20:01:12.000000000","message":"I believe we call this \u0027replica_source\u0027 not \u0027root_replica\u0027","commit_id":"5120614a10ea822287b66cfddbc34080f18c8e6c"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d14d9de09e166f194c108fa032407f7218b8c9c3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"class CreateReplicationSlave(object):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @test"},{"line_number":71,"context_line":"    def test_replica_provisioning_with_missing_root_replica(self):"},{"line_number":72,"context_line":"        assert_raises(exceptions.NotFound,"},{"line_number":73,"context_line":"                      instance_info.dbaas.instances.create,"},{"line_number":74,"context_line":"                      instance_info.name + \"_slave\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_8c2c5e4c","line":71,"range":{"start_line":71,"start_character":47,"end_line":71,"end_character":59},"in_reply_to":"9a80dd14_7188e322","updated":"2015-03-11 20:19:48.000000000","message":"+1","commit_id":"5120614a10ea822287b66cfddbc34080f18c8e6c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"e192fe1ee3a10ce5507533ff6548cb757ff6a99a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      instance_info.name + \"_slave\","},{"line_number":75,"context_line":"                      instance_info.dbaas_flavor_href,"},{"line_number":76,"context_line":"                      instance_info.volume,"},{"line_number":77,"context_line":"                      slave_of\u003d\"Missing root replica\")"},{"line_number":78,"context_line":"        assert_equal(404, instance_info.dbaas.last_http_code)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @test"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_d1850f08","line":77,"updated":"2015-03-11 20:01:12.000000000","message":"ditto","commit_id":"5120614a10ea822287b66cfddbc34080f18c8e6c"}],"trove/tests/unittests/instance/test_instance_models.py":[{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"f427b0677aa9d4f77016c7882dc9dad61244ba02","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from trove.common import exception"},{"line_number":19,"context_line":"from trove.backup import models as backup_models"},{"line_number":20,"context_line":"from trove.datastore import models as datastore_models"},{"line_number":21,"context_line":"from trove.datastore.models import DBDatastoreVersion"},{"line_number":22,"context_line":"from trove.common.instance import ServiceStatuses"},{"line_number":23,"context_line":"from trove.instance.models import filter_ips"},{"line_number":24,"context_line":"from trove.instance.models import InstanceServiceStatus"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_875ef9e7","side":"PARENT","line":21,"updated":"2015-03-12 21:08:14.000000000","message":"This is imported by the above line","commit_id":"417719c5a7089ffd1e784a9147ea48500be9129f"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b9a4b67574c00c216888dfd15962776bf11a6a22","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from trove.common import exception"},{"line_number":19,"context_line":"from trove.backup import models as backup_models"},{"line_number":20,"context_line":"from trove.datastore import models as datastore_models"},{"line_number":21,"context_line":"from trove.datastore.models import DBDatastoreVersion"},{"line_number":22,"context_line":"from trove.common.instance import ServiceStatuses"},{"line_number":23,"context_line":"from trove.instance.models import filter_ips"},{"line_number":24,"context_line":"from trove.instance.models import InstanceServiceStatus"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a75e904_557cf672","side":"PARENT","line":21,"in_reply_to":"9a80dd14_875ef9e7","updated":"2015-03-21 09:18:54.000000000","message":"Doing it twice to be safe!","commit_id":"417719c5a7089ffd1e784a9147ea48500be9129f"}]}