)]}'
{"trove/guestagent/strategies/replication/mysql_base.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"437811db71acc0f3207d06aaec57c5c264396ec9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self.connect_to_master(service, snapshot)"},{"line_number":128,"context_line":"            LOG.debug(\"enable_as_slave: after call connect_to_master\")"},{"line_number":129,"context_line":"        except Exception:"},{"line_number":130,"context_line":"            LOG.exception(\"Exception enabling guest as replica\")"},{"line_number":131,"context_line":"            raise"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def detach_slave(self, service, for_failover):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_0c292537","line":130,"updated":"2015-03-18 17:34:35.000000000","message":"Doesnt this message need to be translated? I see this translated in later files.","commit_id":"7857c5b87b64878d01251f39b67673590134e495"}],"trove/instance/models.py":[{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"ea376835fe1002b31944a013c9d43de2e84f8f0f","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                    _(\"Cannot create a replica of %(id)s \""},{"line_number":732,"context_line":"                      \"as that instance could not be found.\")"},{"line_number":733,"context_line":"                    % {\u0027id\u0027: slave_of_id})"},{"line_number":734,"context_line":"                raise exception.NotFound(uuid\u003dslave_of_id)"},{"line_number":735,"context_line":"        elif replica_count and replica_count !\u003d 1:"},{"line_number":736,"context_line":"            raise exception.Forbidden(_("},{"line_number":737,"context_line":"                \"Replica count only valid when creating replicas. Cannot \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_bffe4636","line":734,"updated":"2015-03-19 15:43:09.000000000","message":"This create method is getting unwieldy. Refactoring the replication setup into its own method may improve readability.","commit_id":"d67997f2517a0bc57852256bb8989ecc15845c99"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"4deed93096887e9fc97b40a38da537754d50778a","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                    _(\"Cannot create a replica of %(id)s \""},{"line_number":732,"context_line":"                      \"as that instance could not be found.\")"},{"line_number":733,"context_line":"                    % {\u0027id\u0027: slave_of_id})"},{"line_number":734,"context_line":"                raise exception.NotFound(uuid\u003dslave_of_id)"},{"line_number":735,"context_line":"        elif replica_count and replica_count !\u003d 1:"},{"line_number":736,"context_line":"            raise exception.Forbidden(_("},{"line_number":737,"context_line":"                \"Replica count only valid when creating replicas. Cannot \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_8ba13fab","line":734,"in_reply_to":"9a80dd14_86213ba0","updated":"2015-03-19 18:02:42.000000000","message":"Yeah I didn\u0027t want it to block the check in just wanted to point this out.","commit_id":"d67997f2517a0bc57852256bb8989ecc15845c99"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"7eccddcf83dd685457e58b4e8fa819a545bd220b","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                    _(\"Cannot create a replica of %(id)s \""},{"line_number":732,"context_line":"                      \"as that instance could not be found.\")"},{"line_number":733,"context_line":"                    % {\u0027id\u0027: slave_of_id})"},{"line_number":734,"context_line":"                raise exception.NotFound(uuid\u003dslave_of_id)"},{"line_number":735,"context_line":"        elif replica_count and replica_count !\u003d 1:"},{"line_number":736,"context_line":"            raise exception.Forbidden(_("},{"line_number":737,"context_line":"                \"Replica count only valid when creating replicas. Cannot \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_86213ba0","line":734,"in_reply_to":"9a80dd14_bffe4636","updated":"2015-03-19 16:42:01.000000000","message":"Can we consider filing a bug to refactor this code post kilo?","commit_id":"d67997f2517a0bc57852256bb8989ecc15845c99"}],"trove/taskmanager/manager.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"437811db71acc0f3207d06aaec57c5c264396ec9","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                                      InstanceTasks.EJECTION_ERROR)"},{"line_number":205,"context_line":"                msg \u003d _(\"Exceptions encountered switching replicas to new \""},{"line_number":206,"context_line":"                        \"master.  The following replicas may not have been \""},{"line_number":207,"context_line":"                        \"switched: %s\")"},{"line_number":208,"context_line":"                raise ReplicationSlaveAttachError(msg % exception_replicas)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        master \u003d BuiltInstanceTasks.load(context, instance_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_ccc9cd26","line":207,"updated":"2015-03-18 17:34:35.000000000","message":"The error messages for both promote and eject replica source looks the same. Is there a way to tell the difference between whether the error occured while promoting or ejecting?","commit_id":"7857c5b87b64878d01251f39b67673590134e495"}],"trove/taskmanager/models.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"437811db71acc0f3207d06aaec57c5c264396ec9","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"        self.guest.make_read_only(read_only)"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"    def _get_floating_ips(self):"},{"line_number":1070,"context_line":"        \"\"\"Returns floating ips as a dict indexed by the ip.\"\"\""},{"line_number":1071,"context_line":"        floating_ips \u003d {}"},{"line_number":1072,"context_line":"        for ip in self.nova_client.floating_ips.list():"},{"line_number":1073,"context_line":"            floating_ips.update({ip.ip: ip})"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_8cb3554c","line":1070,"updated":"2015-03-18 17:34:35.000000000","message":"missing log statement. not a big deal but just to stay consistent with the rest.","commit_id":"7857c5b87b64878d01251f39b67673590134e495"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"a9576cb108dee64cd4c05b81d9d4ef9aa90b9a72","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"        self.guest.make_read_only(read_only)"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"    def _get_floating_ips(self):"},{"line_number":1070,"context_line":"        \"\"\"Returns floating ips as a dict indexed by the ip.\"\"\""},{"line_number":1071,"context_line":"        floating_ips \u003d {}"},{"line_number":1072,"context_line":"        for ip in self.nova_client.floating_ips.list():"},{"line_number":1073,"context_line":"            floating_ips.update({ip.ip: ip})"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_328800c6","line":1070,"in_reply_to":"9a80dd14_8cb3554c","updated":"2015-03-18 18:50:47.000000000","message":"It doesn\u0027t have a log message to stay consistent with the other private methods that don\u0027t have log statements.","commit_id":"7857c5b87b64878d01251f39b67673590134e495"}]}