)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"15cf1e96a2e134e411acc110a60c978a0a966334","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Updating Flavor Resize Restrictions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updating flavor resize restriction logic to allow resize if flavor"},{"line_number":10,"context_line":"id or ram are the same."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If708f795858489114cfa09901591d95b1bcb530b"},{"line_number":13,"context_line":"closing-bug: 1382931"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6ced46_7221aa4c","line":10,"updated":"2015-03-24 17:46:57.000000000","message":"Please put more info from the bug here in the commit message. See https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"f82b9711183874143d7a270214246d89204e7c11"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"881e78353620b2e57f8f34f7b9a9d659033143f5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Updating Flavor Resize Restrictions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updating flavor resize restriction logic to allow resize if flavor"},{"line_number":10,"context_line":"id or ram are the same."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If708f795858489114cfa09901591d95b1bcb530b"},{"line_number":13,"context_line":"closing-bug: 1382931"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6ced46_ab7fffa9","line":10,"in_reply_to":"1a6ced46_7221aa4c","updated":"2015-03-25 17:35:28.000000000","message":"Done","commit_id":"f82b9711183874143d7a270214246d89204e7c11"}],"trove/instance/models.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"f9b5f5c565726f8e76e065f48897f4ed2416917e","unresolved":false,"context_lines":[{"line_number":812,"context_line":"                 {\u0027instance_id\u0027: self.id, \u0027flavor_id\u0027: new_flavor_id})"},{"line_number":813,"context_line":"        if self.db_info.cluster_id is not None:"},{"line_number":814,"context_line":"            raise exception.ClusterInstanceOperationNotSupported()"},{"line_number":815,"context_line":"        # Validate that the flavor can be found and that it isn\u0027t the same size"},{"line_number":816,"context_line":"        # as the current one."},{"line_number":817,"context_line":"        client \u003d create_nova_client(self.context)"},{"line_number":818,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_44619f10","side":"PARENT","line":815,"updated":"2015-03-16 21:12:46.000000000","message":"You may also want to update this comment.","commit_id":"954b5f7c0657e223d03fb82659c9fa16e97e0597"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"15cf1e96a2e134e411acc110a60c978a0a966334","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        if self.db_info.cluster_id is not None:"},{"line_number":817,"context_line":"            raise exception.ClusterInstanceOperationNotSupported()"},{"line_number":818,"context_line":"        # Validate that the flavor can be found and has ephemeral/volume"},{"line_number":819,"context_line":"        # support support if required by current flavor."},{"line_number":820,"context_line":"        client \u003d create_nova_client(self.context)"},{"line_number":821,"context_line":"        try:"},{"line_number":822,"context_line":"            new_flavor \u003d client.flavors.get(new_flavor_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_152b0595","line":819,"updated":"2015-03-24 17:46:57.000000000","message":"Double \u0027support\u0027","commit_id":"f82b9711183874143d7a270214246d89204e7c11"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"881e78353620b2e57f8f34f7b9a9d659033143f5","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        if self.db_info.cluster_id is not None:"},{"line_number":817,"context_line":"            raise exception.ClusterInstanceOperationNotSupported()"},{"line_number":818,"context_line":"        # Validate that the flavor can be found and has ephemeral/volume"},{"line_number":819,"context_line":"        # support support if required by current flavor."},{"line_number":820,"context_line":"        client \u003d create_nova_client(self.context)"},{"line_number":821,"context_line":"        try:"},{"line_number":822,"context_line":"            new_flavor \u003d client.flavors.get(new_flavor_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_0bf65363","line":819,"in_reply_to":"1a6ced46_152b0595","updated":"2015-03-25 17:35:28.000000000","message":"Done","commit_id":"f82b9711183874143d7a270214246d89204e7c11"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"15cf1e96a2e134e411acc110a60c978a0a966334","unresolved":false,"context_lines":[{"line_number":823,"context_line":"        except nova_exceptions.NotFound:"},{"line_number":824,"context_line":"            raise exception.FlavorNotFound(uuid\u003dnew_flavor_id)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        old_flavor \u003d client.flavors.get(self.flavor_id)"},{"line_number":827,"context_line":"        if self.volume_support:"},{"line_number":828,"context_line":"            if new_flavor.ephemeral !\u003d 0:"},{"line_number":829,"context_line":"                raise exception.LocalStorageNotSupported()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_30064fcf","line":826,"updated":"2015-03-24 17:46:57.000000000","message":"It\u0027s now allowed to resize-instance to the same flavor_id; not sure why we\u0027d ever want to do this.  From the bug report (which, by the way, should be included in the commit message):\n\n  the resize instance operation should be permitted if the new flavor id *is different* than the old flavor id\n\nemphasis added","commit_id":"f82b9711183874143d7a270214246d89204e7c11"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"881e78353620b2e57f8f34f7b9a9d659033143f5","unresolved":false,"context_lines":[{"line_number":823,"context_line":"        except nova_exceptions.NotFound:"},{"line_number":824,"context_line":"            raise exception.FlavorNotFound(uuid\u003dnew_flavor_id)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        old_flavor \u003d client.flavors.get(self.flavor_id)"},{"line_number":827,"context_line":"        if self.volume_support:"},{"line_number":828,"context_line":"            if new_flavor.ephemeral !\u003d 0:"},{"line_number":829,"context_line":"                raise exception.LocalStorageNotSupported()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_2be78fad","line":826,"in_reply_to":"1a6ced46_30064fcf","updated":"2015-03-25 17:35:28.000000000","message":"Done","commit_id":"f82b9711183874143d7a270214246d89204e7c11"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"cd75cf60c230d005755db2427268b181820b706e","unresolved":false,"context_lines":[{"line_number":852,"context_line":"        # can be found and has ephemeral/volume support if required by the"},{"line_number":853,"context_line":"        # current flavor."},{"line_number":854,"context_line":"        if self.flavor_id \u003d\u003d new_flavor_id:"},{"line_number":855,"context_line":"            raise exception.BadRequest(_(\"The new flavor id must be different\""},{"line_number":856,"context_line":"                                         \"than the current flavor id of \u0027%s\u0027.\")"},{"line_number":857,"context_line":"                                       % self.flavor_id)"},{"line_number":858,"context_line":"        client \u003d create_nova_client(self.context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_b4b4bc35","line":855,"updated":"2015-03-25 18:25:55.000000000","message":"I think you are missing a space between \u0027different\u0027 and \u0027than\u0027.","commit_id":"5a478c96031fcc6b36df26c69e34469011dfbde9"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"04b0f984522a1b006a076ac6529f8bec7094fed7","unresolved":false,"context_lines":[{"line_number":852,"context_line":"        # can be found and has ephemeral/volume support if required by the"},{"line_number":853,"context_line":"        # current flavor."},{"line_number":854,"context_line":"        if self.flavor_id \u003d\u003d new_flavor_id:"},{"line_number":855,"context_line":"            raise exception.BadRequest(_(\"The new flavor id must be different\""},{"line_number":856,"context_line":"                                         \"than the current flavor id of \u0027%s\u0027.\")"},{"line_number":857,"context_line":"                                       % self.flavor_id)"},{"line_number":858,"context_line":"        client \u003d create_nova_client(self.context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_3f2425ae","line":855,"in_reply_to":"1a6ced46_b4b4bc35","updated":"2015-03-25 18:46:42.000000000","message":"good catch","commit_id":"5a478c96031fcc6b36df26c69e34469011dfbde9"}],"trove/tests/api/instances_actions.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"cfc0d55a2ce4502649df9481206760ee6712ac00","unresolved":false,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    @test"},{"line_number":430,"context_line":"    def test_instance_resize_same_size_should_pass(self):"},{"line_number":431,"context_line":"        if not FAKE_MODE:"},{"line_number":432,"context_line":"            raise SkipTest(\"Cannot run this in non-fake mode.\")"},{"line_number":433,"context_line":"        self.dbaas.instances.resize_instance(self.instance_id, self.flavor_id)"},{"line_number":434,"context_line":"        self.wait_for_resize()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_f7a83679","line":431,"updated":"2015-03-24 14:38:36.000000000","message":"Since you want to skip this when in fake_mode\n\nyour condition should be \n\nif FAKE_MODE:","commit_id":"f82b9711183874143d7a270214246d89204e7c11"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"881e78353620b2e57f8f34f7b9a9d659033143f5","unresolved":false,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    @test"},{"line_number":430,"context_line":"    def test_instance_resize_same_size_should_pass(self):"},{"line_number":431,"context_line":"        if not FAKE_MODE:"},{"line_number":432,"context_line":"            raise SkipTest(\"Cannot run this in non-fake mode.\")"},{"line_number":433,"context_line":"        self.dbaas.instances.resize_instance(self.instance_id, self.flavor_id)"},{"line_number":434,"context_line":"        self.wait_for_resize()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_cb8efbcf","line":431,"in_reply_to":"1a6ced46_f7a83679","updated":"2015-03-25 17:35:28.000000000","message":"we actually want to skip if in real mode here.  Since the two resize operations will add considerable time to current test runtime when testing with a real system.","commit_id":"f82b9711183874143d7a270214246d89204e7c11"}]}