)]}'
{"trove/guestagent/datastore/experimental/vertica/service.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"a2d30adcc1159ade782d3e0e2a4b065f86acf638","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _enable_db_on_boot(self):"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"dbadmin\", \"-c\","},{"line_number":67,"context_line":"                       (system.SET_RESTART_POLICY % (DB_NAME, \"always\"))]"},{"line_number":68,"context_line":"            subprocess.Popen(command)"},{"line_number":69,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"root\", \"-c\","}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_b15a1e82","line":66,"updated":"2015-03-30 17:38:00.000000000","message":"Why don\u0027t you use your system.shell_execute(...) function to execute this and similar below?","commit_id":"f3bf4c19427d97e98b7c618c042f1cae06d32ebb"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"af80d256c013dc570fae30407277ad05e366a899","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _enable_db_on_boot(self):"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"dbadmin\", \"-c\","},{"line_number":67,"context_line":"                       (system.SET_RESTART_POLICY % (DB_NAME, \"always\"))]"},{"line_number":68,"context_line":"            subprocess.Popen(command)"},{"line_number":69,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"root\", \"-c\","}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_743b64d2","line":66,"in_reply_to":"da9b358b_b15a1e82","updated":"2015-03-30 17:43:34.000000000","message":"system.shell_execute uses processutils.execute\n\nUsing subprocess.Popen I want to complete this asynchronously","commit_id":"f3bf4c19427d97e98b7c618c042f1cae06d32ebb"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"5cde3279662b52df8074d16743a33150ddcc50ca","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            subprocess.Popen(command)"},{"line_number":69,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"root\", \"-c\","},{"line_number":70,"context_line":"                       (system.VERTICA_AGENT_SERVICE_COMMAND % \"enable\")]"},{"line_number":71,"context_line":"            subprocess.Popen(command)"},{"line_number":72,"context_line":"        except Exception:"},{"line_number":73,"context_line":"            LOG.exception(_(\"Failed to enable db on boot.\"))"},{"line_number":74,"context_line":"            raise RuntimeError(\"Could not enable db on boot.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_3537ece4","line":71,"updated":"2015-03-31 18:04:34.000000000","message":"Two questions here:\n\n  1. Can these processes run concurrently or in a different order?  You fire them both off at the same time.\n  2. Do you not care anymore if they pass or fail?  You\u0027re no longer checking the error status (of the now child processes).","commit_id":"f3bf4c19427d97e98b7c618c042f1cae06d32ebb"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"9addcf2f1b8151dc341836bc9705b5595a767251","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            subprocess.Popen(command)"},{"line_number":69,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"root\", \"-c\","},{"line_number":70,"context_line":"                       (system.VERTICA_AGENT_SERVICE_COMMAND % \"enable\")]"},{"line_number":71,"context_line":"            subprocess.Popen(command)"},{"line_number":72,"context_line":"        except Exception:"},{"line_number":73,"context_line":"            LOG.exception(_(\"Failed to enable db on boot.\"))"},{"line_number":74,"context_line":"            raise RuntimeError(\"Could not enable db on boot.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_f75a964f","line":71,"in_reply_to":"da9b358b_3537ece4","updated":"2015-04-01 02:52:25.000000000","message":"1. The order does not matters, they can run concurrently.\n\n2. The status is being decided by _get_actual_db_status, which would be enabled to fetch actual status, once start/restart finishes.","commit_id":"f3bf4c19427d97e98b7c618c042f1cae06d32ebb"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"63a9fefbc9d525b74643e529804665964e22fcb9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            self._disable_db_on_boot()"},{"line_number":91,"context_line":"        # Stop vertica-agent service"},{"line_number":92,"context_line":"        command \u003d (system.VERTICA_AGENT_SERVICE_COMMAND % \"stop\")"},{"line_number":93,"context_line":"        system.shell_execute(command)"},{"line_number":94,"context_line":"        # Using Vertica adminTools to stop db."},{"line_number":95,"context_line":"        db_password \u003d self._get_database_password()"},{"line_number":96,"context_line":"        stop_db_command \u003d (system.STOP_DB % (DB_NAME, db_password))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_34b12548","line":93,"updated":"2015-03-31 20:31:02.000000000","message":"Dont we need to catch exceptions here?","commit_id":"f3bf4c19427d97e98b7c618c042f1cae06d32ebb"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"9addcf2f1b8151dc341836bc9705b5595a767251","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            self._disable_db_on_boot()"},{"line_number":91,"context_line":"        # Stop vertica-agent service"},{"line_number":92,"context_line":"        command \u003d (system.VERTICA_AGENT_SERVICE_COMMAND % \"stop\")"},{"line_number":93,"context_line":"        system.shell_execute(command)"},{"line_number":94,"context_line":"        # Using Vertica adminTools to stop db."},{"line_number":95,"context_line":"        db_password \u003d self._get_database_password()"},{"line_number":96,"context_line":"        stop_db_command \u003d (system.STOP_DB % (DB_NAME, db_password))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_17b29a94","line":93,"in_reply_to":"da9b358b_34b12548","updated":"2015-04-01 02:52:25.000000000","message":"Done","commit_id":"f3bf4c19427d97e98b7c618c042f1cae06d32ebb"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"5cde3279662b52df8074d16743a33150ddcc50ca","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            db_password \u003d self._get_database_password()"},{"line_number":122,"context_line":"            start_db_command \u003d [\"sudo\", \"su\", \"-\", \"dbadmin\", \"-c\","},{"line_number":123,"context_line":"                                (system.START_DB % (DB_NAME, db_password))]"},{"line_number":124,"context_line":"            subprocess.Popen(start_db_command)"},{"line_number":125,"context_line":"            if not self.status._is_restarting:"},{"line_number":126,"context_line":"                self.status.end_install_or_restart()"},{"line_number":127,"context_line":"            LOG.debug(\"Database started.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_952118a2","line":124,"updated":"2015-03-31 18:04:34.000000000","message":"ditto","commit_id":"f3bf4c19427d97e98b7c618c042f1cae06d32ebb"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"5cde3279662b52df8074d16743a33150ddcc50ca","unresolved":false,"context_lines":[{"line_number":133,"context_line":"         Will not be implementing configuration change API for Vertica in"},{"line_number":134,"context_line":"         the Kilo release. Currently all that this method does is to start"},{"line_number":135,"context_line":"         the Vertica without any configuration changes. This method needs"},{"line_number":136,"context_line":"         to be implemented to enable volume resize on the guestagent side."},{"line_number":137,"context_line":"        \"\"\""},{"line_number":138,"context_line":"        LOG.info(_(\"Starting Vertica with configuration changes.\"))"},{"line_number":139,"context_line":"        self.start_db(True)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_69b23996","line":136,"updated":"2015-03-31 18:04:34.000000000","message":"I found this confusing as it say \u0027Will not be implementing ...\u0027 and then \u0027This method needs to be implemented ...\u0027  Could this be changed to something like:\n\n  Currently all that this method does is to start the Vertica without any configuration changes; it needs to exist to enable volume resize on the guestagent.","commit_id":"f3bf4c19427d97e98b7c618c042f1cae06d32ebb"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"9addcf2f1b8151dc341836bc9705b5595a767251","unresolved":false,"context_lines":[{"line_number":133,"context_line":"         Will not be implementing configuration change API for Vertica in"},{"line_number":134,"context_line":"         the Kilo release. Currently all that this method does is to start"},{"line_number":135,"context_line":"         the Vertica without any configuration changes. This method needs"},{"line_number":136,"context_line":"         to be implemented to enable volume resize on the guestagent side."},{"line_number":137,"context_line":"        \"\"\""},{"line_number":138,"context_line":"        LOG.info(_(\"Starting Vertica with configuration changes.\"))"},{"line_number":139,"context_line":"        self.start_db(True)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_37ba3e6f","line":136,"in_reply_to":"da9b358b_69b23996","updated":"2015-04-01 02:52:25.000000000","message":"Done","commit_id":"f3bf4c19427d97e98b7c618c042f1cae06d32ebb"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"21836e98827bcd5cfdb7714fad886fac10da4c8a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            subprocess.Popen(command)"},{"line_number":69,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"root\", \"-c\","},{"line_number":70,"context_line":"                       (system.VERTICA_AGENT_SERVICE_COMMAND % \"enable\")]"},{"line_number":71,"context_line":"            subprocess.Popen(command)"},{"line_number":72,"context_line":"        except Exception:"},{"line_number":73,"context_line":"            LOG.exception(_(\"Failed to enable db on boot.\"))"},{"line_number":74,"context_line":"            raise RuntimeError(\"Could not enable db on boot.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_353dd12b","line":71,"updated":"2015-04-02 17:57:27.000000000","message":"If you are using Popen for both commands I would assume this method will return before actually finishing enable db on boot because they are run asynchronously. Would we want to Popen.wait() for these processes to finish before bailing out of the method, or else you can be in a case when the db hasn\u0027t been enabled even though the method has completed?","commit_id":"68c4246998eb13511d48f151b643be3911d321cf"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"2f099e7975e3751ae5a235676d00ce6da87b80dd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            subprocess.Popen(command)"},{"line_number":69,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"root\", \"-c\","},{"line_number":70,"context_line":"                       (system.VERTICA_AGENT_SERVICE_COMMAND % \"enable\")]"},{"line_number":71,"context_line":"            subprocess.Popen(command)"},{"line_number":72,"context_line":"        except Exception:"},{"line_number":73,"context_line":"            LOG.exception(_(\"Failed to enable db on boot.\"))"},{"line_number":74,"context_line":"            raise RuntimeError(\"Could not enable db on boot.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_d8793cfe","line":71,"in_reply_to":"baa041b7_353dd12b","updated":"2015-04-02 18:04:33.000000000","message":"So, this has been done to execute these commands in background","commit_id":"68c4246998eb13511d48f151b643be3911d321cf"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"a11793278dad288aa805ba0928d44010d9bc85cb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            subprocess.Popen(command)"},{"line_number":69,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"root\", \"-c\","},{"line_number":70,"context_line":"                       (system.VERTICA_AGENT_SERVICE_COMMAND % \"enable\")]"},{"line_number":71,"context_line":"            subprocess.Popen(command)"},{"line_number":72,"context_line":"        except Exception:"},{"line_number":73,"context_line":"            LOG.exception(_(\"Failed to enable db on boot.\"))"},{"line_number":74,"context_line":"            raise RuntimeError(\"Could not enable db on boot.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_eb48ac5d","line":71,"in_reply_to":"baa041b7_d8793cfe","updated":"2015-04-02 18:30:30.000000000","message":"Also, these commands are independent of each other on their output","commit_id":"68c4246998eb13511d48f151b643be3911d321cf"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"21836e98827bcd5cfdb7714fad886fac10da4c8a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            # Using Vertica adminTools to stop db."},{"line_number":97,"context_line":"            db_password \u003d self._get_database_password()"},{"line_number":98,"context_line":"            stop_db_command \u003d (system.STOP_DB % (DB_NAME, db_password))"},{"line_number":99,"context_line":"            out, err \u003d system.shell_execute(system.STATUS_ACTIVE_DB, \"dbadmin\")"},{"line_number":100,"context_line":"            if out.strip() \u003d\u003d DB_NAME:"},{"line_number":101,"context_line":"                system.shell_execute(stop_db_command, \"dbadmin\")"},{"line_number":102,"context_line":"                if not self.status._is_restarting:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_95a5bd05","line":99,"updated":"2015-04-02 17:57:27.000000000","message":"Is there a reason to not check/use this err return value?","commit_id":"68c4246998eb13511d48f151b643be3911d321cf"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"2f099e7975e3751ae5a235676d00ce6da87b80dd","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            # Using Vertica adminTools to stop db."},{"line_number":97,"context_line":"            db_password \u003d self._get_database_password()"},{"line_number":98,"context_line":"            stop_db_command \u003d (system.STOP_DB % (DB_NAME, db_password))"},{"line_number":99,"context_line":"            out, err \u003d system.shell_execute(system.STATUS_ACTIVE_DB, \"dbadmin\")"},{"line_number":100,"context_line":"            if out.strip() \u003d\u003d DB_NAME:"},{"line_number":101,"context_line":"                system.shell_execute(stop_db_command, \"dbadmin\")"},{"line_number":102,"context_line":"                if not self.status._is_restarting:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_383dc82b","line":99,"in_reply_to":"baa041b7_95a5bd05","updated":"2015-04-02 18:04:33.000000000","message":"there would be 2 cases\n\n1. in case of exception it breaks from here\n\n2. if there would be an err, then out will not have the intended output and both cases are covered.","commit_id":"68c4246998eb13511d48f151b643be3911d321cf"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"21836e98827bcd5cfdb7714fad886fac10da4c8a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            db_password \u003d self._get_database_password()"},{"line_number":127,"context_line":"            start_db_command \u003d [\"sudo\", \"su\", \"-\", \"dbadmin\", \"-c\","},{"line_number":128,"context_line":"                                (system.START_DB % (DB_NAME, db_password))]"},{"line_number":129,"context_line":"            subprocess.Popen(start_db_command)"},{"line_number":130,"context_line":"            if not self.status._is_restarting:"},{"line_number":131,"context_line":"                self.status.end_install_or_restart()"},{"line_number":132,"context_line":"            LOG.debug(\"Database started.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_f89c006b","line":129,"updated":"2015-04-02 17:57:27.000000000","message":"This method has the same issue a above. The VERTICA_AGENT_SERVICE_COMMAND and START_DB commands are not guaranteed to finish when this method completes because they are run in a child processes. The start_db method will finish even though the database might not actually be started. Is this the intended behavior or should we be doing a Popen.wait()?","commit_id":"68c4246998eb13511d48f151b643be3911d321cf"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"2f099e7975e3751ae5a235676d00ce6da87b80dd","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            db_password \u003d self._get_database_password()"},{"line_number":127,"context_line":"            start_db_command \u003d [\"sudo\", \"su\", \"-\", \"dbadmin\", \"-c\","},{"line_number":128,"context_line":"                                (system.START_DB % (DB_NAME, db_password))]"},{"line_number":129,"context_line":"            subprocess.Popen(start_db_command)"},{"line_number":130,"context_line":"            if not self.status._is_restarting:"},{"line_number":131,"context_line":"                self.status.end_install_or_restart()"},{"line_number":132,"context_line":"            LOG.debug(\"Database started.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_38f6e88f","line":129,"in_reply_to":"baa041b7_f89c006b","updated":"2015-04-02 18:04:33.000000000","message":"this is done intentionally in order to decrease the startup/restart time.\nsince, at the end of start/restart methods there is a end_install_or_restart which would start posting the actual status to host suggesting that guest is in shutdown state until it actually reaches an active state.","commit_id":"68c4246998eb13511d48f151b643be3911d321cf"}],"trove/tests/unittests/guestagent/test_dbaas.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5e8c25dafb9ee85543564e9d125f933a0a6f7fd4","unresolved":false,"context_lines":[{"line_number":2100,"context_line":"                                       rd_instance.ServiceStatuses.NEW)"},{"line_number":2101,"context_line":"        self.app \u003d VerticaApp(self.appStatus)"},{"line_number":2102,"context_line":"        self.setread \u003d VolumeDevice.set_readahead_size"},{"line_number":2103,"context_line":"        vertica_system.shell_execute \u003d MagicMock(return_value\u003d(\u0027\u0027, \u0027\u0027))"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        VolumeDevice.set_readahead_size \u003d Mock()"},{"line_number":2106,"context_line":"        self.test_config \u003d ConfigParser.ConfigParser()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a75e904_e68ffeca","line":2103,"updated":"2015-03-21 00:27:44.000000000","message":"Doesn\u0027t this need to be reverted?","commit_id":"331523f3f35cda7170d318800d57aae7bf967efa"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"b0a32241f665631c5d2fc4349bb35fd0ff7bf115","unresolved":false,"context_lines":[{"line_number":2100,"context_line":"                                       rd_instance.ServiceStatuses.NEW)"},{"line_number":2101,"context_line":"        self.app \u003d VerticaApp(self.appStatus)"},{"line_number":2102,"context_line":"        self.setread \u003d VolumeDevice.set_readahead_size"},{"line_number":2103,"context_line":"        vertica_system.shell_execute \u003d MagicMock(return_value\u003d(\u0027\u0027, \u0027\u0027))"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        VolumeDevice.set_readahead_size \u003d Mock()"},{"line_number":2106,"context_line":"        self.test_config \u003d ConfigParser.ConfigParser()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a75e904_cfc77563","line":2103,"in_reply_to":"7a75e904_e68ffeca","updated":"2015-03-21 04:31:05.000000000","message":"This is coming from vertica code, since noone else is going to use this, why would you rever it.","commit_id":"331523f3f35cda7170d318800d57aae7bf967efa"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5e8c25dafb9ee85543564e9d125f933a0a6f7fd4","unresolved":false,"context_lines":[{"line_number":2247,"context_line":"                self.assertRaises(RuntimeError, app.start_db)"},{"line_number":2248,"context_line":""},{"line_number":2249,"context_line":"    def test_stop_db(self):"},{"line_number":2250,"context_line":"        vertica_system.shell_execute \u003d MagicMock("},{"line_number":2251,"context_line":"            side_effect\u003d[[\u0027\u0027, \u0027\u0027], [\u0027db_srvr\u0027, None], [\u0027\u0027, \u0027\u0027]])"},{"line_number":2252,"context_line":"        mock_status \u003d MagicMock()"},{"line_number":2253,"context_line":"        app \u003d VerticaApp(mock_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a75e904_26c116e5","line":2250,"updated":"2015-03-21 00:27:44.000000000","message":"What will revert this?","commit_id":"331523f3f35cda7170d318800d57aae7bf967efa"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"b0a32241f665631c5d2fc4349bb35fd0ff7bf115","unresolved":false,"context_lines":[{"line_number":2247,"context_line":"                self.assertRaises(RuntimeError, app.start_db)"},{"line_number":2248,"context_line":""},{"line_number":2249,"context_line":"    def test_stop_db(self):"},{"line_number":2250,"context_line":"        vertica_system.shell_execute \u003d MagicMock("},{"line_number":2251,"context_line":"            side_effect\u003d[[\u0027\u0027, \u0027\u0027], [\u0027db_srvr\u0027, None], [\u0027\u0027, \u0027\u0027]])"},{"line_number":2252,"context_line":"        mock_status \u003d MagicMock()"},{"line_number":2253,"context_line":"        app \u003d VerticaApp(mock_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a75e904_4fab8589","line":2250,"in_reply_to":"7a75e904_26c116e5","updated":"2015-03-21 04:31:05.000000000","message":"why would you want to revert this.","commit_id":"331523f3f35cda7170d318800d57aae7bf967efa"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5e8c25dafb9ee85543564e9d125f933a0a6f7fd4","unresolved":false,"context_lines":[{"line_number":2277,"context_line":"                arguments.assert_called_with(expected_command, \u0027dbadmin\u0027)"},{"line_number":2278,"context_line":""},{"line_number":2279,"context_line":"    def test_stop_db_failure(self):"},{"line_number":2280,"context_line":"        vertica_system.shell_execute \u003d MagicMock("},{"line_number":2281,"context_line":"            side_effect\u003d[[\u0027\u0027, \u0027\u0027], [\u0027db_srvr\u0027, None], [\u0027\u0027, \u0027\u0027]])"},{"line_number":2282,"context_line":"        mock_status \u003d MagicMock()"},{"line_number":2283,"context_line":"        app \u003d VerticaApp(mock_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a75e904_46b6128c","line":2280,"updated":"2015-03-21 00:27:44.000000000","message":"What will revert this?","commit_id":"331523f3f35cda7170d318800d57aae7bf967efa"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"b0a32241f665631c5d2fc4349bb35fd0ff7bf115","unresolved":false,"context_lines":[{"line_number":2277,"context_line":"                arguments.assert_called_with(expected_command, \u0027dbadmin\u0027)"},{"line_number":2278,"context_line":""},{"line_number":2279,"context_line":"    def test_stop_db_failure(self):"},{"line_number":2280,"context_line":"        vertica_system.shell_execute \u003d MagicMock("},{"line_number":2281,"context_line":"            side_effect\u003d[[\u0027\u0027, \u0027\u0027], [\u0027db_srvr\u0027, None], [\u0027\u0027, \u0027\u0027]])"},{"line_number":2282,"context_line":"        mock_status \u003d MagicMock()"},{"line_number":2283,"context_line":"        app \u003d VerticaApp(mock_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a75e904_6fb041f5","line":2280,"in_reply_to":"7a75e904_46b6128c","updated":"2015-03-21 04:31:05.000000000","message":"why would you want to revert this.","commit_id":"331523f3f35cda7170d318800d57aae7bf967efa"}]}