)]}'
{"trove/common/strategies/cluster/experimental/vertica/api.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"91132203f03b612f4d3819a7cd404e3572e5bf67","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            inst_models.Instance.create(context, instance_name,"},{"line_number":114,"context_line":"                                        flavor_id,"},{"line_number":115,"context_line":"                                        datastore_version.image_id,"},{"line_number":116,"context_line":"                                        [], users if i \u003d\u003d 1 else [],"},{"line_number":117,"context_line":"                                        datastore, datastore_version,"},{"line_number":118,"context_line":"                                        volume_size, None,"},{"line_number":119,"context_line":"                                        availability_zone\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_857d1eea","line":116,"updated":"2015-03-24 09:59:42.000000000","message":"It wont work here because the instances created from this section wont have vertica installed.","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"a3304cb1c926ba4fe0bd7c54c8c81095a52714b2","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            inst_models.Instance.create(context, instance_name,"},{"line_number":114,"context_line":"                                        flavor_id,"},{"line_number":115,"context_line":"                                        datastore_version.image_id,"},{"line_number":116,"context_line":"                                        [], users if i \u003d\u003d 1 else [],"},{"line_number":117,"context_line":"                                        datastore, datastore_version,"},{"line_number":118,"context_line":"                                        volume_size, None,"},{"line_number":119,"context_line":"                                        availability_zone\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_4f985e78","line":116,"in_reply_to":"1a6ced46_857d1eea","updated":"2015-04-09 17:06:20.000000000","message":"What won\u0027t work from here? The goal here is to pass users along to the first vertica instance, since they only need to be created on one instance for the entire cluster.","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"}],"trove/guestagent/datastore/experimental/vertica/manager.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"91132203f03b612f4d3819a7cd404e3572e5bf67","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                self.app.install_vertica()"},{"line_number":66,"context_line":"                self.app.create_db()"},{"line_number":67,"context_line":"                if users:"},{"line_number":68,"context_line":"                    self.app.create_users(users, True)"},{"line_number":69,"context_line":"                self.app.complete_install_or_restart()"},{"line_number":70,"context_line":"            elif cluster_config[\u0027instance_type\u0027] \u003d\u003d \"member\":"},{"line_number":71,"context_line":"                self.appStatus.set_status(rd_ins.ServiceStatuses.BUILD_PENDING)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_65bbc2e5","line":68,"updated":"2015-03-24 09:59:42.000000000","message":"This section gets executed for single instance and not for cluster.","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"a3304cb1c926ba4fe0bd7c54c8c81095a52714b2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                self.app.install_vertica()"},{"line_number":66,"context_line":"                self.app.create_db()"},{"line_number":67,"context_line":"                if users:"},{"line_number":68,"context_line":"                    self.app.create_users(users, True)"},{"line_number":69,"context_line":"                self.app.complete_install_or_restart()"},{"line_number":70,"context_line":"            elif cluster_config[\u0027instance_type\u0027] \u003d\u003d \"member\":"},{"line_number":71,"context_line":"                self.appStatus.set_status(rd_ins.ServiceStatuses.BUILD_PENDING)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_2f951a3e","line":68,"in_reply_to":"1a6ced46_65bbc2e5","updated":"2015-04-09 17:06:20.000000000","message":"That\u0027s good.","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"077fd2b28e03312e6b773172869da0877475b120","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            operation\u003d\u0027list_users\u0027, datastore\u003dMANAGER)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def enable_root(self, context, root_password\u003dNone):"},{"line_number":184,"context_line":"        LOG.debug(\"Enabling root for password %s.\" % root_password)"},{"line_number":185,"context_line":"        return self.app.enable_root(root_password)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def is_root_enabled(self, context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_a02198b6","line":184,"updated":"2015-04-07 19:04:42.000000000","message":"Is it a good idea to log the password?","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":15090,"name":"Elvis Teixeira","email":"elvis.teixeira@lsbd.ufc.br","username":"ElvisTeixeira"},"change_message_id":"be7841336ad4f0c09bbdee487d23b9a8eb453577","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            operation\u003d\u0027list_users\u0027, datastore\u003dMANAGER)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def enable_root(self, context, root_password\u003dNone):"},{"line_number":184,"context_line":"        LOG.debug(\"Enabling root for password %s.\" % root_password)"},{"line_number":185,"context_line":"        return self.app.enable_root(root_password)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def is_root_enabled(self, context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_835d277b","line":184,"in_reply_to":"9aa53dc9_a02198b6","updated":"2015-04-09 15:38:15.000000000","message":"please don\u0027t write the password","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"}],"trove/guestagent/datastore/experimental/vertica/service.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"077fd2b28e03312e6b773172869da0877475b120","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        \"\"\"Creates a schema.\"\"\""},{"line_number":171,"context_line":"        LOG.info(_(\"Creating schema\"))"},{"line_number":172,"context_line":"        out, err \u003d system.exec_vsql_command(self._get_database_password(),"},{"line_number":173,"context_line":"                                            system.CREATE_SCHEMA % schema)"},{"line_number":174,"context_line":"        if err:"},{"line_number":175,"context_line":"            LOG.error(err)"},{"line_number":176,"context_line":"            raise RuntimeError(\"Failed to create schema %s.\" % schema)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_00d284d2","line":173,"updated":"2015-04-07 19:04:42.000000000","message":"Its probably a good idea to enclose this in a try/catch block.","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"a3304cb1c926ba4fe0bd7c54c8c81095a52714b2","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        \"\"\"Creates a schema.\"\"\""},{"line_number":171,"context_line":"        LOG.info(_(\"Creating schema\"))"},{"line_number":172,"context_line":"        out, err \u003d system.exec_vsql_command(self._get_database_password(),"},{"line_number":173,"context_line":"                                            system.CREATE_SCHEMA % schema)"},{"line_number":174,"context_line":"        if err:"},{"line_number":175,"context_line":"            LOG.error(err)"},{"line_number":176,"context_line":"            raise RuntimeError(\"Failed to create schema %s.\" % schema)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_6f9c425d","line":173,"in_reply_to":"9aa53dc9_00d284d2","updated":"2015-04-09 17:06:20.000000000","message":"system.exec_vsql_command doesn\u0027t throw exceptions - it returns an (output, error) tuple, the same here as everywhere in this module.","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"91132203f03b612f4d3819a7cd404e3572e5bf67","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                dbadmin_password, system.GRANT_TO_USER % (role, username))"},{"line_number":201,"context_line":"        if not err:"},{"line_number":202,"context_line":"            out, err \u003d system.exec_vsql_command("},{"line_number":203,"context_line":"                dbadmin_password, system.ENABLE_FOR_USER % (username, role))"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _generate_database_password(self):"},{"line_number":206,"context_line":"        \"\"\"Generate and write the password to vertica.cnf file.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_254aaac5","line":203,"updated":"2015-03-24 09:59:42.000000000","message":"If you can end LOG.info messages with \u0027.\u0027","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"a3304cb1c926ba4fe0bd7c54c8c81095a52714b2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                dbadmin_password, system.GRANT_TO_USER % (role, username))"},{"line_number":201,"context_line":"        if not err:"},{"line_number":202,"context_line":"            out, err \u003d system.exec_vsql_command("},{"line_number":203,"context_line":"                dbadmin_password, system.ENABLE_FOR_USER % (username, role))"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _generate_database_password(self):"},{"line_number":206,"context_line":"        \"\"\"Generate and write the password to vertica.cnf file.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_efa85279","line":203,"in_reply_to":"1a6ced46_254aaac5","updated":"2015-04-09 17:06:20.000000000","message":"Done","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"077fd2b28e03312e6b773172869da0877475b120","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def is_root_enabled(self):"},{"line_number":342,"context_line":"        \"\"\"Return True if root access is enabled else False.\"\"\""},{"line_number":343,"context_line":"        LOG.debug(\"Checking is root enabled\")"},{"line_number":344,"context_line":"        out, err \u003d system.shell_execute("},{"line_number":345,"context_line":"            system.USER_EXISTS % (self._get_database_password(), \u0027root\u0027),"},{"line_number":346,"context_line":"            \u0027dbadmin\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_40964cf1","line":343,"updated":"2015-04-07 19:04:42.000000000","message":"In other methods, you have used LOG.info except this one.","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"a3304cb1c926ba4fe0bd7c54c8c81095a52714b2","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def is_root_enabled(self):"},{"line_number":342,"context_line":"        \"\"\"Return True if root access is enabled else False.\"\"\""},{"line_number":343,"context_line":"        LOG.debug(\"Checking is root enabled\")"},{"line_number":344,"context_line":"        out, err \u003d system.shell_execute("},{"line_number":345,"context_line":"            system.USER_EXISTS % (self._get_database_password(), \u0027root\u0027),"},{"line_number":346,"context_line":"            \u0027dbadmin\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_4fcdfe64","line":343,"in_reply_to":"9aa53dc9_40964cf1","updated":"2015-04-09 17:06:20.000000000","message":"Done","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"}],"trove/guestagent/datastore/experimental/vertica/system.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"91132203f03b612f4d3819a7cd404e3572e5bf67","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                      \"-d %s -p \u0027%s\u0027\")"},{"line_number":27,"context_line":"CREATE_SCHEMA \u003d \"CREATE SCHEMA %s\""},{"line_number":28,"context_line":"CREATE_USER \u003d \"CREATE USER %s IDENTIFIED BY \u0027%s\u0027\""},{"line_number":29,"context_line":"GRANT_TO_USER \u003d \"GRANT %s to %s\""},{"line_number":30,"context_line":"GRANT_TO_USER_ON_SCHEMA \u003d \"GRANT %s on schema %s to %s\""},{"line_number":31,"context_line":"ENABLE_FOR_USER \u003d \"ALTER USER %s DEFAULT ROLE %s\""},{"line_number":32,"context_line":"USER_EXISTS \u003d (\"/opt/vertica/bin/vsql -w \u0027%s\u0027 -c \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_05ca0e6e","line":29,"updated":"2015-03-24 09:59:42.000000000","message":"GRANT_ROLE_TO_USER","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"a3304cb1c926ba4fe0bd7c54c8c81095a52714b2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                      \"-d %s -p \u0027%s\u0027\")"},{"line_number":27,"context_line":"CREATE_SCHEMA \u003d \"CREATE SCHEMA %s\""},{"line_number":28,"context_line":"CREATE_USER \u003d \"CREATE USER %s IDENTIFIED BY \u0027%s\u0027\""},{"line_number":29,"context_line":"GRANT_TO_USER \u003d \"GRANT %s to %s\""},{"line_number":30,"context_line":"GRANT_TO_USER_ON_SCHEMA \u003d \"GRANT %s on schema %s to %s\""},{"line_number":31,"context_line":"ENABLE_FOR_USER \u003d \"ALTER USER %s DEFAULT ROLE %s\""},{"line_number":32,"context_line":"USER_EXISTS \u003d (\"/opt/vertica/bin/vsql -w \u0027%s\u0027 -c \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_0fc37639","line":29,"in_reply_to":"1a6ced46_05ca0e6e","updated":"2015-04-09 17:06:20.000000000","message":"Done","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"91132203f03b612f4d3819a7cd404e3572e5bf67","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CREATE_SCHEMA \u003d \"CREATE SCHEMA %s\""},{"line_number":28,"context_line":"CREATE_USER \u003d \"CREATE USER %s IDENTIFIED BY \u0027%s\u0027\""},{"line_number":29,"context_line":"GRANT_TO_USER \u003d \"GRANT %s to %s\""},{"line_number":30,"context_line":"GRANT_TO_USER_ON_SCHEMA \u003d \"GRANT %s on schema %s to %s\""},{"line_number":31,"context_line":"ENABLE_FOR_USER \u003d \"ALTER USER %s DEFAULT ROLE %s\""},{"line_number":32,"context_line":"USER_EXISTS \u003d (\"/opt/vertica/bin/vsql -w \u0027%s\u0027 -c \""},{"line_number":33,"context_line":"               \"\\\"select 1 from users where user_name \u003d \u0027%s\u0027\\\" \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_45c4065f","line":30,"updated":"2015-03-24 09:59:42.000000000","message":"GRANT_PRIVILEGE_TO_USER_ON_SCHEMA","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"a3304cb1c926ba4fe0bd7c54c8c81095a52714b2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CREATE_SCHEMA \u003d \"CREATE SCHEMA %s\""},{"line_number":28,"context_line":"CREATE_USER \u003d \"CREATE USER %s IDENTIFIED BY \u0027%s\u0027\""},{"line_number":29,"context_line":"GRANT_TO_USER \u003d \"GRANT %s to %s\""},{"line_number":30,"context_line":"GRANT_TO_USER_ON_SCHEMA \u003d \"GRANT %s on schema %s to %s\""},{"line_number":31,"context_line":"ENABLE_FOR_USER \u003d \"ALTER USER %s DEFAULT ROLE %s\""},{"line_number":32,"context_line":"USER_EXISTS \u003d (\"/opt/vertica/bin/vsql -w \u0027%s\u0027 -c \""},{"line_number":33,"context_line":"               \"\\\"select 1 from users where user_name \u003d \u0027%s\u0027\\\" \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_cfdfce0b","line":30,"in_reply_to":"1a6ced46_45c4065f","updated":"2015-04-09 17:06:20.000000000","message":"Done","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"91132203f03b612f4d3819a7cd404e3572e5bf67","unresolved":false,"context_lines":[{"line_number":28,"context_line":"CREATE_USER \u003d \"CREATE USER %s IDENTIFIED BY \u0027%s\u0027\""},{"line_number":29,"context_line":"GRANT_TO_USER \u003d \"GRANT %s to %s\""},{"line_number":30,"context_line":"GRANT_TO_USER_ON_SCHEMA \u003d \"GRANT %s on schema %s to %s\""},{"line_number":31,"context_line":"ENABLE_FOR_USER \u003d \"ALTER USER %s DEFAULT ROLE %s\""},{"line_number":32,"context_line":"USER_EXISTS \u003d (\"/opt/vertica/bin/vsql -w \u0027%s\u0027 -c \""},{"line_number":33,"context_line":"               \"\\\"select 1 from users where user_name \u003d \u0027%s\u0027\\\" \""},{"line_number":34,"context_line":"               \"| grep row | awk \u0027{print $1}\u0027 | cut -c2-\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_e595f240","line":31,"updated":"2015-03-24 09:59:42.000000000","message":"ENABLE_ROLE_FOR_USER","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"a3304cb1c926ba4fe0bd7c54c8c81095a52714b2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"CREATE_USER \u003d \"CREATE USER %s IDENTIFIED BY \u0027%s\u0027\""},{"line_number":29,"context_line":"GRANT_TO_USER \u003d \"GRANT %s to %s\""},{"line_number":30,"context_line":"GRANT_TO_USER_ON_SCHEMA \u003d \"GRANT %s on schema %s to %s\""},{"line_number":31,"context_line":"ENABLE_FOR_USER \u003d \"ALTER USER %s DEFAULT ROLE %s\""},{"line_number":32,"context_line":"USER_EXISTS \u003d (\"/opt/vertica/bin/vsql -w \u0027%s\u0027 -c \""},{"line_number":33,"context_line":"               \"\\\"select 1 from users where user_name \u003d \u0027%s\u0027\\\" \""},{"line_number":34,"context_line":"               \"| grep row | awk \u0027{print $1}\u0027 | cut -c2-\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_8fe546dd","line":31,"in_reply_to":"1a6ced46_e595f240","updated":"2015-04-09 17:06:20.000000000","message":"Done","commit_id":"3833b5f5e00b3ad1496a5e193ae8b3bf4d8d8e1a"}]}