)]}'
{"trove/guestagent/api.py":[{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"9908b0049242a2a870573c4d8985fd0eeccb139f","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        self._call(\"enable_as_master\", AGENT_HIGH_TIMEOUT, self.version_cap,"},{"line_number":380,"context_line":"                   replica_source_config\u003dreplica_source_config)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    # DEPRECATED: Mantain for API Compatibility"},{"line_number":383,"context_line":"    def get_txn_count(self):"},{"line_number":384,"context_line":"        LOG.debug(\"Executing get_txn_count.\")"},{"line_number":385,"context_line":"        return self._call(\"get_txn_count\","}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_6f4e10c3","line":382,"updated":"2015-03-29 05:02:45.000000000","message":"Maintain*","commit_id":"7ead41f5c97a0654513e3d771ccb678283c43690"}],"trove/guestagent/datastore/mysql/manager.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"8374535cc811154e92a3ffa23ba7cf663d22fe18","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        replication \u003d REPLICATION_STRATEGY_CLASS(context)"},{"line_number":257,"context_line":"        replication.enable_as_master(app, replica_source_config)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def get_txn_count(self, context):"},{"line_number":260,"context_line":"        LOG.debug(\"Calling get_txn_count\")"},{"line_number":261,"context_line":"        return MySqlApp(MySqlAppStatus.get()).get_txn_count()"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_b668cbf6","line":259,"updated":"2015-03-27 18:49:18.000000000","message":"tx_count is no longer used","commit_id":"86bce63516a85e422d51282e6d372015a094cb19"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"42dd7f5d3b66cd1b95529f9fab599e94ff829769","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        replication \u003d REPLICATION_STRATEGY_CLASS(context)"},{"line_number":257,"context_line":"        replication.enable_as_master(app, replica_source_config)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def get_txn_count(self, context):"},{"line_number":260,"context_line":"        LOG.debug(\"Calling get_txn_count\")"},{"line_number":261,"context_line":"        return MySqlApp(MySqlAppStatus.get()).get_txn_count()"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_09ae3885","line":259,"in_reply_to":"fa963961_b668cbf6","updated":"2015-03-27 19:04:50.000000000","message":"I\u0027m not sure what the policy is on removing (or deprecating) guestagent API calls ...","commit_id":"86bce63516a85e422d51282e6d372015a094cb19"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"9908b0049242a2a870573c4d8985fd0eeccb139f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        replication \u003d REPLICATION_STRATEGY_CLASS(context)"},{"line_number":257,"context_line":"        replication.enable_as_master(app, replica_source_config)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    # DEPRECATED: Mantain for API Compatibility"},{"line_number":260,"context_line":"    def get_txn_count(self, context):"},{"line_number":261,"context_line":"        LOG.debug(\"Calling get_txn_count\")"},{"line_number":262,"context_line":"        return MySqlApp(MySqlAppStatus.get()).get_txn_count()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_efd0e0cb","line":259,"updated":"2015-03-29 05:02:45.000000000","message":"Maintain*","commit_id":"7ead41f5c97a0654513e3d771ccb678283c43690"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"050ffa5e0f85faf59c82b7f36fc3862b45e890d1","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        replication \u003d REPLICATION_STRATEGY_CLASS(context)"},{"line_number":257,"context_line":"        replication.enable_as_master(app, replica_source_config)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    # DEPRECATED: Maintain for API Compatibility"},{"line_number":260,"context_line":"    def get_txn_count(self, context):"},{"line_number":261,"context_line":"        LOG.debug(\"Calling get_txn_count\")"},{"line_number":262,"context_line":"        return MySqlApp(MySqlAppStatus.get()).get_txn_count()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_2a377ce4","line":259,"updated":"2015-04-04 16:50:06.000000000","message":"wont it be a good idea to keep this comment inside method","commit_id":"7f07fdbf0dff4aa87b2d796b8d6bba96e15fcbdf"}],"trove/guestagent/datastore/mysql/service.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"050ffa5e0f85faf59c82b7f36fc3862b45e890d1","unresolved":false,"context_lines":[{"line_number":985,"context_line":"        self._write_mycnf(None, config_contents)"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    # DEPRECATED: Mantain for API Compatibility"},{"line_number":988,"context_line":"    def get_txn_count(self):"},{"line_number":989,"context_line":"        LOG.info(_(\"Retrieving latest txn id.\"))"},{"line_number":990,"context_line":"        txn_count \u003d 0"},{"line_number":991,"context_line":"        with LocalSqlClient(get_engine()) as client:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_ca4ed06e","line":988,"updated":"2015-04-04 16:50:06.000000000","message":"it would be a better idea to keep the comment inside method","commit_id":"7f07fdbf0dff4aa87b2d796b8d6bba96e15fcbdf"}],"trove/tests/unittests/guestagent/test_mysql_manager.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"bdd2d6c04a6a2250c7cd7fada9d37de01b0eb75a","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    def test_get_master_UUID(self):"},{"line_number":367,"context_line":"        app \u003d dbaas.MySqlApp(None)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        def test_case(slave_status, expected_value):"},{"line_number":370,"context_line":"            with patch.object(dbaas.MySqlApp, \u0027_get_slave_status\u0027,"},{"line_number":371,"context_line":"                              return_value\u003dslave_status):"},{"line_number":372,"context_line":"                assert_equal(app._get_master_UUID(), expected_value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_d1792095","line":369,"range":{"start_line":369,"start_character":0,"end_line":369,"end_character":8},"updated":"2015-04-02 15:07:41.000000000","message":"typically, names of \u0027local\u0027 methods are started with \u0027_\u0027","commit_id":"7f07fdbf0dff4aa87b2d796b8d6bba96e15fcbdf"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"577f9f9cffac6247384ea4a3d81ba922cc3a06cb","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    def test_get_master_UUID(self):"},{"line_number":367,"context_line":"        app \u003d dbaas.MySqlApp(None)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        def test_case(slave_status, expected_value):"},{"line_number":370,"context_line":"            with patch.object(dbaas.MySqlApp, \u0027_get_slave_status\u0027,"},{"line_number":371,"context_line":"                              return_value\u003dslave_status):"},{"line_number":372,"context_line":"                assert_equal(app._get_master_UUID(), expected_value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_751119ac","line":369,"range":{"start_line":369,"start_character":0,"end_line":369,"end_character":8},"in_reply_to":"baa041b7_88aa49d3","updated":"2015-04-02 17:46:00.000000000","message":"I\u0027m ok with that, however we haven\u0027t always followed that convention ;)","commit_id":"7f07fdbf0dff4aa87b2d796b8d6bba96e15fcbdf"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"308fb1431369ee802f89ef8e8bfe85330c247523","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    def test_get_master_UUID(self):"},{"line_number":367,"context_line":"        app \u003d dbaas.MySqlApp(None)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        def test_case(slave_status, expected_value):"},{"line_number":370,"context_line":"            with patch.object(dbaas.MySqlApp, \u0027_get_slave_status\u0027,"},{"line_number":371,"context_line":"                              return_value\u003dslave_status):"},{"line_number":372,"context_line":"                assert_equal(app._get_master_UUID(), expected_value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_88aa49d3","line":369,"range":{"start_line":369,"start_character":0,"end_line":369,"end_character":8},"in_reply_to":"baa041b7_d1792095","updated":"2015-04-02 16:41:17.000000000","message":"I disagree.  Closures are like local variables, which do not by convention have names beginning with underscores.","commit_id":"7f07fdbf0dff4aa87b2d796b8d6bba96e15fcbdf"}]}