)]}'
{"trove/tests/unittests/cluster/test_cluster_views.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"62ea54afbe27946354c3b6a6f9b3536ab0638800","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        cluster.instances[2].datastore_version.manager \u003d \u0027mongodb\u0027"},{"line_number":91,"context_line":"        view \u003d ClusterView(cluster, MagicMock())"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # Testing various results from query_router"},{"line_number":94,"context_line":"        instances, ip_list \u003d view._build_instances([\u0027query_router\u0027],"},{"line_number":95,"context_line":"                                                   [\u0027member\u0027])"},{"line_number":96,"context_line":"        self.assertEqual(len(ip_list), 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_22a11195","line":93,"updated":"2015-03-27 20:46:05.000000000","message":"Is there something different between these test cases (other than test data)?  Could you define a test_case closure function to test these cases?","commit_id":"18793dd18b6a06dd5fad23a860d62b8c0b854592"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"476821ae7a99fa3c42b829de8b6ea9685c912421","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        cluster.instances[2].datastore_version.manager \u003d \u0027mongodb\u0027"},{"line_number":91,"context_line":"        view \u003d ClusterView(cluster, MagicMock())"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # Testing various results from query_router"},{"line_number":94,"context_line":"        instances, ip_list \u003d view._build_instances([\u0027query_router\u0027],"},{"line_number":95,"context_line":"                                                   [\u0027member\u0027])"},{"line_number":96,"context_line":"        self.assertEqual(len(ip_list), 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_b5f58a84","line":93,"in_reply_to":"da9b358b_15ab168b","updated":"2015-03-29 14:21:08.000000000","message":"A nested function to abstract the testing.  See https://review.openstack.org/#/c/168425/5/trove/tests/unittests/taskmanager/test_manager.py,cm for an example","commit_id":"18793dd18b6a06dd5fad23a860d62b8c0b854592"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"bf5d4e9c7aa1ed5f4b2437390c6bcc69d78e997b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        cluster.instances[2].datastore_version.manager \u003d \u0027mongodb\u0027"},{"line_number":91,"context_line":"        view \u003d ClusterView(cluster, MagicMock())"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # Testing various results from query_router"},{"line_number":94,"context_line":"        instances, ip_list \u003d view._build_instances([\u0027query_router\u0027],"},{"line_number":95,"context_line":"                                                   [\u0027member\u0027])"},{"line_number":96,"context_line":"        self.assertEqual(len(ip_list), 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_d8c4c393","line":93,"in_reply_to":"da9b358b_b5f58a84","updated":"2015-03-29 15:44:02.000000000","message":"I am not sure whats the benefit of that approach over the current one.","commit_id":"18793dd18b6a06dd5fad23a860d62b8c0b854592"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"d3bccbb4533a1146bb8bbb692b5f5b6b45be73ce","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        cluster.instances[2].datastore_version.manager \u003d \u0027mongodb\u0027"},{"line_number":91,"context_line":"        view \u003d ClusterView(cluster, MagicMock())"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # Testing various results from query_router"},{"line_number":94,"context_line":"        instances, ip_list \u003d view._build_instances([\u0027query_router\u0027],"},{"line_number":95,"context_line":"                                                   [\u0027member\u0027])"},{"line_number":96,"context_line":"        self.assertEqual(len(ip_list), 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_15ab168b","line":93,"in_reply_to":"fa963961_22a11195","updated":"2015-03-29 13:56:27.000000000","message":"I did not get what is meant by test_case closure function.","commit_id":"18793dd18b6a06dd5fad23a860d62b8c0b854592"}]}