)]}'
{"trove/taskmanager/models.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"adaf71b7d49c09d8631b0d9ef1f9eb26c1643823","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    def get_guest(cls, instance):"},{"line_number":214,"context_line":"        return remote.create_guest_client(instance.context,"},{"line_number":215,"context_line":"                                          instance.db_info.id,"},{"line_number":216,"context_line":"                                          instance.datastore_version.manager)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _all_instances_ready(self, instance_ids, cluster_id,"},{"line_number":219,"context_line":"                             shard_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_fd50440c","line":216,"updated":"2015-04-21 19:09:44.000000000","message":"-1\n\nThis is now returning remote.create_guest_client().  Both implementations before returned create_guest_client().  You didn\u0027t explain why the need to change this - are you putting in a bug fix as well?","commit_id":"f9247ffd0b6d5f56865ee05ed363ac8178a18a64"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"831e82f51427c7517766cd36d89ca94bcc9d45d9","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    def get_guest(cls, instance):"},{"line_number":214,"context_line":"        return remote.create_guest_client(instance.context,"},{"line_number":215,"context_line":"                                          instance.db_info.id,"},{"line_number":216,"context_line":"                                          instance.datastore_version.manager)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _all_instances_ready(self, instance_ids, cluster_id,"},{"line_number":219,"context_line":"                             shard_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_ddb460f3","line":216,"in_reply_to":"dac4157f_fd50440c","updated":"2015-04-21 19:15:30.000000000","message":"Never mind, I didn\u0027t notice that the files import the module differently","commit_id":"f9247ffd0b6d5f56865ee05ed363ac8178a18a64"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"3c2f32329c47a5635ed81a178ba7643998cb45cd","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    def get_guest(cls, instance):"},{"line_number":214,"context_line":"        return remote.create_guest_client(instance.context,"},{"line_number":215,"context_line":"                                          instance.db_info.id,"},{"line_number":216,"context_line":"                                          instance.datastore_version.manager)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _all_instances_ready(self, instance_ids, cluster_id,"},{"line_number":219,"context_line":"                             shard_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_9d7dc81e","line":216,"in_reply_to":"dac4157f_fd50440c","updated":"2015-04-21 19:17:38.000000000","message":"No that was not a bug-fix, it was just that this module had no import for create_guest_client but had an import for remote and I did not bother to add an extra import just used what was already there available.\n\nFunctionality wise it does not makes any difference.","commit_id":"f9247ffd0b6d5f56865ee05ed363ac8178a18a64"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"adaf71b7d49c09d8631b0d9ef1f9eb26c1643823","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                             shard_id\u003dNone):"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        def _all_status_ready(ids):"},{"line_number":222,"context_line":"            LOG.debug(\"Checking service status of instance ids: %s\" % ids)"},{"line_number":223,"context_line":"            for instance_id in ids:"},{"line_number":224,"context_line":"                status \u003d InstanceServiceStatus.find_by("},{"line_number":225,"context_line":"                    instance_id\u003dinstance_id).get_status()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_bd71acaa","line":222,"updated":"2015-04-21 19:09:44.000000000","message":"+0\n\nSince you\u0027re consolidating code, might as well use the version that has the \u0027.\u0027 at the end of the log messages (I don\u0027t care too much, but it\u0027s good to be consistent).","commit_id":"f9247ffd0b6d5f56865ee05ed363ac8178a18a64"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"adaf71b7d49c09d8631b0d9ef1f9eb26c1643823","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                        LOG.debug(\"Instance %s in %s, continue polling.\" % ("},{"line_number":236,"context_line":"                            instance_id, status))"},{"line_number":237,"context_line":"                        return False"},{"line_number":238,"context_line":"            LOG.debug(\"Instances are ready, exiting polling for: %s\" % ids)"},{"line_number":239,"context_line":"            return True"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        def _instance_ids_with_failures(ids):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_dd7c6074","line":238,"updated":"2015-04-21 19:09:44.000000000","message":"+0\n\nditto","commit_id":"f9247ffd0b6d5f56865ee05ed363ac8178a18a64"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"adaf71b7d49c09d8631b0d9ef1f9eb26c1643823","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        def _instance_ids_with_failures(ids):"},{"line_number":242,"context_line":"            LOG.debug(\"Checking for service status failures for \""},{"line_number":243,"context_line":"                      \"instance ids: %s\" % ids)"},{"line_number":244,"context_line":"            failed_instance_ids \u003d []"},{"line_number":245,"context_line":"            for instance_id in ids:"},{"line_number":246,"context_line":"                status \u003d InstanceServiceStatus.find_by("}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_9d970890","line":243,"updated":"2015-04-21 19:09:44.000000000","message":"+0\n\nditto","commit_id":"f9247ffd0b6d5f56865ee05ed363ac8178a18a64"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"adaf71b7d49c09d8631b0d9ef1f9eb26c1643823","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                        failed_instance_ids.append(instance_id)"},{"line_number":251,"context_line":"            return failed_instance_ids"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        LOG.debug(\"Polling until service status is ready for \""},{"line_number":254,"context_line":"                  \"instance ids: %s\" % instance_ids)"},{"line_number":255,"context_line":"        try:"},{"line_number":256,"context_line":"            utils.poll_until(lambda: instance_ids,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_7d92f4a0","line":253,"updated":"2015-04-21 19:09:44.000000000","message":"+0\n\nditto","commit_id":"f9247ffd0b6d5f56865ee05ed363ac8178a18a64"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"adaf71b7d49c09d8631b0d9ef1f9eb26c1643823","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        failed_ids \u003d _instance_ids_with_failures(instance_ids)"},{"line_number":267,"context_line":"        if failed_ids:"},{"line_number":268,"context_line":"            LOG.error(_(\"Some instances failed to become ready: %s\") %"},{"line_number":269,"context_line":"                      failed_ids)"},{"line_number":270,"context_line":"            self.update_statuses_on_failure(cluster_id, shard_id)"},{"line_number":271,"context_line":"            return False"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_fdecc42a","line":269,"updated":"2015-04-21 19:09:44.000000000","message":"+0\n\nditto","commit_id":"f9247ffd0b6d5f56865ee05ed363ac8178a18a64"}]}