)]}'
{"trove/templates/mysql/config.template":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"3338bf32b3c86ee4280f1e7e23bd118171bdc2cf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ (50 * flavor[\u0027ram\u0027])//512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ (1 * flavor[\u0027ram\u0027])//512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"},{"line_number":19,"context_line":"thread_cache_size \u003d {{ (4 * flavor[\u0027ram\u0027])//512 }}"},{"line_number":20,"context_line":"myisam-recover \u003d BACKUP"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa041b7_2048bb2c","line":17,"range":{"start_line":17,"start_character":24,"end_line":17,"end_character":48},"updated":"2015-04-05 02:17:04.000000000","message":"How exactly is \"(1 * flavor[\u0027ram\u0027])//512\" different from \"1 * flavor[\u0027ram\u0027]//512\"?\nI don\u0027t think it is the brackets. Smells like a truncation in (float-\u003eint) cast to me... We should make sure all operands are interpreted as floating-point numbers if the result is supposed to be a float.","commit_id":"15114bfc4320ccab2a38f407c12da2a2687d291e"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"ff2cd01eaf55cfa0d0335a2c5fabfcb25d9f5eb8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ (50 * flavor[\u0027ram\u0027])//512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ (1 * flavor[\u0027ram\u0027])//512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"},{"line_number":19,"context_line":"thread_cache_size \u003d {{ (4 * flavor[\u0027ram\u0027])//512 }}"},{"line_number":20,"context_line":"myisam-recover \u003d BACKUP"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa041b7_a0996b21","line":17,"in_reply_to":"baa041b7_2048bb2c","updated":"2015-04-05 03:55:42.000000000","message":"The difference is mathematical rule of BODMAS.\n\nI have tested this patchset with a flavor having 256 and 384 mb as value of ram in flavor.\n\nYou too may test it.\n\nThis is the simplest fix.","commit_id":"15114bfc4320ccab2a38f407c12da2a2687d291e"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"f0e4be0800bc3da160123e69ba3b7151d00d0435","unresolved":false,"context_lines":[{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ (50 * flavor[\u0027ram\u0027])//512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ (1 * flavor[\u0027ram\u0027])//512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"},{"line_number":19,"context_line":"thread_cache_size \u003d {{ (4 * flavor[\u0027ram\u0027])//512 }}"},{"line_number":20,"context_line":"myisam-recover \u003d BACKUP"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa041b7_cf1c9bc3","line":17,"in_reply_to":"baa041b7_a0996b21","updated":"2015-04-05 18:37:42.000000000","message":"I don\u0027t think the problem here is the order of operations. After all, if everything worked as expected there would be no need for brackets. Seems to me like flavor is interpreted as an int and the division of two ints truncates the decimal places. Adding the brackets just masks it because the result of the multiplication is treated as a float. Just my theory. if it is the case the computed values should be wrong any time flavor is not an integral multiple of 512.","commit_id":"15114bfc4320ccab2a38f407c12da2a2687d291e"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"4cc090b53e475c78b9be968d246fa74ffcd343d1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ (50 * flavor[\u0027ram\u0027])//512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ (1 * flavor[\u0027ram\u0027])//512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"},{"line_number":19,"context_line":"thread_cache_size \u003d {{ (4 * flavor[\u0027ram\u0027])//512 }}"},{"line_number":20,"context_line":"myisam-recover \u003d BACKUP"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa041b7_c0e1089c","line":17,"in_reply_to":"baa041b7_cf1c9bc3","updated":"2015-04-06 05:56:26.000000000","message":"it was my bad ... i never saw this one that it was 1 * ...\n\nI tried my luck with max_connection and it was working and i updated the rest of things ... missing the point that here it was multiplied by 1.\n\ngot your point :)","commit_id":"15114bfc4320ccab2a38f407c12da2a2687d291e"}],"trove/templates/percona/config.template":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"57ca12a4a243b96894453df8e9e2424763fab5a8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ 50 * flavor[\u0027ram\u0027]/512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ 1 * flavor[\u0027ram\u0027]/512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"},{"line_number":19,"context_line":"thread_cache_size \u003d {{ (4 * flavor[\u0027ram\u0027]/512)|int }}"},{"line_number":20,"context_line":"myisam-recover \u003d BACKUP"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9aa53dc9_ee67cf23","line":17,"updated":"2015-04-06 14:38:37.000000000","message":"This is an integer, too.  Why does it not have an int filter (also all other int values here).","commit_id":"b5563ca7d7c81e8d9812b842eb2934c53a8521ef"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"56fd6e3b6cac422d595a9ffdf67d8ff7a7f5ad71","unresolved":false,"context_lines":[{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ 50 * flavor[\u0027ram\u0027]/512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ 1 * flavor[\u0027ram\u0027]/512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"},{"line_number":19,"context_line":"thread_cache_size \u003d {{ (4 * flavor[\u0027ram\u0027]/512)|int }}"},{"line_number":20,"context_line":"myisam-recover \u003d BACKUP"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9aa53dc9_2e037711","line":17,"in_reply_to":"9aa53dc9_ee67cf23","updated":"2015-04-06 14:39:53.000000000","message":"oh it was my bad, the last time i updated the mysql confs i missed updating the perconas :)","commit_id":"b5563ca7d7c81e8d9812b842eb2934c53a8521ef"}]}