)]}'
{"trove/taskmanager/models.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6e2fea951d464a7104825a8196fea5aa336fd306","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"                  \u0027old_volume_size\u0027: self.old_size,"},{"line_number":1562,"context_line":"                  \u0027new_size\u0027: self.new_size})"},{"line_number":1563,"context_line":""},{"line_number":1564,"context_line":"        try:"},{"line_number":1565,"context_line":"            self._resize_active_volume()"},{"line_number":1566,"context_line":"            self.instance.reset_task_status()"},{"line_number":1567,"context_line":"            # send usage event for size reported by cinder"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_77904096","line":1564,"updated":"2015-07-20 05:56:58.000000000","message":"So, you would attempt this block no matter the status? That seems like an approach fraught with problems.","commit_id":"b7258c643eaca645f9e528ad61ae5668f5fa1e5d"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"cbc8a5b7ee0719b8a13275506302cb48736e54d1","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"                                           modify_at\u003dmodified_time,"},{"line_number":1576,"context_line":"                                           volume_size\u003dvolume.size)"},{"line_number":1577,"context_line":"        except GuestError:"},{"line_number":1578,"context_line":"            LOG.error(_(\"Failed to initiate datastore restart on instance \""},{"line_number":1579,"context_line":"                        \"%s.\") % self.id)"},{"line_number":1580,"context_line":"        finally:"},{"line_number":1581,"context_line":"            self.instance.reset_task_status()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_03735716","line":1578,"updated":"2015-04-09 15:37:56.000000000","message":"Do we know that the only GuestError that can ever get here is from the restart action? GuestError seems to be broader than that.","commit_id":"b7258c643eaca645f9e528ad61ae5668f5fa1e5d"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"2ca5a33e9d6dcd998e5af641542b02f691434471","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"                                           modify_at\u003dmodified_time,"},{"line_number":1576,"context_line":"                                           volume_size\u003dvolume.size)"},{"line_number":1577,"context_line":"        except GuestError:"},{"line_number":1578,"context_line":"            LOG.error(_(\"Failed to initiate datastore restart on instance \""},{"line_number":1579,"context_line":"                        \"%s.\") % self.id)"},{"line_number":1580,"context_line":"        finally:"},{"line_number":1581,"context_line":"            self.instance.reset_task_status()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_f68f7621","line":1578,"in_reply_to":"7aaa499b_70036e43","updated":"2015-04-13 16:14:42.000000000","message":"i did not get this passed back to taskmanager?\n\nThis is taskmanager.models code and we are already logging the error.","commit_id":"b7258c643eaca645f9e528ad61ae5668f5fa1e5d"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"7bba1892eb7a004abdc54398d7c9c6442b45a87b","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"                                           modify_at\u003dmodified_time,"},{"line_number":1576,"context_line":"                                           volume_size\u003dvolume.size)"},{"line_number":1577,"context_line":"        except GuestError:"},{"line_number":1578,"context_line":"            LOG.error(_(\"Failed to initiate datastore restart on instance \""},{"line_number":1579,"context_line":"                        \"%s.\") % self.id)"},{"line_number":1580,"context_line":"        finally:"},{"line_number":1581,"context_line":"            self.instance.reset_task_status()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_de9782ea","line":1578,"in_reply_to":"9aa53dc9_03735716","updated":"2015-04-09 16:00:41.000000000","message":"So point is if guest gets to any errors and sends an exception then resize should free the instance from resize state and let the guest instance take its own state being sent from guestagent","commit_id":"b7258c643eaca645f9e528ad61ae5668f5fa1e5d"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"9c98eb3f8ff2b6bbb8af12cdb13a60eb3e2e45da","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"                                           modify_at\u003dmodified_time,"},{"line_number":1576,"context_line":"                                           volume_size\u003dvolume.size)"},{"line_number":1577,"context_line":"        except GuestError:"},{"line_number":1578,"context_line":"            LOG.error(_(\"Failed to initiate datastore restart on instance \""},{"line_number":1579,"context_line":"                        \"%s.\") % self.id)"},{"line_number":1580,"context_line":"        finally:"},{"line_number":1581,"context_line":"            self.instance.reset_task_status()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_70036e43","line":1578,"in_reply_to":"9aa53dc9_de9782ea","updated":"2015-04-13 15:45:39.000000000","message":"Isn\u0027t GuestError an API error?  As such, shouldn\u0027t it be passed back to the taskmanager to deal with?  Why would you eat that error?","commit_id":"b7258c643eaca645f9e528ad61ae5668f5fa1e5d"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"15e09502b60e10fd19b2cef71a5620f1f1264793","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"            LOG.error(_(\"Failed to initiate datastore restart on instance \""},{"line_number":1579,"context_line":"                        \"%s.\") % self.id)"},{"line_number":1580,"context_line":"        finally:"},{"line_number":1581,"context_line":"            self.instance.reset_task_status()"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"class ResizeActionBase(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_4b15243e","line":1581,"updated":"2015-04-08 15:43:58.000000000","message":"By putting the reset in a finally block, aren\u0027t you causing the instance to go ACTIVE even if the resize fails?  Is this behaviour different than the original code?","commit_id":"b7258c643eaca645f9e528ad61ae5668f5fa1e5d"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"2ca5a33e9d6dcd998e5af641542b02f691434471","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"            LOG.error(_(\"Failed to initiate datastore restart on instance \""},{"line_number":1579,"context_line":"                        \"%s.\") % self.id)"},{"line_number":1580,"context_line":"        finally:"},{"line_number":1581,"context_line":"            self.instance.reset_task_status()"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"class ResizeActionBase(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_56e50a07","line":1581,"in_reply_to":"7aaa499b_507512c9","updated":"2015-04-13 16:14:42.000000000","message":"it would go to active as soon as reet_task executes, but on the next fetch of actual_db_status, the actual db status should be set to the guest.","commit_id":"b7258c643eaca645f9e528ad61ae5668f5fa1e5d"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"9c98eb3f8ff2b6bbb8af12cdb13a60eb3e2e45da","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"            LOG.error(_(\"Failed to initiate datastore restart on instance \""},{"line_number":1579,"context_line":"                        \"%s.\") % self.id)"},{"line_number":1580,"context_line":"        finally:"},{"line_number":1581,"context_line":"            self.instance.reset_task_status()"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"class ResizeActionBase(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_507512c9","line":1581,"in_reply_to":"9aa53dc9_0bcb9773","updated":"2015-04-13 15:45:39.000000000","message":"But resize is asynchronous, and wouldn\u0027t resetting the task status cause the instance status to immediately go ACTIVE, even though resize is still running?","commit_id":"b7258c643eaca645f9e528ad61ae5668f5fa1e5d"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"bf4582a7f692439b4149c1582eb6c5cb359af7c9","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"            LOG.error(_(\"Failed to initiate datastore restart on instance \""},{"line_number":1579,"context_line":"                        \"%s.\") % self.id)"},{"line_number":1580,"context_line":"        finally:"},{"line_number":1581,"context_line":"            self.instance.reset_task_status()"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"class ResizeActionBase(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_0bcb9773","line":1581,"in_reply_to":"9aa53dc9_4b15243e","updated":"2015-04-08 17:24:16.000000000","message":"1. if you see line number 1578 on left side its same, also its the same behavior from restart method in the same class.\n\n2. once reset_task_status is done, it would start fetching the current status from guestagent","commit_id":"b7258c643eaca645f9e528ad61ae5668f5fa1e5d"}]}
