)]}'
{"trove/guestagent/datastore/experimental/couchdb/manager.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"b398cc2b4fca5acdbf262245b06142efa239017d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"         implemented to enable rollback of flavor-resize on guestagent side."},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":"        LOG.debug(\"Resetting CouchDB configuration.\")"},{"line_number":109,"context_line":"        return None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def change_passwords(self, context, users):"},{"line_number":112,"context_line":"        LOG.debug(\"Changing password.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_20fbf148","line":109,"updated":"2015-04-09 15:19:28.000000000","message":"Just use \u0027pass\u0027.","commit_id":"f4f13f5ea4e37016f2b11d502b4fb3693ec13914"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0607c9dd1f5f46112e194b708a519f23750b558d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"         implemented to enable rollback of flavor-resize on guestagent side."},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":"        LOG.debug(\"Resetting CouchDB configuration.\")"},{"line_number":109,"context_line":"        return None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def change_passwords(self, context, users):"},{"line_number":112,"context_line":"        LOG.debug(\"Changing password.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_be515e38","line":109,"in_reply_to":"9aa53dc9_20fbf148","updated":"2015-04-09 16:03:33.000000000","message":"Any special reasons for using pass,\nWhat is the problem with return None.\n\nAt least it gives a value to complete test.","commit_id":"f4f13f5ea4e37016f2b11d502b4fb3693ec13914"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"11854c344720b1123b5baa67f1ec0e96b09918fd","unresolved":false,"context_lines":[{"line_number":106,"context_line":"         implemented to enable rollback of flavor-resize on guestagent side."},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":"        LOG.debug(\"Resetting CouchDB configuration.\")"},{"line_number":109,"context_line":"        return None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def change_passwords(self, context, users):"},{"line_number":112,"context_line":"        LOG.debug(\"Changing password.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_a92f68a0","line":109,"in_reply_to":"9aa53dc9_be515e38","updated":"2015-04-13 01:54:37.000000000","message":"The method is not supposed to return anything. See the other guest agents. Also what do you want to test? Just test the call succeeds - is implemented, but don\u0027t test a return value that never gets used anyway...","commit_id":"f4f13f5ea4e37016f2b11d502b4fb3693ec13914"}],"trove/guestagent/datastore/experimental/db2/manager.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"b398cc2b4fca5acdbf262245b06142efa239017d","unresolved":false,"context_lines":[{"line_number":175,"context_line":"         implemented to enable rollback of flavor-resize on guestagent side."},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        LOG.debug(\"Resetting DB2 configuration.\")"},{"line_number":178,"context_line":"        return None"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def change_passwords(self, context, users):"},{"line_number":181,"context_line":"        LOG.debug(\"Changing password.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_80a2bd49","line":178,"updated":"2015-04-09 15:19:28.000000000","message":"Again, this method is not supposed to return, use \u0027pass\u0027 instead.","commit_id":"f4f13f5ea4e37016f2b11d502b4fb3693ec13914"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0607c9dd1f5f46112e194b708a519f23750b558d","unresolved":false,"context_lines":[{"line_number":175,"context_line":"         implemented to enable rollback of flavor-resize on guestagent side."},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        LOG.debug(\"Resetting DB2 configuration.\")"},{"line_number":178,"context_line":"        return None"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def change_passwords(self, context, users):"},{"line_number":181,"context_line":"        LOG.debug(\"Changing password.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_1e05ea12","line":178,"in_reply_to":"9aa53dc9_80a2bd49","updated":"2015-04-09 16:03:33.000000000","message":"Any special reasons for using pass,\nWhat is the problem with return None.\n\nAt least it gives a value to complete test.","commit_id":"f4f13f5ea4e37016f2b11d502b4fb3693ec13914"}],"trove/guestagent/datastore/experimental/vertica/manager.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"b398cc2b4fca5acdbf262245b06142efa239017d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"         implemented to enable rollback of flavor-resize on guestagent side."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        LOG.debug(\"Resetting Vertica configuration.\")"},{"line_number":124,"context_line":"        return None"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def change_passwords(self, context, users):"},{"line_number":127,"context_line":"        LOG.debug(\"Changing password.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_80b99d7b","line":124,"updated":"2015-04-09 15:19:28.000000000","message":"pass","commit_id":"f4f13f5ea4e37016f2b11d502b4fb3693ec13914"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0607c9dd1f5f46112e194b708a519f23750b558d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"         implemented to enable rollback of flavor-resize on guestagent side."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        LOG.debug(\"Resetting Vertica configuration.\")"},{"line_number":124,"context_line":"        return None"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def change_passwords(self, context, users):"},{"line_number":127,"context_line":"        LOG.debug(\"Changing password.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_d901dc06","line":124,"in_reply_to":"9aa53dc9_80b99d7b","updated":"2015-04-09 16:03:33.000000000","message":"Any special reasons for using pass,\nWhat is the problem with return None.\n\nAt least it gives a value to complete test.","commit_id":"f4f13f5ea4e37016f2b11d502b4fb3693ec13914"}],"trove/tests/unittests/guestagent/test_couchdb_manager.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"6d82f59957876a6ed2117b0a24e35fce097974d1","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            self.manager.reset_configuration(self.context, configuration)"},{"line_number":151,"context_line":"        except Exception:"},{"line_number":152,"context_line":"            raised \u003d True"},{"line_number":153,"context_line":"        self.assertFalse(raised)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_rpc_ping(self):"},{"line_number":156,"context_line":"        output \u003d self.manager.rpc_ping(self.context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_73bb7bc5","line":153,"updated":"2015-04-13 14:55:46.000000000","message":"Do you think this is necessary? Wouldn\u0027t it be enough to just call the method? If it raises the test would fail with that exact exception.","commit_id":"67f2c99906a72e41f16766805bc8209f59133fbc"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"11f0bde099cf64fc1d894db4ac8cce29a85febcc","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            self.manager.reset_configuration(self.context, configuration)"},{"line_number":151,"context_line":"        except Exception:"},{"line_number":152,"context_line":"            raised \u003d True"},{"line_number":153,"context_line":"        self.assertFalse(raised)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_rpc_ping(self):"},{"line_number":156,"context_line":"        output \u003d self.manager.rpc_ping(self.context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_a59f6e02","line":153,"in_reply_to":"7aaa499b_30828695","updated":"2015-04-13 18:06:15.000000000","message":"This is another way that I have seen people write these types of unit tests:\n\ntry:\n    self.manager.reset_configuration(self.context, configuration)\nexcept Exception:\n    self.fail(\"reset_configuration raised Exception unexpectedly.\")","commit_id":"67f2c99906a72e41f16766805bc8209f59133fbc"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"4750ae90c245719d09fed28d6e15e84d1976e7de","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            self.manager.reset_configuration(self.context, configuration)"},{"line_number":151,"context_line":"        except Exception:"},{"line_number":152,"context_line":"            raised \u003d True"},{"line_number":153,"context_line":"        self.assertFalse(raised)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_rpc_ping(self):"},{"line_number":156,"context_line":"        output \u003d self.manager.rpc_ping(self.context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_30828695","line":153,"in_reply_to":"7aaa499b_73bb7bc5","updated":"2015-04-13 15:45:42.000000000","message":"Are you recommending a test method without an assert statement.","commit_id":"67f2c99906a72e41f16766805bc8209f59133fbc"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"62b2e721521d1be7d482e62c3330efce21b0e499","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            self.manager.reset_configuration(self.context, configuration)"},{"line_number":151,"context_line":"        except Exception:"},{"line_number":152,"context_line":"            raised \u003d True"},{"line_number":153,"context_line":"        self.assertFalse(raised)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_rpc_ping(self):"},{"line_number":156,"context_line":"        output \u003d self.manager.rpc_ping(self.context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_25ab5e1f","line":153,"in_reply_to":"7aaa499b_a59f6e02","updated":"2015-04-13 18:16:23.000000000","message":"Done","commit_id":"67f2c99906a72e41f16766805bc8209f59133fbc"}]}