)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"10211c02ef2dd868a46271fd398f8415868b8ab9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"of assertEqual args, whereever I made changes"},{"line_number":21,"context_line":"in existing test or added new tests."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Added Trove to bug 1277104: \"wrong order of assertEquals args\"."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patchset also resolves some bugs."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_47e8a7e2","line":23,"updated":"2015-04-30 18:22:36.000000000","message":"Is this relevant to this change set?","commit_id":"f18c7329e35ab16cc77f2076a9f0ea51eac6a320"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"cfc403301a5dbad6968fbdbddc9806f9130ddcfa","unresolved":false,"context_lines":[{"line_number":20,"context_line":"of assertEqual args, whereever I made changes"},{"line_number":21,"context_line":"in existing test or added new tests."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Added Trove to bug 1277104: \"wrong order of assertEquals args\"."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patchset also resolves some bugs."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_87b0ffde","line":23,"in_reply_to":"3acd31a7_47e8a7e2","updated":"2015-04-30 18:26:20.000000000","message":"I have been hearing this review in my previous patchsets regarding the wrong order of assertEqual,\n\nso I kept addressed with this message.","commit_id":"f18c7329e35ab16cc77f2076a9f0ea51eac6a320"}],"trove/tests/unittests/guestagent/test_api.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d23652f5f4fa8eb49b70cdb84fa1029fee1dd804","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @mock.patch.object(messaging, \u0027Target\u0027)"},{"line_number":392,"context_line":"    @mock.patch.object(rpc, \u0027get_server\u0027)"},{"line_number":393,"context_line":"    def test_prepare(self, mock_target, mock_server):"},{"line_number":394,"context_line":"        self.api.prepare(\u00272048\u0027, \u0027package1\u0027, \u0027db1\u0027, \u0027user1\u0027, \u0027/dev/vdt\u0027,"},{"line_number":395,"context_line":"                         \u0027/mnt/opt\u0027, None, \u0027cont\u0027, \u00271-2-3-4\u0027,"},{"line_number":396,"context_line":"                         \u0027override\u0027, {\u0027id\u0027: \u00272-3-4-5\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_551d2c0e","line":393,"updated":"2015-04-28 16:26:22.000000000","message":"The order of decorators is bottom up. You are not using the mocks, but the parameters are: server, target","commit_id":"6a122f356ba72738557710cddbc6ff3e960e64cf"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d23652f5f4fa8eb49b70cdb84fa1029fee1dd804","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    @mock.patch.object(messaging, \u0027Target\u0027)"},{"line_number":408,"context_line":"    @mock.patch.object(rpc, \u0027get_server\u0027)"},{"line_number":409,"context_line":"    def test_prepare_with_backup(self, mock_target, mock_server):"},{"line_number":410,"context_line":"        backup \u003d {\u0027id\u0027: \u0027backup_id_123\u0027}"},{"line_number":411,"context_line":"        self.api.prepare(\u00272048\u0027, \u0027package1\u0027, \u0027db1\u0027, \u0027user1\u0027, \u0027/dev/vdt\u0027,"},{"line_number":412,"context_line":"                         \u0027/mnt/opt\u0027, backup, \u0027cont\u0027, \u00271-2-3-4\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_95450419","line":409,"updated":"2015-04-28 16:26:22.000000000","message":"ditto","commit_id":"6a122f356ba72738557710cddbc6ff3e960e64cf"}],"trove/tests/unittests/guestagent/test_dbaas.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d23652f5f4fa8eb49b70cdb84fa1029fee1dd804","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        with patch.object(self.mySqlAdmin, \u0027_get_user\u0027, return_value\u003duser):"},{"line_number":684,"context_line":"            self.mySqlAdmin.grant_access(\u0027test_usr\u0027, \u0027%\u0027, databases)"},{"line_number":685,"context_line":"        #since mysql is not a database to be provided access to,"},{"line_number":686,"context_line":"        #testing tat executed was not called in grant access."},{"line_number":687,"context_line":"        dbaas.LocalSqlClient.execute.assert_not_called()"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def test_is_root_enabled(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_5523ec05","line":686,"updated":"2015-04-28 16:26:22.000000000","message":"*that","commit_id":"6a122f356ba72738557710cddbc6ff3e960e64cf"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d23652f5f4fa8eb49b70cdb84fa1029fee1dd804","unresolved":false,"context_lines":[{"line_number":741,"context_line":"                         \u0027cmd_enable\u0027: Mock(),"},{"line_number":742,"context_line":"                         \u0027cmd_disable\u0027: Mock(),"},{"line_number":743,"context_line":"                         \u0027bin\u0027: Mock()}"},{"line_number":744,"context_line":"        dbaas.operating_system.service_discovery \u003d Mock(return_value\u003d"},{"line_number":745,"context_line":"                                                        mysql_service)"},{"line_number":746,"context_line":"        time.sleep \u003d Mock()"},{"line_number":747,"context_line":"        os.unlink \u003d Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_f5ed588f","line":744,"updated":"2015-04-28 16:26:22.000000000","message":"This does not look very safe. I think you are still mocking the global module.","commit_id":"6a122f356ba72738557710cddbc6ff3e960e64cf"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d23652f5f4fa8eb49b70cdb84fa1029fee1dd804","unresolved":false,"context_lines":[{"line_number":952,"context_line":"    @patch.object(operating_system, \u0027remove\u0027)"},{"line_number":953,"context_line":"    @patch.object(dbaas, \u0027get_auth_password\u0027, return_value\u003d\u0027some_password\u0027)"},{"line_number":954,"context_line":"    @patch.object(dbaas.MySqlApp, \u0027_write_config_overrides\u0027)"},{"line_number":955,"context_line":"    def test_reset_configuration(self, mock_write_overrides,"},{"line_number":956,"context_line":"                                 mock_get_auth_password, mock_move,"},{"line_number":957,"context_line":"                                 mock_remove):"},{"line_number":958,"context_line":"        configuration \u003d {\u0027config_contents\u0027: \u0027some junk\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_f8fe6d04","line":955,"updated":"2015-04-28 16:26:22.000000000","message":"I think you should swap the last two parameters.","commit_id":"6a122f356ba72738557710cddbc6ff3e960e64cf"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d23652f5f4fa8eb49b70cdb84fa1029fee1dd804","unresolved":false,"context_lines":[{"line_number":965,"context_line":"    @patch.object(operating_system, \u0027move\u0027)"},{"line_number":966,"context_line":"    @patch.object(operating_system, \u0027remove\u0027)"},{"line_number":967,"context_line":"    @patch.object(dbaas.MySqlApp, \u0027_write_config_overrides\u0027)"},{"line_number":968,"context_line":"    def test__write_mycnf(self, mock_write_overrides, mock_move, mock_remove):"},{"line_number":969,"context_line":"        self.mySqlApp._write_mycnf(\u0027some_password\u0027, \u0027some junk\u0027, \u0027something\u0027)"},{"line_number":970,"context_line":"        self.assertEqual(2, mock_move.call_count)"},{"line_number":971,"context_line":"        self.assertEqual(2, mock_remove.call_count)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_381d0567","line":968,"updated":"2015-04-28 16:26:22.000000000","message":"ditto","commit_id":"6a122f356ba72738557710cddbc6ff3e960e64cf"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d23652f5f4fa8eb49b70cdb84fa1029fee1dd804","unresolved":false,"context_lines":[{"line_number":1048,"context_line":"    @patch.object(operating_system, \u0027remove\u0027)"},{"line_number":1049,"context_line":"    def test_remove_override(self, mock_remove, mock_exists):"},{"line_number":1050,"context_line":"        self.mySqlApp.remove_overrides()"},{"line_number":1051,"context_line":"        self.assertEqual(1, mock_remove.call_count)"},{"line_number":1052,"context_line":"        self.assertEqual(1, mock_exists.call_count)"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"    @patch.object(operating_system, \u0027move\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_d83bb19b","line":1051,"updated":"2015-04-28 16:26:22.000000000","message":"BTW, you can also do something like \"mock_remove.assert_called_once_with(ANY, as_root\u003dTrue)\" to get the coverage of the \"as_root\" argument...","commit_id":"6a122f356ba72738557710cddbc6ff3e960e64cf"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d23652f5f4fa8eb49b70cdb84fa1029fee1dd804","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"    @patch.object(dbaas, \u0027get_engine\u0027,"},{"line_number":1136,"context_line":"                  return_value\u003dMagicMock(name\u003d\u0027get_engine\u0027))"},{"line_number":1137,"context_line":"    @patch.object(dbaas.MySqlApp, \u0027_wait_for_slave_status\u0027)"},{"line_number":1138,"context_line":"    def test_start_slave(self, *args):"},{"line_number":1139,"context_line":"        with patch.object(dbaas, \u0027LocalSqlClient\u0027,"},{"line_number":1140,"context_line":"                          return_value\u003dself.mock_client):"},{"line_number":1141,"context_line":"            self.mySqlApp.start_slave()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_b8b3550a","line":1138,"updated":"2015-04-28 16:26:22.000000000","message":"BTW, you can also use \u0027_\u0027 as placeholders for \u0027ignored\u0027 parameters.","commit_id":"6a122f356ba72738557710cddbc6ff3e960e64cf"}],"trove/tests/unittests/guestagent/test_operating_system.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d23652f5f4fa8eb49b70cdb84fa1029fee1dd804","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \u0027path\u0027, FileMode.ADD_READ_ALL,"},{"line_number":89,"context_line":"            as_root\u003dTrue)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self._assert_execute_call("},{"line_number":92,"context_line":"            [[\u0027chmod\u0027, \u0027-R\u0027, \u0027+060\u0027, \u0027path\u0027]],"},{"line_number":93,"context_line":"            [{\u0027run_as_root\u0027: True, \u0027root_helper\u0027: \u0027sudo\u0027}],"},{"line_number":94,"context_line":"            operating_system.chmod, None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_b8591591","line":91,"updated":"2015-04-28 16:26:22.000000000","message":"Good catch, we may also want to add a case for \"-\" (remove) while being on it...","commit_id":"6a122f356ba72738557710cddbc6ff3e960e64cf"}]}