)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8909ac1f73bc7ffdbfed11b2a27f6a0bc59571a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"now be supplied with a specific neutron network information and"},{"line_number":14,"context_line":"availability zone."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Bug: 1447350"},{"line_number":17,"context_line":"Change-Id: I5a1e9300dd0a16395769acda672943899f9ad0ad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_c62b6093","line":16,"updated":"2015-05-04 14:40:08.000000000","message":"(+0) Should be:\n\n  Closes-Bug: #1447350\n\nSee: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"2bfb4d1255bd7cecc886bebbd5841c10c88899ea","unresolved":false,"context_lines":[{"line_number":13,"context_line":"now be supplied with a specific neutron network information and"},{"line_number":14,"context_line":"availability zone."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Bug: 1447350"},{"line_number":17,"context_line":"Change-Id: I5a1e9300dd0a16395769acda672943899f9ad0ad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aca2d91_b1310c0e","line":16,"in_reply_to":"3acd31a7_c62b6093","updated":"2015-05-06 23:46:10.000000000","message":"Done","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"bce99f7200c31f859739c3397d491d2303593cf7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"availability zone."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also fixed issue where same flavor was being used for all the cluster"},{"line_number":17,"context_line":"instances."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1447350"},{"line_number":20,"context_line":"Change-Id: I5a1e9300dd0a16395769acda672943899f9ad0ad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1aca2d91_cf7e17e4","line":17,"updated":"2015-05-07 00:18:52.000000000","message":"sorry to nitpick, but this was just removed ;)","commit_id":"0f6716ac100decc9e396d3665d2094e11ce8da9d"}],"trove/common/apischema.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8909ac1f73bc7ffdbfed11b2a27f6a0bc59571a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                                \"flavorRef\": flavorref,"},{"line_number":235,"context_line":"                                \"volume\": volume,"},{"line_number":236,"context_line":"                                \"nics\": nics,"},{"line_number":237,"context_line":"                                \"availability_zone\": non_empty_string"},{"line_number":238,"context_line":"                            }"},{"line_number":239,"context_line":"                        }"},{"line_number":240,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_8103120d","line":237,"updated":"2015-05-04 14:40:08.000000000","message":"(+0)  Question: Should we have a bp, since there\u0027s an API change?","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"2bfb4d1255bd7cecc886bebbd5841c10c88899ea","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                                \"flavorRef\": flavorref,"},{"line_number":235,"context_line":"                                \"volume\": volume,"},{"line_number":236,"context_line":"                                \"nics\": nics,"},{"line_number":237,"context_line":"                                \"availability_zone\": non_empty_string"},{"line_number":238,"context_line":"                            }"},{"line_number":239,"context_line":"                        }"},{"line_number":240,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_5114f8f3","line":237,"in_reply_to":"3acd31a7_8103120d","updated":"2015-05-06 23:46:10.000000000","message":"Spoke to Nikhil about this, he suggested that BP may not be required, as these are optional parameters, and also these are already supported for single instance. This change is more of adding missing functionality for cluster creation.","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"}],"trove/common/strategies/cluster/experimental/vertica/api.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8909ac1f73bc7ffdbfed11b2a27f6a0bc59571a","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # Checking volumes"},{"line_number":79,"context_line":"        volume_sizes \u003d [instance[\u0027volume_size\u0027] for instance in instances"},{"line_number":80,"context_line":"                        if instance.get(\u0027volume_size\u0027, None)]"},{"line_number":81,"context_line":"        if vertica_conf.volume_support:"},{"line_number":82,"context_line":"            if len(volume_sizes) !\u003d num_instances:"},{"line_number":83,"context_line":"                raise exception.ClusterVolumeSizeRequired()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_46b870e5","line":80,"updated":"2015-05-04 14:40:08.000000000","message":"Removing this line seems out of scope with the posted bug","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8909ac1f73bc7ffdbfed11b2a27f6a0bc59571a","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        check_quotas(context.tenant, deltas)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        nics \u003d [instance.get(\u0027nics\u0027, None) for instance in instances]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        azs \u003d [instance.get(\u0027availability_zone\u0027, None)"},{"line_number":101,"context_line":"               for instance in instances]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_46487087","line":98,"updated":"2015-05-04 14:40:08.000000000","message":"(-1) Can the nics be different for each instance?  Not described in the bug, so I can\u0027t tell if there\u0027s an error here or not.","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"2bfb4d1255bd7cecc886bebbd5841c10c88899ea","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        check_quotas(context.tenant, deltas)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        nics \u003d [instance.get(\u0027nics\u0027, None) for instance in instances]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        azs \u003d [instance.get(\u0027availability_zone\u0027, None)"},{"line_number":101,"context_line":"               for instance in instances]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_ac609336","line":98,"in_reply_to":"3acd31a7_46487087","updated":"2015-05-06 23:46:10.000000000","message":"I updated the ticket with the details. nics and availability zones can be different for all the instances. \n\nIn general nics parameter will be same, but people suggests that in certain situation user may want to provision certain set of instances in a separate network, so to provide that flexibility this option is made available on instance level for now. \n\nMay be we should try to move some of these parameters like flavor/network on the cluster level because in most of the cases they will be same, and provide option to also specify it on the instance level to be able to customize few set of instances. if somebody needs to provision a 30 or 50 node cluster, where they don\u0027t need much customization they will be supplying redundant information for every instance. I think this change is  out of scope for this fix, but I think we will need that soon.","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8909ac1f73bc7ffdbfed11b2a27f6a0bc59571a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        nics \u003d [instance.get(\u0027nics\u0027, None) for instance in instances]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        azs \u003d [instance.get(\u0027availability_zone\u0027, None)"},{"line_number":101,"context_line":"               for instance in instances]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Updating Cluster Task"},{"line_number":104,"context_line":"        db_info \u003d models.DBCluster.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_065b9855","line":101,"updated":"2015-05-04 14:40:08.000000000","message":"ditto","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"2bfb4d1255bd7cecc886bebbd5841c10c88899ea","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        nics \u003d [instance.get(\u0027nics\u0027, None) for instance in instances]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        azs \u003d [instance.get(\u0027availability_zone\u0027, None)"},{"line_number":101,"context_line":"               for instance in instances]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Updating Cluster Task"},{"line_number":104,"context_line":"        db_info \u003d models.DBCluster.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_cc906fef","line":101,"in_reply_to":"3acd31a7_065b9855","updated":"2015-05-06 23:46:10.000000000","message":"Also updated in the ticket. allowing AZ per instances make it easy to provision a HA cluster spanning multiple AZs","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8909ac1f73bc7ffdbfed11b2a27f6a0bc59571a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        for i in range(1, num_instances + 1):"},{"line_number":114,"context_line":"            instance_name \u003d \"%s-member-%s\" % (name, str(i))"},{"line_number":115,"context_line":"            inst_models.Instance.create(context, instance_name,"},{"line_number":116,"context_line":"                                        flavor_ids[i - 1],"},{"line_number":117,"context_line":"                                        datastore_version.image_id,"},{"line_number":118,"context_line":"                                        [], [], datastore,"},{"line_number":119,"context_line":"                                        datastore_version,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_66ac8ca0","line":116,"updated":"2015-05-04 14:40:08.000000000","message":"(-1) Out of scope, based on the bug/commit msg","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"2bfb4d1255bd7cecc886bebbd5841c10c88899ea","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        for i in range(1, num_instances + 1):"},{"line_number":114,"context_line":"            instance_name \u003d \"%s-member-%s\" % (name, str(i))"},{"line_number":115,"context_line":"            inst_models.Instance.create(context, instance_name,"},{"line_number":116,"context_line":"                                        flavor_ids[i - 1],"},{"line_number":117,"context_line":"                                        datastore_version.image_id,"},{"line_number":118,"context_line":"                                        [], [], datastore,"},{"line_number":119,"context_line":"                                        datastore_version,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_6cb6fb8b","line":116,"in_reply_to":"3acd31a7_66ac8ca0","updated":"2015-05-06 23:46:10.000000000","message":"Done","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8909ac1f73bc7ffdbfed11b2a27f6a0bc59571a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                        datastore_version.image_id,"},{"line_number":118,"context_line":"                                        [], [], datastore,"},{"line_number":119,"context_line":"                                        datastore_version,"},{"line_number":120,"context_line":"                                        volume_sizes[i - 1], None,"},{"line_number":121,"context_line":"                                        nics\u003dnics[i - 1],"},{"line_number":122,"context_line":"                                        availability_zone\u003dazs[i - 1],"},{"line_number":123,"context_line":"                                        configuration_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_46af5094","line":120,"updated":"2015-05-04 14:40:08.000000000","message":"ditto","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"2bfb4d1255bd7cecc886bebbd5841c10c88899ea","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                        datastore_version.image_id,"},{"line_number":118,"context_line":"                                        [], [], datastore,"},{"line_number":119,"context_line":"                                        datastore_version,"},{"line_number":120,"context_line":"                                        volume_sizes[i - 1], None,"},{"line_number":121,"context_line":"                                        nics\u003dnics[i - 1],"},{"line_number":122,"context_line":"                                        availability_zone\u003dazs[i - 1],"},{"line_number":123,"context_line":"                                        configuration_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_4cbb3f73","line":120,"in_reply_to":"3acd31a7_46af5094","updated":"2015-05-06 23:46:10.000000000","message":"Done","commit_id":"1548a010ff363b53ead4be35290c812efa0c3305"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"3b825b55275a673f95c49c1aeea66c0f53f56d87","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        for i in range(1, num_instances + 1):"},{"line_number":115,"context_line":"            instance_name \u003d \"%s-member-%s\" % (name, str(i))"},{"line_number":116,"context_line":"            inst_models.Instance.create(context, instance_name,"},{"line_number":117,"context_line":"                                        flavor_ids[i - 1],"},{"line_number":118,"context_line":"                                        datastore_version.image_id,"},{"line_number":119,"context_line":"                                        [], [], datastore,"},{"line_number":120,"context_line":"                                        datastore_version,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_17d2f800","line":117,"range":{"start_line":117,"start_character":40,"end_line":117,"end_character":50},"updated":"2015-05-06 16:06:34.000000000","message":"I think that more readable solution would be to start indexing at zero and update the above str(i) to str(i + 1).\n\nAlternatively, you could use enumerate over instances for the looping: \"for instances in enumerate(instances)\".\nThat would give you tuples with both index and instance objects from which you could retrieve flavor, nic, azs etc...","commit_id":"a307e1b2b160f1c23b82970ce37b4af20cd1399c"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"02d430c3d765c4827a8473a6c27d9594b6f6a0a9","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        for i in range(1, num_instances + 1):"},{"line_number":115,"context_line":"            instance_name \u003d \"%s-member-%s\" % (name, str(i))"},{"line_number":116,"context_line":"            inst_models.Instance.create(context, instance_name,"},{"line_number":117,"context_line":"                                        flavor_ids[i - 1],"},{"line_number":118,"context_line":"                                        datastore_version.image_id,"},{"line_number":119,"context_line":"                                        [], [], datastore,"},{"line_number":120,"context_line":"                                        datastore_version,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_1a27bd13","line":117,"in_reply_to":"1aca2d91_17d2f800","updated":"2015-05-06 16:21:23.000000000","message":"Does it makes any difference, because we are already filtering flavors to be all equal, check at line number 67-69.\n\nHowever, if you do not want flavors to be all equal, then its a different story, which bug/commit message does not reveals","commit_id":"a307e1b2b160f1c23b82970ce37b4af20cd1399c"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"1e15736869148521b99837af310cbbff3487d31a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        for i in range(1, num_instances + 1):"},{"line_number":115,"context_line":"            instance_name \u003d \"%s-member-%s\" % (name, str(i))"},{"line_number":116,"context_line":"            inst_models.Instance.create(context, instance_name,"},{"line_number":117,"context_line":"                                        flavor_ids[i - 1],"},{"line_number":118,"context_line":"                                        datastore_version.image_id,"},{"line_number":119,"context_line":"                                        [], [], datastore,"},{"line_number":120,"context_line":"                                        datastore_version,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_3ab5d9cc","line":117,"range":{"start_line":117,"start_character":40,"end_line":117,"end_character":50},"in_reply_to":"1aca2d91_17d2f800","updated":"2015-05-06 16:18:07.000000000","message":"Why are you iterating over flavours if they can only be the same? Why not to use \u0027flavor_id\u0027?","commit_id":"a307e1b2b160f1c23b82970ce37b4af20cd1399c"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"d8236e4aaa84910d73b36e2aa6c763bcd1b03257","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        for i in range(1, num_instances + 1):"},{"line_number":115,"context_line":"            instance_name \u003d \"%s-member-%s\" % (name, str(i))"},{"line_number":116,"context_line":"            inst_models.Instance.create(context, instance_name,"},{"line_number":117,"context_line":"                                        flavor_ids[i - 1],"},{"line_number":118,"context_line":"                                        datastore_version.image_id,"},{"line_number":119,"context_line":"                                        [], [], datastore,"},{"line_number":120,"context_line":"                                        datastore_version,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_31217c4e","line":117,"in_reply_to":"1aca2d91_1a27bd13","updated":"2015-05-06 23:46:56.000000000","message":"OK I will revert this change related to flavor. I think we don\u0027t want to restrict flavor and volume size to be same for all the instances in cluster, particularly for vertica. But I think will submit a separate patch for that.","commit_id":"a307e1b2b160f1c23b82970ce37b4af20cd1399c"}],"trove/tests/unittests/cluster/test_cluster_vertica_controller.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"cfba8a9a54dd5590d300a5a02a373922cd7359e3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                \"name\": \"products\","},{"line_number":52,"context_line":"                \"datastore\": {"},{"line_number":53,"context_line":"                    \"type\": \"vertica\","},{"line_number":54,"context_line":"                    \"version\": \"2.4.10\""},{"line_number":55,"context_line":"                },"},{"line_number":56,"context_line":"                \"instances\": instances"},{"line_number":57,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_2bdb367e","line":54,"updated":"2015-05-07 07:26:45.000000000","message":"Any reasons for change of this version number","commit_id":"247f86f10cf0e7a67e16ac014b2fd315bde1c29c"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"81000420e688e3ea99d32245d971469317eff75c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                \"name\": \"products\","},{"line_number":52,"context_line":"                \"datastore\": {"},{"line_number":53,"context_line":"                    \"type\": \"vertica\","},{"line_number":54,"context_line":"                    \"version\": \"2.4.10\""},{"line_number":55,"context_line":"                },"},{"line_number":56,"context_line":"                \"instances\": instances"},{"line_number":57,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_01004400","line":54,"in_reply_to":"1aca2d91_2bdb367e","updated":"2015-05-11 16:32:47.000000000","message":"no it should be 7.1, I will change this back to 7.1, in next patch","commit_id":"247f86f10cf0e7a67e16ac014b2fd315bde1c29c"}]}