)]}'
{"trove/tests/unittests/instance/test_instance_controller.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"a5ca7ddd6f0c88edd4f75ed7339ae10d311bf4fe","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from trove.common import apischema"},{"line_number":20,"context_line":"from trove.instance.service import InstanceController"},{"line_number":21,"context_line":"from trove.tests.unittests import trove_testtools"},{"line_number":22,"context_line":"import jsonschema"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestInstanceController(trove_testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_623db6ba","line":22,"updated":"2015-05-07 18:22:14.000000000","message":"why was this shifted to last, it deserves to be at top(by order)","commit_id":"e958840cd6d23271ffdecb340a713206a827a450"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"7a363571d19578b9c492a01f04fe5387cbd55c3e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from trove.common import apischema"},{"line_number":20,"context_line":"from trove.instance.service import InstanceController"},{"line_number":21,"context_line":"from trove.tests.unittests import trove_testtools"},{"line_number":22,"context_line":"import jsonschema"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestInstanceController(trove_testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_330dad37","line":22,"in_reply_to":"1aca2d91_22733e17","updated":"2015-05-08 15:49:49.000000000","message":"We do prefer imports at the top. It is consistent with all the other files.","commit_id":"e958840cd6d23271ffdecb340a713206a827a450"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"70da6cbc8e518302cd943bb6245767f7b5294704","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from trove.common import apischema"},{"line_number":20,"context_line":"from trove.instance.service import InstanceController"},{"line_number":21,"context_line":"from trove.tests.unittests import trove_testtools"},{"line_number":22,"context_line":"import jsonschema"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestInstanceController(trove_testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_53dee93f","line":22,"in_reply_to":"1aca2d91_330dad37","updated":"2015-05-08 15:56:36.000000000","message":"but we do disable H305 (intentionally).","commit_id":"e958840cd6d23271ffdecb340a713206a827a450"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"923b3072acf09bfefd39fc19c1e574c69c51bb11","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from trove.common import apischema"},{"line_number":20,"context_line":"from trove.instance.service import InstanceController"},{"line_number":21,"context_line":"from trove.tests.unittests import trove_testtools"},{"line_number":22,"context_line":"import jsonschema"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestInstanceController(trove_testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_73e1e5cf","line":22,"in_reply_to":"1aca2d91_53dee93f","updated":"2015-05-08 16:00:22.000000000","message":"Why move it though? If you look in our production code modules the imports are always at the top.","commit_id":"e958840cd6d23271ffdecb340a713206a827a450"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"2b43c57229e94b79a7e5f4bbb6eefd9a26436d84","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from trove.common import apischema"},{"line_number":20,"context_line":"from trove.instance.service import InstanceController"},{"line_number":21,"context_line":"from trove.tests.unittests import trove_testtools"},{"line_number":22,"context_line":"import jsonschema"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestInstanceController(trove_testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_22733e17","line":22,"in_reply_to":"1aca2d91_623db6ba","updated":"2015-05-07 18:36:54.000000000","message":"It would be good to decide on what and if we want to enforce any particular ordering. We currently don\u0027t.","commit_id":"e958840cd6d23271ffdecb340a713206a827a450"}],"trove/tests/unittests/instance/test_instance_models.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"a5ca7ddd6f0c88edd4f75ed7339ae10d311bf4fe","unresolved":false,"context_lines":[{"line_number":31,"context_line":"import uuid"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"},{"line_number":34,"context_line":"task_api.API.get_client \u003d Mock()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class SimpleInstanceTest(trove_testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_626496e4","line":34,"updated":"2015-05-07 18:22:14.000000000","message":"unsafe mock","commit_id":"e958840cd6d23271ffdecb340a713206a827a450"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3197cc9238a69bc0a45c007e985b9f89ad007b64","unresolved":false,"context_lines":[{"line_number":31,"context_line":"import uuid"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"},{"line_number":34,"context_line":"task_api.API.get_client \u003d Mock()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class SimpleInstanceTest(trove_testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_6960d1a5","line":34,"in_reply_to":"1aca2d91_42f3da9e","updated":"2015-05-08 19:06:24.000000000","message":"But you\u0027re still going to fix it, right?  ;)","commit_id":"e958840cd6d23271ffdecb340a713206a827a450"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"c1b0d3880d28b1594a1c3b77dd10002aa251744a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"import uuid"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"},{"line_number":34,"context_line":"task_api.API.get_client \u003d Mock()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class SimpleInstanceTest(trove_testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_42f3da9e","line":34,"in_reply_to":"1aca2d91_626496e4","updated":"2015-05-07 18:33:07.000000000","message":"This is because the detector checks only for leaked objects introduced by test cases. This one is unfortunately introduced in the global scope outside of any test case. The mock detector could be changed to detect these too, but that would make identifying them (at this stage - when they are everywhere) nearly impossible. You would keep seeing same objects all the time for each test case.","commit_id":"e958840cd6d23271ffdecb340a713206a827a450"}]}