)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"e62a7779652ce85e0c853d4834ded35452372765","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sharika \u003csharika.pongubala@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-26 13:26:39 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug in install_vertica"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If install_vertica or create_db fails on the vertica cluster,"},{"line_number":10,"context_line":"a RuntimeError is now raised and is reflected in the logs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a016987_2265a9e0","line":7,"updated":"2015-05-27 06:22:06.000000000","message":"Can you please provide a more descriptive commit header here? \n\nMaybe something like:\n\"Fix create Vertica cluster to show ERROR on failure\"","commit_id":"ace37e861ee4cc410802dae7cda7d8debf1a57c1"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"33c49ccc25319cca0e3586cc18751fe549d10d9a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sharika \u003csharika.pongubala@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-27 11:17:51 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix create Vertica cluster to show ERROR on failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If install_vertica or create_db fails on the vertica cluster,"},{"line_number":10,"context_line":"a RuntimeError is now raised and is reflected in the logs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a016987_6127bfca","line":7,"updated":"2015-05-29 07:24:40.000000000","message":"The update not only impacts the cluster but also impacts the single instance.","commit_id":"76a0814779312103b2194cbe0343d468f643d2d5"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"33c49ccc25319cca0e3586cc18751fe549d10d9a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix create Vertica cluster to show ERROR on failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If install_vertica or create_db fails on the vertica cluster,"},{"line_number":10,"context_line":"a RuntimeError is now raised and is reflected in the logs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changed create_db unittest and install_vertica unittest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a016987_e1196f89","line":9,"updated":"2015-05-29 07:24:40.000000000","message":"Same point, the workflow is also affected for single instance vertica install","commit_id":"76a0814779312103b2194cbe0343d468f643d2d5"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"33c49ccc25319cca0e3586cc18751fe549d10d9a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix create Vertica cluster to show ERROR on failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If install_vertica or create_db fails on the vertica cluster,"},{"line_number":10,"context_line":"a RuntimeError is now raised and is reflected in the logs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changed create_db unittest and install_vertica unittest"},{"line_number":13,"context_line":"according to the new raised exceptions"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a016987_8114fb4c","line":10,"updated":"2015-05-29 07:24:40.000000000","message":"It was reflected earlier also in logs","commit_id":"76a0814779312103b2194cbe0343d468f643d2d5"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"33c49ccc25319cca0e3586cc18751fe549d10d9a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If install_vertica or create_db fails on the vertica cluster,"},{"line_number":10,"context_line":"a RuntimeError is now raised and is reflected in the logs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changed create_db unittest and install_vertica unittest"},{"line_number":13,"context_line":"according to the new raised exceptions"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The trove cluster instances now display the ERROR state"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a016987_410ba32a","line":12,"updated":"2015-05-29 07:24:40.000000000","message":"s/Changed/Updated","commit_id":"76a0814779312103b2194cbe0343d468f643d2d5"}],"trove/guestagent/datastore/experimental/vertica/service.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"bf7c279c35b4c9a92c8ae9c2ea28b32b07050c07","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            system.shell_execute(create_db_command, \"dbadmin\")"},{"line_number":163,"context_line":"        except Exception:"},{"line_number":164,"context_line":"            LOG.exception(_(\"Vertica database create failed.\"))"},{"line_number":165,"context_line":"\t    raise"},{"line_number":166,"context_line":"        LOG.info(_(\"Vertica database create completed.\"))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def install_vertica(self, members\u003dnetutils.get_my_ipv4()):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_83a3719e","line":165,"updated":"2015-05-14 07:42:09.000000000","message":"invalid character","commit_id":"f63ab7b22b3a2cab69274c350570e6b2c2b25b6f"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"3ff87ac70d2cbaa16d691b88c066adb084f2568b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            system.shell_execute(create_db_command, \"dbadmin\")"},{"line_number":163,"context_line":"        except Exception:"},{"line_number":164,"context_line":"            LOG.exception(_(\"Vertica database create failed.\"))"},{"line_number":165,"context_line":"            raise RuntimeError(\"Vertica database create failed\")"},{"line_number":166,"context_line":"        LOG.info(_(\"Vertica database create completed.\"))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def install_vertica(self, members\u003dnetutils.get_my_ipv4()):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_e8d10b24","line":165,"updated":"2015-05-22 19:32:58.000000000","message":"Can we end the message with a \u0027.\u0027","commit_id":"1a4cee2f5a16fc0a7577211dd05867189724b7e4"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"3ff87ac70d2cbaa16d691b88c066adb084f2568b","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            system.shell_execute(install_vertica_cmd)"},{"line_number":176,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":177,"context_line":"            LOG.exception(_(\"install_vertica failed.\"))"},{"line_number":178,"context_line":"            raise"},{"line_number":179,"context_line":"        self._generate_database_password()"},{"line_number":180,"context_line":"        LOG.info(_(\"install_vertica completed.\"))"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_28aa8385","line":178,"updated":"2015-05-22 19:32:58.000000000","message":"raise some exception here like you did in create_db","commit_id":"1a4cee2f5a16fc0a7577211dd05867189724b7e4"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"71d7a12b324388fcacc96d0b06953a56ec0d9836","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            system.shell_execute(create_db_command, \"dbadmin\")"},{"line_number":163,"context_line":"        except Exception:"},{"line_number":164,"context_line":"            LOG.exception(_(\"Vertica database create failed.\"))"},{"line_number":165,"context_line":"            raise RuntimeError(\"Vertica database create failed.\")"},{"line_number":166,"context_line":"        LOG.info(_(\"Vertica database create completed.\"))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def install_vertica(self, members\u003dnetutils.get_my_ipv4()):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_96a4f84a","line":165,"updated":"2015-05-22 21:21:25.000000000","message":"Since, this is potentially a user-facing message (not just a DEBUG log message) it should be internationalized.","commit_id":"0843e3e5dbd9bf3acc58517fcb230bd611859661"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"71d7a12b324388fcacc96d0b06953a56ec0d9836","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            system.shell_execute(install_vertica_cmd)"},{"line_number":176,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":177,"context_line":"            LOG.exception(_(\"install_vertica failed.\"))"},{"line_number":178,"context_line":"            raise RuntimeError(\"install_vertica failed.\")"},{"line_number":179,"context_line":"        self._generate_database_password()"},{"line_number":180,"context_line":"        LOG.info(_(\"install_vertica completed.\"))"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_5669e0f7","line":178,"updated":"2015-05-22 21:21:25.000000000","message":"ditto","commit_id":"0843e3e5dbd9bf3acc58517fcb230bd611859661"}],"trove/tests/unittests/guestagent/test_dbaas.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"805d5410523f491e13aa9ea1f2a419689351e705","unresolved":false,"context_lines":[{"line_number":2774,"context_line":"    def test_failure_create_db(self):"},{"line_number":2775,"context_line":"        with patch.object(self.app, \u0027read_config\u0027,"},{"line_number":2776,"context_line":"                          side_effect\u003dRuntimeError(\u0027Error\u0027)):"},{"line_number":2777,"context_line":"            self.app.create_db(\u002710.0.0.2\u0027)"},{"line_number":2778,"context_line":"        # Because of an exception in read_config there was no shell execution."},{"line_number":2779,"context_line":"        self.assertRaises(Exception, self.app.create_db)"},{"line_number":2780,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_c75c031b","line":2777,"updated":"2015-05-22 16:29:46.000000000","message":"This call is raising the exception/error message which is making your test fail, you need to use assertRaises at this level.","commit_id":"4a6c09d3aa018eaefab4f59644aa0a7b826e6d69"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"da2ba8e445a029e5f1d794c26f7d3f73ef6437e6","unresolved":false,"context_lines":[{"line_number":2774,"context_line":"    def test_failure_create_db(self):"},{"line_number":2775,"context_line":"        with patch.object(self.app, \u0027read_config\u0027,"},{"line_number":2776,"context_line":"                          side_effect\u003dRuntimeError(\u0027Error\u0027)):"},{"line_number":2777,"context_line":"            self.assertRaises(RuntimeError,"},{"line_number":2778,"context_line":"                              self.app.create_db)"},{"line_number":2779,"context_line":""},{"line_number":2780,"context_line":"    def test_vertica_write_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_e86b4bb5","line":2777,"updated":"2015-05-22 19:14:21.000000000","message":"Maybe, this could also test that the \u0027create_db\u0027 does not execute calls following the failing statement in addition to just testing that it \u0027re-raises\u0027 the exception.","commit_id":"1a4cee2f5a16fc0a7577211dd05867189724b7e4"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"3ff87ac70d2cbaa16d691b88c066adb084f2568b","unresolved":false,"context_lines":[{"line_number":2774,"context_line":"    def test_failure_create_db(self):"},{"line_number":2775,"context_line":"        with patch.object(self.app, \u0027read_config\u0027,"},{"line_number":2776,"context_line":"                          side_effect\u003dRuntimeError(\u0027Error\u0027)):"},{"line_number":2777,"context_line":"            self.assertRaises(RuntimeError,"},{"line_number":2778,"context_line":"                              self.app.create_db)"},{"line_number":2779,"context_line":""},{"line_number":2780,"context_line":"    def test_vertica_write_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_280e03e5","line":2777,"in_reply_to":"7a016987_e86b4bb5","updated":"2015-05-22 19:32:58.000000000","message":"It was discussed earlier to use assertRaisesRegexp to test the exception message, whereever possible and we have a case here","commit_id":"1a4cee2f5a16fc0a7577211dd05867189724b7e4"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"71d7a12b324388fcacc96d0b06953a56ec0d9836","unresolved":false,"context_lines":[{"line_number":2763,"context_line":"    def test_failure_install_vertica(self):"},{"line_number":2764,"context_line":"        with patch.object(vertica_system, \u0027shell_execute\u0027,"},{"line_number":2765,"context_line":"                          side_effect\u003dProcessExecutionError(\u0027some exception\u0027)):"},{"line_number":2766,"context_line":"            self.assertRaises(ProcessExecutionError,"},{"line_number":2767,"context_line":"                              self.app.install_vertica(members\u003d\u002710.0.0.2\u0027))"},{"line_number":2768,"context_line":""},{"line_number":2769,"context_line":"    def test_create_db(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_9652b833","line":2766,"updated":"2015-05-22 21:21:25.000000000","message":"Please check the expected message like below.","commit_id":"0843e3e5dbd9bf3acc58517fcb230bd611859661"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"068ee118b3fcbe0f2cb9b11b1e10258a0bccde7e","unresolved":false,"context_lines":[{"line_number":2775,"context_line":"        with patch.object(self.app, \u0027read_config\u0027,"},{"line_number":2776,"context_line":"                          side_effect\u003dRuntimeError(\u0027Error\u0027)):"},{"line_number":2777,"context_line":"            self.app.create_db(\u002710.0.0.2\u0027)"},{"line_number":2778,"context_line":"        # Because of an exception in read_config there was no shell execution."},{"line_number":2779,"context_line":"        self.assertEqual(0, vertica_system.shell_execute.call_count)"},{"line_number":2780,"context_line":""},{"line_number":2781,"context_line":"    def test_vertica_write_config(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_a5168649","side":"PARENT","line":2778,"updated":"2015-05-25 07:29:36.000000000","message":"Please do not remove this space, because in newer version of hacking rules \"E265 block comment should start with \u0027# \u0027\"","commit_id":"fce2e356ed0e243d9d4f0d6b9a290128dee6c58a"}]}