)]}'
{"trove/tests/unittests/instance/test_instance_models.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"ac96342caea9ea9d96f8bbeb0a175d363a2f1fdc","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class CreateInstanceTest(trove_testtools.TestCase):"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @patch.object(task_api.API, \u0027get_client\u0027, Mock(return_value\u003dMock()))"},{"line_number":107,"context_line":"    def setUp(self):"},{"line_number":108,"context_line":"        util.init_db()"},{"line_number":109,"context_line":"        self.context \u003d Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_e8a76709","line":106,"updated":"2015-05-27 12:40:37.000000000","message":"I must be missing something here. Why are we mocking this for setUp? i.e. in setUp, you want task_api.API.get_client to be a Mock(). This fascinates me.","commit_id":"53e7ea9d7293f047ebc87b02a6d9266a5351e25c"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"8e982058150348467d1cd09dd95f553fa6d7c699","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class CreateInstanceTest(trove_testtools.TestCase):"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @patch.object(task_api.API, \u0027get_client\u0027, Mock(return_value\u003dMock()))"},{"line_number":107,"context_line":"    def setUp(self):"},{"line_number":108,"context_line":"        util.init_db()"},{"line_number":109,"context_line":"        self.context \u003d Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_2a3d37dd","line":106,"in_reply_to":"7a016987_c3ddac71","updated":"2015-05-28 17:34:55.000000000","message":"This is the proper way to mock here.","commit_id":"53e7ea9d7293f047ebc87b02a6d9266a5351e25c"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"11c3a36fac3710b8328a9108af8d0ea23d6712f5","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class CreateInstanceTest(trove_testtools.TestCase):"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @patch.object(task_api.API, \u0027get_client\u0027, Mock(return_value\u003dMock()))"},{"line_number":107,"context_line":"    def setUp(self):"},{"line_number":108,"context_line":"        util.init_db()"},{"line_number":109,"context_line":"        self.context \u003d Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_c3ddac71","line":106,"in_reply_to":"7a016987_e8a76709","updated":"2015-05-27 13:03:28.000000000","message":"Line 168: task_api.API(self.context).create_instance, this calls the get_client which if not mocked raises error","commit_id":"53e7ea9d7293f047ebc87b02a6d9266a5351e25c"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"ac96342caea9ea9d96f8bbeb0a175d363a2f1fdc","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            return_value\u003dTrue)"},{"line_number":174,"context_line":"        super(CreateInstanceTest, self).setUp()"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @patch.object(task_api.API, \u0027get_client\u0027, Mock(return_value\u003dMock()))"},{"line_number":177,"context_line":"    def tearDown(self):"},{"line_number":178,"context_line":"        self.db_info.delete()"},{"line_number":179,"context_line":"        self.backup.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_88b91331","line":176,"updated":"2015-05-27 12:40:37.000000000","message":"ditto","commit_id":"53e7ea9d7293f047ebc87b02a6d9266a5351e25c"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"11c3a36fac3710b8328a9108af8d0ea23d6712f5","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            return_value\u003dTrue)"},{"line_number":174,"context_line":"        super(CreateInstanceTest, self).setUp()"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @patch.object(task_api.API, \u0027get_client\u0027, Mock(return_value\u003dMock()))"},{"line_number":177,"context_line":"    def tearDown(self):"},{"line_number":178,"context_line":"        self.db_info.delete()"},{"line_number":179,"context_line":"        self.backup.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_43377cb0","line":176,"in_reply_to":"7a016987_88b91331","updated":"2015-05-27 13:03:28.000000000","message":"Line 183: task_api.API(self.context).create_instance, this calls the get_client which if not mocked raises error","commit_id":"53e7ea9d7293f047ebc87b02a6d9266a5351e25c"}],"trove/tests/unittests/taskmanager/test_api.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"ac96342caea9ea9d96f8bbeb0a175d363a2f1fdc","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ApiTest(trove_testtools.TestCase):"},{"line_number":31,"context_line":"    @patch.object(task_api.API, \u0027get_client\u0027)"},{"line_number":32,"context_line":"    def setUp(self, *args):"},{"line_number":33,"context_line":"        super(ApiTest, self).setUp()"},{"line_number":34,"context_line":"        self.context \u003d context.TroveContext()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4882fb53","line":31,"updated":"2015-05-27 12:40:37.000000000","message":"likewise","commit_id":"53e7ea9d7293f047ebc87b02a6d9266a5351e25c"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"11c3a36fac3710b8328a9108af8d0ea23d6712f5","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ApiTest(trove_testtools.TestCase):"},{"line_number":31,"context_line":"    @patch.object(task_api.API, \u0027get_client\u0027)"},{"line_number":32,"context_line":"    def setUp(self, *args):"},{"line_number":33,"context_line":"        super(ApiTest, self).setUp()"},{"line_number":34,"context_line":"        self.context \u003d context.TroveContext()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_835574c7","line":31,"in_reply_to":"7a016987_4882fb53","updated":"2015-05-27 13:03:28.000000000","message":"Line 35: task_api.API(self.context) raises error in absence of mocked get_client","commit_id":"53e7ea9d7293f047ebc87b02a6d9266a5351e25c"}]}
