)]}'
{"trove/common/pagination.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c1f13a627f950d089d819d80b2c14ef083dafc0c","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def paginate_list(li, limit\u003dNone, marker\u003dNone, include_marker\u003dFalse):"},{"line_number":32,"context_line":"    \"\"\"Sort the given list and return a sublist containing a page of items"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Keyword arguments:"},{"line_number":35,"context_line":"    li -- The list to be paginated"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_bb19528a","line":32,"updated":"2015-06-23 23:00:54.000000000","message":"Could you use Sphinx (http://sphinx-doc.org/) syntax for docs? It will be easier to maintain later :)\n\nIn this case:\n:param list li: list to be paginated\n...\n:return: paginated list\n:rtype: list","commit_id":"5869e67b9d0b012febcb37c3187822f80ecec30c"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"130556a94e57db9d77ddd6f8e2af7a81bc9d73c5","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def paginate_list(li, limit\u003dNone, marker\u003dNone, include_marker\u003dFalse):"},{"line_number":32,"context_line":"    \"\"\"Sort the given list and return a sublist containing a page of items"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Keyword arguments:"},{"line_number":35,"context_line":"    li -- The list to be paginated"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_6cad4e83","line":32,"in_reply_to":"fa32b979_bb19528a","updated":"2015-06-24 01:32:06.000000000","message":"Done.","commit_id":"5869e67b9d0b012febcb37c3187822f80ecec30c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c1f13a627f950d089d819d80b2c14ef083dafc0c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    marker -- Key of the first item to appear on the sublist"},{"line_number":38,"context_line":"    include_marker -- Include the marker value itself in the returned sublist"},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    li.sort()"},{"line_number":41,"context_line":"    if include_marker:"},{"line_number":42,"context_line":"        pos \u003d bisect.bisect_left(li, marker)"},{"line_number":43,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_36df976a","line":40,"updated":"2015-06-23 23:00:54.000000000","message":"Why you sort them? Shouldn\u0027t we retrieve things as PyMongo retrieves them? Also, how is going the sort() function behave for big lists of databases?","commit_id":"5869e67b9d0b012febcb37c3187822f80ecec30c"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"130556a94e57db9d77ddd6f8e2af7a81bc9d73c5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    marker -- Key of the first item to appear on the sublist"},{"line_number":38,"context_line":"    include_marker -- Include the marker value itself in the returned sublist"},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    li.sort()"},{"line_number":41,"context_line":"    if include_marker:"},{"line_number":42,"context_line":"        pos \u003d bisect.bisect_left(li, marker)"},{"line_number":43,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_ccbc9abd","line":40,"in_reply_to":"fa32b979_36df976a","updated":"2015-06-24 01:32:06.000000000","message":"This is a generic function. It is not assumed that all callers will hand it ordered results. Sorting them here is our best bet at guaranteeing the order is consistent.\n\nThe built in function sort is optimal. I don\u0027t see a use case involving a database list large enough to be an issue here, so it is kept simple.","commit_id":"5869e67b9d0b012febcb37c3187822f80ecec30c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"88318d8886250b92bd03b8961bc6139c500f1b83","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"Sort the given list and return a sublist containing a page of items."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    :param list li:             The list to be paginated."},{"line_number":35,"context_line":"    :param int limit:           Maximum number of iterms to be returned."},{"line_number":36,"context_line":"    :param marker:              Key of the first item to appear on the sublist."},{"line_number":37,"context_line":"    :param bool include_marker: Include the marker value itself in the sublist."},{"line_number":38,"context_line":"    :return:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_b46606b9","line":35,"updated":"2015-07-02 19:22:36.000000000","message":"NIT: typo items*","commit_id":"665a5483760d62a790641dc97105d5824e05e579"}],"trove/guestagent/datastore/experimental/mongodb/manager.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8f6fadbeab970936b29d1945478ae02810fe974f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            operation\u003d\u0027update_attributes\u0027, datastore\u003dMANAGER)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def create_database(self, context, databases):"},{"line_number":169,"context_line":"        LOG.debug(\"Creating database.\")"},{"line_number":170,"context_line":"        return service.MongoDBAdmin().create_database(databases)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def create_user(self, context, users):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a50d1a3_d0893327","line":169,"updated":"2015-07-29 21:23:47.000000000","message":"Could you add to the logs the databases being created?","commit_id":"2e457f34f77bd8c539acbafbafac74c771e2f911"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"8506428c76982ddcbd5b56fc8357e1be1d0fd014","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            operation\u003d\u0027update_attributes\u0027, datastore\u003dMANAGER)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def create_database(self, context, databases):"},{"line_number":169,"context_line":"        LOG.debug(\"Creating database.\")"},{"line_number":170,"context_line":"        return service.MongoDBAdmin().create_database(databases)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def create_user(self, context, users):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a50d1a3_dd45d96e","line":169,"updated":"2015-07-23 15:23:29.000000000","message":"s/database/databases","commit_id":"2e457f34f77bd8c539acbafbafac74c771e2f911"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8f6fadbeab970936b29d1945478ae02810fe974f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        return service.MongoDBAdmin().create_users(users)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def delete_database(self, context, database):"},{"line_number":177,"context_line":"        LOG.debug(\"Deleting database.\")"},{"line_number":178,"context_line":"        return service.MongoDBAdmin().delete_database(database)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def delete_user(self, context, user):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a50d1a3_b08267fd","line":177,"updated":"2015-07-29 21:23:47.000000000","message":"Ditto","commit_id":"2e457f34f77bd8c539acbafbafac74c771e2f911"}],"trove/guestagent/datastore/experimental/mongodb/service.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"6dbfceeddf43937796249b8fddd830ce7e0c806f","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        tmp \u003d \u0027dummy\u0027"},{"line_number":462,"context_line":"        with MongoDBClient(self._admin_user()) as admin_client:"},{"line_number":463,"context_line":"            for item in databases:"},{"line_number":464,"context_line":"                db_name \u003d models.MongoDBSchema.deserialize_schema(item).name"},{"line_number":465,"context_line":"                db \u003d admin_client[db_name]"},{"line_number":466,"context_line":"                db[tmp].insert({\u0027dummy\u0027: True})"},{"line_number":467,"context_line":"                db.drop_collection(tmp)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_c6cf00b2","line":464,"updated":"2015-06-22 01:20:31.000000000","message":"What happens if a ValueError is thrown while trying to deserialize the database name. Wouldnt it make sense to catch the exception here which just says \u0027Bad args\u0027 and say something meaningful like \u0027Unable to create database %s\u0027 or something like that.","commit_id":"5aa136ac4c3ff7c39d54eac3edf79c01f8b680db"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"abd3ab1aecae1a8f9cda16c806e00dff12ead0de","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        tmp \u003d \u0027dummy\u0027"},{"line_number":462,"context_line":"        with MongoDBClient(self._admin_user()) as admin_client:"},{"line_number":463,"context_line":"            for item in databases:"},{"line_number":464,"context_line":"                db_name \u003d models.MongoDBSchema.deserialize_schema(item).name"},{"line_number":465,"context_line":"                db \u003d admin_client[db_name]"},{"line_number":466,"context_line":"                db[tmp].insert({\u0027dummy\u0027: True})"},{"line_number":467,"context_line":"                db.drop_collection(tmp)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_2f3460f9","line":464,"in_reply_to":"fa32b979_c6cf00b2","updated":"2015-06-22 17:45:07.000000000","message":"Updated the exception in the deserializer","commit_id":"5aa136ac4c3ff7c39d54eac3edf79c01f8b680db"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"6dbfceeddf43937796249b8fddd830ce7e0c806f","unresolved":false,"context_lines":[{"line_number":477,"context_line":"    def delete_database(self, database):"},{"line_number":478,"context_line":"        \"\"\"Deletes the database.\"\"\""},{"line_number":479,"context_line":"        with MongoDBClient(self._admin_user()) as admin_client:"},{"line_number":480,"context_line":"            db_name \u003d models.MongoDBSchema.deserialize_schema(database).name"},{"line_number":481,"context_line":"            admin_client.drop_database(db_name)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def list_database_names(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_26e4ac39","line":480,"updated":"2015-06-22 01:20:31.000000000","message":"same comment as above regarding ValueError.","commit_id":"5aa136ac4c3ff7c39d54eac3edf79c01f8b680db"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"abd3ab1aecae1a8f9cda16c806e00dff12ead0de","unresolved":false,"context_lines":[{"line_number":477,"context_line":"    def delete_database(self, database):"},{"line_number":478,"context_line":"        \"\"\"Deletes the database.\"\"\""},{"line_number":479,"context_line":"        with MongoDBClient(self._admin_user()) as admin_client:"},{"line_number":480,"context_line":"            db_name \u003d models.MongoDBSchema.deserialize_schema(database).name"},{"line_number":481,"context_line":"            admin_client.drop_database(db_name)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def list_database_names(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_cf3a94e7","line":480,"in_reply_to":"fa32b979_26e4ac39","updated":"2015-06-22 17:45:07.000000000","message":"Same as above.","commit_id":"5aa136ac4c3ff7c39d54eac3edf79c01f8b680db"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"6dbfceeddf43937796249b8fddd830ce7e0c806f","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        with MongoDBClient(self._admin_user()) as admin_client:"},{"line_number":486,"context_line":"            return admin_client.database_names()"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    def list_databases(self):"},{"line_number":489,"context_line":"        \"\"\"Lists the databases.\"\"\""},{"line_number":490,"context_line":"        db_names \u003d self.list_database_names()"},{"line_number":491,"context_line":"        for hidden in [\u0027admin\u0027, \u0027local\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_e69fa4b2","line":488,"updated":"2015-06-22 01:20:31.000000000","message":"Looks like this function will return all the databases every time its called even if the user specifies a limit or marker.  Might be useful to add a note somewhere as a TODO or something like that.","commit_id":"5aa136ac4c3ff7c39d54eac3edf79c01f8b680db"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"24d290e66d793c9c9e02edab797fcc1780d65088","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        with MongoDBClient(self._admin_user()) as admin_client:"},{"line_number":486,"context_line":"            return admin_client.database_names()"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    def list_databases(self):"},{"line_number":489,"context_line":"        \"\"\"Lists the databases.\"\"\""},{"line_number":490,"context_line":"        db_names \u003d self.list_database_names()"},{"line_number":491,"context_line":"        for hidden in [\u0027admin\u0027, \u0027local\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_f380c58d","line":488,"updated":"2015-06-22 06:22:43.000000000","message":"Missing on pagination stuff, need to add marker and limit","commit_id":"5aa136ac4c3ff7c39d54eac3edf79c01f8b680db"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"abd3ab1aecae1a8f9cda16c806e00dff12ead0de","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        with MongoDBClient(self._admin_user()) as admin_client:"},{"line_number":486,"context_line":"            return admin_client.database_names()"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    def list_databases(self):"},{"line_number":489,"context_line":"        \"\"\"Lists the databases.\"\"\""},{"line_number":490,"context_line":"        db_names \u003d self.list_database_names()"},{"line_number":491,"context_line":"        for hidden in [\u0027admin\u0027, \u0027local\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_8f256cc3","line":488,"in_reply_to":"fa32b979_f380c58d","updated":"2015-06-22 17:45:07.000000000","message":"Done.","commit_id":"5aa136ac4c3ff7c39d54eac3edf79c01f8b680db"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"0acfa3ddab50abc48fe560cd731a5c7e2123bb65","unresolved":false,"context_lines":[{"line_number":561,"context_line":"    def list_databases(self, limit\u003dNone, marker\u003dNone, include_marker\u003dFalse):"},{"line_number":562,"context_line":"        \"\"\"Lists the databases.\"\"\""},{"line_number":563,"context_line":"        db_names \u003d self.list_database_names()"},{"line_number":564,"context_line":"        for hidden in [\u0027admin\u0027, \u0027local\u0027]:"},{"line_number":565,"context_line":"            db_names.remove(hidden)"},{"line_number":566,"context_line":"        databases \u003d [models.MongoDBSchema(db_name).serialize()"},{"line_number":567,"context_line":"                     for db_name in db_names]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_87677724","line":564,"updated":"2015-07-21 19:26:39.000000000","message":"Just wondering, wouldn\u0027t the existing \u0027ignore_dbs\u0027 configuration option be appropriate for this?","commit_id":"48616079048b53b65ce238c8df3ceecb33bf1ae5"}],"trove/tests/unittests/common/test_pagination.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"c1a3e19ff73f398b3d3fc1073098201438e1d7b2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # continue list, do not include marker in result"},{"line_number":53,"context_line":"        li_2, marker_2 \u003d self._do_paginate_list(limit\u003d2, marker\u003dmarker_1)"},{"line_number":54,"context_line":"        self.assertEqual([\u0027d\u0027, \u0027e\u0027], li_2)"},{"line_number":55,"context_line":"        self.assertEqual(None, marker_2)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # alternate continue list, include marker in result"},{"line_number":58,"context_line":"        li_3, marker_3 \u003d self._do_paginate_list(limit\u003d2, marker\u003dmarker_1,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_f1b9c77a","line":55,"updated":"2015-07-05 06:29:44.000000000","message":"assertIsNone","commit_id":"665a5483760d62a790641dc97105d5824e05e579"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"c1a3e19ff73f398b3d3fc1073098201438e1d7b2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # bad marker"},{"line_number":64,"context_line":"        li_4, marker_4 \u003d self._do_paginate_list(marker\u003d\u0027f\u0027)"},{"line_number":65,"context_line":"        self.assertEqual([], li_4)"},{"line_number":66,"context_line":"        self.assertEqual(None, marker_4)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_d1b4c383","line":66,"updated":"2015-07-05 06:29:44.000000000","message":"assertIsNone","commit_id":"665a5483760d62a790641dc97105d5824e05e579"}],"trove/tests/unittests/guestagent/test_mongodb_manager.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"a7b6efaa82a72101dec08de8ce593bd1a8fa1e03","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import trove.common.utils as utils"},{"line_number":20,"context_line":"import trove.guestagent.db.models as models"},{"line_number":21,"context_line":"import trove.guestagent.datastore.experimental.mongodb.manager as manager"},{"line_number":22,"context_line":"import trove.guestagent.datastore.experimental.mongodb.service as service"},{"line_number":23,"context_line":"import trove.guestagent.volume as volume"},{"line_number":24,"context_line":"import trove.tests.unittests.trove_testtools as trove_testtools"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_eb2bbe92","line":22,"updated":"2015-06-08 19:35:24.000000000","message":"pep8 error here - imports need to be reordered  a bit to follow H306 rule","commit_id":"7f11873c3adb22a1aca674def33ce806a6e60b4a"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"4b5feaa0fc874a17121a6324c78aa668de1cd306","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.manager.create_database(self.context, [schema])"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        db_client[\u0027dummy\u0027].insert.assert_called_with({\u0027dummy\u0027: True})"},{"line_number":128,"context_line":"        db_client.drop_collection.assert_called_with(\u0027dummy\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_601ec060","line":128,"updated":"2015-06-17 07:04:20.000000000","message":"can we add more tests for list as well as delete database","commit_id":"5aa136ac4c3ff7c39d54eac3edf79c01f8b680db"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"ab808d91e38175811b9117e823d2d16b2c2fa787","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.manager.create_database(self.context, [schema])"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        db_client[\u0027dummy\u0027].insert.assert_called_with({\u0027dummy\u0027: True})"},{"line_number":128,"context_line":"        db_client.drop_collection.assert_called_with(\u0027dummy\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_7115263e","line":128,"in_reply_to":"fa32b979_601ec060","updated":"2015-06-17 13:37:19.000000000","message":"I didn\u0027t see the value in a test for delete database, which just calls pymongo\u0027s drop database command. It was a similar case for list databases, but that got refactored so I will add a test for that.","commit_id":"5aa136ac4c3ff7c39d54eac3edf79c01f8b680db"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"6dbfceeddf43937796249b8fddd830ce7e0c806f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.manager.create_database(self.context, [schema])"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        db_client[\u0027dummy\u0027].insert.assert_called_with({\u0027dummy\u0027: True})"},{"line_number":128,"context_line":"        db_client.drop_collection.assert_called_with(\u0027dummy\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_c63620b4","line":128,"in_reply_to":"fa32b979_7115263e","updated":"2015-06-22 01:20:31.000000000","message":"for delete_database how about we create a test case where you are passing a database name which will cause a ValueError when deserializing and make sure that it throws the ValueError exception.","commit_id":"5aa136ac4c3ff7c39d54eac3edf79c01f8b680db"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c1f13a627f950d089d819d80b2c14ef083dafc0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fa32b979_f6e4cf3c","updated":"2015-06-23 23:00:54.000000000","message":"Could you add a few tests for list databases and delete databases? like, the database lifecycle.","commit_id":"5869e67b9d0b012febcb37c3187822f80ecec30c"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"130556a94e57db9d77ddd6f8e2af7a81bc9d73c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fa32b979_4cc96a58","in_reply_to":"fa32b979_f6e4cf3c","updated":"2015-06-24 01:32:06.000000000","message":"Done.","commit_id":"5869e67b9d0b012febcb37c3187822f80ecec30c"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"2b5690f3f4385de981f132ae9cca1861a36dddf1","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    @mock.patch.object(service.MongoDBAdmin, \u0027_admin_user\u0027)"},{"line_number":132,"context_line":"    def test_list_databases(self, mocked_admin_user, mocked_client):"},{"line_number":133,"context_line":"        mocked_list \u003d mock.MagicMock("},{"line_number":134,"context_line":"            return_value\u003d[\u0027admin\u0027, \u0027local\u0027, \u0027db0\u0027, \u0027db1\u0027, \u0027db2\u0027, \u0027db3\u0027, \u0027db4\u0027])"},{"line_number":135,"context_line":"        mocked_client().__enter__().database_names \u003d mocked_list"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        marker \u003d models.MongoDBSchema(\u0027db1\u0027).serialize()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_91522a66","line":134,"updated":"2015-06-24 02:06:36.000000000","message":"Why do u need a mock for this.\n\nThis should be simply mocked_list\u003d[\u0027a\u0027, \u0027b\u0027, \u0027c\u0027]","commit_id":"56c03165335f90bb67b89ad315310683bbff87d8"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"3bf35a27c49604e47b2053c685f82fccb6de91f0","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    @mock.patch.object(service.MongoDBAdmin, \u0027_admin_user\u0027)"},{"line_number":132,"context_line":"    def test_list_databases(self, mocked_admin_user, mocked_client):"},{"line_number":133,"context_line":"        mocked_list \u003d mock.MagicMock("},{"line_number":134,"context_line":"            return_value\u003d[\u0027admin\u0027, \u0027local\u0027, \u0027db0\u0027, \u0027db1\u0027, \u0027db2\u0027, \u0027db3\u0027, \u0027db4\u0027])"},{"line_number":135,"context_line":"        mocked_client().__enter__().database_names \u003d mocked_list"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        marker \u003d models.MongoDBSchema(\u0027db1\u0027).serialize()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_d1a17c95","line":134,"in_reply_to":"fa32b979_91522a66","updated":"2015-06-24 12:52:40.000000000","message":"It is being used in the next line to replace the method \u0027database_names\u0027.\nThe list is set up this way to test that the special dbs (admin and local) are ignored and also the pagination of the results.","commit_id":"56c03165335f90bb67b89ad315310683bbff87d8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"88318d8886250b92bd03b8961bc6139c500f1b83","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    @mock.patch.object(service, \u0027MongoDBClient\u0027)"},{"line_number":131,"context_line":"    @mock.patch.object(service.MongoDBAdmin, \u0027_admin_user\u0027)"},{"line_number":132,"context_line":"    def test_list_databases(self, mocked_admin_user, mocked_client):"},{"line_number":133,"context_line":"        # This like contains the special \u0027admin\u0027 and \u0027local\u0027 dbs;"},{"line_number":134,"context_line":"        # the special dbs should be skipped in the output."},{"line_number":135,"context_line":"        # Pagination is tested by starting at \u0027db1\u0027, so \u0027db0\u0027 should not"},{"line_number":136,"context_line":"        # be in the output. The limit is set to 2, meaning the result"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_8f196f24","line":133,"updated":"2015-07-02 19:22:36.000000000","message":"NIT: remove \"like\"","commit_id":"665a5483760d62a790641dc97105d5824e05e579"}]}