)]}'
{"trove/common/template.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dc6f54d4ea4b1df25740806c0487874fcf50a06e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        context \u003d self.datastore_dict.copy()"},{"line_number":75,"context_line":"        context[\u0027template_name\u0027] \u003d self.template_name"},{"line_number":76,"context_line":"        names \u003d [name.format(**context) for name in patterns]"},{"line_number":77,"context_line":"        ENV.undefined \u003d jinja2.DebugUndefined"},{"line_number":78,"context_line":"        return ENV.select_template(names)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def render(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_4ab24e4d","line":77,"updated":"2015-06-19 06:59:25.000000000","message":"seems you forgot this one :)","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"}],"trove/guestagent/datastore/experimental/postgresql/pgutil.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dc6f54d4ea4b1df25740806c0487874fcf50a06e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027unix_socket_directory\u0027: \u0027/var/run/postgresql\u0027"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"    operating_system.REDHAT: {"},{"line_number":50,"context_line":"        \u0027base_data_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":51,"context_line":"        \u0027data_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":52,"context_line":"        \u0027base_conf_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":53,"context_line":"        \u0027conf_dir_postfix\u0027: \u0027data\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_0abd2601","line":50,"updated":"2015-06-19 06:59:25.000000000","message":"/var/lib/pgsql/","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"878e5287d861bb796cd63854e5bdd433c51253ee","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027unix_socket_directory\u0027: \u0027/var/run/postgresql\u0027"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"    operating_system.REDHAT: {"},{"line_number":50,"context_line":"        \u0027base_data_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":51,"context_line":"        \u0027data_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":52,"context_line":"        \u0027base_conf_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":53,"context_line":"        \u0027conf_dir_postfix\u0027: \u0027data\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_79611dd3","line":50,"in_reply_to":"fa32b979_0abd2601","updated":"2015-06-19 15:15:20.000000000","message":"Actually this is a problem I had to work around; I thought I had left a comment in the code about this but I guess I didn\u0027t.\n\nYou can see in the fedora-postgresql elements [1] i posted that I move everything from /var/lib/pgsql to /var/lib/postgresql. This is because I was having trouble getting it to work if it was not mounted on /var/lib/\u003cdatastore_name\u003e . If you are able to find a way to get the mount_point cfg option to cooperate please let me know how :)\n\n[1] https://review.openstack.org/#/c/188910/2/scripts/files/elements/fedora-postgresql/install.d/10-postgresql,cm","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dc6f54d4ea4b1df25740806c0487874fcf50a06e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"    operating_system.REDHAT: {"},{"line_number":50,"context_line":"        \u0027base_data_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":51,"context_line":"        \u0027data_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":52,"context_line":"        \u0027base_conf_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":53,"context_line":"        \u0027conf_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":54,"context_line":"        \u0027pid\u0027: \u0027/var/run/postgresql.pid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_a5f46bf0","line":51,"updated":"2015-06-19 06:59:25.000000000","message":"According to the docs for postgresql, for versions above to pgsql 9, the data directory is under the version directory, eg /var/lib/pgsql/9.4/data.\n\nUsing CentOS 7 I see the directory like /var/lib/pgsql/data, so that must be something of the postgres packages. I\u0027ll try them out to confirm.\n\nIs our policy to rely on packages provided by the distribution or on packages provided by the database vendors?","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"878e5287d861bb796cd63854e5bdd433c51253ee","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"    operating_system.REDHAT: {"},{"line_number":50,"context_line":"        \u0027base_data_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":51,"context_line":"        \u0027data_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":52,"context_line":"        \u0027base_conf_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":53,"context_line":"        \u0027conf_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":54,"context_line":"        \u0027pid\u0027: \u0027/var/run/postgresql.pid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_39a075a5","line":51,"in_reply_to":"fa32b979_a5f46bf0","updated":"2015-06-19 15:15:20.000000000","message":"This is a very good question. \n\nIt doesnt\u0027 seem that we have any standard for that, at least not in the elements files we have in redstack. I used the PGDG packages because you can easily choose which version you want to install, something which is not always possible with the distro-provided packages, but I don\u0027t know what problems may be associated with this (e.g. It seems that there are some file and directory differences)","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dc6f54d4ea4b1df25740806c0487874fcf50a06e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    operating_system.REDHAT: {"},{"line_number":50,"context_line":"        \u0027base_data_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":51,"context_line":"        \u0027data_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":52,"context_line":"        \u0027base_conf_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":53,"context_line":"        \u0027conf_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":54,"context_line":"        \u0027pid\u0027: \u0027/var/run/postgresql.pid\u0027,"},{"line_number":55,"context_line":"        \u0027client_bindir\u0027: \u0027/usr/pgsql-{version}/bin\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_65f66390","line":52,"updated":"2015-06-19 06:59:25.000000000","message":"/var/lib/pgsql","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dc6f54d4ea4b1df25740806c0487874fcf50a06e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u0027data_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":52,"context_line":"        \u0027base_conf_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":53,"context_line":"        \u0027conf_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":54,"context_line":"        \u0027pid\u0027: \u0027/var/run/postgresql.pid\u0027,"},{"line_number":55,"context_line":"        \u0027client_bindir\u0027: \u0027/usr/pgsql-{version}/bin\u0027,"},{"line_number":56,"context_line":"        \u0027unix_socket_directory\u0027: \u0027/tmp\u0027"},{"line_number":57,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_851e075d","line":54,"updated":"2015-06-19 06:59:25.000000000","message":"/var/lib/pgsql/data/postmaster.pid","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dc6f54d4ea4b1df25740806c0487874fcf50a06e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \u0027base_conf_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":53,"context_line":"        \u0027conf_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":54,"context_line":"        \u0027pid\u0027: \u0027/var/run/postgresql.pid\u0027,"},{"line_number":55,"context_line":"        \u0027client_bindir\u0027: \u0027/usr/pgsql-{version}/bin\u0027,"},{"line_number":56,"context_line":"        \u0027unix_socket_directory\u0027: \u0027/tmp\u0027"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_45755f61","line":55,"updated":"2015-06-19 06:59:25.000000000","message":"/usr/bin/psql","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"878e5287d861bb796cd63854e5bdd433c51253ee","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \u0027base_conf_dir\u0027: \u0027/var/lib/postgresql\u0027,"},{"line_number":53,"context_line":"        \u0027conf_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":54,"context_line":"        \u0027pid\u0027: \u0027/var/run/postgresql.pid\u0027,"},{"line_number":55,"context_line":"        \u0027client_bindir\u0027: \u0027/usr/pgsql-{version}/bin\u0027,"},{"line_number":56,"context_line":"        \u0027unix_socket_directory\u0027: \u0027/tmp\u0027"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_d99f094f","line":55,"in_reply_to":"fa32b979_45755f61","updated":"2015-06-19 15:15:20.000000000","message":"client_bindir is where I can find the psql client binaries (so not just psql, which is probably on the path, but also things like pg_isready which is a much better way of checking if the db is running)","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dc6f54d4ea4b1df25740806c0487874fcf50a06e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \u0027conf_dir_postfix\u0027: \u0027data\u0027,"},{"line_number":54,"context_line":"        \u0027pid\u0027: \u0027/var/run/postgresql.pid\u0027,"},{"line_number":55,"context_line":"        \u0027client_bindir\u0027: \u0027/usr/pgsql-{version}/bin\u0027,"},{"line_number":56,"context_line":"        \u0027unix_socket_directory\u0027: \u0027/tmp\u0027"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_c5d5ef1b","line":56,"updated":"2015-06-19 06:59:25.000000000","message":"/var/run/postgresql/","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dc6f54d4ea4b1df25740806c0487874fcf50a06e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"def get_psql_version():"},{"line_number":62,"context_line":"    \"\"\"Poll PgSql for the version number."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    Return value is a string representing the version number."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    LOG.debug("},{"line_number":67,"context_line":"        \"{guest_id}: Polling for postgresql version.\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_05c75764","line":64,"updated":"2015-06-19 06:59:25.000000000","message":"NIT\n\n   :return: version number\n   :rtype: string","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"878e5287d861bb796cd63854e5bdd433c51253ee","unresolved":false,"context_lines":[{"line_number":61,"context_line":"def get_psql_version():"},{"line_number":62,"context_line":"    \"\"\"Poll PgSql for the version number."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    Return value is a string representing the version number."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    LOG.debug("},{"line_number":67,"context_line":"        \"{guest_id}: Polling for postgresql version.\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f9ae8d80","line":64,"in_reply_to":"fa32b979_05c75764","updated":"2015-06-19 15:15:20.000000000","message":"Will fix :)","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"}],"trove/templates/postgresql/config.template":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dc6f54d4ea4b1df25740806c0487874fcf50a06e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"data_directory \u003d \u0027{{base_data_dir}}/{{datastore[\u0027version\u0027]}}/{{data_dir_postfix}}\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"hba_file \u003d \u0027{{base_conf_dir}}/{{datastore[\u0027version\u0027]}}/{{conf_dir_postfix}}/pg_hba.conf\u0027"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa32b979_65c8a355","line":1,"updated":"2015-06-19 06:59:25.000000000","message":"Seeing this, I see we are using the convention of putting data under the version directory. So maybe we should rely on the vendor packages.","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"878e5287d861bb796cd63854e5bdd433c51253ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"data_directory \u003d \u0027{{base_data_dir}}/{{datastore[\u0027version\u0027]}}/{{data_dir_postfix}}\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"hba_file \u003d \u0027{{base_conf_dir}}/{{datastore[\u0027version\u0027]}}/{{conf_dir_postfix}}/pg_hba.conf\u0027"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa32b979_592f79f6","line":1,"in_reply_to":"fa32b979_65c8a355","updated":"2015-06-19 15:15:20.000000000","message":"This is a good point. I just followed what would work with the PGDG packages for fedora/redhat and the ubuntu packages. Since we\u0027d probably not have more than one version of pgsql installed on any given trove guest, maybe it\u0027s not necessary.","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"}],"trove/tests/unittests/common/test_template.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dc6f54d4ea4b1df25740806c0487874fcf50a06e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        datastore \u003d Mock(spec\u003dDatastoreVersion)"},{"line_number":110,"context_line":"        datastore.datastore_name \u003d \u0027PostgreSQL\u0027"},{"line_number":111,"context_line":"        # \u0027name\u0027 really is version for some reason in SingleInstConfTemplate"},{"line_number":112,"context_line":"        datastore.name \u003d \u00279.4\u0027"},{"line_number":113,"context_line":"        # datastore.version \u003d \u00279.4\u0027"},{"line_number":114,"context_line":"        datastore.manager \u003d \u0027postgresql\u0027"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_850a8777","line":112,"updated":"2015-06-19 06:59:25.000000000","message":"is 9.4 going to be the version currently supported?","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"878e5287d861bb796cd63854e5bdd433c51253ee","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        datastore \u003d Mock(spec\u003dDatastoreVersion)"},{"line_number":110,"context_line":"        datastore.datastore_name \u003d \u0027PostgreSQL\u0027"},{"line_number":111,"context_line":"        # \u0027name\u0027 really is version for some reason in SingleInstConfTemplate"},{"line_number":112,"context_line":"        datastore.name \u003d \u00279.4\u0027"},{"line_number":113,"context_line":"        # datastore.version \u003d \u00279.4\u0027"},{"line_number":114,"context_line":"        datastore.manager \u003d \u0027postgresql\u0027"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_9973c115","line":112,"in_reply_to":"fa32b979_850a8777","updated":"2015-06-19 15:15:20.000000000","message":"Good catch :) It could be either 9.3 or 9.4, it just made for one less change to install 9.3 since the redstack script has 9.3 for postgresql kickstart","commit_id":"1ed660f401d340c16566c816b12b0fd6059150a8"}]}