)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1cac7aaee781fa5260d58bc33ad3b165e8f6e57b","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        # Initialize trove"},{"line_number":243,"context_line":"        init_trove"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"\t# finish the last step in trove network configuration"},{"line_number":246,"context_line":"\techo_summary \"Finalizing Trove Network Configuration\""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"\tif is_service_enabled neutron; then"},{"line_number":249,"context_line":"            echo \"finalize_trove_network: Neutron is enabled.\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            finalize_trove_network"},{"line_number":252,"context_line":"\telse"},{"line_number":253,"context_line":"            echo \"finalize_trove_network: Neutron is not enabled. Nothing to do.\""},{"line_number":254,"context_line":"\tfi"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        # Start the trove API and trove taskmgr components"},{"line_number":257,"context_line":"        echo_summary \"Starting Trove\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3afb71cf_b083f155","line":254,"range":{"start_line":245,"start_character":0,"end_line":254,"end_character":3},"updated":"2015-06-08 18:48:34.000000000","message":"Need to replace tabs with spaces","commit_id":"a5071dbd7cbe215c558762b379da26a208520d90"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"e7fe44faec97cfeec93ac90c90d6e39d21d24f51","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# finalize_trove_network() - do the last thing(s) before starting Trove"},{"line_number":195,"context_line":"function finalize_trove_network {"},{"line_number":196,"context_line":"    management_network_id\u003d$(neutron --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD net-list | grep $PRIVATE_NETWORK_NAME | awk \u0027{print $2}\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    echo \"finalize_trove_network: found network id $management_network_id\""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa32b979_69a9cb8f","line":196,"updated":"2015-06-17 08:52:15.000000000","message":"How does $PRIVATE_NETWORK_NAME get set?","commit_id":"19c088b5e0160155ef974a0e1e46a60e781fe225"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"00c947c286a963a238781f72ba807003c5e8e47e","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# finalize_trove_network() - do the last thing(s) before starting Trove"},{"line_number":195,"context_line":"function finalize_trove_network {"},{"line_number":196,"context_line":"    management_network_id\u003d$(neutron --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD net-list | grep $PRIVATE_NETWORK_NAME | awk \u0027{print $2}\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    echo \"finalize_trove_network: found network id $management_network_id\""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa32b979_4a571258","line":196,"in_reply_to":"fa32b979_69a9cb8f","updated":"2015-06-17 12:41:03.000000000","message":"In here https://github.com/openstack-dev/devstack/blob/master/stackrc#L618. This is executed after neutron so it should be set.","commit_id":"19c088b5e0160155ef974a0e1e46a60e781fe225"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e40098958f1a23905222b976f1b0e4082b2a9b56","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    iniset $TROVE_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":207,"context_line":"    iniset $TROVE_TASKMANAGER_CONF mysql tcp_ports 22,3306"},{"line_number":208,"context_line":"}"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"# start_trove() - Start running processes, including screen"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa32b979_d83d07c5","line":207,"updated":"2015-06-18 10:18:15.000000000","message":"it makes sense to add port 22 to Vertica group too, doesn\u0027t it?","commit_id":"19c088b5e0160155ef974a0e1e46a60e781fe225"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"69be182a9db4cfcbb53f6bfb43fea7cf0f80e788","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    iniset $TROVE_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":207,"context_line":"    iniset $TROVE_TASKMANAGER_CONF mysql tcp_ports 22,3306"},{"line_number":208,"context_line":"}"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"# start_trove() - Start running processes, including screen"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa32b979_141eba6f","line":207,"in_reply_to":"fa32b979_d83d07c5","updated":"2015-06-18 21:04:18.000000000","message":"I dont think it does because its already in the default conf.","commit_id":"19c088b5e0160155ef974a0e1e46a60e781fe225"}]}
