)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"e7cb3e397e640ae67e4d0c183b184a064c80296d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"oslo.service has graduated, so trove should consume it."},{"line_number":10,"context_line":"Replace a \"ticks_between_runs\u003d3\" parameter with \"spacing\u003d30\""},{"line_number":11,"context_line":"for the periodic tasks. According to the default value of"},{"line_number":12,"context_line":"the \"report_interval\" option, 3 tics are equal 30 seconds."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id14d28146f677faf017160ac93289fd119674fc4"},{"line_number":15,"context_line":"Depends-On: Ia5b887e69853f39b387d309831fb7ce51b881149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba3cc151_a09f04b3","line":12,"updated":"2015-07-01 07:00:03.000000000","message":"So i believe the report_interval is still used. this is set on the rpc service. \n\nhttps://github.com/openstack/trove/blob/5fe08a1f74b763d63bc2c1a3bc9a78574b5f27e1/trove/common/cfg.py#L79\n\nI think that needs to be verified or could cause some latent updates for all the guests and events triggered with the hard coded spacing of 30.","commit_id":"d47b00f8396e8891d576110d8dc0d0b8ab2126da"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"1645172352920cea8a83a1a848b0345a23e783a5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"and increase the default value of it to 3600, according to the old value of"},{"line_number":18,"context_line":"the \"report_interval\" option."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Id14d28146f677faf017160ac93289fd119674fc4"},{"line_number":23,"context_line":"Depends-On: Ia5b887e69853f39b387d309831fb7ce51b881149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba3cc151_104f9e92","line":20,"updated":"2015-07-09 19:41:33.000000000","message":"Could you put under the docimpact here that you changed the config name and that deployers need to make sure to set the report_interval in the guestagent.conf for the status update so that its not defaulted to 30 seconds?\n\nThis would be a good reminder of the impact that this change makes.","commit_id":"e853be8a53e1095f571563b196420a77687cc725"}],"requirements.txt":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bb71c6865cf82fee9526f2321291e40a5829b9c8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"jsonschema\u003e\u003d2.0.0,\u003c3.0.0,!\u003d2.5.0"},{"line_number":28,"context_line":"Jinja2\u003e\u003d2.6  # BSD License (3 clause)"},{"line_number":29,"context_line":"pexpect\u003e\u003d3.1,!\u003d3.3 # ISC License"},{"line_number":30,"context_line":"oslo.concurrency\u003e\u003d2.0.0         # Apache-2.0"},{"line_number":31,"context_line":"oslo.config\u003e\u003d1.11.0  # Apache-2.0"},{"line_number":32,"context_line":"oslo.i18n\u003e\u003d1.5.0  # Apache-2.0"},{"line_number":33,"context_line":"oslo.serialization\u003e\u003d1.4.0               # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"fa32b979_fa991b7a","line":30,"updated":"2015-06-23 19:50:10.000000000","message":"Why the re-ordering?","commit_id":"d64716d4389fe71772b67e95a45926e5d748491d"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"1e6e96dd53b569d53aab977b959e032a413f4991","unresolved":false,"context_lines":[{"line_number":27,"context_line":"jsonschema\u003e\u003d2.0.0,\u003c3.0.0,!\u003d2.5.0"},{"line_number":28,"context_line":"Jinja2\u003e\u003d2.6  # BSD License (3 clause)"},{"line_number":29,"context_line":"pexpect\u003e\u003d3.1,!\u003d3.3 # ISC License"},{"line_number":30,"context_line":"oslo.concurrency\u003e\u003d2.0.0         # Apache-2.0"},{"line_number":31,"context_line":"oslo.config\u003e\u003d1.11.0  # Apache-2.0"},{"line_number":32,"context_line":"oslo.i18n\u003e\u003d1.5.0  # Apache-2.0"},{"line_number":33,"context_line":"oslo.serialization\u003e\u003d1.4.0               # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"fa32b979_62f6b25e","line":30,"in_reply_to":"fa32b979_c79c7bc2","updated":"2015-06-24 04:28:36.000000000","message":"Yes. I did it to keep alphabetically this part.","commit_id":"d64716d4389fe71772b67e95a45926e5d748491d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"d92bf6cc96558218e040b4dfaf30e24a49a1ec47","unresolved":false,"context_lines":[{"line_number":27,"context_line":"jsonschema\u003e\u003d2.0.0,\u003c3.0.0,!\u003d2.5.0"},{"line_number":28,"context_line":"Jinja2\u003e\u003d2.6  # BSD License (3 clause)"},{"line_number":29,"context_line":"pexpect\u003e\u003d3.1,!\u003d3.3 # ISC License"},{"line_number":30,"context_line":"oslo.concurrency\u003e\u003d2.0.0         # Apache-2.0"},{"line_number":31,"context_line":"oslo.config\u003e\u003d1.11.0  # Apache-2.0"},{"line_number":32,"context_line":"oslo.i18n\u003e\u003d1.5.0  # Apache-2.0"},{"line_number":33,"context_line":"oslo.serialization\u003e\u003d1.4.0               # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"fa32b979_c79c7bc2","line":30,"in_reply_to":"fa32b979_fa991b7a","updated":"2015-06-23 20:38:30.000000000","message":"It looks like an attempt at alphabetization (which is heavily discouraged as it can cause things to break - see the comment at the start of the file).  If there\u0027s a valid reason to move it here, please let us know - otherwise I think it should be put back where it was.","commit_id":"d64716d4389fe71772b67e95a45926e5d748491d"}],"trove/cmd/conductor.py":[{"author":{"_account_id":12484,"name":"jazeltq","email":"tianqing@unitedstack.com","username":"litianqing"},"change_message_id":"d26763e2773d0a1faf292fb618300868a271a332","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@with_initialize"},{"line_number":21,"context_line":"def main(conf):"},{"line_number":22,"context_line":"    from oslo_service import service as openstack_service"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    from trove.common.rpc import service as rpc_service"},{"line_number":25,"context_line":"    from trove.common.rpc import version as rpc_version"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_529af215","line":22,"updated":"2015-06-29 11:02:15.000000000","message":"why put here? not like oslo_concurrency?","commit_id":"1825f4f80e37dc0d43091f017d7e871e286ca65a"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"053e4535cf8a0c88c290a1fc240e7a05ee4af2de","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@with_initialize"},{"line_number":21,"context_line":"def main(conf):"},{"line_number":22,"context_line":"    from oslo_service import service as openstack_service"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    from trove.common.rpc import service as rpc_service"},{"line_number":25,"context_line":"    from trove.common.rpc import version as rpc_version"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_7834b7dd","line":22,"in_reply_to":"ba3cc151_529af215","updated":"2015-06-29 12:29:29.000000000","message":"I just didn\u0027t modify the current logic of code.","commit_id":"1825f4f80e37dc0d43091f017d7e871e286ca65a"},{"author":{"_account_id":12484,"name":"jazeltq","email":"tianqing@unitedstack.com","username":"litianqing"},"change_message_id":"d2ad8fcd9eb766adb9c70e4961b81a288b8cf285","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@with_initialize"},{"line_number":21,"context_line":"def main(conf):"},{"line_number":22,"context_line":"    from oslo_service import service as openstack_service"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    from trove.common.rpc import service as rpc_service"},{"line_number":25,"context_line":"    from trove.common.rpc import version as rpc_version"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_e743426b","line":22,"updated":"2015-06-29 13:52:26.000000000","message":"why write here? And oslo_concurrency is outside?","commit_id":"31dcf52f6532d640fdb9035d73b3b2fd44b684de"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"cc6c6552a1528fc087dbc27835d1daac12c333d1","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@with_initialize"},{"line_number":21,"context_line":"def main(conf):"},{"line_number":22,"context_line":"    from oslo_service import service as openstack_service"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    from trove.common.rpc import service as rpc_service"},{"line_number":25,"context_line":"    from trove.common.rpc import version as rpc_version"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_1c8318ce","line":22,"in_reply_to":"ba3cc151_e743426b","updated":"2015-06-29 14:19:20.000000000","message":"Because the original was here and oslo_concurrency there. But, i think It is good idea to move","commit_id":"31dcf52f6532d640fdb9035d73b3b2fd44b684de"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"44c48b5eb21ac4e42090f704ff601cfb322a6c30","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@with_initialize"},{"line_number":21,"context_line":"def main(conf):"},{"line_number":22,"context_line":"    from oslo_service import service as openstack_service"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    from trove.common.rpc import service as rpc_service"},{"line_number":25,"context_line":"    from trove.common.rpc import version as rpc_version"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_8f628cd7","line":22,"in_reply_to":"ba3cc151_e743426b","updated":"2015-06-29 14:27:42.000000000","message":"Done","commit_id":"31dcf52f6532d640fdb9035d73b3b2fd44b684de"}],"trove/cmd/taskmanager.py":[{"author":{"_account_id":12484,"name":"jazeltq","email":"tianqing@unitedstack.com","username":"litianqing"},"change_message_id":"39acf548abd0407332c86b80977726ba8366af11","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def startup(conf, topic):"},{"line_number":23,"context_line":"    from oslo_service import service as openstack_service"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    from trove.common.rpc import service as rpc_service"},{"line_number":26,"context_line":"    from trove.common.rpc import version as rpc_version"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_4fe9e419","line":23,"updated":"2015-06-29 14:30:34.000000000","message":"same","commit_id":"ff94354c859a6361e04c2861a09f55a02e65b9b8"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"56362297191e701c1af207deaab2796781b172e0","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def startup(conf, topic):"},{"line_number":23,"context_line":"    from oslo_service import service as openstack_service"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    from trove.common.rpc import service as rpc_service"},{"line_number":26,"context_line":"    from trove.common.rpc import version as rpc_version"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_2f034075","line":23,"in_reply_to":"ba3cc151_4fe9e419","updated":"2015-06-29 14:38:53.000000000","message":"Done. Thank you","commit_id":"ff94354c859a6361e04c2861a09f55a02e65b9b8"}],"trove/common/rpc/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bb71c6865cf82fee9526f2321291e40a5829b9c8","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import inspect"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import oslo_messaging as messaging"},{"line_number":23,"context_line":"from oslo_service import loopingcall"},{"line_number":24,"context_line":"from oslo_service import service"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_da7457ff","line":21,"updated":"2015-06-23 19:50:10.000000000","message":"Thank you!","commit_id":"d64716d4389fe71772b67e95a45926e5d748491d"}],"trove/taskmanager/manager.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"e7cb3e397e640ae67e4d0c183b184a064c80296d","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        cluster_tasks.delete_cluster(context, cluster_id)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    if CONF.exists_notification_transformer:"},{"line_number":350,"context_line":"        @periodic_task.periodic_task(spacing\u003d30)"},{"line_number":351,"context_line":"        def publish_exists_event(self, context):"},{"line_number":352,"context_line":"            \"\"\""},{"line_number":353,"context_line":"            Push this in Instance Tasks to fetch a report/collection"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_15c71046","line":350,"updated":"2015-07-01 07:00:03.000000000","message":"This spacing should be set in the configuration as exists_notification_ticks or updated with a new field.\n\nThis will also require a docimpact for updating the config for deployer to know that this value changed what it means since report_interval is not set any longer.","commit_id":"d47b00f8396e8891d576110d8dc0d0b8ab2126da"}]}