)]}'
{"trove/common/strategies/cluster/experimental/mongodb/taskmanager.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"cdd814ac63aa0c9ea9242c19b92363cb59d74bc9","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        LOG.debug(\"Making async call to add shard cluster %s \" % cluster_id)"},{"line_number":231,"context_line":"        cctxt \u003d self.client.prepare(version\u003dself.version_cap)"},{"line_number":232,"context_line":"        cctxt.cast(self.context,"},{"line_number":233,"context_line":"                   \"add_shard_cluster\","},{"line_number":234,"context_line":"                   cluster_id\u003dcluster_id,"},{"line_number":235,"context_line":"                   shard_id\u003dshard_id,"},{"line_number":236,"context_line":"                   replica_set_name\u003dreplica_set_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_ec0c903d","line":233,"updated":"2015-07-05 07:02:53.000000000","message":"this does not resembles to https://github.com/openstack/trove/blob/master/trove/common/strategies/cluster/experimental/mongodb/api.py#L219","commit_id":"b98578b152d339b9a032fff6de4830f06b0eaf7b"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"d8a333d348209568cf97763556ba22fd7c9bb4e5","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        LOG.debug(\"Making async call to add shard cluster %s \" % cluster_id)"},{"line_number":231,"context_line":"        cctxt \u003d self.client.prepare(version\u003dself.version_cap)"},{"line_number":232,"context_line":"        cctxt.cast(self.context,"},{"line_number":233,"context_line":"                   \"add_shard_cluster\","},{"line_number":234,"context_line":"                   cluster_id\u003dcluster_id,"},{"line_number":235,"context_line":"                   shard_id\u003dshard_id,"},{"line_number":236,"context_line":"                   replica_set_name\u003dreplica_set_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_e3a2459a","line":233,"in_reply_to":"ba3cc151_ec0c903d","updated":"2015-07-06 13:20:25.000000000","message":"Nope, because that line calls this function (line 228).\n\nThis cast calls the function above this (line 179).\n\nThus the bug...","commit_id":"b98578b152d339b9a032fff6de4830f06b0eaf7b"}],"trove/tests/unittests/cluster/test_cluster.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"d21c0f04021c5242d2553ee7541bfce89b4a6b75","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        self.cluster.add_shard()"},{"line_number":210,"context_line":"        mock_update_db.assert_called_with("},{"line_number":211,"context_line":"            task_status\u003dClusterTasks.ADDING_SHARD)"},{"line_number":212,"context_line":"        mock_task_api.mongodb_add_shard_cluster.assert_called()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_66ad7f9a","line":212,"updated":"2015-07-08 07:49:44.000000000","message":"I believe this is just calling a random mock method which isn\u0027t actually doing anything. You probably want to use something like assert_called_with. More details on valid asserts for Mock are here: http://www.voidspace.org.uk/python/mock/mock.html","commit_id":"533cfb8e3bd508e4beee72f9942377cfef058bad"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"e84aed9bab5fb6454dbf2731eec369ddf13aaa42","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        self.cluster.add_shard()"},{"line_number":210,"context_line":"        mock_update_db.assert_called_with("},{"line_number":211,"context_line":"            task_status\u003dClusterTasks.ADDING_SHARD)"},{"line_number":212,"context_line":"        mock_task_api.mongodb_add_shard_cluster.assert_called()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_ab7a6bef","line":212,"in_reply_to":"ba3cc151_66ad7f9a","updated":"2015-07-08 10:18:52.000000000","message":"there is no such method as \u003cmock_object\u003e.method.assert_called\n\nIf you want to test method call probable options are assert_any_call, assert_called_with","commit_id":"533cfb8e3bd508e4beee72f9942377cfef058bad"}]}