)]}'
{"trove/tests/unittests/guestagent/test_dbaas.py":[{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"d3aec8fa2c6bbadae5cd8f1561102973ad3ebf0d","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":345,"context_line":"                    self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027,"},{"line_number":346,"context_line":"                                                      user_attrs)"},{"line_number":347,"context_line":"                    self.assertEqual(1, self.mySqlAdmin.grant_access.call_count)"},{"line_number":348,"context_line":"            args, _ \u003d dbaas.LocalSqlClient.execute.call_args_list[1]"},{"line_number":349,"context_line":"            expected \u003d (\"UPDATE mysql.user SET Password\u003d\""},{"line_number":350,"context_line":"                        \"PASSWORD(\u0027password\u0027) WHERE User \u003d \u0027test_user\u0027 \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_9ece4c59","line":347,"updated":"2015-07-11 13:32:00.000000000","message":"pep8 said this line is too long (80 \u003e 79 characters).\nThis can be fixed like following:\n\nself.assertEqual(1,\n           self.mySqlAdmin.grant_access.call_count)","commit_id":"4bebd1299d457dd80c1e02913735a0ffcabbe396"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a4b786dbc5d2c9c414abe7acfed82f8045842de","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                          Mock(return_value\u003ddb_result)):"},{"line_number":343,"context_line":"            with patch.object(self.mySqlAdmin, \u0027_get_user\u0027, return_value\u003duser):"},{"line_number":344,"context_line":"                with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":345,"context_line":"                    self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027,"},{"line_number":346,"context_line":"                                                      user_attrs)"},{"line_number":347,"context_line":"                    self.assertEqual(1,"},{"line_number":348,"context_line":"                                     self.mySqlAdmin.grant_access.call_count)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_314b7889","line":345,"updated":"2015-07-13 13:52:02.000000000","message":"This is \"test_usr\" not \"test_user\"...","commit_id":"5c5c69f132a7eb3df5f0d91c176cac4da53a587d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"a41c235540a3d6b73a17bcdfee61eb1ec308cc0f","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                          Mock(return_value\u003ddb_result)):"},{"line_number":343,"context_line":"            with patch.object(self.mySqlAdmin, \u0027_get_user\u0027, return_value\u003duser):"},{"line_number":344,"context_line":"                with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":345,"context_line":"                    self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027,"},{"line_number":346,"context_line":"                                                      user_attrs)"},{"line_number":347,"context_line":"                    self.assertEqual(1,"},{"line_number":348,"context_line":"                                     self.mySqlAdmin.grant_access.call_count)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_e5f46588","line":345,"in_reply_to":"9a41bdd9_314b7889","updated":"2015-07-13 16:19:59.000000000","message":"Would it make sense to change this to:\n\n  self.mySqlAdmin.update_attributes(user.name, user.host,\n\nto avoid typos?","commit_id":"5c5c69f132a7eb3df5f0d91c176cac4da53a587d"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"2b41fd407944e655c184a74984fe3b1aa42b2f03","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":345,"context_line":"                    self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027,"},{"line_number":346,"context_line":"                                                      user_attrs)"},{"line_number":347,"context_line":"                    self.assertEqual(1,"},{"line_number":348,"context_line":"                                     self.mySqlAdmin.grant_access.call_count)"},{"line_number":349,"context_line":"            args, _ \u003d dbaas.LocalSqlClient.execute.call_args_list[1]"},{"line_number":350,"context_line":"            expected \u003d (\"UPDATE mysql.user SET Password\u003d\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_37c163e5","line":347,"updated":"2015-07-12 00:00:19.000000000","message":"i\u0027m confused why this is now set to a call count of 1 now and before it was checked that it was not called. Did the method before just never work right?","commit_id":"5c5c69f132a7eb3df5f0d91c176cac4da53a587d"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a4b786dbc5d2c9c414abe7acfed82f8045842de","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":345,"context_line":"                    self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027,"},{"line_number":346,"context_line":"                                                      user_attrs)"},{"line_number":347,"context_line":"                    self.assertEqual(1,"},{"line_number":348,"context_line":"                                     self.mySqlAdmin.grant_access.call_count)"},{"line_number":349,"context_line":"            args, _ \u003d dbaas.LocalSqlClient.execute.call_args_list[1]"},{"line_number":350,"context_line":"            expected \u003d (\"UPDATE mysql.user SET Password\u003d\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_ec09b72d","line":347,"in_reply_to":"9a41bdd9_37c163e5","updated":"2015-07-13 13:52:02.000000000","message":"... and for that reason grant_access is called once. I don\u0027t think its the intended behavior. It\u0027s not part of this patch, but if we could fix it here it would be awesome.","commit_id":"5c5c69f132a7eb3df5f0d91c176cac4da53a587d"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"bdf4ca9cbf1ef54522f608fabb6bc2bae8eba8a6","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":345,"context_line":"                    self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027,"},{"line_number":346,"context_line":"                                                      user_attrs)"},{"line_number":347,"context_line":"                    self.assertEqual(1,"},{"line_number":348,"context_line":"                                     self.mySqlAdmin.grant_access.call_count)"},{"line_number":349,"context_line":"            args, _ \u003d dbaas.LocalSqlClient.execute.call_args_list[1]"},{"line_number":350,"context_line":"            expected \u003d (\"UPDATE mysql.user SET Password\u003d\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_58cf2f7f","line":347,"in_reply_to":"9a41bdd9_525e3013","updated":"2015-07-13 18:23:11.000000000","message":"So there\u0027s definitely something fishy going on here. How can it work for asserting self.assertEqual(0, ...) and self.assertEqual(1, ...)?","commit_id":"5c5c69f132a7eb3df5f0d91c176cac4da53a587d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"e17c19a53f097e98f5364ad909130d008947e1ae","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":345,"context_line":"                    self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027,"},{"line_number":346,"context_line":"                                                      user_attrs)"},{"line_number":347,"context_line":"                    self.assertEqual(1,"},{"line_number":348,"context_line":"                                     self.mySqlAdmin.grant_access.call_count)"},{"line_number":349,"context_line":"            args, _ \u003d dbaas.LocalSqlClient.execute.call_args_list[1]"},{"line_number":350,"context_line":"            expected \u003d (\"UPDATE mysql.user SET Password\u003d\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_525e3013","line":347,"in_reply_to":"9a41bdd9_ec09b72d","updated":"2015-07-13 17:24:14.000000000","message":"I just tested this with the change I mentioned above, and it works if you put back the original check for not called, i.e.:\n\n  self.assertEqual(0,","commit_id":"5c5c69f132a7eb3df5f0d91c176cac4da53a587d"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"e00f59e6bb95d0cb93caf59f9e576da3158909d9","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        user_attrs \u003d {\"name\": \"new_name\"}"},{"line_number":364,"context_line":"        with patch.object(self.mySqlAdmin, \u0027_get_user\u0027, return_value\u003duser):"},{"line_number":365,"context_line":"            with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":366,"context_line":"                self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027, user_attrs)"},{"line_number":367,"context_line":"                self.mySqlAdmin.grant_access.assert_called_with("},{"line_number":368,"context_line":"                    \u0027new_name\u0027, \u0027%\u0027, set([]))"},{"line_number":369,"context_line":"        args, _ \u003d dbaas.LocalSqlClient.execute.call_args_list[1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_83d9cc85","line":366,"updated":"2015-07-13 18:40:18.000000000","message":"what about this one?","commit_id":"e49deeb7b5c58ab21d02ee28aa83e57ed76cae67"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"e00f59e6bb95d0cb93caf59f9e576da3158909d9","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        user_attrs \u003d {\"host\": \"new_host\"}"},{"line_number":383,"context_line":"        with patch.object(self.mySqlAdmin, \u0027_get_user\u0027, return_value\u003duser):"},{"line_number":384,"context_line":"            with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":385,"context_line":"                self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027, user_attrs)"},{"line_number":386,"context_line":"                self.mySqlAdmin.grant_access.assert_called_with("},{"line_number":387,"context_line":"                    \u0027test_usr\u0027, \u0027new_host\u0027, set([]))"},{"line_number":388,"context_line":"        args, _ \u003d dbaas.LocalSqlClient.execute.call_args_list[1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_43e3c433","line":385,"updated":"2015-07-13 18:40:18.000000000","message":"and here?","commit_id":"e49deeb7b5c58ab21d02ee28aa83e57ed76cae67"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"75838aaf776759a2026ec9570f5238935d89d84d","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":385,"context_line":"                self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027, user_attrs)"},{"line_number":386,"context_line":"                self.mySqlAdmin.grant_access.assert_called_with("},{"line_number":387,"context_line":"                    \u0027test_usr\u0027, \u0027new_host\u0027, set([]))"},{"line_number":388,"context_line":"        args, _ \u003d dbaas.LocalSqlClient.execute.call_args_list[1]"},{"line_number":389,"context_line":"        expected \u003d (\"UPDATE mysql.user SET Host\u003d\u0027new_host\u0027 \""},{"line_number":390,"context_line":"                    \"WHERE User \u003d \u0027test_user\u0027 AND Host \u003d \u0027%\u0027;\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_a3ddf043","line":387,"updated":"2015-07-13 18:43:20.000000000","message":"this as well probably needs to change.\n\nI think the idea that Peter had using the `user.name` might help with these silly typos.","commit_id":"e49deeb7b5c58ab21d02ee28aa83e57ed76cae67"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"6dbe0ecb4267b10edce46c3cb8fe87d9e8b7245c","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            with patch.object(self.mySqlAdmin, \u0027grant_access\u0027):"},{"line_number":385,"context_line":"                self.mySqlAdmin.update_attributes(\u0027test_usr\u0027, \u0027%\u0027, user_attrs)"},{"line_number":386,"context_line":"                self.mySqlAdmin.grant_access.assert_called_with("},{"line_number":387,"context_line":"                    \u0027test_usr\u0027, \u0027new_host\u0027, set([]))"},{"line_number":388,"context_line":"        args, _ \u003d dbaas.LocalSqlClient.execute.call_args_list[1]"},{"line_number":389,"context_line":"        expected \u003d (\"UPDATE mysql.user SET Host\u003d\u0027new_host\u0027 \""},{"line_number":390,"context_line":"                    \"WHERE User \u003d \u0027test_user\u0027 AND Host \u003d \u0027%\u0027;\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_43c0a42a","line":387,"in_reply_to":"9a41bdd9_a3ddf043","updated":"2015-07-13 18:47:29.000000000","message":"Yeah, there seems to be bunch of these.  What say we push this up as-is and then put in a bug to fix the tests?","commit_id":"e49deeb7b5c58ab21d02ee28aa83e57ed76cae67"}]}