)]}'
{"requirements.txt":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[{"line_number":30,"context_line":"pexpect!\u003d3.3,\u003e\u003d3.1 # ISC License"},{"line_number":31,"context_line":"oslo.config\u003e\u003d1.11.0 # Apache-2.0"},{"line_number":32,"context_line":"oslo.i18n\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":33,"context_line":"oslo.log\u003e\u003d1.6.0 # Apache-2.0"},{"line_number":34,"context_line":"oslo.serialization\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":35,"context_line":"oslo.service\u003e\u003d0.1.0 # Apache-2.0"},{"line_number":36,"context_line":"oslo.utils\u003e\u003d1.9.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":6,"id":"3a50d1a3_ee80488d","line":33,"updated":"2015-07-23 02:42:02.000000000","message":"thee don\u0027t have to be alpha sorted; I\u0027d suggest adding at end of the file.","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6146e24314766299175bad84c2ee1f42444aeb85","unresolved":false,"context_lines":[{"line_number":30,"context_line":"pexpect!\u003d3.3,\u003e\u003d3.1 # ISC License"},{"line_number":31,"context_line":"oslo.config\u003e\u003d1.11.0 # Apache-2.0"},{"line_number":32,"context_line":"oslo.i18n\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":33,"context_line":"oslo.log\u003e\u003d1.6.0 # Apache-2.0"},{"line_number":34,"context_line":"oslo.serialization\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":35,"context_line":"oslo.service\u003e\u003d0.1.0 # Apache-2.0"},{"line_number":36,"context_line":"oslo.utils\u003e\u003d1.9.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":6,"id":"3a50d1a3_bf2ee8f8","line":33,"in_reply_to":"3a50d1a3_ee80488d","updated":"2015-07-23 05:13:46.000000000","message":"Done","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"}],"trove/common/base_wsgi.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import datetime"},{"line_number":24,"context_line":"import errno"},{"line_number":25,"context_line":"import logging"},{"line_number":26,"context_line":"import socket"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_2e107056","line":25,"updated":"2015-07-23 02:42:02.000000000","message":"you import all of logging just for logging.INFO? Just a question, not suggesting there\u0027s a better way of doing it; merely inquiring why we added logging here ...","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6146e24314766299175bad84c2ee1f42444aeb85","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import datetime"},{"line_number":24,"context_line":"import errno"},{"line_number":25,"context_line":"import logging"},{"line_number":26,"context_line":"import socket"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_b515a79c","line":25,"in_reply_to":"3a50d1a3_2e107056","updated":"2015-07-23 05:13:46.000000000","message":"Done","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import eventlet.wsgi"},{"line_number":31,"context_line":"from oslo_config import cfg"},{"line_number":32,"context_line":"from oslo_log import log as os_logging"},{"line_number":33,"context_line":"from oslo_service import service"},{"line_number":34,"context_line":"from oslo_service import sslutils"},{"line_number":35,"context_line":"import routes"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_a1025108","line":32,"updated":"2015-07-23 02:42:02.000000000","message":"may I suggest a name other than os_logging. The implication of the name is that this is os.logging or some such thing. oslo_logging would be easier to follow.\n\nOptionally since all other locations use logging as the name, can you change the earlier import of logging to have a different name\n\nimport logging as system_logging and reference system_logging.INFO?","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6146e24314766299175bad84c2ee1f42444aeb85","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import eventlet.wsgi"},{"line_number":31,"context_line":"from oslo_config import cfg"},{"line_number":32,"context_line":"from oslo_log import log as os_logging"},{"line_number":33,"context_line":"from oslo_service import service"},{"line_number":34,"context_line":"from oslo_service import sslutils"},{"line_number":35,"context_line":"import routes"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_b57cc7ec","line":32,"in_reply_to":"3a50d1a3_a1025108","updated":"2015-07-23 05:13:46.000000000","message":"Done","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d35e132cf7a355ad966f1bc89b50969d6e7c89d3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    eventlet.wsgi.server(sock, application, **kwargs)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class WritableLogger(object):"},{"line_number":70,"context_line":"    \"\"\"A thin wrapper that responds to `write` and logs.\"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def __init__(self, logger, level\u003dsystem_logging.INFO):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_5adf8468","line":69,"updated":"2015-07-29 20:40:28.000000000","message":"Not in this patch set, but this should be in a different place (perhaps a common.py)","commit_id":"19862628e43296686344a1dff5db495638a1a995"}],"trove/common/extensions.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import abc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from lxml import etree"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":"import routes"},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":"import stevedore"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_c12c3d9b","line":19,"updated":"2015-07-23 02:42:02.000000000","message":"I believe this is in the wrong section of imports. But I may be wrong.","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6146e24314766299175bad84c2ee1f42444aeb85","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import abc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from lxml import etree"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":"import routes"},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":"import stevedore"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_f0b81d2c","line":19,"in_reply_to":"3a50d1a3_c12c3d9b","updated":"2015-07-23 05:13:46.000000000","message":"This section is for the external libraries, the oslo_log is external. This is correct place.","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"}],"trove/db/sqlalchemy/migrate_repo/versions/028_recreate_agent_heartbeat.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from sqlalchemy.exc import OperationalError"},{"line_number":17,"context_line":"from sqlalchemy.schema import Column"},{"line_number":18,"context_line":"from sqlalchemy.schema import MetaData"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import Boolean"},{"line_number":21,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import create_tables"},{"line_number":22,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import DateTime"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_4167cde8","line":19,"updated":"2015-07-23 02:42:02.000000000","message":"thank you!","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6146e24314766299175bad84c2ee1f42444aeb85","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from sqlalchemy.exc import OperationalError"},{"line_number":17,"context_line":"from sqlalchemy.schema import Column"},{"line_number":18,"context_line":"from sqlalchemy.schema import MetaData"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import Boolean"},{"line_number":21,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import create_tables"},{"line_number":22,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import DateTime"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_707bad7b","line":19,"in_reply_to":"3a50d1a3_4167cde8","updated":"2015-07-23 05:13:46.000000000","message":"you are welcome :)","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"}],"trove/extensions/routes/mgmt.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from trove.common import extensions"},{"line_number":18,"context_line":"from trove.extensions.mgmt.clusters.service import MgmtClusterController"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_617be97b","line":15,"updated":"2015-07-23 02:42:02.000000000","message":"may we have a blank line above this please!","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6146e24314766299175bad84c2ee1f42444aeb85","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from trove.common import extensions"},{"line_number":18,"context_line":"from trove.extensions.mgmt.clusters.service import MgmtClusterController"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_90f519ee","line":15,"in_reply_to":"3a50d1a3_617be97b","updated":"2015-07-23 05:13:46.000000000","message":"Done","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"}],"trove/extensions/security_group/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from trove.common import cfg"},{"line_number":19,"context_line":"from trove.common import exception"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_018b0569","line":16,"updated":"2015-07-23 02:42:02.000000000","message":"a blank line above please!","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6146e24314766299175bad84c2ee1f42444aeb85","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from trove.common import cfg"},{"line_number":19,"context_line":"from trove.common import exception"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_d0ef211c","line":16,"in_reply_to":"3a50d1a3_018b0569","updated":"2015-07-23 05:13:46.000000000","message":"Done","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"}],"trove/guestagent/strategies/restore/base.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"from eventlet.green import subprocess"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from trove.common import cfg"},{"line_number":21,"context_line":"from trove.common import utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_21c881a5","line":18,"updated":"2015-07-23 02:42:02.000000000","message":"in other places I think you group oslo_log with eventlet?\n\nsee trove/guestagent/strategies/restore/experimental/postgresql_impl.py","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6146e24314766299175bad84c2ee1f42444aeb85","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"from eventlet.green import subprocess"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from trove.common import cfg"},{"line_number":21,"context_line":"from trove.common import utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_10b90915","line":18,"in_reply_to":"3a50d1a3_21c881a5","updated":"2015-07-23 05:13:46.000000000","message":"I didn\u0027t group especially with eventlet, but you are right, an error is here, eventless and oslo should be in one section.\n\nDone","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"}],"trove/guestagent/strategies/restore/experimental/mongo_impl.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"from oslo_utils import netutils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from trove.common import cfg"},{"line_number":22,"context_line":"from trove.common import utils"},{"line_number":23,"context_line":"from trove.guestagent.common import operating_system"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_6140c907","line":20,"updated":"2015-07-23 02:42:02.000000000","message":"thank you!","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6146e24314766299175bad84c2ee1f42444aeb85","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"from oslo_utils import netutils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from trove.common import cfg"},{"line_number":22,"context_line":"from trove.common import utils"},{"line_number":23,"context_line":"from trove.guestagent.common import operating_system"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_50947141","line":20,"in_reply_to":"3a50d1a3_6140c907","updated":"2015-07-23 05:13:46.000000000","message":"you are welcome","commit_id":"e60d2b67833a22f0bfed6f62b62aa6922ff20096"}],"trove/openstack/common/log.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 OpenStack Foundation."},{"line_number":2,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":3,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_610e89e6","side":"PARENT","line":1,"updated":"2015-07-23 02:42:02.000000000","message":"I don\u0027t like this but the OSLO team is OK with this kind of delete. I foresee problems with the o.i sync.","commit_id":"7b6e086c399597b80f90759d2627498083006fd5"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6146e24314766299175bad84c2ee1f42444aeb85","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 OpenStack Foundation."},{"line_number":2,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":3,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_d032c1a6","side":"PARENT","line":1,"in_reply_to":"3a50d1a3_610e89e6","updated":"2015-07-23 05:13:46.000000000","message":"Trove don\u0027t need the o.i. libraries, i made the series of the patches to remove the openstack.common package.","commit_id":"7b6e086c399597b80f90759d2627498083006fd5"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a37cff470dd2d028cd9c0d2e1506493f0b342fac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a50d1a3_21fde1b3","side":"PARENT","line":719,"updated":"2015-07-23 02:42:02.000000000","message":"I don\u0027t like this but the oslo folks seem to think it is OK. I foresee problems when we do the next o.i sync.","commit_id":"7b6e086c399597b80f90759d2627498083006fd5"}]}