)]}'
{"trove/common/template.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd37192dc5c5b8ed52adf36ae3450cdd14dfbe86","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"ENV \u003d utils.ENV"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# TODO(cp16net) Maybe this should be moved to a config dict"},{"line_number":33,"context_line":"SERVICE_PARSERS \u003d {"},{"line_number":34,"context_line":"    \u0027mongodb\u0027: configurations.MongoDBConfParser,"},{"line_number":35,"context_line":"    \u0027mysql\u0027: configurations.MySQLConfParser,"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a5ae5dd_421a3319","line":32,"updated":"2016-02-03 07:00:56.000000000","message":"Can you remove this comment because it doesnt seem to serve a purpose as these should not need to be configured.","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"b4ce8c554869664a49aa6e0be4cde7d156cc38a4","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"ENV \u003d utils.ENV"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# TODO(cp16net) Maybe this should be moved to a config dict"},{"line_number":33,"context_line":"SERVICE_PARSERS \u003d {"},{"line_number":34,"context_line":"    \u0027mongodb\u0027: configurations.MongoDBConfParser,"},{"line_number":35,"context_line":"    \u0027mysql\u0027: configurations.MySQLConfParser,"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a5ae5dd_faf163ce","line":32,"in_reply_to":"5a5ae5dd_421a3319","updated":"2016-02-03 18:24:49.000000000","message":"Done","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"}],"trove/guestagent/datastore/experimental/cassandra/service.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd37192dc5c5b8ed52adf36ae3450cdd14dfbe86","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        updates \u003d {"},{"line_number":248,"context_line":"            \u0027cluster_name\u0027: CONF.guest_id,"},{"line_number":249,"context_line":"            \u0027authenticator\u0027: \u0027org.apache.cassandra.auth.PasswordAuthenticator\u0027,"},{"line_number":250,"context_line":"            \u0027authorizer\u0027: \u0027org.apache.cassandra.auth.CassandraAuthorizer\u0027,"},{"line_number":251,"context_line":"            \u0027rpc_address\u0027: \"0.0.0.0\","},{"line_number":252,"context_line":"            \u0027broadcast_rpc_address\u0027: netutils.get_my_ipv4(),"},{"line_number":253,"context_line":"            \u0027listen_address\u0027: netutils.get_my_ipv4(),"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a5ae5dd_e2b8ffe7","line":250,"updated":"2016-02-03 07:00:56.000000000","message":"these configs for auth are the default i thought now?","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"b0fbca5fe9960fd9fd36aea5a16e13efd1e07bdf","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        updates \u003d {"},{"line_number":248,"context_line":"            \u0027cluster_name\u0027: CONF.guest_id,"},{"line_number":249,"context_line":"            \u0027authenticator\u0027: \u0027org.apache.cassandra.auth.PasswordAuthenticator\u0027,"},{"line_number":250,"context_line":"            \u0027authorizer\u0027: \u0027org.apache.cassandra.auth.CassandraAuthorizer\u0027,"},{"line_number":251,"context_line":"            \u0027rpc_address\u0027: \"0.0.0.0\","},{"line_number":252,"context_line":"            \u0027broadcast_rpc_address\u0027: netutils.get_my_ipv4(),"},{"line_number":253,"context_line":"            \u0027listen_address\u0027: netutils.get_my_ipv4(),"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a57f1b5_e12b2132","line":250,"in_reply_to":"5a5ae5dd_3ae85be2","updated":"2016-02-12 20:45:09.000000000","message":"yeah ok i get the reasoning.","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"b4ce8c554869664a49aa6e0be4cde7d156cc38a4","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        updates \u003d {"},{"line_number":248,"context_line":"            \u0027cluster_name\u0027: CONF.guest_id,"},{"line_number":249,"context_line":"            \u0027authenticator\u0027: \u0027org.apache.cassandra.auth.PasswordAuthenticator\u0027,"},{"line_number":250,"context_line":"            \u0027authorizer\u0027: \u0027org.apache.cassandra.auth.CassandraAuthorizer\u0027,"},{"line_number":251,"context_line":"            \u0027rpc_address\u0027: \"0.0.0.0\","},{"line_number":252,"context_line":"            \u0027broadcast_rpc_address\u0027: netutils.get_my_ipv4(),"},{"line_number":253,"context_line":"            \u0027listen_address\u0027: netutils.get_my_ipv4(),"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a5ae5dd_3ae85be2","line":250,"in_reply_to":"5a5ae5dd_e2b8ffe7","updated":"2016-02-03 18:24:49.000000000","message":"Well, the Cassandra\u0027s defaults are:\n\nauthenticator: AllowAllAuthenticator\nauthorizer: AllowAllAuthorizer\n\nWe needed to turn these on in order to support user functions. Provided that they are now defined in the template these two lines are no longer needed. I guess, they were included here to prevent anybody from disabling them via the template as it would very likely result in provisioning errors (not even considering the whole user support bit).\n\nIf we trust operators sufficiently enough :-) , we may safely remove them from here (we should then document that authentication/authorization need to be enabled in order for guest-agent to work).","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd37192dc5c5b8ed52adf36ae3450cdd14dfbe86","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            \u0027authorizer\u0027: \u0027org.apache.cassandra.auth.CassandraAuthorizer\u0027,"},{"line_number":251,"context_line":"            \u0027rpc_address\u0027: \"0.0.0.0\","},{"line_number":252,"context_line":"            \u0027broadcast_rpc_address\u0027: netutils.get_my_ipv4(),"},{"line_number":253,"context_line":"            \u0027listen_address\u0027: netutils.get_my_ipv4(),"},{"line_number":254,"context_line":"            \u0027seed_provider\u0027: {\u0027parameters\u0027:"},{"line_number":255,"context_line":"                              [{\u0027seeds\u0027: netutils.get_my_ipv4()}]"},{"line_number":256,"context_line":"                              }"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a5ae5dd_e286bf12","line":253,"range":{"start_line":253,"start_character":30,"end_line":253,"end_character":52},"updated":"2016-02-03 07:00:56.000000000","message":"\u003cmental note\u003e\n\noh man this is going to be another issue because the ip that is returned may not be the network that the user chose to put the instance on with the --nics \"net-id\u003d\u003cuuid\u003e\" on create...\n\ni found this for mongo and some other datastores as well.\n\nopened a bug on this so i dont forget.\nhttps://bugs.launchpad.net/trove/+bug/1541222","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"b0fbca5fe9960fd9fd36aea5a16e13efd1e07bdf","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            \u0027authorizer\u0027: \u0027org.apache.cassandra.auth.CassandraAuthorizer\u0027,"},{"line_number":251,"context_line":"            \u0027rpc_address\u0027: \"0.0.0.0\","},{"line_number":252,"context_line":"            \u0027broadcast_rpc_address\u0027: netutils.get_my_ipv4(),"},{"line_number":253,"context_line":"            \u0027listen_address\u0027: netutils.get_my_ipv4(),"},{"line_number":254,"context_line":"            \u0027seed_provider\u0027: {\u0027parameters\u0027:"},{"line_number":255,"context_line":"                              [{\u0027seeds\u0027: netutils.get_my_ipv4()}]"},{"line_number":256,"context_line":"                              }"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a57f1b5_e15d61ed","line":253,"range":{"start_line":253,"start_character":30,"end_line":253,"end_character":52},"in_reply_to":"5a5ae5dd_3a7dbb1c","updated":"2016-02-12 20:45:09.000000000","message":"yeah thats fine for now but i know its a problem across all datastores. i bumped that bug into m-3 milestone","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"b4ce8c554869664a49aa6e0be4cde7d156cc38a4","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            \u0027authorizer\u0027: \u0027org.apache.cassandra.auth.CassandraAuthorizer\u0027,"},{"line_number":251,"context_line":"            \u0027rpc_address\u0027: \"0.0.0.0\","},{"line_number":252,"context_line":"            \u0027broadcast_rpc_address\u0027: netutils.get_my_ipv4(),"},{"line_number":253,"context_line":"            \u0027listen_address\u0027: netutils.get_my_ipv4(),"},{"line_number":254,"context_line":"            \u0027seed_provider\u0027: {\u0027parameters\u0027:"},{"line_number":255,"context_line":"                              [{\u0027seeds\u0027: netutils.get_my_ipv4()}]"},{"line_number":256,"context_line":"                              }"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a5ae5dd_3a7dbb1c","line":253,"range":{"start_line":253,"start_character":30,"end_line":253,"end_character":52},"in_reply_to":"5a5ae5dd_e286bf12","updated":"2016-02-03 18:24:49.000000000","message":"ok, so I guess we are leaving this for now?","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"}],"trove/templates/cassandra/config.template":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1c2647db15a93b9d07ff66bcf754ac9eebfd3944","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Cassandra storage config YAML "},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# NOTE:"},{"line_number":4,"context_line":"#   See http://wiki.apache.org/cassandra/StorageConfiguration for"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1a4dcd0f_0163ce42","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":31},"updated":"2015-08-13 16:52:00.000000000","message":"Looks like you have some trailing white-space here","commit_id":"01a7c4eb4cfdc1212b915755a30d34977d176d44"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1c2647db15a93b9d07ff66bcf754ac9eebfd3944","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# Specifying initial_token will override this setting on the node\u0027s initial start,"},{"line_number":21,"context_line":"# on subsequent starts, this setting will apply even if initial token is set."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# If you already have a cluster with 1 token per node, and wish to migrate to "},{"line_number":24,"context_line":"# multiple tokens per node, see http://wiki.apache.org/cassandra/Operations"},{"line_number":25,"context_line":"num_tokens: 256"},{"line_number":26,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1a4dcd0f_a1577a59","line":23,"updated":"2015-08-13 16:52:00.000000000","message":"ditto","commit_id":"01a7c4eb4cfdc1212b915755a30d34977d176d44"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1c2647db15a93b9d07ff66bcf754ac9eebfd3944","unresolved":false,"context_lines":[{"line_number":25,"context_line":"num_tokens: 256"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# initial_token allows you to specify tokens manually.  While you can use # it with"},{"line_number":28,"context_line":"# vnodes (num_tokens \u003e 1, above) -- in which case you should provide a "},{"line_number":29,"context_line":"# comma-separated list -- it\u0027s primarily used when adding nodes # to legacy clusters "},{"line_number":30,"context_line":"# that do not have vnodes enabled."},{"line_number":31,"context_line":"# initial_token:"},{"line_number":32,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1a4dcd0f_e1c4a20f","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":85},"updated":"2015-08-13 16:52:00.000000000","message":"ditto","commit_id":"01a7c4eb4cfdc1212b915755a30d34977d176d44"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1c2647db15a93b9d07ff66bcf754ac9eebfd3944","unresolved":false,"context_lines":[{"line_number":216,"context_line":"# well as caches.  Experiments show that JEMAlloc saves some memory"},{"line_number":217,"context_line":"# than the native GCC allocator (i.e., JEMalloc is more"},{"line_number":218,"context_line":"# fragmentation-resistant)."},{"line_number":219,"context_line":"# "},{"line_number":220,"context_line":"# Supported values are: NativeAllocator, JEMallocAllocator"},{"line_number":221,"context_line":"#"},{"line_number":222,"context_line":"# If you intend to use JEMallocAllocator you have to install JEMalloc as library and"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1a4dcd0f_01f18e6a","line":219,"updated":"2015-08-13 16:52:00.000000000","message":"actually, there\u0027s lots more, won\u0027t list the rest","commit_id":"01a7c4eb4cfdc1212b915755a30d34977d176d44"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd37192dc5c5b8ed52adf36ae3450cdd14dfbe86","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Cassandra storage config YAML "},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# NOTE:"},{"line_number":4,"context_line":"#   See http://wiki.apache.org/cassandra/StorageConfiguration for"}],"source_content_type":"application/octet-stream","patch_set":30,"id":"5a5ae5dd_e216bf54","line":1,"updated":"2016-02-03 07:00:56.000000000","message":"can you save this file without trailing space plz","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"d9e6e335a98401996ad626964b699efe2fc9718b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Cassandra storage config YAML "},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# NOTE:"},{"line_number":4,"context_line":"#   See http://wiki.apache.org/cassandra/StorageConfiguration for"}],"source_content_type":"application/octet-stream","patch_set":36,"id":"3a57f1b5_a6433f12","line":1,"updated":"2016-02-12 20:52:51.000000000","message":"can you save this without tailing spaces. thanks.","commit_id":"96307f997ccf3d63f6719e5162f71ed78191c91a"}],"trove/tests/unittests/guestagent/test_cassandra_manager.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd37192dc5c5b8ed52adf36ae3450cdd14dfbe86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"5a5ae5dd_dd5b662d","updated":"2016-02-03 07:00:56.000000000","message":"you didnt add any tests after updating the manager. the update_overrides and reset_configuration tests.","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"b0fbca5fe9960fd9fd36aea5a16e13efd1e07bdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"3a57f1b5_c3342dfd","in_reply_to":"5a5ae5dd_3aa4dba4","updated":"2016-02-12 20:45:09.000000000","message":"k","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"b4ce8c554869664a49aa6e0be4cde7d156cc38a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"5a5ae5dd_3aa4dba4","in_reply_to":"5a5ae5dd_dd5b662d","updated":"2016-02-03 18:24:49.000000000","message":"Right, I will add tests to ensure the config manager is called as expected.","commit_id":"52f10ceee0ef863a60e7e80fd459e2631f7813a1"}],"trove/tests/unittests/guestagent/test_dbaas.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd37192dc5c5b8ed52adf36ae3450cdd14dfbe86","unresolved":false,"context_lines":[{"line_number":2415,"context_line":""},{"line_number":2416,"context_line":"    @patch.multiple(\u0027trove.guestagent.common.operating_system\u0027,"},{"line_number":2417,"context_line":"                    chown\u003dDEFAULT, chmod\u003dDEFAULT, write_file\u003dDEFAULT)"},{"line_number":2418,"context_line":"    def test_cassandra_write_config(self, chown, chmod, write_file):"},{"line_number":2419,"context_line":"        configuration \u003d \u0027some arbitrary configuration text\u0027"},{"line_number":2420,"context_line":"        self.cassandra.write_config(configuration)"},{"line_number":2421,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"5a5ae5dd_bd7b0a7b","side":"PARENT","line":2418,"updated":"2016-02-03 07:00:56.000000000","message":"you removed this and didnt add the configuration tests. plz add.","commit_id":"b398bccbe4335a9b5bca83839d99d8243464fa62"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"b4ce8c554869664a49aa6e0be4cde7d156cc38a4","unresolved":false,"context_lines":[{"line_number":2415,"context_line":""},{"line_number":2416,"context_line":"    @patch.multiple(\u0027trove.guestagent.common.operating_system\u0027,"},{"line_number":2417,"context_line":"                    chown\u003dDEFAULT, chmod\u003dDEFAULT, write_file\u003dDEFAULT)"},{"line_number":2418,"context_line":"    def test_cassandra_write_config(self, chown, chmod, write_file):"},{"line_number":2419,"context_line":"        configuration \u003d \u0027some arbitrary configuration text\u0027"},{"line_number":2420,"context_line":"        self.cassandra.write_config(configuration)"},{"line_number":2421,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"5a5ae5dd_bab68bda","side":"PARENT","line":2418,"in_reply_to":"5a5ae5dd_bd7b0a7b","updated":"2016-02-03 18:24:49.000000000","message":"Done","commit_id":"b398bccbe4335a9b5bca83839d99d8243464fa62"}]}