)]}'
{"trove/cluster/models.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c4d41d901c3d914d3535a1a9b3fbf4b4f36bbbdd","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @classmethod"},{"line_number":184,"context_line":"    def create(cls, context, name, datastore, datastore_version,"},{"line_number":185,"context_line":"               instances, extended_properties):"},{"line_number":186,"context_line":"        api_strategy \u003d strategy.load_api_strategy(datastore_version.manager)"},{"line_number":187,"context_line":"        return api_strategy.cluster_class.create(context, name, datastore,"},{"line_number":188,"context_line":"                                                 datastore_version, instances,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_566bbc85","line":185,"updated":"2015-09-01 20:19:32.000000000","message":"IMHO, extended_properties should default to {}","commit_id":"dc56a49a7e473077b9a3912629da7b6673212495"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"cbe0f5f3f24baa8b4199bdc9c773c60154775645","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @classmethod"},{"line_number":184,"context_line":"    def create(cls, context, name, datastore, datastore_version,"},{"line_number":185,"context_line":"               instances, extended_properties):"},{"line_number":186,"context_line":"        api_strategy \u003d strategy.load_api_strategy(datastore_version.manager)"},{"line_number":187,"context_line":"        return api_strategy.cluster_class.create(context, name, datastore,"},{"line_number":188,"context_line":"                                                 datastore_version, instances,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_75577f02","line":185,"in_reply_to":"da20952f_566bbc85","updated":"2015-09-03 12:14:40.000000000","message":"Hi vkmc: This is defined to be {} by default in trove/cluster/service.py which is the entry point for all of this code. Thanks!","commit_id":"dc56a49a7e473077b9a3912629da7b6673212495"}],"trove/cluster/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7adc5b1eb0c48104431cf926c3b21322eee39af0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        datastore, datastore_version \u003d ("},{"line_number":144,"context_line":"            datastore_models.get_datastore_version(**datastore_args))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        extended_properties \u003d body[\u0027cluster\u0027].get(\u0027extended_properties\u0027, {})"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        try:"},{"line_number":149,"context_line":"            clusters_enabled \u003d (CONF.get(datastore_version.manager)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba15a1d1_2202ab0a","line":146,"updated":"2015-09-18 12:46:06.000000000","message":"It would be nice if apischema.py were updated to reflect this. Would you consider adding this later, if yes, please add a bug in LP or a #TODO in the code.","commit_id":"6ecd3503d95685c5ef5e1e4db56f902ac5b98992"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"28612913a66aa813c80e82cfb994b9964b3b00fc","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        datastore, datastore_version \u003d ("},{"line_number":144,"context_line":"            datastore_models.get_datastore_version(**datastore_args))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        extended_properties \u003d body[\u0027cluster\u0027].get(\u0027extended_properties\u0027, {})"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        try:"},{"line_number":149,"context_line":"            clusters_enabled \u003d (CONF.get(datastore_version.manager)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba15a1d1_0550c730","line":146,"in_reply_to":"ba15a1d1_2202ab0a","updated":"2015-09-18 16:42:20.000000000","message":"Done. Added a TODO for now.","commit_id":"6ecd3503d95685c5ef5e1e4db56f902ac5b98992"}],"trove/cluster/views.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7adc5b1eb0c48104431cf926c3b21322eee39af0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if ip_list:"},{"line_number":50,"context_line":"            cluster_dict[\"ip\"] \u003d ip_list"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        extended_properties \u003d self.get_extended_properties()"},{"line_number":53,"context_line":"        if extended_properties:"},{"line_number":54,"context_line":"            cluster_dict[\"extended_properties\"] \u003d extended_properties"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba15a1d1_c2388fd5","line":52,"updated":"2015-09-18 12:46:06.000000000","message":"What\u0027s this? an extension point for a later commit?","commit_id":"6ecd3503d95685c5ef5e1e4db56f902ac5b98992"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"0509c978276475632abf0f44bfed670b7fa5857a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if ip_list:"},{"line_number":50,"context_line":"            cluster_dict[\"ip\"] \u003d ip_list"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        extended_properties \u003d self.get_extended_properties()"},{"line_number":53,"context_line":"        if extended_properties:"},{"line_number":54,"context_line":"            cluster_dict[\"extended_properties\"] \u003d extended_properties"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba15a1d1_789281a1","line":52,"in_reply_to":"ba15a1d1_c2388fd5","updated":"2015-09-18 20:05:02.000000000","message":"Yes, this is an extension point for datastores that want to set this. Basically they would override the get_extended_properties() method to output the extended properties that they want the view to expose for their datastore type. By default, if the datastores don\u0027t override this, get_extended_properties() would be None, and the view would not return an extended_properties section (same as today).","commit_id":"6ecd3503d95685c5ef5e1e4db56f902ac5b98992"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7adc5b1eb0c48104431cf926c3b21322eee39af0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def build_instances(self):"},{"line_number":96,"context_line":"        raise NotImplementedError()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_extended_properties(self):"},{"line_number":99,"context_line":"        return None"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _build_flavor_info(self, flavor_id):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba15a1d1_e25593f9","line":98,"updated":"2015-09-18 12:46:06.000000000","message":"maybe earlier comment would have been better placed here.","commit_id":"6ecd3503d95685c5ef5e1e4db56f902ac5b98992"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"28612913a66aa813c80e82cfb994b9964b3b00fc","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def build_instances(self):"},{"line_number":96,"context_line":"        raise NotImplementedError()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_extended_properties(self):"},{"line_number":99,"context_line":"        return None"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _build_flavor_info(self, flavor_id):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba15a1d1_85ae172c","line":98,"in_reply_to":"ba15a1d1_e25593f9","updated":"2015-09-18 16:42:20.000000000","message":"As per my understanding, this method will allow datastores to expose extended_properties as per datastore specific requirements.\nCheck this for example: https://review.openstack.org/#/c/207578/19/trove/common/strategies/cluster/experimental/vertica/api.py\n\nAlso since extended_properties is an optional field, default implementation returns None here. So this doesn\u0027t affect the datastores which don\u0027t want to use extended_properties.","commit_id":"6ecd3503d95685c5ef5e1e4db56f902ac5b98992"}]}