)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3258228fe7d04d949c7f6f2033c45bb06e0d8816","unresolved":false,"context_lines":[{"line_number":17,"context_line":"The MCClient.jar file is used to perform the above tasks which is"},{"line_number":18,"context_line":"built in the vertica image."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I087ce474d555d2a78bbaaa720d455fc66cacefb2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a4dcd0f_0438189f","line":20,"updated":"2015-08-12 06:31:39.000000000","message":"a bug would be nice ...","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"}],"trove/common/cfg.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"ce1d8c238d3e25f9242a903cad3d9b55f5492c28","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"               default\u003d\u0027trove.extensions.vertica.service.\u0027"},{"line_number":1050,"context_line":"                       \u0027VerticaRootController\u0027,"},{"line_number":1051,"context_line":"               help\u003d\u0027Root controller implementation for Vertica.\u0027),"},{"line_number":1052,"context_line":"    cfg.StrOpt(\u0027mc_client_path\u0027,"},{"line_number":1053,"context_line":"               default\u003d\u0027/opt/datastore_package/MCClient-7.1.2.jar\u0027,"},{"line_number":1054,"context_line":"               help\u003d\u0027Path to the MCClient.jar file.\u0027),"},{"line_number":1055,"context_line":"    cfg.StrOpt(\u0027db_package_path\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_d31af57c","line":1052,"updated":"2015-12-07 19:21:59.000000000","message":"mc_client_path and db_package_path should be hardcoded in the guest agent.  These values are specific to a particular datastore_version, so you can\u0027t specify them in cfg.","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"3195d4e664ca4421bfca886293f491f56ca9372b","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"               default\u003d\u0027trove.extensions.vertica.service.\u0027"},{"line_number":1050,"context_line":"                       \u0027VerticaRootController\u0027,"},{"line_number":1051,"context_line":"               help\u003d\u0027Root controller implementation for Vertica.\u0027),"},{"line_number":1052,"context_line":"    cfg.StrOpt(\u0027mc_client_path\u0027,"},{"line_number":1053,"context_line":"               default\u003d\u0027/opt/datastore_package/MCClient-7.1.2.jar\u0027,"},{"line_number":1054,"context_line":"               help\u003d\u0027Path to the MCClient.jar file.\u0027),"},{"line_number":1055,"context_line":"    cfg.StrOpt(\u0027db_package_path\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_4743106d","line":1052,"in_reply_to":"7a740942_d31af57c","updated":"2015-12-10 00:27:38.000000000","message":"mc_client_path and db_package_path both actually depends on the jar file and the debian package which may change with the name and version. That is why it\u0027s put in the cfg.\nThanks","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"ce1d8c238d3e25f9242a903cad3d9b55f5492c28","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"               default\u003d300,"},{"line_number":1063,"context_line":"               help\u003d\u0027Time (in seconds) estimated for the vertica management \u0027"},{"line_number":1064,"context_line":"                    \u0027console service to start.\u0027),"},{"line_number":1065,"context_line":"    cfg.StrOpt(\u0027mc_default_password\u0027,"},{"line_number":1066,"context_line":"               default\u003d\u0027vertica123\u0027,"},{"line_number":1067,"context_line":"               help\u003d\u0027Vertica management console dbadmin password baked into \u0027"},{"line_number":1068,"context_line":"                    \u0027the vertica image.\u0027),"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_d34c35a0","line":1065,"updated":"2015-12-07 19:21:59.000000000","message":"This should be hardcoded.  There is no reason this should ever be changed.","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"3195d4e664ca4421bfca886293f491f56ca9372b","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"               default\u003d300,"},{"line_number":1063,"context_line":"               help\u003d\u0027Time (in seconds) estimated for the vertica management \u0027"},{"line_number":1064,"context_line":"                    \u0027console service to start.\u0027),"},{"line_number":1065,"context_line":"    cfg.StrOpt(\u0027mc_default_password\u0027,"},{"line_number":1066,"context_line":"               default\u003d\u0027vertica123\u0027,"},{"line_number":1067,"context_line":"               help\u003d\u0027Vertica management console dbadmin password baked into \u0027"},{"line_number":1068,"context_line":"                    \u0027the vertica image.\u0027),"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_27092432","line":1065,"in_reply_to":"7a740942_d34c35a0","updated":"2015-12-10 00:27:38.000000000","message":"The password should be configurable and can be decided/changed during the image building process. That is why this has been put here.","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"}],"trove/guestagent/datastore/experimental/vertica/manager.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"ce1d8c238d3e25f9242a903cad3d9b55f5492c28","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            LOG.info(_(\u0027Completed setup of Vertica database instance.\u0027))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            LOG.exception(_(\u0027Cannot prepare Vertica database instance.\u0027))"},{"line_number":77,"context_line":"            self.appStatus.set_status(rd_ins.ServiceStatuses.FAILED)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def restart(self, context):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_8980bcf8","line":76,"updated":"2015-12-07 19:21:59.000000000","message":"Don\u0027t eat the exception here.  pass it along.","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"3195d4e664ca4421bfca886293f491f56ca9372b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            LOG.info(_(\u0027Completed setup of Vertica database instance.\u0027))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            LOG.exception(_(\u0027Cannot prepare Vertica database instance.\u0027))"},{"line_number":77,"context_line":"            self.appStatus.set_status(rd_ins.ServiceStatuses.FAILED)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def restart(self, context):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_59fe9806","line":76,"in_reply_to":"7a740942_8980bcf8","updated":"2015-12-10 00:27:38.000000000","message":"Done","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd8e94b7f27e252837e84044fbd290e5f4357705","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                self.app._set_vertica_installed())"},{"line_number":73,"context_line":"            LOG.info(_(\u0027Completed setup of Vertica database instance.\u0027))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            LOG.exception(_(\u0027Cannot prepare Vertica database instance.\u0027))"},{"line_number":77,"context_line":"            self.appStatus.set_status(rd_ins.ServiceStatuses.FAILED)"},{"line_number":78,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_dc09d9de","line":75,"updated":"2015-12-17 23:47:31.000000000","message":"can we narrow the Exception caught here down? I do not prefer catching everything if we can avoid it.","commit_id":"7467c0dbc5da327e97de5160c6ac0d3b2dc2d117"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7600085228abade247fbc2e2a7ecfd2d449eec06","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                self.app._set_vertica_installed())"},{"line_number":73,"context_line":"            LOG.info(_(\u0027Completed setup of Vertica database instance.\u0027))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            LOG.exception(_(\u0027Cannot prepare Vertica database instance.\u0027))"},{"line_number":77,"context_line":"            self.appStatus.set_status(rd_ins.ServiceStatuses.FAILED)"},{"line_number":78,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_0004c847","line":75,"in_reply_to":"3a7e1126_dc09d9de","updated":"2015-12-18 08:16:36.000000000","message":"I agree, but for a different reason.  The base class now traps exceptions, logs them and marks the instance in error state.  Each datastore doesn\u0027t need to (and shouldn\u0027t) do it on its own.","commit_id":"7467c0dbc5da327e97de5160c6ac0d3b2dc2d117"}],"trove/guestagent/datastore/experimental/vertica/service.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0f5393924720a79624a1ab376cba0021d60e3b87","unresolved":false,"context_lines":[{"line_number":36,"context_line":"DB_NAME \u003d \u0027db_srvr\u0027"},{"line_number":37,"context_line":"MOUNT_POINT \u003d CONF.vertica.mount_point"},{"line_number":38,"context_line":"MCCLIENT_PATH \u003d CONF.vertica.mc_client_jar"},{"line_number":39,"context_line":"USEREMAIL \u003d \"fake_root@hp.com\""},{"line_number":40,"context_line":"DB_SERVER \u003d \"db_srvr\""},{"line_number":41,"context_line":"URL \u003d \"https://localhost:5450/webui\""},{"line_number":42,"context_line":"NODEIP \u003d \"localhost\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_bb105e01","line":39,"updated":"2015-08-12 07:28:48.000000000","message":"this should be configurable.","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"09e7cef8afc55214792795e3f02d92582c63ea0e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"DB_NAME \u003d \u0027db_srvr\u0027"},{"line_number":37,"context_line":"MOUNT_POINT \u003d CONF.vertica.mount_point"},{"line_number":38,"context_line":"MCCLIENT_PATH \u003d CONF.vertica.mc_client_jar"},{"line_number":39,"context_line":"USEREMAIL \u003d \"fake_root@hp.com\""},{"line_number":40,"context_line":"DB_SERVER \u003d \"db_srvr\""},{"line_number":41,"context_line":"URL \u003d \"https://localhost:5450/webui\""},{"line_number":42,"context_line":"NODEIP \u003d \"localhost\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_f902f73d","line":39,"in_reply_to":"1a4dcd0f_bb105e01","updated":"2015-08-26 22:21:11.000000000","message":"Done","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0f5393924720a79624a1ab376cba0021d60e3b87","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def __init__(self, status):"},{"line_number":67,"context_line":"        self.state_change_wait_time \u003d CONF.state_change_wait_time"},{"line_number":68,"context_line":"        self.status \u003d status"},{"line_number":69,"context_line":"        self.mc_password \u003d \"vertica123\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _enable_db_on_boot(self):"},{"line_number":72,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_5bf91a7f","line":69,"updated":"2015-08-12 07:28:48.000000000","message":"are we hardcoding the password, it could be a security concern","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3258228fe7d04d949c7f6f2033c45bb06e0d8816","unresolved":false,"context_lines":[{"line_number":406,"context_line":"    def _get_api_key(self):"},{"line_number":407,"context_line":"        \"\"\"Gets the api key needed for the Management console\"\"\""},{"line_number":408,"context_line":"        try:"},{"line_number":409,"context_line":"            LOG.debug(_(\"Trying to get the API key\"))"},{"line_number":410,"context_line":"            out, err \u003d system.shell_execute(system.MC_API_KEY,"},{"line_number":411,"context_line":"                                            command_executor\u003d\"dbadmin\")"},{"line_number":412,"context_line":"            LOG.debug(_(\"OUT : %s\") % out)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_0406d8cd","line":409,"updated":"2015-08-12 06:31:39.000000000","message":"do not i18n debug messages","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"09e7cef8afc55214792795e3f02d92582c63ea0e","unresolved":false,"context_lines":[{"line_number":406,"context_line":"    def _get_api_key(self):"},{"line_number":407,"context_line":"        \"\"\"Gets the api key needed for the Management console\"\"\""},{"line_number":408,"context_line":"        try:"},{"line_number":409,"context_line":"            LOG.debug(_(\"Trying to get the API key\"))"},{"line_number":410,"context_line":"            out, err \u003d system.shell_execute(system.MC_API_KEY,"},{"line_number":411,"context_line":"                                            command_executor\u003d\"dbadmin\")"},{"line_number":412,"context_line":"            LOG.debug(_(\"OUT : %s\") % out)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_fc41853a","line":409,"in_reply_to":"1a4dcd0f_0406d8cd","updated":"2015-08-26 22:21:11.000000000","message":"Done","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0f5393924720a79624a1ab376cba0021d60e3b87","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                                                  db_pwd, db_pwd,"},{"line_number":429,"context_line":"                                                  api_key, DB_SERVER))"},{"line_number":430,"context_line":"            out, err \u003d system.shell_execute(jar_cmd)"},{"line_number":431,"context_line":"            LOG.debug(_(\"OUT: %s\") % out)"},{"line_number":432,"context_line":"            LOG.info(_(\"Import db to MC succesfull.\"))"},{"line_number":433,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":434,"context_line":"            LOG.debug(\"Cannot import db to MC.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_dbd3ea36","line":431,"updated":"2015-08-12 07:28:48.000000000","message":"debug does not needs translation","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"09e7cef8afc55214792795e3f02d92582c63ea0e","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                                                  db_pwd, db_pwd,"},{"line_number":429,"context_line":"                                                  api_key, DB_SERVER))"},{"line_number":430,"context_line":"            out, err \u003d system.shell_execute(jar_cmd)"},{"line_number":431,"context_line":"            LOG.debug(_(\"OUT: %s\") % out)"},{"line_number":432,"context_line":"            LOG.info(_(\"Import db to MC succesfull.\"))"},{"line_number":433,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":434,"context_line":"            LOG.debug(\"Cannot import db to MC.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_1c3f99b5","line":431,"in_reply_to":"1a4dcd0f_dbd3ea36","updated":"2015-08-26 22:21:11.000000000","message":"Done","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0f5393924720a79624a1ab376cba0021d60e3b87","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                                                  api_key, DB_SERVER))"},{"line_number":430,"context_line":"            out, err \u003d system.shell_execute(jar_cmd)"},{"line_number":431,"context_line":"            LOG.debug(_(\"OUT: %s\") % out)"},{"line_number":432,"context_line":"            LOG.info(_(\"Import db to MC succesfull.\"))"},{"line_number":433,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":434,"context_line":"            LOG.debug(\"Cannot import db to MC.\")"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_3bc20e54","line":432,"updated":"2015-08-12 07:28:48.000000000","message":"successful (\u0027typo\u0027)","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"09e7cef8afc55214792795e3f02d92582c63ea0e","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                                                  api_key, DB_SERVER))"},{"line_number":430,"context_line":"            out, err \u003d system.shell_execute(jar_cmd)"},{"line_number":431,"context_line":"            LOG.debug(_(\"OUT: %s\") % out)"},{"line_number":432,"context_line":"            LOG.info(_(\"Import db to MC succesfull.\"))"},{"line_number":433,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":434,"context_line":"            LOG.debug(\"Cannot import db to MC.\")"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_fc68a5bc","line":432,"in_reply_to":"1a4dcd0f_3bc20e54","updated":"2015-08-26 22:21:11.000000000","message":"Done","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0f5393924720a79624a1ab376cba0021d60e3b87","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def _change_user_password_management_console(self, username, mc_pwd,"},{"line_number":437,"context_line":"                                                 new_pwd):"},{"line_number":438,"context_line":"        \"\"\"Changes the password in the /management Console.\"\"\""},{"line_number":439,"context_line":"        LOG.debug(_(\"Trying to change the password in MC..\"))"},{"line_number":440,"context_line":"        usecase \u003d \"change_password\""},{"line_number":441,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_3b70ce3f","line":438,"updated":"2015-08-12 07:28:48.000000000","message":"/management?","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"09e7cef8afc55214792795e3f02d92582c63ea0e","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def _change_user_password_management_console(self, username, mc_pwd,"},{"line_number":437,"context_line":"                                                 new_pwd):"},{"line_number":438,"context_line":"        \"\"\"Changes the password in the /management Console.\"\"\""},{"line_number":439,"context_line":"        LOG.debug(_(\"Trying to change the password in MC..\"))"},{"line_number":440,"context_line":"        usecase \u003d \"change_password\""},{"line_number":441,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_7c9b35ca","line":438,"in_reply_to":"1a4dcd0f_3b70ce3f","updated":"2015-08-26 22:21:11.000000000","message":"Done","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0f5393924720a79624a1ab376cba0021d60e3b87","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    def _change_user_password_management_console(self, username, mc_pwd,"},{"line_number":437,"context_line":"                                                 new_pwd):"},{"line_number":438,"context_line":"        \"\"\"Changes the password in the /management Console.\"\"\""},{"line_number":439,"context_line":"        LOG.debug(_(\"Trying to change the password in MC..\"))"},{"line_number":440,"context_line":"        usecase \u003d \"change_password\""},{"line_number":441,"context_line":"        try:"},{"line_number":442,"context_line":"            api_key \u003d self._get_api_key()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_5ba4baa4","line":439,"updated":"2015-08-12 07:28:48.000000000","message":"no translations with debug","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"09e7cef8afc55214792795e3f02d92582c63ea0e","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    def _change_user_password_management_console(self, username, mc_pwd,"},{"line_number":437,"context_line":"                                                 new_pwd):"},{"line_number":438,"context_line":"        \"\"\"Changes the password in the /management Console.\"\"\""},{"line_number":439,"context_line":"        LOG.debug(_(\"Trying to change the password in MC..\"))"},{"line_number":440,"context_line":"        usecase \u003d \"change_password\""},{"line_number":441,"context_line":"        try:"},{"line_number":442,"context_line":"            api_key \u003d self._get_api_key()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_9ca089f6","line":439,"in_reply_to":"1a4dcd0f_5ba4baa4","updated":"2015-08-26 22:21:11.000000000","message":"Done","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0f5393924720a79624a1ab376cba0021d60e3b87","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                                                 new_pwd):"},{"line_number":438,"context_line":"        \"\"\"Changes the password in the /management Console.\"\"\""},{"line_number":439,"context_line":"        LOG.debug(_(\"Trying to change the password in MC..\"))"},{"line_number":440,"context_line":"        usecase \u003d \"change_password\""},{"line_number":441,"context_line":"        try:"},{"line_number":442,"context_line":"            api_key \u003d self._get_api_key()"},{"line_number":443,"context_line":"            jar_cmd \u003d (system.MC_JAR_EXECUTION % (usecase, URL,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_3bbe8eae","line":440,"updated":"2015-08-12 07:28:48.000000000","message":"i do not see the need of this variable","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"09e7cef8afc55214792795e3f02d92582c63ea0e","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                                                 new_pwd):"},{"line_number":438,"context_line":"        \"\"\"Changes the password in the /management Console.\"\"\""},{"line_number":439,"context_line":"        LOG.debug(_(\"Trying to change the password in MC..\"))"},{"line_number":440,"context_line":"        usecase \u003d \"change_password\""},{"line_number":441,"context_line":"        try:"},{"line_number":442,"context_line":"            api_key \u003d self._get_api_key()"},{"line_number":443,"context_line":"            jar_cmd \u003d (system.MC_JAR_EXECUTION % (usecase, URL,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_7c37b5b0","line":440,"in_reply_to":"1a4dcd0f_3bbe8eae","updated":"2015-08-26 22:21:11.000000000","message":"Done","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"01222a4f2ad8f40210071ab86cf04dab5b518caf","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                                                              mc_pwd, db_pwd)"},{"line_number":421,"context_line":"            out, err \u003d system.shell_execute(jar_cmd, log_level\u003d0)"},{"line_number":422,"context_line":"            LOG.debug(\"OUT: %s\" % out)"},{"line_number":423,"context_line":"            LOG.info(\"Import db to MC successful.\")"},{"line_number":424,"context_line":"        except exception.ProcessExecutionError as err:"},{"line_number":425,"context_line":"            LOG.debug(err)"},{"line_number":426,"context_line":"            raise RuntimeError(_(\"Cannot import db to MC.\"))"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a8ffd7b_3e74de9a","line":423,"updated":"2015-11-24 18:11:48.000000000","message":"_()","commit_id":"41b63c9704ebdd0a617cdd2dfcf044ff2c866014"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"01222a4f2ad8f40210071ab86cf04dab5b518caf","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            out, err \u003d system.shell_execute(jar_cmd, log_level\u003d0)"},{"line_number":436,"context_line":"            LOG.debug(\"OUT: %s\" % out)"},{"line_number":437,"context_line":"            if \"User Password Changed Successfully\" in out:"},{"line_number":438,"context_line":"                LOG.info(\"Changed user password in MC.\")"},{"line_number":439,"context_line":"                return True"},{"line_number":440,"context_line":"            else:"},{"line_number":441,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a8ffd7b_5e520215","line":438,"updated":"2015-11-24 18:11:48.000000000","message":"_()","commit_id":"41b63c9704ebdd0a617cdd2dfcf044ff2c866014"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"01222a4f2ad8f40210071ab86cf04dab5b518caf","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                \"add_user\", username, mc_pwd, user_pwd)"},{"line_number":452,"context_line":"            out, err \u003d system.shell_execute(jar_cmd, log_level\u003d0)"},{"line_number":453,"context_line":"            LOG.debug(\"OUT: %s\" % out)"},{"line_number":454,"context_line":"            LOG.info(\"Added user to MC.\")"},{"line_number":455,"context_line":"        except exception.ProcessExecutionError as err:"},{"line_number":456,"context_line":"            LOG.debug(err)"},{"line_number":457,"context_line":"            raise RuntimeError(_(\"Cannot create new user.\"))"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a8ffd7b_5e044214","line":454,"updated":"2015-11-24 18:11:48.000000000","message":"info level logs should be i18n _() and exception messages but not debug messages.","commit_id":"41b63c9704ebdd0a617cdd2dfcf044ff2c866014"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"01222a4f2ad8f40210071ab86cf04dab5b518caf","unresolved":false,"context_lines":[{"line_number":516,"context_line":"                LOG.info(\"Vertica console service is running.\")"},{"line_number":517,"context_line":"                return True"},{"line_number":518,"context_line":"            else:"},{"line_number":519,"context_line":"                LOG.info(\"Vertica console service is not running.\")"},{"line_number":520,"context_line":"                return False"},{"line_number":521,"context_line":"        except exception.ProcessExecutionError as err:"},{"line_number":522,"context_line":"            LOG.debug(err)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a8ffd7b_4331cf0a","line":519,"updated":"2015-11-24 18:11:48.000000000","message":"these log messages seem to be more like debug messages in this method as well as the ones in the _check_mc_jar_present method.","commit_id":"41b63c9704ebdd0a617cdd2dfcf044ff2c866014"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"ce1d8c238d3e25f9242a903cad3d9b55f5492c28","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _enable_db_on_boot(self):"},{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"dbadmin\", \"-c\","},{"line_number":91,"context_line":"                       (system.SET_RESTART_POLICY % (DB_NAME, \"always\"))]"},{"line_number":92,"context_line":"            subprocess.Popen(command)"},{"line_number":93,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"root\", \"-c\","}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_76f8cf7b","line":90,"updated":"2015-12-07 19:21:59.000000000","message":"This should call the new set_restart_policy method you made below.","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"3195d4e664ca4421bfca886293f491f56ca9372b","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _enable_db_on_boot(self):"},{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"dbadmin\", \"-c\","},{"line_number":91,"context_line":"                       (system.SET_RESTART_POLICY % (DB_NAME, \"always\"))]"},{"line_number":92,"context_line":"            subprocess.Popen(command)"},{"line_number":93,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"root\", \"-c\","}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_7951140e","line":90,"in_reply_to":"7a740942_76f8cf7b","updated":"2015-12-10 00:27:38.000000000","message":"I agree, but I have not changed this part of the code, so can do it in another patch/file a bug regarding this and using popen.\n\nThanks","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"ce1d8c238d3e25f9242a903cad3d9b55f5492c28","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            subprocess.Popen(command)"},{"line_number":93,"context_line":"            command \u003d [\"sudo\", \"su\", \"-\", \"root\", \"-c\","},{"line_number":94,"context_line":"                       (system.VERTICA_AGENT_SERVICE_COMMAND % \"enable\")]"},{"line_number":95,"context_line":"            subprocess.Popen(command)"},{"line_number":96,"context_line":"        except Exception:"},{"line_number":97,"context_line":"            LOG.exception(_(\"Failed to enable db on boot.\"))"},{"line_number":98,"context_line":"            raise RuntimeError(\"Could not enable db on boot.\")"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_36eec7b4","line":95,"updated":"2015-12-07 19:21:59.000000000","message":"Why does one place use popen and the other shell_execute?","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"ce1d8c238d3e25f9242a903cad3d9b55f5492c28","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                                     MOUNT_POINT, MOUNT_POINT,"},{"line_number":185,"context_line":"                                                     db_password))"},{"line_number":186,"context_line":"            system.shell_execute(create_db_command, \"dbadmin\", log_level\u003d0)"},{"line_number":187,"context_line":"            if self._check_mc_jar_present():"},{"line_number":188,"context_line":"                self._start_vertica_console_service()"},{"line_number":189,"context_line":"        except Exception:"},{"line_number":190,"context_line":"            LOG.exception(_(\"Vertica database create failed.\"))"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_f6ceff2c","line":187,"updated":"2015-12-07 19:21:59.000000000","message":"This doesn\u0027t seem right.  First, changing behaviour based on the presence of a package file seems dubious, but starting the service when you create a database seems wrong.  What happens when the instance is restarted?  Wouldn\u0027t you need to ensure that the console starts at system boot?","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"3195d4e664ca4421bfca886293f491f56ca9372b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                                     MOUNT_POINT, MOUNT_POINT,"},{"line_number":185,"context_line":"                                                     db_password))"},{"line_number":186,"context_line":"            system.shell_execute(create_db_command, \"dbadmin\", log_level\u003d0)"},{"line_number":187,"context_line":"            if self._check_mc_jar_present():"},{"line_number":188,"context_line":"                self._start_vertica_console_service()"},{"line_number":189,"context_line":"        except Exception:"},{"line_number":190,"context_line":"            LOG.exception(_(\"Vertica database create failed.\"))"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a740942_d9dcc876","line":187,"in_reply_to":"7a740942_f6ceff2c","updated":"2015-12-10 00:27:38.000000000","message":"here the presence of mc_jar is checked because we still want the cluster creation to complete successfully even if the jar file is absent. In this case, just the management console will not be installed.\nAt the time of image building, we disable the VCONSOLE_autostart option. If everything comes up fine, then only we enable the vconsoel autostart option.\n\nThanks","commit_id":"d3250f24bb4ce8dde714d4b8dcc39906b8108be1"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd8e94b7f27e252837e84044fbd290e5f4357705","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                LOG.info(_(\"Service Status is SHUTDOWN.\"))"},{"line_number":62,"context_line":"                return rd_instance.ServiceStatuses.SHUTDOWN"},{"line_number":63,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":64,"context_line":"            if not self.vertica_installed:"},{"line_number":65,"context_line":"                LOG.info(_(\"Service Status is BUILDING.\"))"},{"line_number":66,"context_line":"                return rd_instance.ServiceStatuses.BUILDING"},{"line_number":67,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_3ce9fde6","line":64,"updated":"2015-12-17 23:47:31.000000000","message":"This should be at the top of this method so that it doesnt require running the shell if its not installed.","commit_id":"7467c0dbc5da327e97de5160c6ac0d3b2dc2d117"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd8e94b7f27e252837e84044fbd290e5f4357705","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                \"change_password\", username, mc_pwd, new_pwd)"},{"line_number":466,"context_line":"            out, err \u003d system.shell_execute(jar_cmd, log_level\u003d0)"},{"line_number":467,"context_line":"            LOG.debug(\"OUT: %s\" % out)"},{"line_number":468,"context_line":"            if \"User Password Changed Successfully\" in out:"},{"line_number":469,"context_line":"                LOG.info(_(\"Changed user password in MC.\"))"},{"line_number":470,"context_line":"                return True"},{"line_number":471,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_5cce495b","line":468,"updated":"2015-12-17 23:47:31.000000000","message":"this is better than whats below.","commit_id":"7467c0dbc5da327e97de5160c6ac0d3b2dc2d117"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd8e94b7f27e252837e84044fbd290e5f4357705","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        LOG.debug(\"Check whether the service is running.\")"},{"line_number":544,"context_line":"        try:"},{"line_number":545,"context_line":"            out, err \u003d system.shell_execute(system.VCONSOLE_STATUS_CHECK)"},{"line_number":546,"context_line":"            if \":5450\" in out:"},{"line_number":547,"context_line":"                LOG.debug(\"Vertica console service is running.\")"},{"line_number":548,"context_line":"                return True"},{"line_number":549,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_7ce8e5b4","line":546,"updated":"2015-12-17 23:47:31.000000000","message":"checking for such a small thing in the output of a cmd seems dangerous to validate the service is up or not. is there something more we can check on?","commit_id":"7467c0dbc5da327e97de5160c6ac0d3b2dc2d117"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"fd8e94b7f27e252837e84044fbd290e5f4357705","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        try:"},{"line_number":560,"context_line":"            out, err \u003d system.shell_execute(system.MC_JAR_PRESENCE %"},{"line_number":561,"context_line":"                                            MCCLIENT_PATH)"},{"line_number":562,"context_line":"            if \"Found\" in out:"},{"line_number":563,"context_line":"                LOG.debug(\"MCCLIent.jar is present.\")"},{"line_number":564,"context_line":"                return True"},{"line_number":565,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_9ceb51b0","line":562,"updated":"2015-12-17 23:47:31.000000000","message":"same here.","commit_id":"7467c0dbc5da327e97de5160c6ac0d3b2dc2d117"}],"trove/guestagent/datastore/experimental/vertica/system.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0f5393924720a79624a1ab376cba0021d60e3b87","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                   \" -d %s -X -N -S default -r\""},{"line_number":24,"context_line":"                   \" /vertica.deb -L CE -Y --no-system-checks\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"MC_API_KEY \u003d \"/opt/vertica/bin/apikeymgr --user dbadmin --app vertica \" \\"},{"line_number":27,"context_line":"             \"--create --secure admin\""},{"line_number":28,"context_line":"MC_JAR_EXECUTION \u003d \"java -jar /MCClient-7.1.1-jar-with-dependencies.jar \" \\"},{"line_number":29,"context_line":"                   \"%s %s %s %s %s %s %s %s %s %s %s\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_bb837e02","line":26,"updated":"2015-08-12 07:28:48.000000000","message":"refrain from using \\","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"09e7cef8afc55214792795e3f02d92582c63ea0e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                   \" -d %s -X -N -S default -r\""},{"line_number":24,"context_line":"                   \" /vertica.deb -L CE -Y --no-system-checks\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"MC_API_KEY \u003d \"/opt/vertica/bin/apikeymgr --user dbadmin --app vertica \" \\"},{"line_number":27,"context_line":"             \"--create --secure admin\""},{"line_number":28,"context_line":"MC_JAR_EXECUTION \u003d \"java -jar /MCClient-7.1.1-jar-with-dependencies.jar \" \\"},{"line_number":29,"context_line":"                   \"%s %s %s %s %s %s %s %s %s %s %s\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_9ce2c9d4","line":26,"in_reply_to":"1a4dcd0f_bb837e02","updated":"2015-08-26 22:21:11.000000000","message":"Done","commit_id":"2dbc05d92677030df5011e036b0b4ea052b5aadd"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"1a4cfda937d83fa6dbc27d4bcf00f4e8a5607907","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"VCONSOLE_START \u003d \"sudo service vertica-consoled start \u003e /dev/null 2\u003e\u00261\""},{"line_number":49,"context_line":"VCONSOLE_RESTART \u003d \"sudo service vertica-consoled restart \u003e /dev/null 2\u003e\u00261\""},{"line_number":50,"context_line":"# VCONSOLE_STATUS_CHECK \u003d \"sudo service vertica-consoled status\""},{"line_number":51,"context_line":"VCONSOLE_STATUS_CHECK \u003d \"netstat -na | grep LISTEN\""},{"line_number":52,"context_line":"VCONSOLE_STOP \u003d \"sudo service vertica-consoled stop\""},{"line_number":53,"context_line":"VCONSOLE_AUTOSTART_ENABLE \u003d \"sudo update-rc.d vertica-consoled enable\""}],"source_content_type":"text/x-python","patch_set":26,"id":"9a68dd71_9b14edf5","line":50,"updated":"2016-01-21 05:21:23.000000000","message":"Did you figure out why this didnt work right and needed to just check the listening ports? I know you were looking into why last time we chatted about it.","commit_id":"bc449cd515d5d586d5ba4299cd3d1bca4b3a386c"}]}