)]}'
{"apidocs/src/xslts/js/trc/schema/sampleManager.js":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"09a0feb83270fe244ea99eaee292e77f9bf03f4a","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    },"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    //"},{"line_number":196,"context_line":"    //  Sets code text replacing any text already existing there."},{"line_number":197,"context_line":"    //"},{"line_number":198,"context_line":"    _setCodeText : function ( codeData /* Info of the code to set (code object) */,"},{"line_number":199,"context_line":"                              code     /* Code text to set (string) */)"}],"source_content_type":"text/javascript","patch_set":3,"id":"1a4dcd0f_89276111","line":196,"updated":"2015-08-12 06:10:54.000000000","message":"this sentence isn\u0027t grammatical; why not fix it as well?","commit_id":"5738388a6216b8269ad5dc24a3e32c0f2b11f8fa"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"0192ba6e277fac712fbe1cb86ec5881637a65c95","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                              code     /* Code text to set (string) */)"},{"line_number":200,"context_line":"    {"},{"line_number":201,"context_line":"        //"},{"line_number":202,"context_line":"        // Preprocess the txt if necessary..."},{"line_number":203,"context_line":"        //"},{"line_number":204,"context_line":"        var ieVersion \u003d trc.util.browser.detectIEVersion();"},{"line_number":205,"context_line":"        if ((ieVersion \u003e -1) \u0026\u0026"}],"source_content_type":"text/javascript","patch_set":3,"id":"1a4dcd0f_66a8168d","line":202,"updated":"2015-08-11 18:49:06.000000000","message":"Might as well spell \u0027text\u0027 correctly too","commit_id":"5738388a6216b8269ad5dc24a3e32c0f2b11f8fa"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"09a0feb83270fe244ea99eaee292e77f9bf03f4a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                              code     /* Code text to set (string) */)"},{"line_number":200,"context_line":"    {"},{"line_number":201,"context_line":"        //"},{"line_number":202,"context_line":"        // Preprocess the txt if necessary..."},{"line_number":203,"context_line":"        //"},{"line_number":204,"context_line":"        var ieVersion \u003d trc.util.browser.detectIEVersion();"},{"line_number":205,"context_line":"        if ((ieVersion \u003e -1) \u0026\u0026"}],"source_content_type":"text/javascript","patch_set":3,"id":"1a4dcd0f_494639c1","line":202,"in_reply_to":"1a4dcd0f_66a8168d","updated":"2015-08-12 06:10:54.000000000","message":"really, we want to submit a change that fixes a comment?\n\nWhat next, someone wants to fix grammar?","commit_id":"5738388a6216b8269ad5dc24a3e32c0f2b11f8fa"}],"trove/extensions/mgmt/instances/service.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"eb213f0f74ab08a017e5a642beabe2b7ab295027","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def diagnostics(self, req, tenant_id, id):"},{"line_number":184,"context_line":"        \"\"\"Return a single instance diagnostics.\"\"\""},{"line_number":185,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % req)"},{"line_number":186,"context_line":"        LOG.info(_(\"Showing an instance diagnostics for \""},{"line_number":187,"context_line":"                   \"the instance \u0027%s\u0027\") % id)"},{"line_number":188,"context_line":"        LOG.info(_(\"id : \u0027%s\u0027\\n\\n\") % id)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_b985065a","line":186,"updated":"2015-08-11 07:25:48.000000000","message":"there should be no \u0027a\u0027 or \u0027an\u0027 here","commit_id":"7e855004aa0c7ce33f41c529461b076e7a892d5d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0d1637d31318e721ffb9822d5c994e7c2b46204e","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def diagnostics(self, req, tenant_id, id):"},{"line_number":184,"context_line":"        \"\"\"Return a single instance diagnostics.\"\"\""},{"line_number":185,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % req)"},{"line_number":186,"context_line":"        LOG.info(_(\"Showing an instance diagnostics for \""},{"line_number":187,"context_line":"                   \"the instance \u0027%s\u0027\") % id)"},{"line_number":188,"context_line":"        LOG.info(_(\"id : \u0027%s\u0027\\n\\n\") % id)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_34425d3f","line":186,"in_reply_to":"1a4dcd0f_b985065a","updated":"2015-08-11 07:42:11.000000000","message":"Done","commit_id":"7e855004aa0c7ce33f41c529461b076e7a892d5d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"0192ba6e277fac712fbe1cb86ec5881637a65c95","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @admin_context"},{"line_number":183,"context_line":"    def diagnostics(self, req, tenant_id, id):"},{"line_number":184,"context_line":"        \"\"\"Return instance diagnostics for a single instance.\"\"\""},{"line_number":185,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % req)"},{"line_number":186,"context_line":"        LOG.info(_(\"Showing instance diagnostics for the instance \u0027%s\u0027\") % id)"},{"line_number":187,"context_line":"        LOG.info(_(\"id : \u0027%s\u0027\\n\\n\") % id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_e673c64c","line":184,"updated":"2015-08-11 18:49:06.000000000","message":"Having \u0027instance\u0027 twice seems redundant.  How about:\n\n  \"\"\"Return diagnostics for a single instance.\"\"\"","commit_id":"5738388a6216b8269ad5dc24a3e32c0f2b11f8fa"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"09a0feb83270fe244ea99eaee292e77f9bf03f4a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    @admin_context"},{"line_number":183,"context_line":"    def diagnostics(self, req, tenant_id, id):"},{"line_number":184,"context_line":"        \"\"\"Return instance diagnostics for a single instance.\"\"\""},{"line_number":185,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % req)"},{"line_number":186,"context_line":"        LOG.info(_(\"Showing instance diagnostics for the instance \u0027%s\u0027\") % id)"},{"line_number":187,"context_line":"        LOG.info(_(\"id : \u0027%s\u0027\\n\\n\") % id)"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_491dd9bc","line":185,"updated":"2015-08-12 06:10:54.000000000","message":"merge these three LOG.info() lines into one ...","commit_id":"5738388a6216b8269ad5dc24a3e32c0f2b11f8fa"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"0192ba6e277fac712fbe1cb86ec5881637a65c95","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def diagnostics(self, req, tenant_id, id):"},{"line_number":184,"context_line":"        \"\"\"Return instance diagnostics for a single instance.\"\"\""},{"line_number":185,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % req)"},{"line_number":186,"context_line":"        LOG.info(_(\"Showing instance diagnostics for the instance \u0027%s\u0027\") % id)"},{"line_number":187,"context_line":"        LOG.info(_(\"id : \u0027%s\u0027\\n\\n\") % id)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_86ea0273","line":186,"updated":"2015-08-11 18:49:06.000000000","message":"Ditto:\n\n  LOG.info(_(\"Showing diagnostics for instance id \u0027%s\u0027.\\n\\n\") % id)","commit_id":"5738388a6216b8269ad5dc24a3e32c0f2b11f8fa"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"0192ba6e277fac712fbe1cb86ec5881637a65c95","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        \"\"\"Return instance diagnostics for a single instance.\"\"\""},{"line_number":185,"context_line":"        LOG.info(_(\"req : \u0027%s\u0027\\n\\n\") % req)"},{"line_number":186,"context_line":"        LOG.info(_(\"Showing instance diagnostics for the instance \u0027%s\u0027\") % id)"},{"line_number":187,"context_line":"        LOG.info(_(\"id : \u0027%s\u0027\\n\\n\") % id)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":190,"context_line":"        instance \u003d models.MgmtInstance.load(context\u003dcontext, id\u003did)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_a6bdbe69","line":187,"updated":"2015-08-11 18:49:06.000000000","message":"This line is redundant, as the id is printed out above","commit_id":"5738388a6216b8269ad5dc24a3e32c0f2b11f8fa"}],"trove/taskmanager/models.py":[{"author":{"_account_id":17360,"name":"Ishita Mandhan","email":"imandha@us.ibm.com","username":"imandhan"},"change_message_id":"1b8d64b0d119145d926334a65c303ad2c9da6c8d","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            return False"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        failed_ids \u003d _instance_ids_with_failures(instance_ids)"},{"line_number":266,"context_line":"        if failed_ids:"},{"line_number":267,"context_line":"            LOG.error(_(\"Some instances failed to become ready: %s\") %"},{"line_number":268,"context_line":"                      failed_ids)"},{"line_number":269,"context_line":"            self.update_statuses_on_failure(cluster_id, shard_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_60a8fe8c","line":266,"updated":"2015-08-11 18:36:42.000000000","message":"While you\u0027re at it, you can add the missing period at the end of the error message.","commit_id":"5738388a6216b8269ad5dc24a3e32c0f2b11f8fa"},{"author":{"_account_id":17360,"name":"Ishita Mandhan","email":"imandha@us.ibm.com","username":"imandhan"},"change_message_id":"1b8d64b0d119145d926334a65c303ad2c9da6c8d","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        return True"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def delete_cluster(self, context, cluster_id):"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        LOG.debug(\"begin delete_cluster for id: %s\" % cluster_id)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        def all_instances_marked_deleted():"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_03e02495","line":275,"updated":"2015-08-11 18:36:42.000000000","message":"You could capitalize the b in begin and add a period at the end of the debug message. Similarly, lots of debug messages could be capitalized throughout the file.","commit_id":"5738388a6216b8269ad5dc24a3e32c0f2b11f8fa"}],"trove/tests/unittests/guestagent/test_dbaas.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"09a0feb83270fe244ea99eaee292e77f9bf03f4a","unresolved":false,"context_lines":[{"line_number":3065,"context_line":"                          return_value\u003dself.test_config):"},{"line_number":3066,"context_line":"            self.app.install_cluster(members\u003d[\u0027member1\u0027, \u0027member2\u0027])"},{"line_number":3067,"context_line":"        # Verifying the number of shell calls,"},{"line_number":3068,"context_line":"        # as command has already been tested in preceding tests"},{"line_number":3069,"context_line":"        self.assertEqual(5, vertica_system.shell_execute.call_count)"},{"line_number":3070,"context_line":""},{"line_number":3071,"context_line":"    def test__enable_db_on_boot(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_e984e5d3","line":3068,"updated":"2015-08-12 06:10:54.000000000","message":"as THE command has ...in THE preceding tests","commit_id":"5738388a6216b8269ad5dc24a3e32c0f2b11f8fa"}]}